groupcore-utils 3.0.2 → 3.0.4

package/database/crud.js

@@ -109,21 +109,16 @@ module.exports = class {
     let updateQuery = '';
 
     // set this to be used inside the map function to check when we get to the last index key so that we dont add the comma to the last key in the generated sql query
-    const count = Object.keys(data).length;
     Object.keys(data)
       .filter((key) => key !== 'id')
-      .forEach((key, i) => {
-        if (count - i === 1) {
-          updateQuery += `${key} = '${escapeQuotes(data[key])}'`;
-        } else {
-          updateQuery += `${key} = '${escapeQuotes(data[key])}', `;
-        }
+      .forEach((key) => {
+        updateQuery += `${key} = '${escapeQuotes(data[key])}', `;
         return true;
       });
 
     const query = `update ${this.dbTable} set ${updateQuery} where id = '${id}'`;
 
-    return this.db.query(query);
+    return this.db.query(query.replace(',  where', ' where')); // using replace to remove the last comma before the where clause
   }
 
   /**

package/database/crud.spec.js

@@ -142,3 +142,20 @@ describe('read()', () => {
     expect(querySpy).toHaveBeenCalledWith("select * from test where id = 'test'");
   });
 });
+
+describe('update()', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+  it('should generate the right query', async () => {
+    expect.hasAssertions();
+
+    const querySpy = jest.spyOn(Init.prototype, 'query').mockImplementation(() => {
+      console.log('query called');
+    });
+
+    await new Crud({ dbTable: 'test', db }).update({ data: { id: 1, tag: 'test', slug: 'test' }, id: 1 });
+    expect(querySpy).toHaveBeenCalledWith("update test set tag = 'test', slug = 'test' where id = '1'");
+    expect(querySpy).toHaveBeenCalledTimes(1);
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "groupcore-utils",
-  "version": "3.0.2",
+  "version": "3.0.4",
   "description": "Utilities for working with some core features",
   "main": "Utils.js",
   "scripts": {