groundswell 0.0.2 → 0.0.3

package/dist/__tests__/adversarial/attachChild-performance.test.d.ts

@@ -0,0 +1,16 @@
+/**
+ * Performance Test: attachChild() with isDescendantOf() validation
+ *
+ * Validates that the isDescendantOf() method (added in P1.M1.T2.S2)
+ * does not cause significant performance degradation in attachChild()
+ * operations across various tree sizes and configurations.
+ *
+ * Performance Thresholds (from deep-hierarchy-stress.test.ts):
+ * - Single operation: < 100ms
+ * - Bulk operations (100 iterations): < 1000ms
+ * - isDescendantOf() complexity: O(d) where d = tree depth
+ *
+ * Related: plan/bugfix/P1M4T2S2/PRP.md
+ */
+export {};
+//# sourceMappingURL=attachChild-performance.test.d.ts.map

package/dist/__tests__/adversarial/attachChild-performance.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"attachChild-performance.test.d.ts","sourceRoot":"","sources":["../../../src/__tests__/adversarial/attachChild-performance.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}

package/dist/__tests__/adversarial/attachChild-performance.test.js

@@ -0,0 +1,187 @@
+/**
+ * Performance Test: attachChild() with isDescendantOf() validation
+ *
+ * Validates that the isDescendantOf() method (added in P1.M1.T2.S2)
+ * does not cause significant performance degradation in attachChild()
+ * operations across various tree sizes and configurations.
+ *
+ * Performance Thresholds (from deep-hierarchy-stress.test.ts):
+ * - Single operation: < 100ms
+ * - Bulk operations (100 iterations): < 1000ms
+ * - isDescendantOf() complexity: O(d) where d = tree depth
+ *
+ * Related: plan/bugfix/P1M4T2S2/PRP.md
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { Workflow } from '../../index.js';
+import { validateTreeConsistency, verifyBidirectionalLink } from '../helpers/tree-verification.js';
+/**
+ * SimpleWorkflow class for performance testing
+ * Pattern from: src/__tests__/adversarial/deep-hierarchy-stress.test.ts:20-26
+ */
+class SimpleWorkflow extends Workflow {
+    async run() {
+        this.setStatus('running');
+        this.setStatus('completed');
+        return 'done';
+    }
+}
+describe('attachChild Performance Regression Tests', () => {
+    /**
+     * Setup: Mock console methods to capture error messages
+     * Pattern from: src/__tests__/adversarial/deep-hierarchy-stress.test.ts:33-37
+     */
+    beforeEach(() => {
+        vi.spyOn(console, 'log').mockImplementation(() => { });
+        vi.spyOn(console, 'error').mockImplementation(() => { });
+        vi.spyOn(console, 'warn').mockImplementation(() => { });
+    });
+    /**
+     * Teardown: Restore all mocks to prevent test pollution
+     * CRITICAL: Always use vi.restoreAllMocks() in afterEach
+     */
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    /**
+     * Test 1: Shallow tree performance (depth 10)
+     *
+     * Validates that attachChild() performs very fast on shallow trees
+     * where isDescendantOf() only needs to traverse a short parent chain.
+     *
+     * Threshold: < 10ms (should be very fast for shallow trees)
+     */
+    it('should attach child in shallow tree within acceptable time', () => {
+        // ARRANGE: Create shallow tree (depth 10)
+        const DEPTH = 10;
+        const root = new SimpleWorkflow('Root');
+        let current = root;
+        for (let i = 0; i < DEPTH; i++) {
+            current = new SimpleWorkflow(`Level-${i}`, current);
+        }
+        // ACT: Measure attachChild() time for new child at depth 10
+        const startTime = performance.now();
+        const newChild = new SimpleWorkflow('NewChild', current);
+        const attachDuration = performance.now() - startTime;
+        // ASSERT: Verify functional correctness
+        expect(newChild.parent).toBe(current);
+        expect(current.children).toContain(newChild);
+        verifyBidirectionalLink(current, newChild);
+        // ASSERT: Verify performance threshold (< 10ms for shallow tree)
+        expect(attachDuration).toBeLessThan(10);
+    });
+    /**
+     * Test 2: Deep tree performance (depth 100)
+     *
+     * Validates that attachChild() scales linearly with tree depth.
+     * isDescendantOf() must traverse 100 parent references, which should
+     * complete in < 50ms given the O(d) iterative implementation.
+     *
+     * Threshold: < 50ms (linear scaling with depth)
+     */
+    it('should attach child in deep tree (depth 100) within acceptable time', () => {
+        // ARRANGE: Create deep tree
+        const DEPTH = 100;
+        const root = new SimpleWorkflow('Root');
+        let current = root;
+        for (let i = 0; i < DEPTH; i++) {
+            current = new SimpleWorkflow(`Child-${i}`, current);
+        }
+        // ACT: Measure attachChild() at deepest level
+        const startTime = performance.now();
+        const newChild = new SimpleWorkflow('NewChild', current);
+        const attachDuration = performance.now() - startTime;
+        // ASSERT: Functional correctness
+        verifyBidirectionalLink(current, newChild);
+        // ASSERT: Performance threshold (< 50ms for depth 100)
+        expect(attachDuration).toBeLessThan(50);
+        // ASSERT: Validate overall tree consistency
+        const errors = validateTreeConsistency(root);
+        expect(errors).toHaveLength(0);
+    });
+    /**
+     * Test 3: Extreme deep tree (depth 1000)
+     *
+     * Validates that attachChild() handles extreme depth without stack overflow
+     * and completes within acceptable time. This tests the O(d) complexity
+     * at the upper bound of typical workflow tree depths.
+     *
+     * Threshold: < 100ms (from deep-hierarchy-stress.test.ts:169)
+     */
+    it('should attach child in extreme deep tree (depth 1000) without stack overflow', () => {
+        const DEPTH = 1000;
+        const root = new SimpleWorkflow('Root');
+        let current = root;
+        for (let i = 0; i < DEPTH; i++) {
+            current = new SimpleWorkflow(`Child-${i}`, current);
+        }
+        // ACT: Measure attachChild() at depth 1000
+        const startTime = performance.now();
+        const newChild = new SimpleWorkflow('NewChild', current);
+        const attachDuration = performance.now() - startTime;
+        // ASSERT: Functional correctness
+        verifyBidirectionalLink(current, newChild);
+        // ASSERT: Performance threshold (< 100ms from deep-hierarchy-stress.test.ts:169)
+        expect(attachDuration).toBeLessThan(100);
+        // ASSERT: Validate tree consistency at extreme depth
+        const errors = validateTreeConsistency(root);
+        expect(errors).toHaveLength(0);
+    });
+    /**
+     * Test 4: Wide tree performance (100 children)
+     *
+     * Validates that attachChild() performs efficiently when attaching
+     * multiple children to a single parent. Each attachment only requires
+     * checking immediate parent chain, so performance should be excellent.
+     *
+     * Threshold: < 100ms total, < 1ms average per attachment
+     */
+    it('should attach 100 children to single parent efficiently', () => {
+        // ARRANGE: Create parent
+        const parent = new SimpleWorkflow('Parent');
+        const NUM_CHILDREN = 100;
+        // ACT: Measure time to attach all children
+        const startTime = performance.now();
+        for (let i = 0; i < NUM_CHILDREN; i++) {
+            const child = new SimpleWorkflow(`Child-${i}`, parent);
+        }
+        const totalDuration = performance.now() - startTime;
+        // ASSERT: Verify all children attached
+        expect(parent.children).toHaveLength(NUM_CHILDREN);
+        parent.children.forEach(child => {
+            verifyBidirectionalLink(parent, child);
+        });
+        // ASSERT: Performance (< 100ms total, < 1ms average)
+        expect(totalDuration).toBeLessThan(100);
+        const avgTime = totalDuration / NUM_CHILDREN;
+        expect(avgTime).toBeLessThan(1); // < 1ms per attachment
+    });
+    /**
+     * Test 5: Bulk attachment performance (100 operations)
+     *
+     * Validates that sequential attachChild() operations complete within
+     * acceptable time. This measures cumulative overhead of isDescendantOf()
+     * validation across multiple operations.
+     *
+     * Threshold: < 1000ms (from deep-hierarchy-stress.test.ts:186)
+     */
+    it('should complete 100 sequential attachChild operations within acceptable time', () => {
+        // ARRANGE: Create root workflow
+        const root = new SimpleWorkflow('Root');
+        const ITERATIONS = 100;
+        // ACT: Measure cumulative time for 100 attachments
+        const totalStartTime = performance.now();
+        for (let i = 0; i < ITERATIONS; i++) {
+            const child = new SimpleWorkflow(`Child-${i}`, root);
+        }
+        const totalDuration = performance.now() - totalStartTime;
+        // ASSERT: Verify functional correctness
+        expect(root.children).toHaveLength(ITERATIONS);
+        // ASSERT: Performance threshold (< 1000ms from deep-hierarchy-stress.test.ts:186)
+        expect(totalDuration).toBeLessThan(1000);
+        // ASSERT: Average time per operation
+        const avgTime = totalDuration / ITERATIONS;
+        expect(avgTime).toBeLessThan(10); // < 10ms average
+    });
+});
+//# sourceMappingURL=attachChild-performance.test.js.map

package/dist/__tests__/adversarial/attachChild-performance.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"attachChild-performance.test.js","sourceRoot":"","sources":["../../../src/__tests__/adversarial/attachChild-performance.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAC1C,OAAO,EAAE,uBAAuB,EAAE,uBAAuB,EAAE,MAAM,iCAAiC,CAAC;AAEnG;;;GAGG;AACH,MAAM,cAAe,SAAQ,QAAQ;IACnC,KAAK,CAAC,GAAG;QACP,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QAC1B,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC5B,OAAO,MAAM,CAAC;IAChB,CAAC;CACF;AAED,QAAQ,CAAC,0CAA0C,EAAE,GAAG,EAAE;IACxD;;;OAGG;IACH,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACtD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACxD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH;;;OAGG;IACH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH;;;;;;;OAOG;IACH,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,0CAA0C;QAC1C,MAAM,KAAK,GAAG,EAAE,CAAC;QACjB,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,IAAI,OAAO,GAAQ,IAAI,CAAC;QAExB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,CAAC,EAAE,EAAE,CAAC;YAC/B,OAAO,GAAG,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC;QACtD,CAAC;QAED,4DAA4D;QAC5D,MAAM,SAAS,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC;QACpC,MAAM,QAAQ,GAAG,IAAI,cAAc,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;QACzD,MAAM,cAAc,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QAErD,wCAAwC;QACxC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACtC,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC;QAC7C,uBAAuB,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;QAE3C,iEAAiE;QACjE,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH;;;;;;;;OAQG;IACH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,4BAA4B;QAC5B,MAAM,KAAK,GAAG,GAAG,CAAC;QAClB,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,IAAI,OAAO,GAAQ,IAAI,CAAC;QAExB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,CAAC,EAAE,EAAE,CAAC;YAC/B,OAAO,GAAG,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC;QACtD,CAAC;QAED,8CAA8C;QAC9C,MAAM,SAAS,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC;QACpC,MAAM,QAAQ,GAAG,IAAI,cAAc,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;QACzD,MAAM,cAAc,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QAErD,iCAAiC;QACjC,uBAAuB,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;QAE3C,uDAAuD;QACvD,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC;QAExC,4CAA4C;QAC5C,MAAM,MAAM,GAAG,uBAAuB,CAAC,IAAI,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACjC,CAAC,CAAC,CAAC;IAEH;;;;;;;;OAQG;IACH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,KAAK,GAAG,IAAI,CAAC;QACnB,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,IAAI,OAAO,GAAQ,IAAI,CAAC;QAExB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,CAAC,EAAE,EAAE,CAAC;YAC/B,OAAO,GAAG,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC;QACtD,CAAC;QAED,2CAA2C;QAC3C,MAAM,SAAS,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC;QACpC,MAAM,QAAQ,GAAG,IAAI,cAAc,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;QACzD,MAAM,cAAc,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QAErD,iCAAiC;QACjC,uBAAuB,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;QAE3C,iFAAiF;QACjF,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC;QAEzC,qDAAqD;QACrD,MAAM,MAAM,GAAG,uBAAuB,CAAC,IAAI,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACjC,CAAC,CAAC,CAAC;IAEH;;;;;;;;OAQG;IACH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,yBAAyB;QACzB,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,CAAC,CAAC;QAC5C,MAAM,YAAY,GAAG,GAAG,CAAC;QAEzB,2CAA2C;QAC3C,MAAM,SAAS,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC;QACpC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,MAAM,KAAK,GAAG,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;QACzD,CAAC;QACD,MAAM,aAAa,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QAEpD,uCAAuC;QACvC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,YAAY,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE;YAC9B,uBAAuB,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;QACzC,CAAC,CAAC,CAAC;QAEH,qDAAqD;QACrD,MAAM,CAAC,aAAa,CAAC,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC;QACxC,MAAM,OAAO,GAAG,aAAa,GAAG,YAAY,CAAC;QAC7C,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC,uBAAuB;IAC1D,CAAC,CAAC,CAAC;IAEH;;;;;;;;OAQG;IACH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,gCAAgC;QAChC,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,UAAU,GAAG,GAAG,CAAC;QAEvB,mDAAmD;QACnD,MAAM,cAAc,GAAG,WAAW,CAAC,GAAG,EAAE,CAAC;QACzC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,UAAU,EAAE,CAAC,EAAE,EAAE,CAAC;YACpC,MAAM,KAAK,GAAG,IAAI,cAAc,CAAC,SAAS,CAAC,EAAE,EAAE,IAAI,CAAC,CAAC;QACvD,CAAC;QACD,MAAM,aAAa,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,cAAc,CAAC;QAEzD,wCAAwC;QACxC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,UAAU,CAAC,CAAC;QAE/C,kFAAkF;QAClF,MAAM,CAAC,aAAa,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;QAEzC,qCAAqC;QACrC,MAAM,OAAO,GAAG,aAAa,GAAG,UAAU,CAAC;QAC3C,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC,CAAC,iBAAiB;IACrD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/adversarial/circular-reference.test.d.ts

@@ -0,0 +1,13 @@
+/**
+ * Circular Reference Tests (TDD Red Phase)
+ *
+ * These tests validate the attachChild() method properly prevents
+ * attaching an ancestor workflow as a child (which would create a circular reference).
+ *
+ * This is the RED phase of TDD - tests are written to FAIL initially,
+ * documenting the expected behavior before implementation.
+ *
+ * Related: plan/docs/bugfix-architecture/bug_analysis.md
+ */
+export {};
+//# sourceMappingURL=circular-reference.test.d.ts.map

package/dist/__tests__/adversarial/circular-reference.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"circular-reference.test.d.ts","sourceRoot":"","sources":["../../../src/__tests__/adversarial/circular-reference.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG"}

package/dist/__tests__/adversarial/circular-reference.test.js

@@ -0,0 +1,92 @@
+/**
+ * Circular Reference Tests (TDD Red Phase)
+ *
+ * These tests validate the attachChild() method properly prevents
+ * attaching an ancestor workflow as a child (which would create a circular reference).
+ *
+ * This is the RED phase of TDD - tests are written to FAIL initially,
+ * documenting the expected behavior before implementation.
+ *
+ * Related: plan/docs/bugfix-architecture/bug_analysis.md
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { Workflow } from '../../index.js';
+/**
+ * SimpleWorkflow class for testing
+ * Pattern from: src/__tests__/unit/workflow.test.ts:4-11
+ */
+class SimpleWorkflow extends Workflow {
+    async run() {
+        this.setStatus('running');
+        this.setStatus('completed');
+        return 'done';
+    }
+}
+describe('Adversarial: Circular Reference Detection', () => {
+    /**
+     * Setup: Mock console methods to capture error messages
+     * Pattern from: research/console-mocking.md "Basic Spying Patterns"
+     */
+    beforeEach(() => {
+        vi.spyOn(console, 'log').mockImplementation(() => { });
+        vi.spyOn(console, 'error').mockImplementation(() => { });
+        vi.spyOn(console, 'warn').mockImplementation(() => { });
+    });
+    /**
+     * Teardown: Restore all mocks to prevent test pollution
+     * CRITICAL: Always use vi.restoreAllMocks() in afterEach
+     */
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    /**
+     * Test 1: Immediate Circular Reference
+     *
+     * Bug: attachChild() does NOT check if the child being attached is actually
+     * an ancestor of this workflow (would create a circular reference)
+     *
+     * Expected: Error thrown with message containing 'circular' OR 'cycle' OR 'ancestor'
+     * Actual: No error thrown, circular reference created
+     *
+     * Pattern from: plan/docs/bugfix-architecture/implementation_patterns.md "Pattern 2"
+     */
+    it('should throw when attaching immediate parent as child', () => {
+        // ARRANGE: Create parent and child workflows
+        const parent = new SimpleWorkflow('Parent');
+        const child = new SimpleWorkflow('Child', parent);
+        // Verify initial state
+        // CRITICAL: Constructor auto-attaches child to parent at workflow.ts:113-116
+        expect(child.parent).toBe(parent);
+        expect(parent.children).toContain(child);
+        // ACT & ASSERT: Attempting to attach parent as child should throw
+        // This test FAILS because attachChild() doesn't call this.isDescendantOf(child)
+        expect(() => child.attachChild(parent)).toThrow(/circular|cycle|ancestor/i);
+    });
+    /**
+     * Test 2: Ancestor Circular Reference (Multi-level)
+     *
+     * Bug: attachChild() does NOT check if the child being attached is an ancestor
+     * anywhere up the parent chain (would create a circular reference)
+     *
+     * Expected: Error thrown with message containing 'circular' OR 'cycle' OR 'ancestor'
+     * Actual: No error thrown, circular reference created
+     *
+     * Pattern from: plan/docs/bugfix-architecture/implementation_patterns.md "Pattern 2"
+     */
+    it('should throw when attaching ancestor as child', () => {
+        // ARRANGE: Create 3-level hierarchy
+        const root = new SimpleWorkflow('Root');
+        const child1 = new SimpleWorkflow('Child1', root);
+        const child2 = new SimpleWorkflow('Child2', child1);
+        // Verify initial state
+        // CRITICAL: Constructor auto-attaches at workflow.ts:113-116
+        expect(child2.parent).toBe(child1);
+        expect(child1.parent).toBe(root);
+        expect(root.children).toContain(child1);
+        expect(child1.children).toContain(child2);
+        // ACT & ASSERT: Attempting to attach root as child of child2 should throw
+        // This test FAILS because attachChild() doesn't call this.isDescendantOf(child)
+        expect(() => child2.attachChild(root)).toThrow(/circular|cycle|ancestor/i);
+    });
+});
+//# sourceMappingURL=circular-reference.test.js.map

package/dist/__tests__/adversarial/circular-reference.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"circular-reference.test.js","sourceRoot":"","sources":["../../../src/__tests__/adversarial/circular-reference.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAE1C;;;GAGG;AACH,MAAM,cAAe,SAAQ,QAAQ;IACnC,KAAK,CAAC,GAAG;QACP,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QAC1B,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC5B,OAAO,MAAM,CAAC;IAChB,CAAC;CACF;AAED,QAAQ,CAAC,2CAA2C,EAAE,GAAG,EAAE;IACzD;;;OAGG;IACH,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACtD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACxD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH;;;OAGG;IACH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH;;;;;;;;;;OAUG;IACH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,6CAA6C;QAC7C,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,CAAC,CAAC;QAC5C,MAAM,KAAK,GAAG,IAAI,cAAc,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC;QAElD,uBAAuB;QACvB,6EAA6E;QAC7E,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;QAEzC,kEAAkE;QAClE,gFAAgF;QAChF,MAAM,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH;;;;;;;;;;OAUG;IACH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,oCAAoC;QACpC,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QAClD,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAEpD,uBAAuB;QACvB,6DAA6D;QAC7D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAE1C,0EAA0E;QAC1E,gFAAgF;QAChF,MAAM,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;IAC7E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/adversarial/complex-circular-reference.test.d.ts

@@ -0,0 +1,16 @@
+/**
+ * Complex Circular Reference Tests
+ *
+ * These tests validate that isDescendantOf() correctly detects circular
+ * references at various depths in the workflow tree.
+ *
+ * Test Cases:
+ * 1. Immediate circular reference (depth 1): child.attachChild(parent)
+ * 2. Two-level circular reference (depth 2): grandchild.attachChild(root)
+ * 3. Three-level circular reference (depth 3): great-grandchild.attachChild(root)
+ *
+ * Pattern from: plan/docs/bugfix-architecture/implementation_patterns.md Pattern 8
+ * Related: plan/bugfix/P1M3T1S3/PRP.md
+ */
+export {};
+//# sourceMappingURL=complex-circular-reference.test.d.ts.map

package/dist/__tests__/adversarial/complex-circular-reference.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"complex-circular-reference.test.d.ts","sourceRoot":"","sources":["../../../src/__tests__/adversarial/complex-circular-reference.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}

package/dist/__tests__/adversarial/complex-circular-reference.test.js

@@ -0,0 +1,127 @@
+/**
+ * Complex Circular Reference Tests
+ *
+ * These tests validate that isDescendantOf() correctly detects circular
+ * references at various depths in the workflow tree.
+ *
+ * Test Cases:
+ * 1. Immediate circular reference (depth 1): child.attachChild(parent)
+ * 2. Two-level circular reference (depth 2): grandchild.attachChild(root)
+ * 3. Three-level circular reference (depth 3): great-grandchild.attachChild(root)
+ *
+ * Pattern from: plan/docs/bugfix-architecture/implementation_patterns.md Pattern 8
+ * Related: plan/bugfix/P1M3T1S3/PRP.md
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { Workflow } from '../../index.js';
+/**
+ * SimpleWorkflow class for testing
+ * Pattern from: src/__tests__/adversarial/circular-reference.test.ts:20-26
+ */
+class SimpleWorkflow extends Workflow {
+    async run() {
+        this.setStatus('running');
+        this.setStatus('completed');
+        return 'done';
+    }
+}
+describe('Adversarial: Complex Circular Reference Detection', () => {
+    /**
+     * Setup: Mock console methods to capture error messages
+     * Pattern from: src/__tests__/adversarial/circular-reference.test.ts:33-37
+     */
+    beforeEach(() => {
+        vi.spyOn(console, 'log').mockImplementation(() => { });
+        vi.spyOn(console, 'error').mockImplementation(() => { });
+        vi.spyOn(console, 'warn').mockImplementation(() => { });
+    });
+    /**
+     * Teardown: Restore all mocks to prevent test pollution
+     * CRITICAL: Always use vi.restoreAllMocks() in afterEach
+     */
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    /**
+     * Test 1: Immediate Circular Reference (depth 1)
+     *
+     * Validates that attachChild() prevents creating a cycle when a child
+     * attempts to attach its immediate parent as its child.
+     *
+     * Hierarchy: root -> child1
+     * Cycle attempt: child1.attachChild(root)
+     *
+     * Expected: Error thrown with message containing 'circular' OR 'cycle' OR 'ancestor'
+     */
+    it('should throw when attaching immediate parent as child (depth 1)', () => {
+        // ARRANGE: Create 2-level hierarchy (root, child1)
+        const root = new SimpleWorkflow('Root');
+        const child1 = new SimpleWorkflow('Child1', root);
+        // Verify initial state
+        // CRITICAL: Constructor auto-attaches child to parent at workflow.ts:113-116
+        expect(child1.parent).toBe(root);
+        expect(root.children).toContain(child1);
+        // ACT & ASSERT: Attempting to attach parent as child should throw
+        // This validates isDescendantOf() detects the immediate ancestor
+        expect(() => child1.attachChild(root)).toThrow(/circular|cycle|ancestor/i);
+    });
+    /**
+     * Test 2: Two-Level Circular Reference (depth 2)
+     *
+     * Validates that attachChild() prevents creating a cycle when a grandchild
+     * attempts to attach its grandparent (root) as its child.
+     *
+     * Hierarchy: root -> child1 -> child2
+     * Cycle attempt: child2.attachChild(root)
+     *
+     * Expected: Error thrown with message containing 'circular' OR 'cycle' OR 'ancestor'
+     */
+    it('should throw when attaching grandparent as child (depth 2)', () => {
+        // ARRANGE: Create 3-level hierarchy (root, child1, child2)
+        const root = new SimpleWorkflow('Root');
+        const child1 = new SimpleWorkflow('Child1', root);
+        const child2 = new SimpleWorkflow('Child2', child1);
+        // Verify initial state
+        // CRITICAL: Constructor auto-attaches at workflow.ts:113-116
+        expect(child2.parent).toBe(child1);
+        expect(child1.parent).toBe(root);
+        expect(root.children).toContain(child1);
+        expect(child1.children).toContain(child2);
+        // ACT & ASSERT: Attempting to attach root as child of child2 should throw
+        // This validates isDescendantOf() traverses the full ancestor chain
+        expect(() => child2.attachChild(root)).toThrow(/circular|cycle|ancestor/i);
+    });
+    /**
+     * Test 3: Three-Level Circular Reference (depth 3)
+     *
+     * Validates that attachChild() prevents creating a cycle when a great-grandchild
+     * attempts to attach its great-grandparent (root) as its child.
+     *
+     * Hierarchy: root -> child1 -> child2 -> child3
+     * Cycle attempt: child3.attachChild(root)
+     *
+     * Expected: Error thrown with message containing 'circular' OR 'cycle' OR 'ancestor'
+     *
+     * This test provides NEW coverage not present in circular-reference.test.ts
+     * which only tests depth 1 (immediate parent) and depth 2 (ancestor).
+     */
+    it('should throw when attaching great-grandparent as child (depth 3)', () => {
+        // ARRANGE: Create 4-level hierarchy (root, child1, child2, child3)
+        const root = new SimpleWorkflow('Root');
+        const child1 = new SimpleWorkflow('Child1', root); // root -> child1
+        const child2 = new SimpleWorkflow('Child2', child1); // root -> child1 -> child2
+        const child3 = new SimpleWorkflow('Child3', child2); // root -> child1 -> child2 -> child3
+        // Verify initial state
+        // CRITICAL: Constructor auto-attaches at workflow.ts:113-116
+        expect(child3.parent).toBe(child2);
+        expect(child2.parent).toBe(child1);
+        expect(child1.parent).toBe(root);
+        expect(root.children).toContain(child1);
+        expect(child1.children).toContain(child2);
+        expect(child2.children).toContain(child3);
+        // ACT & ASSERT: Attempting to attach root as child of child3 should throw
+        // This validates isDescendantOf() detects deep ancestors (3+ levels)
+        expect(() => child3.attachChild(root)).toThrow(/circular|cycle|ancestor/i);
+    });
+});
+//# sourceMappingURL=complex-circular-reference.test.js.map

package/dist/__tests__/adversarial/complex-circular-reference.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"complex-circular-reference.test.js","sourceRoot":"","sources":["../../../src/__tests__/adversarial/complex-circular-reference.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAE1C;;;GAGG;AACH,MAAM,cAAe,SAAQ,QAAQ;IACnC,KAAK,CAAC,GAAG;QACP,IAAI,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QAC1B,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC5B,OAAO,MAAM,CAAC;IAChB,CAAC;CACF;AAED,QAAQ,CAAC,mDAAmD,EAAE,GAAG,EAAE;IACjE;;;OAGG;IACH,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACtD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACxD,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,kBAAkB,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH;;;OAGG;IACH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH;;;;;;;;;;OAUG;IACH,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,mDAAmD;QACnD,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QAElD,uBAAuB;QACvB,6EAA6E;QAC7E,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAExC,kEAAkE;QAClE,iEAAiE;QACjE,MAAM,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;IAC7E,CAAC,CAAC,CAAC;IAEH;;;;;;;;;;OAUG;IACH,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,2DAA2D;QAC3D,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QAClD,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAEpD,uBAAuB;QACvB,6DAA6D;QAC7D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAE1C,0EAA0E;QAC1E,oEAAoE;QACpE,MAAM,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;IAC7E,CAAC,CAAC,CAAC;IAEH;;;;;;;;;;;;;OAaG;IACH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QAC1E,mEAAmE;QACnE,MAAM,IAAI,GAAG,IAAI,cAAc,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAG,iBAAiB;QACtE,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC,2BAA2B;QAChF,MAAM,MAAM,GAAG,IAAI,cAAc,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC,qCAAqC;QAE1F,uBAAuB;QACvB,6DAA6D;QAC7D,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAE1C,0EAA0E;QAC1E,qEAAqE;QACrE,MAAM,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;IAC7E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/adversarial/concurrent-task-failures.test.d.ts

@@ -0,0 +1,21 @@
+/**
+ * Concurrent Task Failure Scenarios Test Suite
+ *
+ * Tests the Promise.allSettled implementation in @Task decorator
+ * for concurrent execution with various failure scenarios.
+ *
+ * Validates:
+ * - Single child failure in concurrent batch
+ * - Multiple children failing concurrently
+ * - Mixed success/failure scenarios
+ * - All children failing edge case
+ * - No orphaned or hanging promises
+ * - Error collection correctness
+ * - Event emission during failures
+ *
+ * Related:
+ * - S2 Implementation: Promise.allSettled in task.ts (lines 111-120)
+ * - Bug: 001_e8e04329daf3 - Concurrent task error collection
+ */
+export {};
+//# sourceMappingURL=concurrent-task-failures.test.d.ts.map

package/dist/__tests__/adversarial/concurrent-task-failures.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"concurrent-task-failures.test.d.ts","sourceRoot":"","sources":["../../../src/__tests__/adversarial/concurrent-task-failures.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG"}