groove-dev 0.27.217 → 0.27.220

package/.promote-remotes

@@ -0,0 +1 @@
+axom@10.0.0.205   # DGX Spark (edgexpert-aaa6) — "axom" is just the login user on that box

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.217",
+  "version": "0.27.220",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.217",
+  "version": "0.27.220",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/providers/claude-code.js

@@ -43,11 +43,12 @@ export class ClaudeCodeProvider extends Provider {
     // FIRST model of a tier. Opus 5 stays first so auto-routing doesn't silently
     // move heavy agents onto the Fable price tier (2× Opus per token) — Fable is
     // an explicit user choice.
-    { id: 'claude-opus-5', name: 'Claude Opus 5', tier: 'heavy', contextWindow: 1_000_000 },
+    { id: 'claude-opus-5-5', name: 'Claude Opus 5.5', tier: 'heavy', contextWindow: 1_000_000 },
     { id: 'claude-fable-5-1', name: 'Claude Fable 5.1', tier: 'heavy', contextWindow: 1_000_000 },
     { id: 'claude-fable-5', name: 'Claude Fable 5', tier: 'heavy', contextWindow: 1_000_000 },
     { id: 'claude-opus-4-8', name: 'Claude Opus 4.8', tier: 'heavy', contextWindow: 1_000_000 },
     { id: 'claude-opus-4-6', name: 'Claude Opus 4.6', tier: 'heavy', contextWindow: 1_000_000 },
+    { id: 'claude-sonnet-5', name: 'Claude Sonnet 5', tier: 'medium', contextWindow: 1_000_000 },
     { id: 'claude-sonnet-4-6', name: 'Claude Sonnet 4.6', tier: 'medium', contextWindow: 200_000 },
     { id: 'claude-haiku-4-5-20251001', name: 'Claude Haiku 4.5', tier: 'light', contextWindow: 200_000 },
   ];

package/node_modules/@groove-dev/daemon/src/terminal-pty.js

@@ -4,6 +4,7 @@
 import { spawn, execFileSync } from 'child_process';
 import { randomUUID } from 'crypto';
 import { existsSync } from 'fs';
+import { StringDecoder } from 'string_decoder';
 
 // Python helper that creates a real PTY and relays I/O through stdin/stdout pipes.
 // The shell sees a genuine TTY — prompts, colors, line editing, tab completion all work.
@@ -64,12 +65,22 @@ try:
             bel_pos = stdin_buf.find(ESC_END)
             if bel_pos == -1:
                 break
-            params = stdin_buf[4:bel_pos].decode().split(';')
-            if len(params) == 2:
-                r, c = int(params[0]), int(params[1])
-                fcntl.ioctl(master, termios.TIOCSWINSZ, struct.pack('HHHH', r, c, 0, 0))
-                os.kill(pid, signal.SIGWINCH)
+            # Only OUR resize command lives on this channel — no real terminal
+            # sends OSC 7 as keyboard input. A malformed one used to raise
+            # inside this loop, escape it, and take the whole shell down; now
+            # it is simply dropped (forwarding it would feed the shell's line
+            # editor a garbage key chord).
+            raw = stdin_buf[:bel_pos+1]
             stdin_buf = stdin_buf[bel_pos+1:]
+            try:
+                params = raw[4:-1].decode().split(';')
+                if len(params) == 2:
+                    r, c = int(params[0]), int(params[1])
+                    if 0 < r < 1000 and 0 < c < 1000:
+                        fcntl.ioctl(master, termios.TIOCSWINSZ, struct.pack('HHHH', r, c, 0, 0))
+                        os.kill(pid, signal.SIGWINCH)
+            except (ValueError, UnicodeDecodeError, OSError):
+                pass
         if master in rlist:
             try:
                 data = os.read(master, 4096)
@@ -128,16 +139,23 @@ export class TerminalManager {
     const session = { proc, ws, id, label: options.label || '' };
     this.sessions.set(id, session);
 
+    // The PTY relay hands us arbitrary 4096-byte slices, and a multi-byte UTF-8
+    // character (box drawing, emoji — TUI apps are full of them) can straddle a
+    // slice. Buffer.toString() on each slice independently turns every such
+    // character into U+FFFD garbage; a StringDecoder carries the partial byte
+    // sequence across chunks.
+    const outDecoder = new StringDecoder('utf8');
+    const errDecoder = new StringDecoder('utf8');
     proc.stdout.on('data', (data) => {
-      if (ws.readyState === 1) {
-        ws.send(JSON.stringify({ type: 'terminal:output', id, data: data.toString('utf8') }));
-      }
+      if (ws.readyState !== 1) return;
+      const text = outDecoder.write(data);
+      if (text) ws.send(JSON.stringify({ type: 'terminal:output', id, data: text }));
     });
 
     proc.stderr.on('data', (data) => {
-      if (ws.readyState === 1) {
-        ws.send(JSON.stringify({ type: 'terminal:output', id, data: data.toString('utf8') }));
-      }
+      if (ws.readyState !== 1) return;
+      const text = errDecoder.write(data);
+      if (text) ws.send(JSON.stringify({ type: 'terminal:output', id, data: text }));
     });
 
     proc.on('exit', (code) => {

package/node_modules/@groove-dev/daemon/src/tunnel-manager.js

@@ -15,6 +15,20 @@ function getLocalVersion() {
   } catch { return '0.0.0'; }
 }
 
+// True only when `a` is strictly older than `b` (numeric x.y.z; any suffix such
+// as "-local" is ignored). Auto-upgrade must never move a remote BACKWARDS: a
+// box running a newer local build (promote-local.sh) than npm's latest would
+// otherwise be "upgraded" down to the published release on every connect.
+export function isOlderVersion(a, b) {
+  const parse = (v) => String(v || '').split('-')[0].split('.').map((n) => parseInt(n, 10) || 0);
+  const pa = parse(a), pb = parse(b);
+  for (let i = 0; i < Math.max(pa.length, pb.length); i++) {
+    const d = (pa[i] || 0) - (pb[i] || 0);
+    if (d !== 0) return d < 0;
+  }
+  return false;
+}
+
 const REMOTE_PORT = 31415;
 
 // Every remote `groove start` must run from the directory of the daemon's
@@ -665,13 +679,13 @@ export class TunnelManager {
         }).trim();
       } catch { return; }
 
-      if (!npmVer || npmVer === remoteVer) {
+      if (!npmVer || !isOlderVersion(remoteVer, npmVer)) {
         const localVer = getLocalVersion();
         this.daemon.broadcast({ type: 'tunnel.version-info', data: { id, localVersion: localVer, remoteVersion: remoteVer, match: remoteVer === localVer } });
         return;
       }
 
-      // Remote is behind npm — upgrade
+      // Remote is strictly behind npm — upgrade
       this.daemon.broadcast({ type: 'tunnel.status', data: { id, step: 'upgrading', from: remoteVer, to: npmVer } });
 
       const target = `${config.user}@${config.host}`;

package/node_modules/@groove-dev/daemon/test/claude-code-provider.test.js

@@ -125,9 +125,9 @@ describe('ClaudeCodeProvider models', () => {
   it('offers Fable 5', () => {
     assert.ok(ClaudeCodeProvider.models.some((m) => m.id === 'claude-fable-5'));
     assert.ok(ClaudeCodeProvider.models.some((m) => m.id === 'claude-fable-5-1'));
-    // Routing guard: Opus 5 must stay models[0] — the Router defaults to it and
-    // putting a Fable model first would silently route heavy agents onto a tier
-    // priced at twice Opus.
-    assert.equal(ClaudeCodeProvider.models[0].id, 'claude-opus-5');
+    // Routing guard: an Opus model must stay models[0] — the Router defaults to
+    // it and putting a Fable model first would silently route heavy agents onto
+    // a tier priced at twice Opus.
+    assert.equal(ClaudeCodeProvider.models[0].id, 'claude-opus-5-5');
   });
 });

package/node_modules/@groove-dev/daemon/test/terminal-pty.test.js

@@ -0,0 +1,80 @@
+// GROOVE — Terminal PTY relay tests
+// FSL-1.1-Apache-2.0 — see LICENSE
+//
+// Spawns the real Python PTY helper + a shell. Guards the relay against the
+// failures that made TUI apps (Textual etc.) render garbage or die:
+//   - multi-byte UTF-8 split across 4096-byte relay chunks → U+FFFD garbage
+//   - a malformed in-band resize sequence killing the whole relay loop
+
+import { describe, it, afterEach } from 'node:test';
+import assert from 'node:assert/strict';
+import { TerminalManager } from '../src/terminal-pty.js';
+
+function fakeWs() {
+  const ws = { readyState: 1, out: [], exit: null };
+  ws.send = (raw) => {
+    const m = JSON.parse(raw);
+    if (m.type === 'terminal:output') ws.out.push(m.data);
+    if (m.type === 'terminal:exit') ws.exit = m.code;
+  };
+  return ws;
+}
+const settle = (ms) => new Promise((r) => setTimeout(r, ms));
+async function waitFor(pred, ms = 20000) {
+  const end = Date.now() + ms;
+  while (Date.now() < end) { if (pred()) return true; await settle(100); }
+  return pred();
+}
+
+describe('TerminalManager (real PTY helper)', () => {
+  let mgr;
+  afterEach(() => { mgr?.killAll(); });
+
+  it('relays multi-byte UTF-8 intact across chunk boundaries', async () => {
+    mgr = new TerminalManager({ projectDir: '/tmp' });
+    const ws = fakeWs();
+    const id = mgr.spawn(ws, { cols: 100, rows: 30, cwd: '/tmp' });
+    assert.ok(id);
+    await waitFor(() => ws.out.join('').length > 0);
+
+    // 3000 × '★' (3 bytes each) = 9000 bytes: guaranteed to straddle the
+    // helper's 4096-byte reads several times. The marker is assembled at
+    // runtime from two halves so the shell's ECHO of the typed command never
+    // contains it — only the real output does. (Counting echoed markers made
+    // this race on shells that redraw the input line.)
+    const marker = 'UTF8TEST';
+    mgr.write(id, `M="UTF8""TEST"; printf "$M"; python3 -c "print('\\u2605'*3000, end='')"; printf "$M\\n"\r`);
+    const ok = await waitFor(() => {
+      const all = ws.out.join('');
+      const first = all.indexOf(marker);
+      return first !== -1 && all.indexOf(marker, first + marker.length) !== -1;
+    });
+    assert.ok(ok, 'command output arrived');
+
+    const all = ws.out.join('');
+    const body = all.slice(all.indexOf(marker) + marker.length, all.lastIndexOf(marker));
+    assert.equal((body.match(/�/g) || []).length, 0, 'no replacement characters');
+    assert.equal((body.match(/★/g) || []).length, 3000, 'every star survived the relay');
+  });
+
+  it('resizes the PTY in-band and survives a malformed resize sequence', async () => {
+    mgr = new TerminalManager({ projectDir: '/tmp' });
+    const ws = fakeWs();
+    const id = mgr.spawn(ws, { cols: 80, rows: 24, cwd: '/tmp' });
+    await waitFor(() => ws.out.join('').length > 0);
+
+    mgr.resize(id, 40, 132);
+    await settle(300);
+    mgr.write(id, 'stty size\r');
+    assert.ok(await waitFor(() => /40 132/.test(ws.out.join(''))), 'shell sees the new size');
+
+    // Garbage that shares our OSC 7 prefix — previously raised inside the relay
+    // loop, escaped it, and took the shell down with it.
+    mgr.write(id, '\x1b]7;not;numbers;at;all\x07');
+    mgr.write(id, '\x1b]7;file://host/tmp\x07');
+    await settle(300);
+    mgr.write(id, 'echo STILL_ALIVE_$((6*7))\r');
+    assert.ok(await waitFor(() => ws.out.join('').includes('STILL_ALIVE_42')), 'relay survived');
+    assert.equal(ws.exit, null, 'session did not exit');
+  });
+});

package/node_modules/@groove-dev/daemon/test/tunnel-manager.test.js

@@ -392,3 +392,14 @@ describe('resolveBestAddress — multi-homed host selection', () => {
     assert.equal(await resolveBestAddress('localhost', deadPort, 500), 'localhost');
   });
 });
+
+describe('isOlderVersion (auto-upgrade never downgrades)', () => {
+  it('only reports strictly older versions', async () => {
+    const { isOlderVersion } = await import('../src/tunnel-manager.js');
+    assert.equal(isOlderVersion('0.27.216', '0.27.217'), true);
+    assert.equal(isOlderVersion('0.27.9', '0.27.10'), true);
+    assert.equal(isOlderVersion('0.27.219', '0.27.217'), false); // local build ahead of npm
+    assert.equal(isOlderVersion('0.27.217', '0.27.217'), false);
+    assert.equal(isOlderVersion('0.27.219-local', '0.27.217'), false);
+  });
+});