groove-dev 0.27.138 → 0.27.139

package/CLAUDE.md

@@ -1,7 +1,30 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
 # GROOVE — Agent Orchestration Layer
 
 > Spawn fast. Stay aware. Never lose context.
 
+## Build & Development Commands
+
+```bash
+# Build GUI (required after any GUI changes — daemon serves built assets)
+npm run build                    # or: cd packages/gui && npx vite build
+
+# Run all tests (265 tests, 24 suites)
+npm test                         # or: node --test packages/daemon/test/*.test.js
+
+# Run a single test file
+node --test packages/daemon/test/registry.test.js
+
+# Dev servers (not for agents — agents use npm run build)
+npm run dev:gui                  # Vite dev server (HMR)
+npm run dev:daemon               # Daemon in dev mode
+```
+
+**Important:** GUI changes require `npm run build` to take effect (daemon serves static build from `packages/gui/dist/`). Daemon changes require a manual daemon restart — agents must NEVER restart the daemon themselves.
+
 ## What This Is
 
 GROOVE is a lightweight, open-source agent orchestration layer for AI coding tools. It is a **process manager** — it spawns, coordinates, and monitors AI coding agents. It does NOT wrap, proxy, or impersonate any AI API.
@@ -92,7 +115,7 @@ Bundled starter teams: `fullstack.json`, `api-builder.json`, `monorepo.json`
 - Tailwind CSS v4 + Radix UI (GUI styling + accessible primitives)
 - Zustand 5 (GUI state + WebSocket sync)
 - React Flow / @xyflow/react (agent tree visualization)
-- CodeMirror 6 (code editor, 7 languages)
+- CodeMirror 6 + @uiw/codemirror-themes-all (code editor, 7 languages, 38 selectable themes)
 - xterm.js (terminal emulation)
 - Framer Motion (animations)
 - Lucide React (icons)
@@ -201,7 +224,7 @@ React app served by daemon at `http://localhost:31415`. VS Code-style layout. Ta
 - Log files created with 0o600 permissions
 - Command injection prevention (execFileSync with array args in tmux)
 - Scope patterns validated (no absolute paths, no traversal)
-- 137 automated tests across 14 suites
+- 265 automated tests across 24 suites
 
 ## Conventions
 
@@ -211,6 +234,15 @@ React app served by daemon at `http://localhost:31415`. VS Code-style layout. Ta
 - `.groove/` directory in project root for runtime state (gitignored)
 - Generated markdown files: `AGENTS_REGISTRY.md`, `GROOVE_PROJECT_MAP.md`, `GROOVE_DECISIONS.md`
 
+## GUI Styling Rules
+
+- **Tailwind CSS v4 only** — zero inline styles (no `style={{}}` except dynamic values like `width`, `height`)
+- **No absolute-positioned floating buttons** over content — use flex layout rails instead
+- **File tree icons** must be neutral/muted (`text-text-2`/`text-text-3`) — no rainbow colors
+- **Editor themes** are user-selectable via status bar picker — do not hardcode syntax highlight colors
+- **Font sizes:** file trees use `text-xs` (12px), editor uses 12px via theme
+- **No inline styles for colors** — use design token CSS variables (`--color-accent`, `--color-danger`, etc.)
+
 ## Compliance (CRITICAL)
 
 GROOVE is a process manager, NOT a harness. Hard rules:

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.138",
+  "version": "0.27.139",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.138",
+  "version": "0.27.139",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/api.js

@@ -1693,18 +1693,29 @@ export function createApi(app, daemon) {
   // Rotation = full handoff brief (only for degradation or no session)
   app.post('/api/agents/:id/instruct', async (req, res) => {
     try {
-      const { message } = req.body;
+      const { message, codeContext } = req.body;
       if (!message || typeof message !== 'string' || !message.trim()) {
         return res.status(400).json({ error: 'message is required' });
       }
       const agent = daemon.registry.get(req.params.id);
       if (!agent) return res.status(404).json({ error: 'Agent not found' });
 
+      // Build the final instruction, optionally enriched with code context
+      let finalMessage = message.trim();
+      if (codeContext && typeof codeContext === 'object') {
+        const { filePath, lineStart, lineEnd, selectedCode } = codeContext;
+        if (filePath && typeof filePath === 'string' && selectedCode && typeof selectedCode === 'string') {
+          const start = Number.isFinite(lineStart) ? lineStart : '?';
+          const end = Number.isFinite(lineEnd) ? lineEnd : '?';
+          finalMessage = `${finalMessage}\n\nCode context from ${filePath} (lines ${start}-${end}):\n\`\`\`\n${selectedCode}\n\`\`\``;
+        }
+      }
+
       // Record user feedback so the journalist can include it in future agent context
-      if (daemon.journalist) daemon.journalist.recordUserFeedback(agent, message.trim());
+      if (daemon.journalist) daemon.journalist.recordUserFeedback(agent, finalMessage);
 
       // Agent loop path — send message directly to the running loop
-      const wrappedMessage = wrapWithRoleReminder(agent.role, message.trim());
+      const wrappedMessage = wrapWithRoleReminder(agent.role, finalMessage);
       if (daemon.processes.hasAgentLoop(req.params.id)) {
         const sent = await daemon.processes.sendMessage(req.params.id, wrappedMessage);
         if (sent) {
@@ -1731,7 +1742,7 @@ export function createApi(app, daemon) {
           scope: oldConfig.scope,
           provider: oldConfig.provider,
           model: oldConfig.model,
-          prompt: message.trim(),
+          prompt: finalMessage,
           permission: oldConfig.permission || 'full',
           workingDir: oldConfig.workingDir,
           name: oldConfig.name,
@@ -1754,7 +1765,7 @@ export function createApi(app, daemon) {
           scope: oldConfig.scope,
           provider: oldConfig.provider,
           model: oldConfig.model,
-          prompt: message.trim(),
+          prompt: finalMessage,
           introContext: oldConfig.introContext,
           permission: oldConfig.permission || 'full',
           workingDir: oldConfig.workingDir,
@@ -3340,11 +3351,118 @@ Keep responses concise. Help them think, don't lecture them about the system the
     });
   });
 
+  // Git line status — per-line modification status for editor gutter decorations
+  app.get('/api/files/git-line-status', (req, res) => {
+    const relPath = req.query.path;
+    if (!relPath || typeof relPath !== 'string') {
+      return res.status(400).json({ error: 'path parameter is required' });
+    }
+    if (relPath.includes('\0') || relPath.startsWith('/')) {
+      return res.status(400).json({ error: 'Invalid path' });
+    }
+    const segments = relPath.split(/[/\\]/);
+    if (segments.some(s => s === '..')) {
+      return res.status(400).json({ error: 'Path traversal not allowed' });
+    }
+
+    const rootDir = getEditorRoot();
+    if (!rootDir) return res.status(400).json({ error: 'Editor root not set' });
+
+    const fullPath = resolve(rootDir, relPath);
+    if (!fullPath.startsWith(rootDir + sep) && fullPath !== rootDir) {
+      return res.status(400).json({ error: 'Path outside project' });
+    }
+
+    const result = { lines: { added: [], modified: [], deleted: [] } };
+
+    // Check if file is tracked by git
+    try {
+      execFileSync('git', ['ls-files', '--error-unmatch', '--', relPath], { cwd: rootDir, timeout: 5000, stdio: 'pipe' });
+    } catch {
+      // File not tracked — check if it exists (untracked = all lines added)
+      if (existsSync(fullPath)) {
+        try {
+          const content = readFileSync(fullPath, 'utf8');
+          const lineCount = content.split('\n').length;
+          for (let i = 1; i <= lineCount; i++) result.lines.added.push(i);
+        } catch { /* binary or unreadable */ }
+      }
+      return res.json(result);
+    }
+
+    try {
+      const diffOut = execFileSync('git', ['diff', '--unified=0', '--', relPath], {
+        cwd: rootDir, timeout: 10000, maxBuffer: 5 * 1024 * 1024,
+      }).toString();
+
+      if (!diffOut.trim()) return res.json(result);
+
+      // Check for binary
+      if (diffOut.includes('Binary files')) return res.json(result);
+
+      // Parse unified diff hunks: @@ -oldStart,oldCount +newStart,newCount @@
+      const hunkRe = /^@@ -(\d+)(?:,(\d+))? \+(\d+)(?:,(\d+))? @@/gm;
+      let match;
+      while ((match = hunkRe.exec(diffOut)) !== null) {
+        const oldCount = parseInt(match[2] ?? '1', 10);
+        const newStart = parseInt(match[3], 10);
+        const newCount = parseInt(match[4] ?? '1', 10);
+
+        if (oldCount === 0 && newCount > 0) {
+          // Pure addition
+          for (let i = newStart; i < newStart + newCount; i++) result.lines.added.push(i);
+        } else if (newCount === 0 && oldCount > 0) {
+          // Pure deletion — mark the line where content was removed
+          result.lines.deleted.push(newStart);
+        } else {
+          // Modification
+          for (let i = newStart; i < newStart + newCount; i++) result.lines.modified.push(i);
+        }
+      }
+
+      res.json(result);
+    } catch (err) {
+      if (err.status !== undefined) return res.json(result);
+      res.status(500).json({ error: 'Failed to compute line status' });
+    }
+  });
+
+  // Git branches — list all local branches with current branch marked
+  app.get('/api/files/git-branches', (req, res) => {
+    const rootDir = getEditorRoot();
+    if (!rootDir) return res.status(400).json({ error: 'Editor root not set' });
+
+    const fallback = { current: null, branches: [] };
+
+    try {
+      let current = null;
+      try {
+        current = execFileSync('git', ['rev-parse', '--abbrev-ref', 'HEAD'], {
+          cwd: rootDir, timeout: 5000, stdio: 'pipe',
+        }).toString().trim();
+      } catch { return res.json(fallback); }
+
+      const branchOut = execFileSync('git', ['branch', '--list', '--format=%(refname:short)'], {
+        cwd: rootDir, timeout: 5000, stdio: 'pipe',
+      }).toString();
+
+      const branches = branchOut.split('\n').map(b => b.trim()).filter(Boolean);
+      res.json({ current, branches });
+    } catch {
+      res.json(fallback);
+    }
+  });
+
   // Files touched by an agent during its session
   app.get('/api/agents/:id/files-touched', (req, res) => {
     const agent = daemon.registry.get(req.params.id);
     if (!agent) return res.status(404).json({ error: 'Agent not found' });
-    const files = daemon.registry.getFilesTouched(req.params.id);
+    const rawFiles = daemon.registry.getFilesTouched(req.params.id);
+    const rootDir = agent.workingDir || daemon.projectDir;
+    const files = rawFiles.map(f => {
+      const fullPath = isAbsolute(f.path) ? f.path : resolve(rootDir, f.path);
+      return { ...f, exists: existsSync(fullPath) };
+    });
     res.json({ files, total: files.length });
   });
 

package/node_modules/@groove-dev/daemon/src/introducer.js

@@ -173,12 +173,17 @@ export class Introducer {
         }
       }
 
-      // Project files section — tell the new agent what exists and what to read
+      // Project files section — tell the new agent what exists
+      // When no task is assigned, list files as reference only (not an action prompt)
       if (allTeamFiles.length > 0) {
         lines.push('');
         lines.push(`## Project Files`);
         lines.push('');
-        lines.push(`Your team has created the following files. **Read relevant ones before starting work** to understand what's been built and planned:`);
+        if (hasTask || isRotation) {
+          lines.push(`Your team has created the following files. **Read relevant ones before starting work** to understand what's been built and planned:`);
+        } else {
+          lines.push(`Your team has created the following files (for reference — do NOT read or act on these until you receive a task):`);
+        }
         lines.push('');
 
         // Group by agent for clarity

package/node_modules/@groove-dev/daemon/src/process.js

@@ -887,23 +887,26 @@ export class ProcessManager {
       }
     }
 
+    // Compute hasTask from actual prompt content — agents spawned without a
+    // prompt should NOT receive handoff history (prevents cross-team contamination).
+    // Discoveries + constraints are always injected (project knowledge).
+    // Handoffs are injected only when the agent has a real task or is a rotation.
+    const hasTask = !!(config.prompt && config.prompt.trim().length > 0);
+    const isRotation = !!(config.isRotation);
+
     // Pre-spawn task negotiation — if same-role agents are running,
-    // query them about current work so the new agent gets a clear assignment
+    // query them about current work so the new agent gets a clear assignment.
+    // Only negotiate when the agent has a task — otherwise the negotiator
+    // output acts as an implicit task and the agent starts working immediately.
     const sameRole = registry.getAll().filter(
       (a) => a.role === config.role && a.id !== agent.id &&
         (a.status === 'running' || a.status === 'starting')
     );
     let taskNegotiation = '';
-    if (sameRole.length > 0) {
+    if (sameRole.length > 0 && (hasTask || isRotation)) {
       taskNegotiation = await this.negotiateTaskSplit(agent, sameRole);
     }
 
-    // Compute hasTask from actual prompt content — agents spawned without a
-    // prompt should NOT receive handoff history (prevents cross-team contamination).
-    // Discoveries + constraints are always injected (project knowledge).
-    // Handoffs are injected only when the agent has a real task or is a rotation.
-    const hasTask = !!(config.prompt && config.prompt.trim().length > 0);
-    const isRotation = !!(config.isRotation);
     let introContext = introducer.generateContext(agent, { taskNegotiation, hasTask, isRotation });
 
     // Intro context size warning and optional truncation (Change 7)