groove-dev 0.27.131 → 0.27.134

package/packages/daemon/src/preview.js

@@ -116,67 +116,94 @@ export class PreviewService {
       return { launched: false, reason: installResult.reason };
     }
 
-    let result;
-    if (preview.kind === 'static-html') {
-      if (this._needsBuild(baseDir, preview)) {
-        const buildResult = this._runBuild(teamId, baseDir);
-        if (buildResult?.failed) {
-          this.daemon.audit?.log('preview.failed', { teamId, reason: buildResult.reason });
-          return { launched: false, reason: buildResult.reason };
-        }
-        const distDir = resolve(baseDir, 'dist');
-        if (existsSync(distDir)) {
-          result = await this._launchStatic(teamId, distDir, { ...preview, openPath: preview.openPath || 'index.html' });
-        } else {
-          result = await this._launchStatic(teamId, baseDir, preview);
-        }
-      } else {
-        const distDir = resolve(baseDir, 'dist');
-        const openFile = (preview.openPath || 'index.html').replace(/^\/+/, '');
-        if (existsSync(resolve(distDir, openFile))) {
-          result = await this._launchStatic(teamId, distDir, { ...preview, openPath: openFile });
-        } else {
-          result = await this._launchStatic(teamId, baseDir, preview);
+    // Static-first strategy: always try build+static before dev-server.
+    // Static serving is near-100% reliable — no port conflicts, no proxy
+    // issues, no HMR quirks, no URL rewriting. Dev servers fail constantly
+    // in AI-generated projects (wrong ports, missing scripts, relative path
+    // breakage through the proxy). Only fall back to dev-server when there
+    // is no build output at all.
+
+    const openFile = (preview.openPath || 'index.html').replace(/^\/+/, '');
+    const pkgPath = resolve(baseDir, 'package.json');
+    let hasBuildScript = false;
+    let isFrontendProject = false;
+    try {
+      const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+      hasBuildScript = !!pkg.scripts?.build;
+      const allDeps = { ...pkg.dependencies, ...pkg.devDependencies };
+      isFrontendProject = !!(allDeps?.react || allDeps?.vue || allDeps?.svelte || allDeps?.vite
+        || allDeps?.['@angular/core'] || allDeps?.next || allDeps?.nuxt || allDeps?.astro);
+    } catch { /* no package.json or malformed */ }
+
+    // Also detect frontend by config files
+    if (!isFrontendProject) {
+      const frontendConfigs = ['vite.config', 'next.config', 'webpack.config', 'svelte.config', 'astro.config', 'nuxt.config', 'angular.json'];
+      for (const cfg of frontendConfigs) {
+        if (['.js', '.ts', '.mjs', '.cjs', ''].some((ext) => existsSync(resolve(baseDir, cfg + ext)))) {
+          isFrontendProject = true;
+          break;
         }
       }
-    } else if (preview.kind === 'dev-server') {
-      if (this._needsPreBuild(baseDir)) {
-        const preBuild = this._runBuild(teamId, baseDir);
-        if (preBuild?.failed) {
-          this.daemon.audit?.log('preview.prebuild-failed', { teamId, reason: preBuild.reason });
+    }
+
+    // Common build output directories
+    const OUTPUT_DIRS = ['dist', 'build', 'out', '.next/standalone', 'public'];
+
+    let result;
+
+    // Strategy 1: Build and serve static (only for frontend projects — skip for backends)
+    if (hasBuildScript && (isFrontendProject || preview.kind === 'static-html')) {
+      const buildResult = this._runBuild(teamId, baseDir);
+      if (!buildResult?.failed) {
+        result = this._findAndServeStatic(teamId, baseDir, OUTPUT_DIRS, openFile, preview);
+        if (result && (await result).launched) {
+          result = await result;
+          this.daemon.audit?.log('preview.launched', { teamId, url: result.url, kind: result.kind, baseDir, strategy: 'build-static' });
+          return result;
         }
       }
+    }
+
+    // Strategy 2: Serve existing static files (pre-built, plain HTML, no-build projects)
+    result = this._findAndServeStatic(teamId, baseDir, OUTPUT_DIRS, openFile, preview);
+    if (result && (await result).launched) {
+      result = await result;
+      this.daemon.audit?.log('preview.launched', { teamId, url: result.url, kind: result.kind, baseDir, strategy: 'serve-existing' });
+      return result;
+    }
+
+    // Strategy 3: Dev server (backends, SSR frameworks, projects with no static output)
+    if (preview.kind === 'dev-server') {
       result = await this._launchDevServer(teamId, baseDir, preview);
-      // Fallback: if dev-server failed, try building and serving statically
-      if (!result.launched) {
-        const pkgPath = resolve(baseDir, 'package.json');
-        if (existsSync(pkgPath)) {
-          try {
-            const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
-            if (pkg.scripts?.build) {
-              const buildResult = this._runBuild(teamId, baseDir);
-              if (!buildResult?.failed) {
-                const distDir = resolve(baseDir, 'dist');
-                if (existsSync(resolve(distDir, 'index.html'))) {
-                  result = await this._launchStatic(teamId, distDir, { ...preview, openPath: 'index.html' });
-                }
-              }
-            }
-          } catch { /* fallback failed, keep original error */ }
-        }
+      if (result?.launched) {
+        this.daemon.audit?.log('preview.launched', { teamId, url: result.url, kind: result.kind, baseDir, strategy: 'dev-server' });
+        return result;
       }
-    } else {
-      result = { launched: false, reason: `unknown_kind: ${preview.kind}` };
     }
 
-    if (result.launched) {
-      this.daemon.audit?.log('preview.launched', { teamId, url: result.url, kind: result.kind, baseDir });
-    } else {
-      this.daemon.audit?.log('preview.failed', { teamId, reason: result.reason, baseDir });
-    }
+    result = result || { launched: false, reason: 'all_strategies_failed' };
+    this.daemon.audit?.log('preview.failed', { teamId, reason: result.reason, baseDir });
     return result;
   }
 
+  _findAndServeStatic(teamId, baseDir, outputDirs, openFile, preview) {
+    // Check output directories first, then baseDir itself
+    for (const dir of outputDirs) {
+      const fullDir = resolve(baseDir, dir);
+      if (existsSync(resolve(fullDir, openFile))) {
+        return this._launchStatic(teamId, fullDir, { ...preview, openPath: openFile });
+      }
+      if (openFile !== 'index.html' && existsSync(resolve(fullDir, 'index.html'))) {
+        return this._launchStatic(teamId, fullDir, { ...preview, openPath: 'index.html' });
+      }
+    }
+    // Finally check baseDir itself (plain HTML projects)
+    if (existsSync(resolve(baseDir, openFile))) {
+      return this._launchStatic(teamId, baseDir, { ...preview, openPath: openFile });
+    }
+    return Promise.resolve({ launched: false, reason: 'no_static_entry' });
+  }
+
   _ensureDependencies(teamId, baseDir) {
     const pkgPath = resolve(baseDir, 'package.json');
     const nodeModules = resolve(baseDir, 'node_modules');
@@ -262,18 +289,18 @@ export class PreviewService {
       if (!pkg.scripts?.build) return { failed: true, reason: 'no build script' };
     } catch { return { failed: true, reason: 'malformed package.json' }; }
 
-    const isVite = ['vite.config.js', 'vite.config.ts', 'vite.config.mjs']
+    const isVite = ['vite.config.js', 'vite.config.ts', 'vite.config.mjs', 'vite.config.cjs']
       .some((f) => existsSync(resolve(baseDir, f)));
 
     let command = 'npm run build';
-    const buildScript = (pkg.scripts.build || '').trim();
-
-    if (isVite && /^(tsc\s*&&\s*)?vite\s+build\s*$/.test(buildScript)) {
-      command = `npm run build -- --base=./`;
-    }
-
     const env = { ...process.env };
-    if (isVite && command === 'npm run build') {
+
+    // Force relative base paths for Vite — absolute paths break in iframe
+    if (isVite) {
+      const buildScript = (pkg.scripts.build || '').trim();
+      if (/\bvite\s+build\b/.test(buildScript)) {
+        command = `npm run build -- --base=./`;
+      }
       env.VITE_BASE = './';
     }
 

package/packages/daemon/src/process.js

@@ -266,6 +266,13 @@ For NEW projects (team creation only):
 Include "projectDir" with a short kebab-case directory name. All agents spawn inside it.
 For EXISTING codebases: Do NOT include "projectDir".
 
+DIRECTORY RULES:
+Your team directory (where you are spawned) is for ORCHESTRATION ONLY — .groove/, AGENTS_REGISTRY.md, coordination files. Do NOT instruct agents to create source code, projects, or build artifacts inside the team directory.
+
+All source code, features, and projects MUST be created in the PARENT directory (one level up from the team dir). Look at the parent directory structure provided in your context to understand existing directories, naming conventions, and paths. Reference files and directories relative to the parent using "../" prefix in prompts (e.g., "../demo/", "../training/src/").
+
+Scope patterns CAN use "../" to reference directories outside the team dir. For multi-directory projects, use patterns like "../demo/**", "../training/**". If the project spans many directories or you are unsure of boundaries, use empty scope ([]) to give agents unrestricted access.
+
 MANDATORY RULES:
 
 1. For team creation: the LAST entry MUST be { "role": "fullstack", "phase": 2 } — the QC agent.
@@ -284,6 +291,8 @@ MANDATORY RULES:
 
 7. In MODE 2, be FAST. Read only the files needed to understand the specific task. Do not re-analyze the full codebase.
 
+8. NEVER build source code or project files inside the team directory. The team dir is ephemeral — the user may delete it at any time. All persistent work goes in the parent directory.
+
 IMPORTANT: Do not use markdown formatting like ** or ### in your output. Write in plain text with clean formatting. Use line breaks, dashes, and indentation for structure.
 
 `,

package/packages/daemon/src/terminal-pty.js

@@ -37,6 +37,10 @@ signal.signal(signal.SIGWINCH, resize)
 flags = fcntl.fcntl(0, fcntl.F_GETFL)
 fcntl.fcntl(0, fcntl.F_SETFL, flags | os.O_NONBLOCK)
 
+ESC_START = b'\\x1b]7;'
+ESC_END = b'\\x07'
+stdin_buf = b''
+
 try:
     while True:
         rlist = select.select([0, master], [], [], 0.05)[0]
@@ -44,22 +48,28 @@ try:
             try:
                 data = os.read(0, 4096)
                 if not data: break
-                # Resize command: ESC ] 7 ; <rows> ; <cols> BEL
-                if b'\\x1b]7;' in data:
-                    idx = data.index(b'\\x1b]7;')
-                    end = data.index(b'\\x07', idx)
-                    params = data[idx+4:end].decode().split(';')
-                    if len(params) == 2:
-                        r, c = int(params[0]), int(params[1])
-                        fcntl.ioctl(master, termios.TIOCSWINSZ, struct.pack('HHHH', r, c, 0, 0))
-                        os.kill(pid, signal.SIGWINCH)
-                    rest = data[:idx] + data[end+1:]
-                    if rest:
-                        os.write(master, rest)
-                else:
-                    os.write(master, data)
+                stdin_buf += data
             except OSError as e:
                 if e.errno != errno.EAGAIN: break
+        # Process buffered stdin — extract resize commands, forward the rest
+        while stdin_buf:
+            esc_pos = stdin_buf.find(ESC_START)
+            if esc_pos == -1:
+                os.write(master, stdin_buf)
+                stdin_buf = b''
+                break
+            if esc_pos > 0:
+                os.write(master, stdin_buf[:esc_pos])
+                stdin_buf = stdin_buf[esc_pos:]
+            bel_pos = stdin_buf.find(ESC_END)
+            if bel_pos == -1:
+                break
+            params = stdin_buf[4:bel_pos].decode().split(';')
+            if len(params) == 2:
+                r, c = int(params[0]), int(params[1])
+                fcntl.ioctl(master, termios.TIOCSWINSZ, struct.pack('HHHH', r, c, 0, 0))
+                os.kill(pid, signal.SIGWINCH)
+            stdin_buf = stdin_buf[bel_pos+1:]
         if master in rlist:
             try:
                 data = os.read(master, 4096)

package/packages/daemon/src/validate.js

@@ -146,10 +146,6 @@ export function validateScopePattern(pattern) {
   if (pattern.startsWith('/')) {
     throw new Error('Scope patterns cannot be absolute paths');
   }
-  // No path traversal
-  if (pattern.includes('..')) {
-    throw new Error('Scope patterns cannot contain path traversal (..)');
-  }
   // No null bytes
   if (pattern.includes('\0')) {
     throw new Error('Scope pattern contains invalid characters');