groove-dev 0.27.112 → 0.27.115

package/EMBEDDING_DIAGNOSTIC.md

@@ -0,0 +1,197 @@
+# Embedding Service Diagnostic — Central Command Rebuild
+
+## Problem
+
+After the Central Command rebuild, `session_embedding` is `null` on all SESSION_CLOSE envelopes and `domain_tags` show keyword-mode confidence (~0.067) instead of embedding-mode confidence (~0.3-0.5). Embeddings were working correctly before the rebuild (TRAINING_DATA_v3 had full 384-dim vectors on every session).
+
+The endpoint responds to direct curl tests from a developer machine, but the Groove client is falling back to keyword mode during live sessions.
+
+## What "working" looked like (v3 data)
+
+```
+domain_tags: primary=react_frontend (0.4932)
+session_embedding: 384d, model=sentence-transformers/all-MiniLM-L6-v2, nonzero=377/384
+```
+
+## What's happening now (v4 data)
+
+```
+domain_tags: primary=nlp_llm (0.0769)     ← keyword mode
+session_embedding: null                     ← embed() returns null in keyword mode
+```
+
+## How the client decides between keyword and embedding mode
+
+On every agent spawn, the `DomainTagger.init()` runs this sequence:
+
+```
+1. POST to EMBEDDING_SERVICE_URL with {"input": "health check", "model": "sentence-transformers/all-MiniLM-L6-v2"}
+2. If response is 200 OK:
+   a. Switch to "http" mode
+   b. Call _buildCentroids() — embeds all 40 domain descriptions (40 sequential POST calls)
+   c. If all succeeds → ready, embedding mode active
+3. If ANYTHING fails (network error, non-200, timeout, _buildCentroids() error):
+   → Fall back to "keyword" mode silently
+```
+
+The client **never logs** why it fell back — it catches all errors silently. So the failure is invisible.
+
+## Likely failure points (in order of probability)
+
+### 1. `_buildCentroids()` is failing
+
+Even if the health probe succeeds, `init()` then makes **40 sequential embed calls** to build domain centroids. If any single one fails, the whole init throws and falls back to keyword mode. The entire block is wrapped in a try/catch:
+
+```javascript
+try {
+  const res = await fetch(this._serviceUrl, { ... });  // health probe
+  if (res.ok) {
+    this._mode = this._leafRegistry?.length ? 'registry' : 'http';
+    await this._buildCentroids();  // ← 40 more calls, if this throws → keyword mode
+    this._ready = true;
+    return;
+  }
+} catch {
+  // silently falls through to keyword mode
+}
+```
+
+**To check:** Look at Central Command logs during a Groove session. You should see ~41 POST requests to `/v1/embed` in quick succession (1 health probe + 40 centroid builds). If you see fewer, one is failing.
+
+### 2. Timeout under load
+
+The health probe has a **5-second timeout**. The centroid embed calls have a **10-second timeout** each. If the ONNX model is cold or the server is under load, individual calls might be timing out.
+
+**To check:** Add timing logs to the `/v1/embed` endpoint:
+```javascript
+const start = Date.now();
+const vector = await embed(text);
+console.log(`[embed] ${Date.now() - start}ms "${text.slice(0, 50)}..."`);
+```
+
+### 3. Response format mismatch
+
+The client parses the response as:
+```javascript
+const data = await res.json();
+const embedding = data?.data?.[0]?.embedding;
+if (!Array.isArray(embedding)) {
+  // returns null — "Invalid embedding response format"
+}
+```
+
+The expected response is **exactly**:
+```json
+{
+  "data": [
+    {
+      "embedding": [0.0123, -0.0456, ...384 floats],
+      "index": 0
+    }
+  ],
+  "model": "sentence-transformers/all-MiniLM-L6-v2"
+}
+```
+
+**To check:** Verify the response structure. Common mistakes:
+- Returning `{ "embedding": [...] }` instead of `{ "data": [{ "embedding": [...] }] }`
+- Returning the vector as a nested array `[[0.01, ...]]` instead of flat `[0.01, ...]`
+- Returning Float32Array or typed array instead of plain JSON numbers
+
+### 4. CORS or request rejection
+
+The Groove daemon makes requests from `localhost` (or wherever it runs). If the rebuilt server has stricter CORS, different firewall rules, or middleware that rejects requests without a specific User-Agent or Origin header, the fetch would fail.
+
+**To check:** The original Central Command had `Access-Control-Allow-Origin: *`. Verify the rebuild has the same.
+
+### 5. URL path mismatch
+
+The client hits exactly: `POST https://api.groovedev.ai/v1/embed`
+
+**To check:** Verify the route is mounted at `/v1/embed`, not `/embed` or `/v1/embeddings` or `/api/v1/embed`.
+
+## Quick diagnostic commands
+
+Run these on the Central Command server:
+
+```bash
+# 1. Verify endpoint exists and responds correctly
+curl -s -X POST http://localhost:8443/v1/embed \
+  -H "Content-Type: application/json" \
+  -d '{"input": "Python programming debugging testing"}' \
+  | python3 -c "
+import sys, json
+d = json.load(sys.stdin)
+v = d.get('data', [{}])[0].get('embedding')
+if v and isinstance(v, list):
+    print(f'OK: {len(v)}-dim vector, type={type(v[0]).__name__}')
+else:
+    print(f'BROKEN: response structure = {json.dumps(d)[:200]}')"
+
+# 2. Simulate the full init sequence (health probe + 40 centroids)
+python3 -c "
+import requests, time
+url = 'http://localhost:8443/v1/embed'
+domains = [
+    'Python programming, debugging, testing with pytest',
+    'TypeScript and Node.js backend, Express frameworks',
+    'React frontend development, JSX components, hooks',
+    # ...add all 40 domain descriptions from domain-tagger.js
+]
+
+# Health probe
+start = time.time()
+r = requests.post(url, json={'input': 'health check', 'model': 'sentence-transformers/all-MiniLM-L6-v2'}, timeout=5)
+print(f'Health probe: {r.status_code} in {time.time()-start:.1f}s')
+
+# Centroid batch
+fails = 0
+for i, desc in enumerate(domains):
+    try:
+        r = requests.post(url, json={'input': desc}, timeout=10)
+        d = r.json()
+        v = d.get('data', [{}])[0].get('embedding')
+        if not v or not isinstance(v, list) or len(v) != 384:
+            print(f'  Domain {i}: BAD RESPONSE')
+            fails += 1
+    except Exception as e:
+        print(f'  Domain {i}: FAILED - {e}')
+        fails += 1
+
+print(f'Centroid build: {len(domains)-fails}/{len(domains)} succeeded, {fails} failed')
+if fails > 0:
+    print('THIS IS WHY EMBEDDINGS ARE NULL - any failure causes full fallback to keyword mode')
+"
+
+# 3. Check response time under sequential load
+for i in $(seq 1 10); do
+  time curl -s -X POST http://localhost:8443/v1/embed \
+    -H "Content-Type: application/json" \
+    -d "{\"input\": \"test embedding call $i\"}" > /dev/null
+done
+
+# 4. Check server logs during a live Groove session
+# Start a Groove agent and watch for /v1/embed requests in the Central Command logs
+```
+
+## What success looks like
+
+After fix, a SESSION_CLOSE envelope should show:
+```json
+{
+  "metadata": {
+    "domain_tags": {
+      "primary": { "domain": "react_frontend", "confidence": 0.49 },
+      "secondary": { "domain": "vue_frontend", "confidence": 0.47 },
+      "tertiary": { "domain": "typescript_node", "confidence": 0.40 }
+    },
+    "session_embedding": {
+      "model": "sentence-transformers/all-MiniLM-L6-v2",
+      "vector": [0.0123, -0.0456, "...384 floats"],
+      "source_text": "frontend\nI'll scaffold the project..."
+    }
+  }
+}
+```
+
+Confidence scores in the 0.25-0.55 range (cosine similarity), NOT 0.06-0.08 (keyword hit ratio).

package/TRAINING_DATA_v4.md

@@ -0,0 +1,3 @@
+{"envelope_id":"env_70dfa132-575b-48a3-becc-a2ea8a75aecc","session_id":"sess_54e35697-302f-45bc-bc3e-c4282b5f6034","chunk_sequence":0,"contributor_id":"23e6dd8c4a884836bf78cafda9fbe57d","attestation":{"session_hmac":"9f2d5a6369edcb2545181101574e61e02c65e939e253c068d398d2cbf8f20cd4","sequence":0,"app_version_hash":"4a527565d85cc601d3c47c376e4f361d5af987de58f60cf71dbc263a0de91247"},"metadata":{"model_engine":"claude-opus-4-6","provider":"claude-code","agent_role":"fullstack","agent_id":"e18a8fa4","task_complexity":"medium","team_size":2,"session_quality":0,"groove_version":"0.27.113","leaf_context":null},"trajectory_log":[{"step":1,"type":"thought","timestamp":1777354900.276,"content":"Let me trace the exact URL the client is using.","token_count":12},{"step":2,"type":"action","timestamp":1777354901.244,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && grep -n 'EMBEDDING_SERVICE_URL\\|CENTRAL_COMMAND_URL' moe-training/shared/constants.js"},"content":"Using Bash","token_count":37},{"step":3,"type":"observation","timestamp":1777354901.808,"content":"41:export const CENTRAL_COMMAND_URL = process.env.GROOVE_CENTRAL_URL || 'https://api.groovedev.ai';\n42:export const EMBEDDING_SERVICE_URL = process.env.EMBEDDING_SERVICE_URL || `${CENTRAL_COMMAND_URL}/v1/embed`;\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":71,"is_error":false,"tool":"Bash","token_count":69},{"step":4,"type":"action","timestamp":1777354905.484,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && grep -n 'serviceUrl\\|EMBEDDING' moe-training/client/domain-tagger.js | head -10"},"content":"Using Bash","token_count":36},{"step":5,"type":"observation","timestamp":1777354905.528,"content":"3:import { EMBEDDING_SERVICE_URL } from '../shared/constants.js';\n176:    this._serviceUrl = options.serviceUrl !== undefined ? options.serviceUrl : EMBEDDING_SERVICE_URL;\n208:    if (this._serviceUrl) {\n210:        const res = await fetch(this._serviceUrl, {\n361:      const res = await fetch(this._serviceUrl, {\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":97,"is_error":false,"tool":"Bash","token_count":95},{"step":6,"type":"thought","timestamp":1777354911.293,"content":"The constant looks correct — `https://api.groovedev.ai/v1/embed`, no trailing slash. But let me check what the DomainTagger actually receives at runtime. The `TrajectoryCapture` creates the DomainTagger — let me see if it passes any options.","token_count":61},{"step":7,"type":"action","timestamp":1777354911.644,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && grep -n 'DomainTagger\\|domainTagger\\|_domainTagger' moe-training/client/trajectory-capture.js"},"content":"Using Bash","token_count":40},{"step":8,"type":"observation","timestamp":1777354911.695,"content":"11:import { DomainTagger } from './domain-tagger.js';\n48:    this._domainTagger = new DomainTagger();\n49:    await this._domainTagger.init();\n299:    if (this._domainTagger) {\n304:      const routingText = DomainTagger.buildRoutingText(role, firstPrompt, remainingThoughts);\n305:      ctx.metadata.domain_tags = await this._domainTagger.tag(routingText);\n306:      ctx.metadata.session_embedding = await this._domainTagger.embed(routingText);\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":129,"is_error":false,"tool":"Bash","token_count":127},{"step":9,"type":"thought","timestamp":1777354916.313,"content":"`new DomainTagger()` — no options passed, so it uses the default `EMBEDDING_SERVICE_URL`. Now let me check where the daemon actually imports and uses this. The `moe-training` module is consumed by the daemon.","token_count":52},{"step":10,"type":"action","timestamp":1777354916.852,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && grep -rn 'TrajectoryCapture\\|trajectory-capture\\|moe-training' packages/daemon/src/ | grep -v node_modules"},"content":"Using Bash","token_count":43},{"step":11,"type":"observation","timestamp":1777354916.946,"content":"packages/daemon/src/index.js:46:import { TrajectoryCapture, ConsentManager } from '../../../moe-training/client/index.js';\npackages/daemon/src/index.js:594:        this._initTrajectoryCapture().catch(() => {});\npackages/daemon/src/index.js:680:  async _initTrajectoryCapture() {\npackages/daemon/src/index.js:685:      this.trajectoryCapture = new TrajectoryCapture({\npackages/daemon/src/api.js:18:import { ConsentManager } from '../../../moe-training/client/index.js';\npackages/daemon/src/api.js:4939:        await daemon._initTrajectoryCapture();\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":155,"is_error":false,"tool":"Bash","token_count":153},{"step":12,"type":"action","timestamp":1777354920.727,"tool":"Read","arguments":{"file_path":"~/Desktop/groove-project/groove/packages/daemon/src/index.js","offset":678,"limit":25},"content":"Using Read","token_count":28},{"step":13,"type":"observation","timestamp":1777354920.728,"content":"678\t  }\n679\t\n680\t  async _initTrajectoryCapture() {\n681\t    try {\n682\t      if (!ConsentManager.isCaptureEnabled()) return;\n683\t      const pkgPath = new URL('../package.json', import.meta.url);\n684\t      const version = JSON.parse(readFileSync(pkgPath, 'utf8')).version;\n685\t      this.trajectoryCapture = new TrajectoryCapture({\n686\t        centralCommandUrl: process.env.GROOVE_CENTRAL_URL || 'https://api.groovedev.ai',\n687\t        grooveVersion: version,\n688\t      });\n689\t      this.trajectoryCapture.init();\n690\t    } catch (e) {\n691\t      // Training capture is never critical\n692\t    }\n693\t  }\n694\t\n695\t  _startGarbageCollector() {\n696\t    // Run once on startup, then every 24 hours\n697\t    this._gc();\n698\t    this._gcInterval = setInterval(() => this._gc(), 24 * 60 * 60 * 1000);\n699\t\n700\t    // Periodic state save — crash protection (every 30s)\n701\t    this._stateSaveInterval = setInterval(async () => {\n702\t      try { this.state.set('agents', this.registry.getAll()); await this.state.save(); } catch {}","truncated":false,"original_token_count":255,"is_error":false,"tool":"Read","token_count":255},{"step":14,"type":"thought","timestamp":1777354925.525,"content":"Line 689 — `this.trajectoryCapture.init()` — no `await`. That's not the bug here though. Let me look at what `TrajectoryCapture.init()` does with the DomainTagger.","token_count":41},{"step":15,"type":"action","timestamp":1777354926.407,"tool":"Read","arguments":{"file_path":"~/Desktop/groove-project/groove/moe-training/client/trajectory-capture.js","offset":38,"limit":16},"content":"Using Read","token_count":31},{"step":16,"type":"observation","timestamp":1777354926.407,"content":"38\t  async init() {\n39\t    if (!ConsentManager.isCaptureEnabled()) {\n40\t      this._enabled = false;\n41\t      return;\n42\t    }\n43\t    this._enabled = true;\n44\t    this._scrubber = new PIIScrubber();\n45\t    this._attestation = new SessionAttestation(this._centralCommandUrl);\n46\t    this._transmissionQueue = new TransmissionQueue(this._centralCommandUrl);\n47\t    this._transmissionQueue.start();\n48\t    this._domainTagger = new DomainTagger();\n49\t    await this._domainTagger.init();\n50\t    this._offlineRetryTimer = setInterval(() => {\n51\t      this._retryOfflineQueue();\n52\t    }, OFFLINE_RETRY_INTERVAL_MS);\n53\t  }","truncated":false,"original_token_count":155,"is_error":false,"tool":"Read","token_count":155},{"step":17,"type":"thought","timestamp":1777354935.764,"content":"Wait — line 689 in `index.js`: `this.trajectoryCapture.init()` — **no await**. That means `init()` runs as a fire-and-forget promise. The DomainTagger's `init()` calls `await this._domainTagger.init()` which does 41 HTTP requests. But the daemon doesn't await the TrajectoryCapture's init.\n\nThat's fine in theory — the DomainTagger should still eventually resolve. But let me check: if `init()` isn't awaited and an agent spawns before the DomainTagger finishes its 41 embed calls, the `_domainTagger` might be set but not yet `_ready`. Let me look at the timing.\n\nActually, that's not the issue either — `onAgentSpawn` doesn't check `_domainTagger.ready`. The domain tagging only happens in `_closeAgent`, by which point init would have long completed.\n\nLet me look at this from another angle — is the `EMBEDDING_SERVICE_URL` constant actually making it into the published npm package?","token_count":222},{"step":18,"type":"action","timestamp":1777354936.676,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && node -e \"\nimport { EMBEDDING_SERVICE_URL, CENTRAL_COMMAND_URL } from './moe-training/shared/constants.js';\nconsole.log('CENTRAL_COMMAND_URL:', CENTRAL_COMMAND_URL);\nconsole.log('EMBEDDING_SERVICE_URL:', EMBEDDING_SERVICE_URL);\n\""},"content":"Using Bash","token_count":74},{"step":19,"type":"observation","timestamp":1777354936.764,"content":"CENTRAL_COMMAND_URL: https://api.groovedev.ai\nEMBEDDING_SERVICE_URL: https://api.groovedev.ai/v1/embed\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":44,"is_error":false,"tool":"Bash","token_count":42},{"step":20,"type":"action","timestamp":1777354948.816,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && node -e \"\nimport { DomainTagger } from './moe-training/client/domain-tagger.js';\nconst t = new DomainTagger();\nconsole.log('serviceUrl:', t._serviceUrl);\nconsole.log('mode:', t._mode);\nconsole.log('ready:', t._ready);\n\""},"content":"Using Bash","token_count":73},{"step":21,"type":"observation","timestamp":1777354948.897,"content":"serviceUrl: https://api.groovedev.ai/v1/embed\nmode: null\nready: false\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":36,"is_error":false,"tool":"Bash","token_count":34},{"step":22,"type":"thought","timestamp":1777354952.865,"content":"URL is correct. Let me test the full init flow.","token_count":12},{"step":23,"type":"action","timestamp":1777354956.383,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && node -e \"\nimport { DomainTagger } from './moe-training/client/domain-tagger.js';\nconst t = new DomainTagger();\nconsole.log('serviceUrl:', t._serviceUrl);\nconsole.time('init');\ntry {\n  await t.init();\n  console.timeEnd('init');\n  console.log('mode:', t.mode);\n  console.log('ready:', t.ready);\n  console.log('lastError:', t.lastError);\n  if (t._centroids) {\n    console.log('centroids:', Object.keys(t._centroids).length);\n  }\n  const result = await t.tag('Build a React frontend with TypeScript and Tailwind CSS');\n  console.log('tag result:', JSON.stringify(result));\n  const emb = await t.embed('Build a React frontend with TypeScript');\n  console.log('embed:', emb ? emb.vector.length + 'd' : 'null');\n} catch (e) {\n  console.error('ERROR:', e.message);\n}\n\" 2>&1","timeout":60000},"content":"Using Bash","token_count":217},{"step":24,"type":"observation","timestamp":1777354961.386,"content":"serviceUrl: https://api.groovedev.ai/v1/embed\ninit: 4.706s\nmode: http\nready: true\nlastError: null\ncentroids: 40\ntag result: {\"primary\":{\"domain\":\"react_frontend\",\"confidence\":0.685},\"secondary\":{\"domain\":\"typescript_node\",\"confidence\":0.4633},\"tertiary\":{\"domain\":\"vue_frontend\",\"confidence\":0.3264}}\nembed: 384d\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":97,"is_error":false,"tool":"Bash","token_count":94},{"step":25,"type":"thought","timestamp":1777354969.631,"content":"It works perfectly from this machine — `http` mode, 40 centroids, 0.685 confidence on React, 384d embedding. The code is correct.\n\nThe issue is that the **running daemon** was started before these changes were committed. The daemon process has the old code in memory where `DomainTagger` didn't import `EMBEDDING_SERVICE_URL` and defaulted `serviceUrl` to `null`.\n\nYou need to restart the Groove daemon to pick up the new code. The changes are in the files but the running Node process is still using the old version.","token_count":130},{"step":26,"type":"action","timestamp":1777354971.472,"tool":"Bash","arguments":{"command":"cd ~/Desktop/groove-project/groove && node -e \"\nimport { DomainTagger } from './moe-training/client/domain-tagger.js';\nconst t = new DomainTagger();\nconsole.log('Confirmed: serviceUrl =', t._serviceUrl);\nconsole.log('This proves the code is correct.');\nconsole.log('If live sessions show keyword mode, the running daemon has stale code in memory.');\nconsole.log('Fix: restart the daemon (groove stop && groove start)');\n\""},"content":"Using Bash","token_count":114},{"step":27,"type":"observation","timestamp":1777354971.549,"content":"Confirmed: serviceUrl = https://api.groovedev.ai/v1/embed\nThis proves the code is correct.\nIf live sessions show keyword mode, the running daemon has stale code in memory.\nFix: restart the daemon (groove stop && groove start)\nShell cwd was reset to ~/Desktop/groove-project/groove/training","truncated":false,"original_token_count":75,"is_error":false,"tool":"Bash","token_count":73},{"step":28,"type":"thought","timestamp":1777354976.411,"content":"Mystery solved. The code works — `http` mode, 40 centroids built in 4.7s, 0.685 confidence, 384d embeddings. The running daemon just needs a restart to pick up the new `EMBEDDING_SERVICE_URL` default. Run `groove stop && groove start` and the next session will have full embeddings.","token_count":71},{"step":29,"type":"resolution","timestamp":1777354976.457,"content":"Mystery solved. The code works — `http` mode, 40 centroids built in 4.7s, 0.685 confidence, 384d embeddings. The running daemon just needs a restart to pick up the new `EMBEDDING_SERVICE_URL` default. Run `groove stop && groove start` and the next session will have full embeddings.","token_count":71}]}
+{"envelope_id":"env_8c59a800-92c2-486e-aab2-d251958883da","session_id":"sess_54e35697-302f-45bc-bc3e-c4282b5f6034","type":"SESSION_CLOSE","attestation":{"session_hmac":"3fd6f3891108e43eb7482a0361fc5789ecfb9fdf40f637a63edb01e154c6f74f","sequence":1,"app_version_hash":"4a527565d85cc601d3c47c376e4f361d5af987de58f60cf71dbc263a0de91247"},"metadata":{"model_engine":"claude-opus-4-6","provider":"claude-code","agent_role":"fullstack","agent_id":"e18a8fa4","task_complexity":"medium","team_size":2,"session_quality":70,"groove_version":"0.27.113","leaf_context":null,"domain_tags":{"primary":{"domain":"linux_admin","confidence":0.0769},"secondary":{"domain":"nlp_llm","confidence":0.0769},"tertiary":{"domain":"react_frontend","confidence":0.0667}},"session_embedding":null},"outcome":{"status":"SUCCESS","session_quality":70,"quality_tier":"TIER_A","quality_tier_reason":"high_quality_no_errors","user_interventions":0,"total_steps":29,"total_chunks":1,"total_tokens":2462,"duration_seconds":86,"files_modified":0,"errors_encountered":0,"errors_recovered":0,"coordination_events":0,"training_eligible":true,"training_exclusion_reason":null}}
+{"envelope_id":"env_eafaf868-6b85-46c8-b687-43a576aedc50","session_id":"sess_54e35697-302f-45bc-bc3e-c4282b5f6034","type":"USER_FEEDBACK","attestation":{"session_hmac":"a60cc84ce26d8714749bbaedd3d51a8fb153d008e3cb396d3413740d6970454c","sequence":2,"app_version_hash":"4a527565d85cc601d3c47c376e4f361d5af987de58f60cf71dbc263a0de91247"},"feedback":{"signal":"accepted","timestamp":1777354977.009,"context":"session completed successfully with no user interventions","target_step":29,"revision_rounds":0,"delta_summary":null}}

package/moe-training/client/parsers/codex.js

@@ -57,15 +57,15 @@ export class CodexParser {
         if (item.type === 'command_execution') {
           const rawOutput = item.aggregated_output || '';
           if (item.exit_code !== 0) {
-            return { type: 'error', content: rawOutput.slice(0, 2000) || `Exit code: ${item.exit_code}` };
+            return { type: 'error', is_error: true, content: rawOutput.slice(0, 2000) || `Exit code: ${item.exit_code}` };
           }
           const obs = truncateObservation(rawOutput);
-          return { type: 'observation', content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
+          return { type: 'observation', is_error: false, content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
         }
         if (item.type === 'file_edit' || item.type === 'file_write' || item.type === 'file_read') {
           const rawOutput = item.output || item.content || '';
           const obs = truncateObservation(rawOutput);
-          return { type: 'observation', content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
+          return { type: 'observation', is_error: false, content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
         }
         return null;
       }

package/moe-training/client/parsers/gemini.js

@@ -64,11 +64,11 @@ export class GeminiParser {
         const contentParts = Array.isArray(rawContent) ? rawContent : (typeof rawContent === 'string' ? [{ text: rawContent }] : rawContent ? [rawContent] : []);
         const rawText = contentParts.map((p) => p.text || '').join('');
         const obs = truncateObservation(rawText);
-        return { type: 'observation', content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
+        return { type: 'observation', is_error: false, content: obs.content, truncated: obs.truncated, original_token_count: obs.original_token_count };
       }
 
       case 'error': {
-        return { type: 'error', content: jsonEvent.message || 'Unknown error' };
+        return { type: 'error', is_error: true, content: jsonEvent.message || 'Unknown error' };
       }
 
       case 'agent_end': {

package/moe-training/client/step-classifier.js

@@ -1,6 +1,6 @@
 // FSL-1.1-Apache-2.0 — see LICENSE
 
-const ERROR_SIGNAL_RE = /\b(?:error|Error|ERROR|exception|Exception|EXCEPTION|failed|FAILED|exit code [1-9]|ENOENT|EACCES|EPERM|TypeError|ReferenceError|SyntaxError|Cannot find|Module not found|Command failed|non-zero exit)\b/;
+const ERROR_SIGNAL_RE = /(?:^|\n)\s*(?:error[ :\[]\S|Error[ :\[]\S|ERROR[ :\[]\S)|(?:exit code [1-9]|non-zero exit|ENOENT|EACCES|EPERM|Command failed)|(?:(?:TypeError|ReferenceError|SyntaxError|RangeError|URIError):\s)|(?:Cannot find module|Module not found|ModuleNotFoundError|ImportError:)|(?:FATAL|PANIC|Traceback \(most recent)|(?:error TS\d{4}:)/;
 const FIX_SIGNAL_RE = /\b(?:fix|correcting|I see the issue|let me fix|the (?:issue|problem|bug) (?:is|was)|instead I should|my mistake)\b/i;
 
 const CORRECTION_RE = /\b(?:no[,. ](?:that|not|don't|wrong)|that'?s (?:not|wrong|incorrect)|don'?t do that|stop (?:doing|that)|instead (?:of|do)|undo|revert|go back|try (?:again|differently)|you (?:broke|missed|forgot))\b/i;
@@ -54,7 +54,7 @@ export class StepClassifier {
 
     const content = step.content || '';
 
-    if ((step.type === 'action' || step.type === 'observation') && step.is_error !== false && ERROR_SIGNAL_RE.test(content)) {
+    if (step.type === 'observation' && step.is_error !== false && ERROR_SIGNAL_RE.test(content)) {
       step.type = 'error';
     }
 

package/moe-training/test/client/step-classifier.test.js

@@ -132,11 +132,11 @@ describe('StepClassifier', () => {
     assert.equal(StepClassifier.countUserInterventions(steps), 0);
   });
 
-  it('reclassifies action with error content to error', () => {
+  it('never reclassifies action to error', () => {
     const classifier = new StepClassifier();
     const step = { type: 'action', content: 'Command failed with exit code 1' };
     const result = classifier.onStep(step);
-    assert.equal(result.type, 'error');
+    assert.equal(result.type, 'action');
   });
 
   it('reclassifies observation with error content to error', () => {
@@ -215,19 +215,75 @@ describe('StepClassifier', () => {
     assert.equal(result.type, 'error');
   });
 
-  it('preserves action type when is_error is false', () => {
+  it('does not reclassify observation containing bare word "error" in source code', () => {
     const classifier = new StepClassifier();
-    const step = { type: 'action', content: 'Command failed with exit code 1', is_error: false };
+    const step = { type: 'observation', content: 'function handleError(err) { console.error(err); }' };
     const result = classifier.onStep(step);
-    assert.equal(result.type, 'action');
+    assert.equal(result.type, 'observation');
   });
 
-  it('still reclassifies action to error when is_error is not set', () => {
+  it('does not reclassify observation with "0 errors" or "found 0 vulnerabilities"', () => {
     const classifier = new StepClassifier();
-    const step = { type: 'action', content: 'Command failed with exit code 1' };
+    const step = { type: 'observation', content: 'Build succeeded\n0 errors, 0 warnings\nfound 0 vulnerabilities' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'observation');
+  });
+
+  it('does not reclassify observation reading a file that mentions exceptions', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: '{"scripts": {"build": "tsc && vite build"}, "name": "my-app"}' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'observation');
+  });
+
+  it('reclassifies observation with real TypeScript build error', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'src/main.ts(1,8): error TS2882: Cannot find module' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with Python traceback', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'Traceback (most recent call last):\n  File "main.py", line 5' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with actual TypeError message', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'TypeError: Cannot read properties of undefined (reading "map")' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with exit code failure', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'Process exited with exit code 1' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'error');
+  });
+
+  it('reclassifies observation with ModuleNotFoundError', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'observation', content: 'ModuleNotFoundError: No module named requests' };
     const result = classifier.onStep(step);
     assert.equal(result.type, 'error');
   });
+
+  it('preserves action type even with error keywords', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'action', content: 'Command failed with exit code 1' };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'action');
+  });
+
+  it('preserves action type regardless of is_error flag', () => {
+    const classifier = new StepClassifier();
+    const step = { type: 'action', content: 'ENOENT: no such file', is_error: true };
+    const result = classifier.onStep(step);
+    assert.equal(result.type, 'action');
+  });
 });
 
 describe('StepClassifier.classifyIntent', () => {

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.112",
+  "version": "0.27.115",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/cli/src/commands/team.js

@@ -1,9 +1,17 @@
 // GROOVE CLI — team commands
 // FSL-1.1-Apache-2.0 — see LICENSE
 
+import { createInterface } from 'readline';
 import chalk from 'chalk';
 import { apiCall } from '../client.js';
 
+function confirm(prompt) {
+  return new Promise((resolve) => {
+    const rl = createInterface({ input: process.stdin, output: process.stdout });
+    rl.question(prompt, (answer) => { rl.close(); resolve(answer.trim().toLowerCase() === 'y'); });
+  });
+}
+
 export async function teamCreate(name) {
   try {
     const team = await apiCall('POST', '/api/teams', { name });
@@ -37,9 +45,43 @@ export async function teamList() {
 }
 
 export async function teamDelete(id) {
+  const ok = await confirm(`  This will archive the team directory. Continue? [y/N] `);
+  if (!ok) {
+    console.log(chalk.dim('  Cancelled.'));
+    return;
+  }
   try {
     await apiCall('DELETE', `/api/teams/${encodeURIComponent(id)}`);
-    console.log(chalk.green(`  Deleted team "${id}"`));
+    console.log(chalk.green(`  Archived team "${id}"`) + chalk.dim(' — restore with `groove team restore <id>`'));
+  } catch (err) {
+    console.error(chalk.red('  Failed:'), err.message);
+    process.exit(1);
+  }
+}
+
+export async function teamArchived() {
+  try {
+    const { archived } = await apiCall('GET', '/api/teams/archived');
+    if (archived.length === 0) {
+      console.log(chalk.dim('  No archived teams.'));
+      return;
+    }
+    console.log(chalk.bold(`\n  Archived Teams (${archived.length})\n`));
+    for (const t of archived) {
+      const date = t.deletedAt ? new Date(t.deletedAt).toLocaleDateString() : 'unknown';
+      console.log(`  ${chalk.bold(t.originalName || t.id)}  — archive-id: ${t.id} — deleted ${date} — ${t.agentCount} agent(s)`);
+    }
+    console.log('');
+  } catch {
+    console.error(chalk.red('  Cannot connect to daemon.'));
+    process.exit(1);
+  }
+}
+
+export async function teamRestore(id) {
+  try {
+    const team = await apiCall('POST', `/api/teams/archived/${encodeURIComponent(id)}/restore`);
+    console.log(chalk.green(`  Restored team "${team.name}"`) + ` (new id: ${team.id})`);
   } catch (err) {
     console.error(chalk.red('  Failed:'), err.message);
     process.exit(1);

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.112",
+  "version": "0.27.115",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/api.js

@@ -1100,6 +1100,30 @@ export function createApi(app, daemon) {
     }
   });
 
+  app.get('/api/teams/archived', (req, res) => {
+    res.json({ archived: daemon.teams.listArchived() });
+  });
+
+  app.post('/api/teams/archived/:id/restore', (req, res) => {
+    try {
+      const team = daemon.teams.restore(req.params.id);
+      daemon.audit.log('team.restore', { archivedId: req.params.id, newId: team.id, name: team.name });
+      res.json(team);
+    } catch (err) {
+      res.status(400).json({ error: err.message });
+    }
+  });
+
+  app.delete('/api/teams/archived/:id', (req, res) => {
+    try {
+      daemon.teams.purge(req.params.id);
+      daemon.audit.log('team.purge', { archivedId: req.params.id });
+      res.json({ ok: true });
+    } catch (err) {
+      res.status(400).json({ error: err.message });
+    }
+  });
+
   app.patch('/api/teams/:id', (req, res) => {
     try {
       if (req.body.name) daemon.teams.rename(req.params.id, req.body.name);
@@ -3855,6 +3879,48 @@ Keep responses concise. Help them think, don't lecture them about the system the
   // --- Preview Proxy (same-origin iframe support) ---
   // Forwards HTTP requests to the dev server so the GUI can iframe the preview
   // without cross-origin issues. WebSocket upgrade for HMR is handled in index.js.
+
+  function rewriteAbsoluteUrls(body, proxyBase) {
+    let out = body;
+    // HTML attributes: src, href, action, poster
+    out = out.replace(/((?:src|href|action|poster)\s*=\s*(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    // JS imports: from '/' and import('/')
+    out = out.replace(/(from\s+(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    out = out.replace(/(import\s*\(\s*(["']))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    // CSS url()
+    out = out.replace(/(url\s*\(\s*(["']?))\/(?!\/|api\/preview\/)/g, `$1${proxyBase}/`);
+    return out;
+  }
+
+  const REWRITABLE_TYPES = ['text/html', 'application/javascript', 'text/javascript', 'text/css'];
+
+  function handleProxyResponse(proxyRes, res, proxyBase) {
+    const fwdHeaders = { ...proxyRes.headers };
+    delete fwdHeaders['content-security-policy'];
+    delete fwdHeaders['x-frame-options'];
+
+    const ct = (fwdHeaders['content-type'] || '').toLowerCase();
+    const shouldRewrite = REWRITABLE_TYPES.some((t) => ct.includes(t));
+
+    if (!shouldRewrite) {
+      res.writeHead(proxyRes.statusCode, fwdHeaders);
+      proxyRes.pipe(res);
+      return;
+    }
+
+    const chunks = [];
+    proxyRes.on('data', (c) => chunks.push(c));
+    proxyRes.on('end', () => {
+      let body = Buffer.concat(chunks).toString('utf8');
+      body = rewriteAbsoluteUrls(body, proxyBase);
+      const buf = Buffer.from(body, 'utf8');
+      fwdHeaders['content-length'] = buf.length;
+      delete fwdHeaders['transfer-encoding'];
+      res.writeHead(proxyRes.statusCode, fwdHeaders);
+      res.end(buf);
+    });
+  }
+
   app.all('/api/preview/:teamId/proxy/*', (req, res) => {
     const entry = daemon.preview?.get(req.params.teamId);
     if (!entry || !entry.url) return res.status(404).json({ error: 'No active preview for this team' });
@@ -3865,9 +3931,11 @@ Keep responses concise. Help them think, don't lecture them about the system the
     const proxyPath = req.params[0] || '';
     const search = req.url.includes('?') ? '?' + req.url.split('?').slice(1).join('?') : '';
     const fullPath = '/' + proxyPath + search;
+    const proxyBase = `/api/preview/${req.params.teamId}/proxy`;
 
     const headers = { ...req.headers };
     delete headers.host;
+    delete headers['accept-encoding'];
     headers.host = targetUrl.host;
 
     const proxyReq = httpRequest({
@@ -3876,13 +3944,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
       path: fullPath,
       method: req.method,
       headers,
-    }, (proxyRes) => {
-      const fwdHeaders = { ...proxyRes.headers };
-      delete fwdHeaders['content-security-policy'];
-      delete fwdHeaders['x-frame-options'];
-      res.writeHead(proxyRes.statusCode, fwdHeaders);
-      proxyRes.pipe(res);
-    });
+    }, (proxyRes) => handleProxyResponse(proxyRes, res, proxyBase));
 
     proxyReq.on('error', (err) => {
       if (!res.headersSent) res.status(502).json({ error: `Proxy error: ${err.message}` });
@@ -3899,9 +3961,11 @@ Keep responses concise. Help them think, don't lecture them about the system the
     try { targetUrl = new URL(entry.devUrl || entry.url); } catch { return res.status(500).json({ error: 'Invalid preview URL' }); }
 
     const search = req.url.includes('?') ? '?' + req.url.split('?').slice(1).join('?') : '';
+    const proxyBase = `/api/preview/${req.params.teamId}/proxy`;
 
     const headers = { ...req.headers };
     delete headers.host;
+    delete headers['accept-encoding'];
     headers.host = targetUrl.host;
 
     const proxyReq = httpRequest({
@@ -3910,13 +3974,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
       path: '/' + search,
       method: req.method,
       headers,
-    }, (proxyRes) => {
-      const fwdHeaders = { ...proxyRes.headers };
-      delete fwdHeaders['content-security-policy'];
-      delete fwdHeaders['x-frame-options'];
-      res.writeHead(proxyRes.statusCode, fwdHeaders);
-      proxyRes.pipe(res);
-    });
+    }, (proxyRes) => handleProxyResponse(proxyRes, res, proxyBase));
 
     proxyReq.on('error', (err) => {
       if (!res.headersSent) res.status(502).json({ error: `Proxy error: ${err.message}` });
@@ -6183,13 +6241,15 @@ Keep responses concise. Help them think, don't lecture them about the system the
         stdio: ['ignore', 'pipe', 'pipe'],
         env: tagEnv,
       });
+      daemon._networkCheckProc = proc;
       let stdout = '';
       let stderr = '';
       proc.stdout.on('data', (c) => { stdout += c.toString(); });
       proc.stderr.on('data', (c) => { stderr += c.toString(); });
       const timeout = setTimeout(() => { safeKill(proc, 'SIGTERM'); }, 10_000);
-      proc.on('error', () => { clearTimeout(timeout); resolvePromise(null); });
+      proc.on('error', () => { clearTimeout(timeout); daemon._networkCheckProc = null; resolvePromise(null); });
       proc.on('close', (code) => {
+        daemon._networkCheckProc = null;
         clearTimeout(timeout);
         if (code !== 0) return resolvePromise(null);
         const tags = [];