groove-dev 0.27.104 → 0.27.107

package/moe-training/client/scrubber.js

@@ -65,7 +65,7 @@ export class PIIScrubber {
       },
       {
         name: 'ipv6',
-        regex: /(?:[0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}|(?:[0-9a-fA-F]{1,4}:){1,7}:|(?:[0-9a-fA-F]{1,4}:){1,6}:[0-9a-fA-F]{1,4}|::(?:[fF]{4}:)?(?:\d{1,3}\.){3}\d{1,3}|::1?\b/g,
+        regex: /(?:[0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}|(?:[0-9a-fA-F]{1,4}:){1,7}:|(?:[0-9a-fA-F]{1,4}:){1,6}:[0-9a-fA-F]{1,4}|::(?:[fF]{4}:)?(?:\d{1,3}\.){3}\d{1,3}|::1\b/g,
         replacement: '[IP]',
       },
       {
@@ -100,7 +100,7 @@ export class PIIScrubber {
       },
       {
         name: 'base64_secret',
-        regex: /(?<![A-Za-z0-9+/])[A-Za-z0-9+/]{40,}={0,2}(?![A-Za-z0-9+/])/g,
+        regex: /(?<![A-Za-z0-9+])[A-Za-z0-9+]{40,}={0,2}(?![A-Za-z0-9+])/g,
         replacement: '[API_KEY]',
       },
     ];

package/moe-training/client/trajectory-capture.js

@@ -154,6 +154,42 @@ export class TrajectoryCapture {
     this._processStep(agentId, ctx, classified);
   }
 
+  onParsedOutput(agentId, output) {
+    if (!this._enabled) return;
+    const ctx = this._contexts.get(agentId);
+    if (!ctx || !output || !output.type) return;
+
+    if (output.type === 'activity') {
+      if (output.subtype === 'assistant') {
+        this._processStep(agentId, ctx, { type: 'thought', content: output.data || '' });
+      } else if (output.subtype === 'tool_use' && Array.isArray(output.data)) {
+        for (const item of output.data) {
+          this._processStep(agentId, ctx, {
+            type: 'action',
+            tool: item.name || '',
+            arguments: item.input || {},
+            content: `Using ${item.name || 'tool'}`,
+          });
+        }
+      } else if (output.subtype === 'tool_result' && Array.isArray(output.data)) {
+        for (const item of output.data) {
+          const isError = item.success === false;
+          this._processStep(agentId, ctx, {
+            type: isError ? 'error' : 'observation',
+            content: item.output || '',
+            tool: item.name || '',
+            is_error: isError,
+          });
+        }
+      }
+    } else if (output.type === 'result') {
+      this._processStep(agentId, ctx, {
+        type: 'resolution',
+        content: typeof output.data === 'string' ? output.data : '',
+      });
+    }
+  }
+
   async onAgentComplete(agentId, outcome) {
     await this._closeAgent(agentId, outcome?.status || 'SUCCESS', outcome);
   }

package/moe-training/test/client/scrubber.test.js

@@ -131,6 +131,30 @@ describe('PIIScrubber', () => {
     assert.equal(scrubber.scrub(input), 'cd ~');
   });
 
+  it('does not scrub CSS pseudo-elements as IPv6', () => {
+    const input = '.hero-icon::before { content: ""; }';
+    assert.equal(scrubber.scrub(input), input);
+  });
+
+  it('still scrubs IPv6 loopback ::1', () => {
+    const input = 'listening on ::1 port 3000';
+    assert.equal(scrubber.scrub(input), 'listening on [IP] port 3000');
+  });
+
+  it('does not scrub file paths as base64 secrets', () => {
+    const input = '/home/user/project/groove/packages/gui/src/views/settings.jsx';
+    const result = scrubber.scrub(input);
+    assert.ok(!result.includes('[API_KEY]'), `expected no [API_KEY] in: ${result}`);
+  });
+
+  it('still scrubs real base64 secrets without slashes', () => {
+    const b64 = 'YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoxMjM0NTY3ODk';
+    const input = `key: ${b64} end`;
+    const result = scrubber.scrub(input);
+    assert.ok(result.includes('[API_KEY]'), `expected [API_KEY] in: ${result}`);
+    assert.ok(!result.includes(b64));
+  });
+
   it('patterns do not interfere with each other', () => {
     const input = 'user@example.com called 555-123-4567 from 192.168.1.1';
     const result = scrubber.scrub(input);

package/moe-training/test/client/trajectory-capture.test.js

@@ -438,3 +438,107 @@ describe('TrajectoryCapture — _computeQuality', () => {
     assert.equal(quality, 100);
   });
 });
+
+describe('TrajectoryCapture — onParsedOutput', () => {
+  function makeEnabledTc() {
+    const tc = makeTc();
+    tc._enabled = true;
+    tc._scrubber = { scrub: (s) => s };
+    const ctx = makeCtx();
+    ctx.totalTokens = 0;
+    ctx.stepCount = 0;
+    ctx.allSteps = [];
+    ctx.builder = { addStep: () => null };
+    ctx.classifier = { onStep: (s) => s };
+    tc._contexts.set('agent-loop-1', ctx);
+    return { tc, ctx };
+  }
+
+  it('converts assistant activity to thought step', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', { type: 'activity', subtype: 'assistant', data: 'I will fix the bug' });
+    assert.equal(ctx.stepCount, 1);
+    assert.equal(ctx.allSteps[0].type, 'thought');
+    assert.equal(ctx.allSteps[0].content, 'I will fix the bug');
+  });
+
+  it('converts tool_use activity to action step', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', {
+      type: 'activity', subtype: 'tool_use',
+      data: [{ type: 'tool_use', name: 'Edit', input: { path: 'foo.js' } }],
+    });
+    assert.equal(ctx.stepCount, 1);
+    assert.equal(ctx.allSteps[0].type, 'action');
+    assert.equal(ctx.allSteps[0].tool, 'Edit');
+  });
+
+  it('converts successful tool_result to observation step', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', {
+      type: 'activity', subtype: 'tool_result',
+      data: [{ type: 'tool_result', name: 'Bash', success: true, output: 'tests passed' }],
+    });
+    assert.equal(ctx.stepCount, 1);
+    assert.equal(ctx.allSteps[0].type, 'observation');
+    assert.equal(ctx.allSteps[0].content, 'tests passed');
+  });
+
+  it('converts failed tool_result to error step', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', {
+      type: 'activity', subtype: 'tool_result',
+      data: [{ type: 'tool_result', name: 'Bash', success: false, output: 'command not found' }],
+    });
+    assert.equal(ctx.stepCount, 1);
+    assert.equal(ctx.allSteps[0].type, 'error');
+    assert.equal(ctx.allSteps[0].is_error, true);
+  });
+
+  it('converts result to resolution step', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', { type: 'result', subtype: 'assistant', data: 'Task complete' });
+    assert.equal(ctx.stepCount, 1);
+    assert.equal(ctx.allSteps[0].type, 'resolution');
+    assert.equal(ctx.allSteps[0].content, 'Task complete');
+  });
+
+  it('ignores stream activity (partial deltas)', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', { type: 'activity', subtype: 'stream', data: 'partial' });
+    assert.equal(ctx.stepCount, 0);
+  });
+
+  it('ignores token-only activity', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', { type: 'activity', tokensUsed: 500, inputTokens: 400, outputTokens: 100 });
+    assert.equal(ctx.stepCount, 0);
+  });
+
+  it('silently returns for unknown agent', () => {
+    const { tc } = makeEnabledTc();
+    tc.onParsedOutput('unknown-agent', { type: 'activity', subtype: 'assistant', data: 'hello' });
+  });
+
+  it('silently returns when disabled', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc._enabled = false;
+    tc.onParsedOutput('agent-loop-1', { type: 'activity', subtype: 'assistant', data: 'hello' });
+    assert.equal(ctx.stepCount, 0);
+  });
+
+  it('accumulates tokens across multiple outputs', () => {
+    const { tc, ctx } = makeEnabledTc();
+    tc.onParsedOutput('agent-loop-1', { type: 'activity', subtype: 'assistant', data: 'thinking about the problem' });
+    tc.onParsedOutput('agent-loop-1', {
+      type: 'activity', subtype: 'tool_use',
+      data: [{ type: 'tool_use', name: 'Bash', input: { command: 'ls' } }],
+    });
+    tc.onParsedOutput('agent-loop-1', {
+      type: 'activity', subtype: 'tool_result',
+      data: [{ type: 'tool_result', name: 'Bash', success: true, output: 'file1.js\nfile2.js' }],
+    });
+    assert.equal(ctx.stepCount, 3);
+    assert.ok(ctx.totalTokens > 0);
+  });
+});

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.104",
+  "version": "0.27.107",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.104",
+  "version": "0.27.107",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/api.js

@@ -631,9 +631,8 @@ export function createApi(app, daemon) {
 
     write({ status: 'installing', output: `Installing ${pkg}...`, progress: 0 });
 
-    const proc = spawn('npm', ['install', '-g', pkg], {
+    const proc = spawn('bash', ['-lc', `npm install -g ${pkg}`], {
       stdio: ['ignore', 'pipe', 'pipe'],
-      shell: true,
       env: { ...process.env, NODE_ENV: undefined },
     });
 
@@ -741,9 +740,10 @@ export function createApi(app, daemon) {
           };
 
           const proc = spawn('codex', ['login'], {
-            stdio: ['ignore', 'pipe', 'pipe'],
+            stdio: ['pipe', 'pipe', 'pipe'],
             shell: true,
           });
+          proc.stdin.on('error', () => {});
           let stdout = '';
           let stderr = '';
           proc.stdout.on('data', (d) => { stdout += d.toString(); });
@@ -752,8 +752,8 @@ export function createApi(app, daemon) {
           const timeout = setTimeout(() => {
             const urlMatch = (stdout + stderr).match(/https:\/\/\S+/);
             respond(urlMatch
-              ? { status: 'pending', url: urlMatch[0] }
-              : { status: 'pending', message: 'Login started — check your browser' });
+              ? { status: 'pending', url: urlMatch[0], browserOpened: true }
+              : { status: 'pending', message: 'Login started — check your browser', browserOpened: true });
           }, 5000);
 
           proc.on('close', (code) => {
@@ -4666,7 +4666,13 @@ Keep responses concise. Help them think, don't lecture them about the system the
       const hasKey = daemon.credentials.hasKey(p.id);
       let authStatus = 'not-configured';
       if (p.authType === 'subscription') {
-        authStatus = p.installed ? 'authenticated' : 'not-configured';
+        if (!p.installed) {
+          authStatus = 'not-configured';
+        } else {
+          const provObj = getProvider(p.id);
+          const authResult = provObj?.constructor?.isAuthenticated?.();
+          authStatus = authResult?.authenticated ? 'authenticated' : 'not-configured';
+        }
       } else if (p.authType === 'api-key') {
         authStatus = hasKey ? 'key-set' : 'not-configured';
         if (p.authStatus?.authenticated) authStatus = 'authenticated';
@@ -4729,9 +4735,8 @@ Keep responses concise. Help them think, don't lecture them about the system the
 
     write({ status: 'installing', output: `Installing ${pkg}...`, progress: 0 });
 
-    const proc = spawn('npm', ['install', '-g', pkg], {
+    const proc = spawn('bash', ['-lc', `npm install -g ${pkg}`], {
       stdio: ['ignore', 'pipe', 'pipe'],
-      shell: true,
       env: { ...process.env, NODE_ENV: undefined },
     });
 

package/node_modules/@groove-dev/daemon/src/process.js

@@ -1760,6 +1760,15 @@ For normal file edits within your scope, proceed without review.
       locks.register(newAgent.id, newAgent.scope, newAgent.workingDir);
     }
 
+    if (this.daemon.trajectoryCapture) {
+      try {
+        const teamSize = registry.getAll().filter(a => a.status === 'active' || a.status === 'running' || a.status === 'starting').length;
+        this.daemon.trajectoryCapture.onAgentSpawn(
+          newAgent.id, config.provider, config.model || null, config.role, teamSize
+        ).catch(() => {});
+      } catch (e) { /* fail silent */ }
+    }
+
     // Spawn the resumed process
     const resumeCwd = [config.workingDir, this.daemon.projectDir].find(d => d && existsSync(d)) || this.daemon.projectDir;
     const proc = cpSpawn(command, args, {
@@ -1815,6 +1824,23 @@ For normal file edits within your scope, proceed without review.
 
       const finalStatus = signal === 'SIGTERM' || signal === 'SIGKILL' ? 'killed' : code === 0 ? 'completed' : 'crashed';
       registry.update(newAgent.id, { status: finalStatus, pid: null });
+
+      if (this.daemon.trajectoryCapture) {
+        try {
+          if (finalStatus === 'completed') {
+            this.daemon.trajectoryCapture.onAgentComplete(newAgent.id, {
+              status: 'SUCCESS', exit_code: code, signal,
+            });
+          } else {
+            this.daemon.trajectoryCapture.onAgentCrash(newAgent.id,
+              signal ? 'Killed by signal ' + signal : 'Exit code ' + code
+            );
+          }
+          const count = (this.daemon.state.get('training_sessions_captured') || 0) + 1;
+          this.daemon.state.set('training_sessions_captured', count);
+        } catch (e) { /* fail silent */ }
+      }
+
       this.daemon.broadcast({ type: 'agent:exit', agentId: newAgent.id, code, signal, status: finalStatus });
       if (finalStatus === 'completed' && this.daemon.journalist) {
         const a = registry.get(newAgent.id);
@@ -1930,8 +1956,20 @@ For normal file edits within your scope, proceed without review.
       });
     }
 
+    if (this.daemon.trajectoryCapture) {
+      try {
+        const teamSize = registry.getAll().filter(a => a.status === 'active' || a.status === 'running' || a.status === 'starting').length;
+        this.daemon.trajectoryCapture.onAgentSpawn(
+          newAgent.id, config.provider, loopConfig.model || config.model || null, config.role, teamSize
+        ).catch(() => {});
+      } catch (e) { /* fail silent */ }
+    }
+
     loop.on('output', (output) => {
       this._handleAgentOutput(newAgent.id, output);
+      if (this.daemon.trajectoryCapture) {
+        try { this.daemon.trajectoryCapture.onParsedOutput(newAgent.id, output); } catch (e) { /* fail silent */ }
+      }
     });
 
     loop.on('exit', ({ code, signal, status }) => {
@@ -1960,6 +1998,22 @@ For normal file edits within your scope, proceed without review.
         });
       }
 
+      if (this.daemon.trajectoryCapture) {
+        try {
+          if (status === 'completed') {
+            this.daemon.trajectoryCapture.onAgentComplete(newAgent.id, {
+              status: 'SUCCESS', exit_code: code || 0, signal,
+            });
+          } else {
+            this.daemon.trajectoryCapture.onAgentCrash(newAgent.id,
+              signal ? 'Killed by signal ' + signal : 'Exit status ' + status
+            );
+          }
+          const count = (this.daemon.state.get('training_sessions_captured') || 0) + 1;
+          this.daemon.state.set('training_sessions_captured', count);
+        } catch (e) { /* fail silent */ }
+      }
+
       this.daemon.broadcast({ type: 'agent:exit', agentId: newAgent.id, code: code || 0, signal, status });
       if (this.daemon.integrations) this.daemon.integrations.refreshMcpJson();
 

package/node_modules/@groove-dev/daemon/src/providers/claude-code.js

@@ -46,7 +46,7 @@ export class ClaudeCodeProvider extends Provider {
 
   static isInstalled() {
     try {
-      const cmd = process.platform === 'win32' ? 'where claude' : 'which claude';
+      const cmd = process.platform === 'win32' ? 'where claude' : 'bash -lc "which claude"';
       execSync(cmd, { stdio: 'ignore' });
       return true;
     } catch {
@@ -55,14 +55,14 @@ export class ClaudeCodeProvider extends Provider {
   }
 
   static isAuthenticated() {
-    const home = homedir();
-    const settingsPath = resolve(home, '.claude', 'settings.json');
-    if (!existsSync(settingsPath)) return { authenticated: false, reason: 'Claude Code not configured' };
+    if (!ClaudeCodeProvider.isInstalled()) return { authenticated: false, reason: 'Claude Code not installed' };
     try {
-      execSync('claude --version', { stdio: 'ignore', timeout: 5000 });
-      return { authenticated: true, method: 'subscription' };
+      const out = execSync('bash -lc "claude auth status --json"', { encoding: 'utf8', timeout: 10_000, stdio: ['pipe', 'pipe', 'pipe'] });
+      const data = JSON.parse(out);
+      const method = data.authMethod || data.auth_method || 'subscription';
+      return { authenticated: true, method };
     } catch {
-      return { authenticated: false, reason: 'Claude CLI not responding' };
+      return { authenticated: false, reason: 'Not logged in. Run: claude auth login' };
     }
   }
 

package/node_modules/@groove-dev/daemon/src/providers/codex.js

@@ -49,7 +49,7 @@ export class CodexProvider extends Provider {
 
   static isInstalled() {
     try {
-      const cmd = process.platform === 'win32' ? 'where codex' : 'which codex';
+      const cmd = process.platform === 'win32' ? 'where codex' : 'bash -lc "which codex"';
       execSync(cmd, { stdio: 'ignore' });
       return true;
     } catch {

package/node_modules/@groove-dev/daemon/src/providers/gemini.js

@@ -41,7 +41,7 @@ export class GeminiProvider extends Provider {
 
   static isInstalled() {
     try {
-      const cmd = process.platform === 'win32' ? 'where gemini' : 'which gemini';
+      const cmd = process.platform === 'win32' ? 'where gemini' : 'bash -lc "which gemini"';
       execSync(cmd, { stdio: 'ignore' });
       return true;
     } catch {