groove-dev 0.27.100 → 0.27.102

package/CLAUDE.md

@@ -263,3 +263,10 @@ Audit-driven release. Multi-agent orchestration system with 7 coordination layer
 - Dashboard: routing donut, cache panel, context health gauges
 - Monitor/QC agent mode (stay active, loop)
 - Distribution: demo video, HN launch, Twitter content
+
+<!-- GROOVE:START -->
+## GROOVE Orchestration (auto-injected)
+Active agents: 0
+See AGENTS_REGISTRY.md for full agent state.
+**Memory policy:** GROOVE manages project memory automatically. Do not read or write MEMORY.md or .groove/memory/ files directly.
+<!-- GROOVE:END -->

package/node_modules/@groove-dev/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/cli",
-  "version": "0.27.100",
+  "version": "0.27.102",
   "description": "GROOVE CLI — manage AI coding agents from your terminal",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@groove-dev/daemon",
-  "version": "0.27.100",
+  "version": "0.27.102",
   "description": "GROOVE daemon — agent orchestration engine",
   "license": "FSL-1.1-Apache-2.0",
   "type": "module",

package/node_modules/@groove-dev/daemon/src/api.js

@@ -174,10 +174,10 @@ export function createApi(app, daemon) {
       const agent = daemon.registry.get(req.params.id);
       if (!agent) return res.status(404).json({ error: 'Agent not found' });
 
-      const isAlive = agent.status === 'running' || agent.status === 'starting';
-      if (isAlive) {
-        await daemon.processes.kill(req.params.id);
-      }
+      // Always attempt kill — handles race where GUI sees 'running' but daemon
+      // already marked the agent completed (common with fast non-interactive
+      // providers like Gemini). processes.kill() is a no-op when no handle exists.
+      await daemon.processes.kill(req.params.id);
 
       // Only purge from registry when explicitly requested.
       // Killed/completed agents stay visible so the user can review output.
@@ -1519,6 +1519,30 @@ export function createApi(app, daemon) {
         return res.json(newAgent);
       }
 
+      // Non-interactive CLI providers (e.g. Gemini): respawn with the new
+      // message as the prompt, preserving original introContext. These providers
+      // run one prompt per spawn and cannot resume sessions.
+      if (provider?.constructor?.nonInteractive && !daemon.processes.isRunning(req.params.id)) {
+        const oldConfig = { ...agent };
+        daemon.registry.remove(req.params.id);
+        daemon.locks.release(req.params.id);
+
+        const newAgent = await daemon.processes.spawn({
+          role: oldConfig.role,
+          scope: oldConfig.scope,
+          provider: oldConfig.provider,
+          model: oldConfig.model,
+          prompt: message.trim(),
+          introContext: oldConfig.introContext,
+          permission: oldConfig.permission || 'full',
+          workingDir: oldConfig.workingDir,
+          name: oldConfig.name,
+          teamId: oldConfig.teamId,
+        });
+        daemon.audit.log('agent.instruct', { id: req.params.id, newId: newAgent.id, resumed: false });
+        return res.json(newAgent);
+      }
+
       // Running CLI agent (no loop) — queue the message for delivery after
       // the current task completes instead of killing and respawning.
       if (daemon.processes.isRunning(req.params.id)) {
@@ -3364,6 +3388,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
       // Resolve base directory from the planner that wrote the file, not the daemon root
       const plannerAgent = found.agentId ? daemon.registry.get(found.agentId) : null;
       const baseDir = plannerAgent?.workingDir || daemon.config?.defaultWorkingDir || daemon.projectDir;
+      const plannerProvider = plannerAgent?.provider || undefined;
 
       // Use the planner's teamId so launched agents join the correct team.
       // Priority: explicit from frontend > agent that wrote the file > most recent planner > default
@@ -3424,6 +3449,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
         phase2 = [{
           name: 'qc-agent',
           role: 'fullstack', phase: 2, scope: [],
+          provider: teamProvider || plannerProvider || daemon.config?.defaultProvider || undefined,
           prompt: 'QC Senior Dev: All builder agents have completed. Audit their changes for correctness, fix any issues, run tests, and verify the project builds cleanly (npm run build). Do NOT start long-running dev servers — just verify the build succeeds. Commit all changes. IMPORTANT: Do NOT delete files from other projects or directories outside this project.',
         }];
       }
@@ -3476,7 +3502,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
               role: existing.role,
               scope: normalizeScope(config.scope || existing.scope || [], existing.workingDir || projectWorkingDir),
               prompt,
-              provider: config.provider || daemon.config?.defaultProvider || existing.provider || undefined,
+              provider: config.provider || plannerProvider || daemon.config?.defaultProvider || existing.provider || undefined,
               model: config.model || existing.model || daemon.config?.defaultModel || 'auto',
               permission: config.permission || existing.permission || 'auto',
               workingDir: existing.workingDir || projectWorkingDir,
@@ -3501,7 +3527,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
               role: config.role,
               scope: normalizeScope(config.scope || [], config.workingDir || projectWorkingDir),
               prompt,
-              provider: config.provider || daemon.config?.defaultProvider || undefined,
+              provider: config.provider || plannerProvider || daemon.config?.defaultProvider || undefined,
               model: config.model || daemon.config?.defaultModel || 'auto',
               permission: config.permission || 'auto',
               workingDir: config.workingDir || projectWorkingDir,
@@ -3544,7 +3570,7 @@ Keep responses concise. Help them think, don't lecture them about the system the
             waitFor: phase1Ids,
             agents: phase2.map((c) => ({
               role: c.role, scope: c.scope || [], prompt: c.prompt || '',
-              provider: c.provider || daemon.config?.defaultProvider || undefined, model: c.model || daemon.config?.defaultModel || 'auto',
+              provider: c.provider || plannerProvider || daemon.config?.defaultProvider || undefined, model: c.model || daemon.config?.defaultModel || 'auto',
               permission: c.permission || 'auto',
               reasoningEffort: c.reasoningEffort, temperature: c.temperature, verbosity: c.verbosity,
               workingDir: c.workingDir || projectWorkingDir,

package/node_modules/@groove-dev/daemon/src/gateways/manager.js

@@ -799,7 +799,7 @@ export class GatewayManager {
             role: config.role,
             scope: config.scope || [],
             prompt: config.prompt || '',
-            provider: config.provider || 'claude-code',
+            provider: config.provider || this.daemon.config?.defaultProvider || 'claude-code',
             model: config.model || 'auto',
             permission: config.permission || 'auto',
             workingDir: config.workingDir || defaultDir,
@@ -833,7 +833,7 @@ export class GatewayManager {
             waitFor: phase1Ids,
             agents: phase2.map((c) => ({
               role: c.role, scope: c.scope || [], prompt: c.prompt || '',
-              provider: c.provider || 'claude-code', model: c.model || 'auto',
+              provider: c.provider || this.daemon.config?.defaultProvider || 'claude-code', model: c.model || 'auto',
               permission: c.permission || 'auto',
               workingDir: c.workingDir || defaultDir,
               name: c.name || undefined,

package/node_modules/@groove-dev/daemon/src/preview.js

@@ -11,7 +11,7 @@
 // kills the previous one. Previews are also killed on team delete and on
 // daemon shutdown.
 
-import { spawn as cpSpawn } from 'child_process';
+import { spawn as cpSpawn, execSync } from 'child_process';
 import { resolve, extname } from 'path';
 import { existsSync, readFileSync, statSync } from 'fs';
 import { createServer } from 'http';
@@ -101,11 +101,55 @@ export class PreviewService {
       return result;
     }
 
+    const installResult = this._ensureDependencies(teamId, baseDir);
+    if (installResult?.failed) {
+      this.daemon.audit?.log('preview.failed', { teamId, reason: installResult.reason });
+      return { launched: false, reason: installResult.reason };
+    }
+
     let result;
     if (preview.kind === 'static-html') {
-      result = await this._launchStatic(teamId, baseDir, preview);
+      if (this._needsBuild(baseDir, preview)) {
+        const buildResult = this._runBuild(teamId, baseDir);
+        if (buildResult?.failed) {
+          this.daemon.audit?.log('preview.failed', { teamId, reason: buildResult.reason });
+          return { launched: false, reason: buildResult.reason };
+        }
+        const distDir = resolve(baseDir, 'dist');
+        if (existsSync(distDir)) {
+          result = await this._launchStatic(teamId, distDir, { ...preview, openPath: preview.openPath || 'index.html' });
+        } else {
+          result = await this._launchStatic(teamId, baseDir, preview);
+        }
+      } else {
+        result = await this._launchStatic(teamId, baseDir, preview);
+      }
     } else if (preview.kind === 'dev-server') {
+      if (this._needsPreBuild(baseDir)) {
+        const preBuild = this._runBuild(teamId, baseDir);
+        if (preBuild?.failed) {
+          this.daemon.audit?.log('preview.prebuild-failed', { teamId, reason: preBuild.reason });
+        }
+      }
       result = await this._launchDevServer(teamId, baseDir, preview);
+      // Fallback: if dev-server failed, try building and serving statically
+      if (!result.launched) {
+        const pkgPath = resolve(baseDir, 'package.json');
+        if (existsSync(pkgPath)) {
+          try {
+            const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+            if (pkg.scripts?.build) {
+              const buildResult = this._runBuild(teamId, baseDir);
+              if (!buildResult?.failed) {
+                const distDir = resolve(baseDir, 'dist');
+                if (existsSync(resolve(distDir, 'index.html'))) {
+                  result = await this._launchStatic(teamId, distDir, { ...preview, openPath: 'index.html' });
+                }
+              }
+            }
+          } catch { /* fallback failed, keep original error */ }
+        }
+      }
     } else {
       result = { launched: false, reason: `unknown_kind: ${preview.kind}` };
     }
@@ -118,6 +162,99 @@ export class PreviewService {
     return result;
   }
 
+  _ensureDependencies(teamId, baseDir) {
+    const pkgPath = resolve(baseDir, 'package.json');
+    const nodeModules = resolve(baseDir, 'node_modules');
+    if (!existsSync(pkgPath) || existsSync(nodeModules)) return null;
+    try {
+      console.log(`[Groove:Preview] Running npm install in ${baseDir}`);
+      this.daemon.audit?.log('preview.npm-install', { teamId, baseDir });
+      execSync('npm install', { cwd: baseDir, timeout: 120_000, stdio: 'pipe' });
+      return null;
+    } catch (err) {
+      return { failed: true, reason: `npm install failed: ${err.message?.slice(0, 300)}` };
+    }
+  }
+
+  _needsBuild(baseDir, preview) {
+    const pkgPath = resolve(baseDir, 'package.json');
+    let hasBuildScript = false;
+    try {
+      const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+      hasBuildScript = !!pkg.scripts?.build;
+    } catch { /* no package.json or malformed */ }
+
+    const distDir = resolve(baseDir, 'dist');
+    const distExists = existsSync(distDir);
+
+    // Primary: build script exists and dist/ doesn't
+    if (hasBuildScript && !distExists) return true;
+
+    // Stale check: dist/ exists but package.json is newer than dist/index.html
+    if (hasBuildScript && distExists) {
+      const distIndex = resolve(distDir, 'index.html');
+      if (existsSync(distIndex) && existsSync(pkgPath)) {
+        try {
+          const distMtime = statSync(distIndex).mtimeMs;
+          const pkgMtime = statSync(pkgPath).mtimeMs;
+          if (pkgMtime > distMtime) return true;
+        } catch { /* ignore stat errors */ }
+      }
+    }
+
+    // Secondary: entry file references .tsx/.jsx sources (needs transpilation)
+    const openPath = (preview.openPath || 'index.html').replace(/^\/+/, '');
+    const entryFile = resolve(baseDir, openPath);
+    if (existsSync(entryFile)) {
+      try {
+        const html = readFileSync(entryFile, 'utf8');
+        if (/src=["'][^"']*\.(tsx?|jsx)["']/i.test(html)) return true;
+      } catch { /* ignore */ }
+    }
+
+    // Entry file missing — check if a build might create it
+    if (!existsSync(entryFile) && hasBuildScript) {
+      const frameworkConfigs = ['vite.config', 'next.config', 'webpack.config'];
+      for (const cfg of frameworkConfigs) {
+        for (const ext of ['.js', '.ts', '.mjs', '.cjs']) {
+          if (existsSync(resolve(baseDir, cfg + ext))) return true;
+        }
+      }
+    }
+
+    return false;
+  }
+
+  _needsPreBuild(baseDir) {
+    const pkgPath = resolve(baseDir, 'package.json');
+    if (!existsSync(pkgPath)) return false;
+    try {
+      const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+      const startScript = pkg.scripts?.start || '';
+      if (/\bnext\s+start\b/.test(startScript)) return true;
+      if (/\bserve\b/.test(startScript) && !pkg.scripts?.dev) return true;
+      if (/\bhttp-server\b/.test(startScript)) return true;
+    } catch { /* ignore */ }
+    return false;
+  }
+
+  _runBuild(teamId, baseDir) {
+    const pkgPath = resolve(baseDir, 'package.json');
+    if (!existsSync(pkgPath)) return { failed: true, reason: 'no package.json for build' };
+    try {
+      const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+      if (!pkg.scripts?.build) return { failed: true, reason: 'no build script' };
+    } catch { return { failed: true, reason: 'malformed package.json' }; }
+    try {
+      console.log(`[Groove:Preview] Running npm run build in ${baseDir}`);
+      this.daemon.audit?.log('preview.build', { teamId, baseDir });
+      execSync('npm run build', { cwd: baseDir, timeout: 120_000, stdio: 'pipe' });
+      return null;
+    } catch (err) {
+      return { failed: true, reason: `build failed: ${err.message?.slice(0, 300)}` };
+    }
+  }
+
   _launchStatic(teamId, baseDir, preview) {
     const openPath = (preview.openPath || 'index.html').replace(/^\/+/, '');
     const entryFile = resolve(baseDir, openPath);
@@ -130,6 +267,15 @@ export class PreviewService {
       const filePath = resolve(baseDir, rel);
       if (!filePath.startsWith(baseDir)) { res.statusCode = 403; return res.end(); }
       if (!existsSync(filePath) || !statSync(filePath).isFile()) {
+        // SPA fallback: serve index.html for HTML requests (client-side routing)
+        const acceptsHtml = (req.headers.accept || '').includes('text/html');
+        if (acceptsHtml) {
+          const fallback = resolve(baseDir, openPath);
+          if (existsSync(fallback) && statSync(fallback).isFile()) {
+            res.setHeader('Content-Type', 'text/html');
+            return res.end(readFileSync(fallback));
+          }
+        }
         res.statusCode = 404; return res.end('Not found');
       }
       res.setHeader('Content-Type', mimeLookup(extname(filePath)) || 'application/octet-stream');

package/node_modules/@groove-dev/daemon/src/process.js

@@ -741,6 +741,10 @@ For normal file edits within your scope, proceed without review.
         // Clean up per-agent maps to prevent unbounded growth in long sessions
         this.peakContextUsage.delete(agent.id);
         this.pendingMessages.delete(agent.id);
+
+        // Release file-scope locks so they don't persist after agent death
+        if (this.daemon.locks) this.daemon.locks.release(agent.id);
+
         registry.update(agent.id, { status, pid: null });
 
         if (this.daemon.timeline) {
@@ -1351,6 +1355,13 @@ For normal file edits within your scope, proceed without review.
               if (block.type === 'text') textParts.push(block.text);
             }
           }
+          if (evt.type === 'message' && evt.content) {
+            const parts = Array.isArray(evt.content) ? evt.content : [evt.content];
+            for (const p of parts) {
+              if (typeof p === 'string') textParts.push(p);
+              else if (p.text) textParts.push(p.text);
+            }
+          }
         } catch { textParts.push(line); }
       }
       const fullText = textParts.join('\n');
@@ -1798,6 +1809,10 @@ For normal file edits within your scope, proceed without review.
       logStream.end();
       this.handles.delete(newAgent.id);
       this._stalledAgents.delete(newAgent.id);
+
+      // Release file-scope locks so they don't persist after agent death
+      if (this.daemon.locks) this.daemon.locks.release(newAgent.id);
+
       const finalStatus = signal === 'SIGTERM' || signal === 'SIGKILL' ? 'killed' : code === 0 ? 'completed' : 'crashed';
       registry.update(newAgent.id, { status: finalStatus, pid: null });
       this.daemon.broadcast({ type: 'agent:exit', agentId: newAgent.id, code, signal, status: finalStatus });
@@ -1929,6 +1944,10 @@ For normal file edits within your scope, proceed without review.
       this._streamThrottle.delete(newAgent.id);
       this.peakContextUsage.delete(newAgent.id);
       this.pendingMessages.delete(newAgent.id);
+
+      // Release file-scope locks so they don't persist after agent death
+      if (this.daemon.locks) this.daemon.locks.release(newAgent.id);
+
       registry.update(newAgent.id, { status, pid: null });
 
       const agentData = registry.get(newAgent.id);
@@ -2077,14 +2096,26 @@ For normal file edits within your scope, proceed without review.
 
     // CLI process path — spawn's exit handler sets status='killed' for SIGTERM
     return new Promise((resolveKill) => {
+      let resolved = false;
+      const resolve = () => { if (!resolved) { resolved = true; resolveKill(); } };
+
       const forceTimer = setTimeout(() => {
         try { proc.kill('SIGKILL'); } catch {}
       }, 5000);
 
+      // Hard timeout: resolve even if exit event never fires (prevents HTTP hang)
+      const hardTimer = setTimeout(() => {
+        clearTimeout(forceTimer);
+        this.handles.delete(agentId);
+        this.daemon.locks.release(agentId);
+        resolve();
+      }, 10000);
+
       proc.on('exit', () => {
         clearTimeout(forceTimer);
+        clearTimeout(hardTimer);
         this.daemon.locks.release(agentId);
-        resolveKill();
+        resolve();
       });
 
       try {
@@ -2092,9 +2123,10 @@ For normal file edits within your scope, proceed without review.
       } catch {
         // Already dead
         clearTimeout(forceTimer);
+        clearTimeout(hardTimer);
         this.handles.delete(agentId);
         this.daemon.locks.release(agentId);
-        resolveKill();
+        resolve();
       }
     });
   }

package/node_modules/@groove-dev/daemon/src/providers/gemini.js

@@ -28,6 +28,7 @@ export class GeminiProvider extends Provider {
   static name = 'gemini';
   static displayName = 'Gemini CLI';
   static command = 'gemini';
+  static nonInteractive = true;
   static authType = 'api-key';
   static envKey = 'GEMINI_API_KEY';
   static models = [
@@ -59,7 +60,7 @@ export class GeminiProvider extends Provider {
 
     args.push('--yolo');
     args.push('--output-format', 'stream-json');
-    args.push('-p', '');
+    args.push('-p');
 
     this._currentModel = agent.model;
 
@@ -84,8 +85,13 @@ export class GeminiProvider extends Provider {
     if (agent.role !== 'planner') {
       parts.push(
         `## Non-Interactive Commands\n\n` +
-        `Always use non-interactive flags when running package manager commands to prevent timeout hangs: ` +
-        `\`npx --yes\`, \`npm create --yes\`, \`npm init --yes\`. Never run these commands without the \`--yes\` flag.`
+        `Always use non-interactive flags when running package manager commands to prevent timeout hangs:\n` +
+        `- npx: always use \`npx --yes\`\n` +
+        `- create-vite: always add \`--no-interactive\` flag (e.g. \`npx --yes create-vite . --template react --no-interactive\`)\n` +
+        `- create-next-app: always add \`--yes\` flag\n` +
+        `- npm init/create: always add \`--yes\` flag\n` +
+        `- Any scaffolding tool: look for --no-interactive, --yes, or -y flags to skip prompts\n` +
+        `Never run these commands without non-interactive flags — they will hang and be auto-killed after 5 minutes.`
       );
     }
     return parts.join('\n\n');
@@ -155,7 +161,7 @@ export class GeminiProvider extends Provider {
 
     switch (event.type) {
       case 'init':
-        return { type: 'activity', subtype: 'assistant', sessionId: event.session_id, model: event.model, data: [{ type: 'text', text: '' }] };
+        return { type: 'activity', subtype: 'assistant', model: event.model, data: [{ type: 'text', text: '' }] };
 
       case 'message': {
         if (event.role === 'user') return null;