groove-dev 0.26.16 → 0.26.18

package/node_modules/@groove-dev/daemon/src/api.js

@@ -1768,7 +1768,17 @@ Keep responses concise. Help them think, don't lecture them about the system the
       }
 
       const baseDir = daemon.config?.defaultWorkingDir || daemon.projectDir;
-      const defaultTeamId = daemon.teams.getDefault()?.id || null;
+
+      // Use the planner's teamId so launched agents join the correct team.
+      // Accept explicit teamId from request body, or find the most recent planner agent.
+      let launchTeamId = req.body?.teamId || null;
+      if (!launchTeamId) {
+        const planners = daemon.registry.getAll()
+          .filter((a) => a.role === 'planner')
+          .sort((a, b) => (b.lastActivity || '').localeCompare(a.lastActivity || ''));
+        launchTeamId = planners[0]?.teamId || null;
+      }
+      const defaultTeamId = launchTeamId || daemon.teams.getDefault()?.id || null;
 
       // If planner specified a project directory, create it and use it as workingDir
       let projectWorkingDir = baseDir;

package/node_modules/@groove-dev/daemon/src/process.js

@@ -368,6 +368,12 @@ For normal file edits within your scope, proceed without review.
         if (this.daemon.integrations) this.daemon.integrations.refreshMcpJson();
         if (status === 'completed' && this.daemon.journalist) this.daemon.journalist.cycle().catch(() => {});
         this._checkPhase2(agent.id);
+
+        // Auto-trigger idle QC in the same team
+        if (status === 'completed') {
+          const files = this.daemon.journalist?.getAgentFiles(agent) || [];
+          if (files.length > 0) this._triggerIdleQC(agent);
+        }
       });
 
       // Wire errors — broadcast to GUI for display
@@ -561,6 +567,13 @@ For normal file edits within your scope, proceed without review.
 
       // Phase 2 auto-spawn: check if all phase 1 agents for a team are done
       this._checkPhase2(agent.id);
+
+      // Auto-trigger idle QC: if this agent modified files and there's an idle QC
+      // in the same team, activate it to verify the changes
+      if (finalStatus === 'completed') {
+        const files = this.daemon.journalist?.getAgentFiles(agent) || [];
+        if (files.length > 0) this._triggerIdleQC(agent);
+      }
     });
 
     proc.on('error', (err) => {
@@ -660,8 +673,20 @@ For normal file edits within your scope, proceed without review.
         // Remove from pending
         pending.splice(i, 1);
 
-        // Auto-spawn phase 2 agents
+        // Check if phase 1 agents did any real work by looking at file modifications.
+        // If no agent modified any files, there's nothing to QC.
+        const journalist = this.daemon.journalist;
+        const phase1Idle = group.waitFor.every((id) => {
+          const a = registry.get(id);
+          if (!a) return true;
+          const files = journalist?.getAgentFiles(a) || [];
+          return files.length === 0;
+        });
+
+        // Auto-spawn phase 2 agents — if phase 1 was idle, clear the prompt
+        // so QC also waits for instructions instead of auditing nothing
         for (const config of group.agents) {
+          if (phase1Idle) config.prompt = '';
           try {
             const validated = validateAgentConfig(config);
             if (!validated.teamId) validated.teamId = this.daemon.teams.getDefault()?.id || null;
@@ -694,6 +719,48 @@ For normal file edits within your scope, proceed without review.
     }
   }
 
+  /**
+   * Auto-trigger an idle QC agent in the same team when a teammate completes real work.
+   * "Idle" = running fullstack agent that hasn't modified any files yet.
+   */
+  _triggerIdleQC(completedAgent) {
+    const registry = this.daemon.registry;
+    if (!completedAgent.teamId) return;
+
+    // Find a running fullstack/QC agent in the same team that's idle (no files modified)
+    const journalist = this.daemon.journalist;
+    const qc = registry.getAll().find((a) =>
+      a.id !== completedAgent.id &&
+      a.teamId === completedAgent.teamId &&
+      a.role === 'fullstack' &&
+      a.status === 'running' &&
+      (journalist?.getAgentFiles(a) || []).length === 0
+    );
+    if (!qc) return;
+
+    // Gather context about what the completed agent did
+    const files = this.daemon.journalist?.getAgentFiles(completedAgent) || [];
+    const result = this.daemon.journalist?.getAgentResult(completedAgent) || '';
+    const fileList = files.length > 0 ? `\nFiles modified: ${files.slice(0, 20).join(', ')}` : '';
+
+    const message = `Your teammate ${completedAgent.name} (${completedAgent.role}) just finished their work.${fileList}${result ? `\n\nTheir summary:\n${result.slice(0, 2000)}` : ''}\n\nPlease audit their changes: verify correctness, check for bugs, run tests if available, and report any issues.`;
+
+    // Send message to the QC agent via the instruct flow
+    this.sendMessage(qc.id, message).catch((err) => {
+      console.error(`[Groove] QC auto-trigger failed: ${err.message}`);
+    });
+
+    this.daemon.audit.log('qc.autoTrigger', {
+      qcId: qc.id, qcName: qc.name,
+      triggeredBy: completedAgent.name, role: completedAgent.role,
+    });
+    this.daemon.broadcast({
+      type: 'qc:triggered',
+      qcId: qc.id, qcName: qc.name,
+      triggeredBy: completedAgent.name,
+    });
+  }
+
   /**
    * Resume a completed agent's session with a new message.
    * Uses --resume SESSION_ID for zero cold-start continuation.