groove-dev 0.17.8 → 0.18.2

package/packages/daemon/src/process.js

@@ -2,9 +2,10 @@
 // FSL-1.1-Apache-2.0 — see LICENSE
 
 import { spawn as cpSpawn } from 'child_process';
-import { createWriteStream, mkdirSync, chmodSync } from 'fs';
+import { createWriteStream, mkdirSync, chmodSync, existsSync, readFileSync, unlinkSync } from 'fs';
 import { resolve } from 'path';
 import { getProvider } from './providers/index.js';
+import { validateAgentConfig } from './validate.js';
 
 // Role-specific prompt prefixes — applied during spawn regardless of entry point
 // (SpawnPanel, chat continue, CLI, API) for consistency
@@ -58,11 +59,15 @@ Do NOT write code unless explicitly asked. Use your MCP tools (database queries,
 Do NOT write code unless explicitly asked. Use your MCP tools to interact with Home Assistant.
 
 `,
-  planner: `You are a planning and architecture agent. Research, analyze, and create plans — do NOT implement code unless explicitly asked. Focus on:
+  planner: `You are a PLANNING ONLY agent. You create plans. You do NOT write code, edit files, or run commands.
+
+ABSOLUTE RULE: Never use the Edit, Write, or Bash tools to modify source code. You ONLY use Read, Glob, and Grep to understand the codebase, then output a written plan. If the user says "build this" or "redesign this", create a PLAN for how other agents should build it — do NOT build it yourself.
+
+Focus on:
 - Understanding requirements
-- Exploring the codebase
+- Exploring the codebase to understand current architecture
 - Identifying approaches and trade-offs
-- Writing structured plans
+- Writing structured plans with agent assignments
 
 After completing your plan, you MUST do two things:
 
@@ -70,15 +75,25 @@ After completing your plan, you MUST do two things:
 
 2. Save a machine-readable team config to .groove/recommended-team.json using this EXACT format:
 [
-  { "role": "fullstack", "scope": [], "prompt": "Set up project infrastructure: package.json, tsconfig, vite config, dependencies. Once all other agents finish, audit and QC their work, fix any issues, then launch the dev server. Output the localhost URL where the app can be accessed." },
-  { "role": "backend", "scope": ["src/api/**", "src/server/**", "src/db/**", "src/lib/**"], "workingDir": "packages/backend", "prompt": "Build the backend: [specific tasks from your plan]" },
-  { "role": "frontend", "scope": ["src/components/**", "src/views/**", "src/pages/**", "src/styles/**"], "workingDir": "packages/frontend", "prompt": "Build the frontend: [specific tasks from your plan]" }
+  { "role": "frontend", "phase": 1, "scope": ["src/components/**", "src/views/**"], "prompt": "Build the frontend: [specific tasks]" },
+  { "role": "backend", "phase": 1, "scope": ["src/api/**", "src/server/**"], "prompt": "Build the backend: [specific tasks]" },
+  { "role": "fullstack", "phase": 2, "scope": [], "prompt": "QC Senior Dev: Audit all changes from phase 1 agents. Verify correctness, fix issues, run tests, build the project, commit, and launch. Output the localhost URL." }
 ]
 
-Include only the agents needed. Set appropriate scopes for each role. Write detailed prompts based on your plan so each agent knows exactly what to build.
-If the project is a monorepo or has distinct subdirectories (e.g. packages/, apps/), set "workingDir" to the relative path for each agent so it spawns inside its subdirectory. Omit workingDir for agents that need full project access (like fullstack or planner).
+MANDATORY RULES — NEVER SKIP THESE:
+
+1. The LAST entry in the array MUST be: { "role": "fullstack", "phase": 2, ... }
+   This is the QC Senior Dev. It auto-spawns after all other agents finish.
+   Its prompt: audit changes, fix issues, run tests, build, commit, launch.
+   NEVER omit this agent. Every team needs a QC.
+
+2. ALL other agents are phase: 1 — they run in parallel.
+
+3. Do NOT tell any agent to "wait for" another agent. Phase 2 handles sequencing automatically.
+
+4. Set appropriate scopes. Write detailed prompts so each agent knows exactly what to build.
 
-Always include a fullstack agent. Its job: set up infrastructure first, then after all other agents finish, audit their work, fix issues, build the project, launch the dev server, and output the localhost URL so the user can immediately see the result. Include testing/devops only if the project needs them.
+5. If the project is a monorepo, set "workingDir" for agents that need specific subdirectories.
 
 IMPORTANT: Do not use markdown formatting like ** or ### in your output. Write in plain text with clean formatting. Use line breaks, dashes, and indentation for structure.
 
@@ -105,6 +120,17 @@ export class ProcessManager {
   async spawn(config) {
     const { registry, locks, introducer } = this.daemon;
 
+    // Clean stale recommended-team.json when spawning a new planner
+    if (config.role === 'planner') {
+      const dirs = [this.daemon.grooveDir];
+      if (config.workingDir) dirs.push(resolve(config.workingDir, '.groove'));
+      if (this.daemon.config?.defaultWorkingDir) dirs.push(resolve(this.daemon.config.defaultWorkingDir, '.groove'));
+      for (const dir of dirs) {
+        const p = resolve(dir, 'recommended-team.json');
+        if (existsSync(p)) try { unlinkSync(p); } catch { /* */ }
+      }
+    }
+
     // Validate provider exists and is installed
     const provider = getProvider(config.provider || 'claude-code');
     if (!provider) {
@@ -325,6 +351,9 @@ For normal file edits within your scope, proceed without review.
       if (finalStatus === 'completed' && this.daemon.journalist) {
         this.daemon.journalist.cycle().catch(() => {});
       }
+
+      // Phase 2 auto-spawn: check if all phase 1 agents for a team are done
+      this._checkPhase2(agent.id);
     });
 
     proc.on('error', (err) => {
@@ -338,6 +367,49 @@ For normal file edits within your scope, proceed without review.
     return agent;
   }
 
+  /**
+   * Check if a completed/crashed agent was the last phase 1 agent in a team.
+   * If so, auto-spawn the phase 2 (QC/finisher) agents.
+   */
+  _checkPhase2(completedAgentId) {
+    const pending = this.daemon._pendingPhase2;
+    if (!pending || pending.length === 0) return;
+
+    const registry = this.daemon.registry;
+
+    for (let i = pending.length - 1; i >= 0; i--) {
+      const group = pending[i];
+      if (!group.waitFor.includes(completedAgentId)) continue;
+
+      // Check if ALL phase 1 agents in this group are done
+      const allDone = group.waitFor.every((id) => {
+        const a = registry.get(id);
+        return !a || a.status === 'completed' || a.status === 'crashed' || a.status === 'stopped' || a.status === 'killed';
+      });
+
+      if (allDone) {
+        // Remove from pending
+        pending.splice(i, 1);
+
+        // Auto-spawn phase 2 agents
+        for (const config of group.agents) {
+          try {
+            const validated = validateAgentConfig(config);
+            this.spawn(validated).then((agent) => {
+              this.daemon.broadcast({
+                type: 'phase2:spawned',
+                agentId: agent.id,
+                name: agent.name,
+                role: agent.role,
+              });
+              this.daemon.audit.log('phase2.autoSpawn', { id: agent.id, name: agent.name, role: agent.role });
+            }).catch(() => {});
+          } catch { /* skip invalid configs */ }
+        }
+      }
+    }
+  }
+
   /**
    * Resume a completed agent's session with a new message.
    * Uses --resume SESSION_ID for zero cold-start continuation.
@@ -390,7 +462,7 @@ For normal file edits within your scope, proceed without review.
       model: config.model,
       prompt: config.prompt,
       permission: config.permission,
-      workingDir: config.workingDir,
+      workingDir: config.workingDir || this.daemon.config?.defaultWorkingDir || undefined,
       name: config.name,
     });
 

package/packages/daemon/src/providers/claude-code.js

@@ -48,6 +48,10 @@ export class ClaudeCodeProvider extends Provider {
       args.push('--model', agent.model);
     }
 
+    if (agent.effort) {
+      args.push('--effort', agent.effort);
+    }
+
     // Pass the initial prompt as positional arg (includes GROOVE context)
     const fullPrompt = this.buildFullPrompt(agent);
     if (fullPrompt) {

package/packages/daemon/src/registry.js

@@ -50,7 +50,7 @@ export class Registry extends EventEmitter {
     if (!agent) return null;
 
     // Only allow known fields to prevent prototype pollution
-    const SAFE_FIELDS = ['status', 'pid', 'tokensUsed', 'contextUsage', 'lastActivity', 'model', 'name', 'routingMode', 'routingReason', 'sessionId', 'skills', 'integrations'];
+    const SAFE_FIELDS = ['status', 'pid', 'tokensUsed', 'contextUsage', 'lastActivity', 'model', 'name', 'routingMode', 'routingReason', 'sessionId', 'skills', 'integrations', 'workingDir', 'effort'];
     for (const key of Object.keys(updates)) {
       if (SAFE_FIELDS.includes(key)) {
         agent[key] = updates[key];