npm - groove-dev - Versions diffs - 0.16.2 → 0.16.4 - Mend

groove-dev 0.16.2 → 0.16.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (15) hide show

package/node_modules/@groove-dev/gui/dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>GROOVE</title>
-    <script type="module" crossorigin src="/assets/index-DeXW9EFU.js"></script>
+    <script type="module" crossorigin src="/assets/index-B_VHpncx.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-BhjOFLBc.css">
   </head>
   <body>

package/node_modules/@groove-dev/gui/src/components/EditorTabs.jsx CHANGED Viewed

@@ -30,7 +30,7 @@ export default function EditorTabs() {
               ...styles.tab,
               color: isActive ? 'var(--text-bright)' : 'var(--text-primary)',
               borderBottom: isActive ? '1px solid var(--accent)' : '1px solid transparent',
-              background: isActive ? 'var(--bg-active)' : 'transparent',
+              background: isActive ? 'var(--bg-base)' : 'transparent',
             }}
           >
             {isDirty && <span style={styles.dirtyDot} />}
@@ -62,7 +62,7 @@ const styles = {
     cursor: 'pointer', whiteSpace: 'nowrap',
     fontSize: 11, fontFamily: 'var(--font)',
     transition: 'background 0.08s',
-    borderRight: '1px solid var(--border)',
+    borderRight: '1px solid rgba(75, 82, 99, 0.4)',
     flexShrink: 0,
   },
   tabName: {

package/node_modules/@groove-dev/gui/src/components/FileTree.jsx CHANGED Viewed

@@ -111,11 +111,9 @@ function ContextMenu({ x, y, entry, onClose, onAction }) {
   const isDir = entry?.type === 'dir';
   const items = [
-    ...(isDir ? [
-      { label: 'New File Here', action: 'newFileIn' },
-      { label: 'New Folder Here', action: 'newDirIn' },
-      { sep: true },
-    ] : []),
+    { label: 'New File', action: isDir ? 'newFileIn' : 'newFileSibling' },
+    { label: 'New Folder', action: isDir ? 'newDirIn' : 'newDirSibling' },
+    { sep: true },
     { label: 'Rename', action: 'rename' },
     { label: 'Delete', action: 'delete', danger: true },
   ];
@@ -219,7 +217,6 @@ export default function FileTree() {
     switch (action) {
       case 'newFileIn':
         setCreating({ type: 'file', parentPath: entry.path });
-        // Ensure dir is expanded
         setExpandedDirs((prev) => {
           const next = new Set(prev);
           next.add(entry.path);
@@ -236,6 +233,12 @@ export default function FileTree() {
           return next;
         });
         break;
+      case 'newFileSibling':
+        setCreating({ type: 'file', parentPath: parentDir });
+        break;
+      case 'newDirSibling':
+        setCreating({ type: 'dir', parentPath: parentDir });
+        break;
       case 'rename':
         setRenamingPath(entry.path);
         setRenameValue(entry.name);
@@ -300,14 +303,21 @@ export default function FileTree() {
             title="New File"
             style={styles.toolbarBtn}
           >
-            +f
+            <svg width="14" height="14" viewBox="0 0 16 16" fill="none" stroke="currentColor" strokeWidth="1.3">
+              <path d="M3 1.5h6l4 4V14a.5.5 0 01-.5.5h-9A.5.5 0 013 14V2a.5.5 0 01.5-.5z"/>
+              <path d="M9 1.5V5.5h4"/>
+              <path d="M8 8.5v4M6 10.5h4" strokeLinecap="round"/>
+            </svg>
           </button>
           <button
             onClick={() => setCreating({ type: 'dir', parentPath: '' })}
             title="New Folder"
             style={styles.toolbarBtn}
           >
-            +d
+            <svg width="14" height="14" viewBox="0 0 16 16" fill="none" stroke="currentColor" strokeWidth="1.3">
+              <path d="M1.5 3.5h4l1.5 1.5H14a.5.5 0 01.5.5v8a.5.5 0 01-.5.5H2a.5.5 0 01-.5-.5V4z"/>
+              <path d="M8 8v3M6.5 9.5h3" strokeLinecap="round"/>
+            </svg>
           </button>
         </div>
       </div>

package/node_modules/@groove-dev/gui/src/components/Terminal.jsx CHANGED Viewed

@@ -1,7 +1,7 @@
 // GROOVE GUI — Embedded Terminal (xterm.js)
 // FSL-1.1-Apache-2.0 — see LICENSE
-import React, { useRef, useEffect, useCallback } from 'react';
+import React, { useRef, useEffect } from 'react';
 import { Terminal as XTerm } from '@xterm/xterm';
 import { FitAddon } from '@xterm/addon-fit';
 import { WebLinksAddon } from '@xterm/addon-web-links';
@@ -13,9 +13,10 @@ export default function Terminal({ visible }) {
   const termRef = useRef(null);
   const fitAddonRef = useRef(null);
   const sessionIdRef = useRef(null);
+  const spawnedRef = useRef(false);
   const ws = useGrooveStore((s) => s.ws);
-  // Create terminal on mount
+  // Create xterm instance on mount
   useEffect(() => {
     if (!containerRef.current) return;
@@ -55,7 +56,11 @@ export default function Terminal({ visible }) {
     term.loadAddon(webLinksAddon);
     term.open(containerRef.current);
-    fitAddon.fit();
+    // Fit after a frame so container has final dimensions
+    requestAnimationFrame(() => {
+      try { fitAddon.fit(); } catch { /* ignore */ }
+    });
     termRef.current = term;
     fitAddonRef.current = fitAddon;
@@ -64,19 +69,24 @@ export default function Terminal({ visible }) {
       term.dispose();
       termRef.current = null;
       fitAddonRef.current = null;
+      spawnedRef.current = false;
     };
   }, []);
-  // Spawn shell session when ws is ready
+  // Spawn shell session when ws + term are ready
   useEffect(() => {
-    if (!ws || ws.readyState !== 1 || !termRef.current) return;
+    if (!ws || ws.readyState !== 1 || !termRef.current || spawnedRef.current) return;
     const term = termRef.current;
+    spawnedRef.current = true;
-    // Request a shell session
-    ws.send(JSON.stringify({ type: 'terminal:spawn' }));
+    // Send spawn with initial dimensions
+    ws.send(JSON.stringify({
+      type: 'terminal:spawn',
+      cols: term.cols || 120,
+      rows: term.rows || 30,
+    }));
-    // Listen for terminal messages
     const handler = (event) => {
       try {
         const msg = JSON.parse(event.data);
@@ -93,31 +103,38 @@ export default function Terminal({ visible }) {
     ws.addEventListener('message', handler);
-    // Forward keystrokes to daemon
+    // Forward keystrokes
     const inputDisposable = term.onData((data) => {
       if (sessionIdRef.current && ws.readyState === 1) {
         ws.send(JSON.stringify({ type: 'terminal:input', id: sessionIdRef.current, data }));
       }
     });
+    // Forward resize events
+    const resizeDisposable = term.onResize(({ cols, rows }) => {
+      if (sessionIdRef.current && ws.readyState === 1) {
+        ws.send(JSON.stringify({ type: 'terminal:resize', id: sessionIdRef.current, cols, rows }));
+      }
+    });
     return () => {
       ws.removeEventListener('message', handler);
       inputDisposable.dispose();
-      // Kill session on unmount
+      resizeDisposable.dispose();
       if (sessionIdRef.current && ws.readyState === 1) {
         ws.send(JSON.stringify({ type: 'terminal:kill', id: sessionIdRef.current }));
       }
       sessionIdRef.current = null;
+      spawnedRef.current = false;
     };
   }, [ws]);
   // Refit on visibility change
   useEffect(() => {
     if (visible && fitAddonRef.current) {
-      // Small delay so container has its final size
       const timer = setTimeout(() => {
         try { fitAddonRef.current.fit(); } catch { /* ignore */ }
-      }, 50);
+      }, 80);
       return () => clearTimeout(timer);
     }
   }, [visible]);

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "groove-dev",
-  "version": "0.16.2",
+  "version": "0.16.4",
   "description": "Open-source agent orchestration layer for AI coding tools. GUI dashboard, multi-agent coordination, zero cold-start (Journalist), infinite sessions (adaptive context rotation), AI Project Manager, Quick Launch. Works with Claude Code, Codex, Gemini CLI, Ollama.",
   "license": "FSL-1.1-Apache-2.0",
   "author": "Groove Dev <hello@groovedev.ai> (https://groovedev.ai)",

package/packages/daemon/src/index.js CHANGED Viewed

@@ -174,13 +174,16 @@ export class Daemon {
               break;
             // Terminal
             case 'terminal:spawn': {
-              const id = this.terminalManager.spawn(ws, { cwd: msg.cwd });
+              const id = this.terminalManager.spawn(ws, { cwd: msg.cwd, cols: msg.cols, rows: msg.rows });
               ws.send(JSON.stringify({ type: 'terminal:spawned', id }));
               break;
             }
             case 'terminal:input':
               if (msg.id && msg.data) this.terminalManager.write(msg.id, msg.data);
               break;
+            case 'terminal:resize':
+              if (msg.id && msg.rows && msg.cols) this.terminalManager.resize(msg.id, msg.rows, msg.cols);
+              break;
             case 'terminal:kill':
               if (msg.id) this.terminalManager.kill(msg.id);
               break;

package/packages/daemon/src/terminal-pty.js CHANGED Viewed

@@ -1,38 +1,116 @@
 // GROOVE — Terminal PTY Manager (shell sessions over WebSocket)
 // FSL-1.1-Apache-2.0 — see LICENSE
-import { spawn } from 'child_process';
+import { spawn, execFileSync } from 'child_process';
 import { existsSync } from 'fs';
-/**
- * Manages interactive shell sessions for the GUI terminal.
- * Uses child_process.spawn with pipe stdio + TERM=xterm-256color
- * so most CLI tools produce colored output.
- */
+// Python helper that creates a real PTY and relays I/O through stdin/stdout pipes.
+// The shell sees a genuine TTY — prompts, colors, line editing, tab completion all work.
+const PTY_HELPER = `
+import pty, os, sys, select, signal, struct, fcntl, termios, errno
+master, slave = pty.openpty()
+cols = int(os.environ.get('COLS', '120'))
+rows = int(os.environ.get('ROWS', '30'))
+fcntl.ioctl(slave, termios.TIOCSWINSZ, struct.pack('HHHH', rows, cols, 0, 0))
+pid = os.fork()
+if pid == 0:
+    os.setsid()
+    fcntl.ioctl(slave, termios.TIOCSCTTY, 0)
+    os.dup2(slave, 0)
+    os.dup2(slave, 1)
+    os.dup2(slave, 2)
+    os.close(master)
+    os.close(slave)
+    shell = os.environ.get('GROOVE_SHELL', os.environ.get('SHELL', '/bin/bash'))
+    os.execvp(shell, [shell, '-l'])
+os.close(slave)
+def resize(sig, frame):
+    pass
+signal.signal(signal.SIGWINCH, resize)
+flags = fcntl.fcntl(0, fcntl.F_GETFL)
+fcntl.fcntl(0, fcntl.F_SETFL, flags | os.O_NONBLOCK)
+try:
+    while True:
+        rlist = select.select([0, master], [], [], 0.05)[0]
+        if 0 in rlist:
+            try:
+                data = os.read(0, 4096)
+                if not data: break
+                # Resize command: ESC ] 7 ; <rows> ; <cols> BEL
+                if b'\\x1b]7;' in data:
+                    idx = data.index(b'\\x1b]7;')
+                    end = data.index(b'\\x07', idx)
+                    params = data[idx+4:end].decode().split(';')
+                    if len(params) == 2:
+                        r, c = int(params[0]), int(params[1])
+                        fcntl.ioctl(master, termios.TIOCSWINSZ, struct.pack('HHHH', r, c, 0, 0))
+                        os.kill(pid, signal.SIGWINCH)
+                    rest = data[:idx] + data[end+1:]
+                    if rest:
+                        os.write(master, rest)
+                else:
+                    os.write(master, data)
+            except OSError as e:
+                if e.errno != errno.EAGAIN: break
+        if master in rlist:
+            try:
+                data = os.read(master, 4096)
+                if not data: break
+                sys.stdout.buffer.write(data)
+                sys.stdout.buffer.flush()
+            except OSError: break
+        # Check child
+        try:
+            p, status = os.waitpid(pid, os.WNOHANG)
+            if p != 0: break
+        except ChildProcessError: break
+except: pass
+finally:
+    try: os.kill(pid, signal.SIGTERM)
+    except: pass
+`.trim();
 export class TerminalManager {
   constructor(daemon) {
     this.daemon = daemon;
-    this.sessions = new Map(); // sessionId → { proc, ws }
+    this.sessions = new Map();
     this.counter = 0;
+    this._python = this._findPython();
   }
-  /**
-   * Spawn a new shell session connected to a specific WebSocket client.
-   */
   spawn(ws, options = {}) {
     const id = `term-${++this.counter}`;
     const shell = this._detectShell();
     const cwd = options.cwd || this.daemon.projectDir;
+    const cols = options.cols || 120;
+    const rows = options.rows || 30;
+    if (!this._python) {
+      ws.send(JSON.stringify({
+        type: 'terminal:output', id,
+        data: '\r\n\x1b[31mTerminal requires Python 3 (python3 not found in PATH)\x1b[0m\r\n',
+      }));
+      ws.send(JSON.stringify({ type: 'terminal:exit', id, code: 1 }));
+      return id;
+    }
-    const proc = spawn(shell, ['-l'], {
+    const proc = spawn(this._python, ['-u', '-c', PTY_HELPER], {
       cwd,
       env: {
         ...process.env,
         TERM: 'xterm-256color',
         COLORTERM: 'truecolor',
         LANG: process.env.LANG || 'en_US.UTF-8',
-        // Remove NODE_CHANNEL_FD to prevent child confusion
-        NODE_CHANNEL_FD: undefined,
+        GROOVE_SHELL: shell,
+        COLS: String(cols),
+        ROWS: String(rows),
       },
       stdio: ['pipe', 'pipe', 'pipe'],
     });
@@ -40,14 +118,12 @@ export class TerminalManager {
     const session = { proc, ws, id };
     this.sessions.set(id, session);
-    // Relay stdout → WS
     proc.stdout.on('data', (data) => {
       if (ws.readyState === 1) {
         ws.send(JSON.stringify({ type: 'terminal:output', id, data: data.toString('utf8') }));
       }
     });
-    // Relay stderr → WS (merge with stdout)
     proc.stderr.on('data', (data) => {
       if (ws.readyState === 1) {
         ws.send(JSON.stringify({ type: 'terminal:output', id, data: data.toString('utf8') }));
@@ -71,18 +147,19 @@ export class TerminalManager {
     return id;
   }
-  /**
-   * Write input to a terminal session.
-   */
   write(id, data) {
     const session = this.sessions.get(id);
     if (!session || !session.proc.stdin.writable) return;
     session.proc.stdin.write(data);
   }
-  /**
-   * Kill a terminal session.
-   */
+  resize(id, rows, cols) {
+    const session = this.sessions.get(id);
+    if (!session || !session.proc.stdin.writable) return;
+    // Send resize command via the custom escape sequence
+    session.proc.stdin.write(`\x1b]7;${rows};${cols}\x07`);
+  }
   kill(id) {
     const session = this.sessions.get(id);
     if (!session) return;
@@ -95,18 +172,12 @@ export class TerminalManager {
     this.sessions.delete(id);
   }
-  /**
-   * Kill all sessions (daemon shutdown).
-   */
   killAll() {
     for (const [id] of this.sessions) {
       this.kill(id);
     }
   }
-  /**
-   * Clean up sessions for a disconnected WS client.
-   */
   cleanupClient(ws) {
     for (const [id, session] of this.sessions) {
       if (session.ws === ws) {
@@ -116,14 +187,20 @@ export class TerminalManager {
   }
   _detectShell() {
-    // Prefer user's shell, fall back to common ones
-    if (process.env.SHELL && existsSync(process.env.SHELL)) {
-      return process.env.SHELL;
-    }
-    const candidates = ['/bin/zsh', '/bin/bash', '/bin/sh'];
-    for (const sh of candidates) {
+    if (process.env.SHELL && existsSync(process.env.SHELL)) return process.env.SHELL;
+    for (const sh of ['/bin/zsh', '/bin/bash', '/bin/sh']) {
       if (existsSync(sh)) return sh;
     }
     return 'sh';
   }
+  _findPython() {
+    for (const cmd of ['python3', 'python']) {
+      try {
+        const v = execFileSync(cmd, ['--version'], { encoding: 'utf8', timeout: 3000 }).trim();
+        if (v.startsWith('Python 3')) return cmd;
+      } catch { /* not found */ }
+    }
+    return null;
+  }
 }