groove-dev 0.16.2 → 0.16.3

package/node_modules/@groove-dev/daemon/src/terminal-pty.js

@@ -6,8 +6,8 @@ import { existsSync } from 'fs';
 
 /**
  * Manages interactive shell sessions for the GUI terminal.
- * Uses child_process.spawn with pipe stdio + TERM=xterm-256color
- * so most CLI tools produce colored output.
+ * Uses the `script` command to allocate a real PTY (prompts, colors, line editing).
+ * No native modules required — works on macOS and Linux out of the box.
  */
 export class TerminalManager {
   constructor(daemon) {
@@ -24,18 +24,31 @@ export class TerminalManager {
     const shell = this._detectShell();
     const cwd = options.cwd || this.daemon.projectDir;
 
-    const proc = spawn(shell, ['-l'], {
-      cwd,
-      env: {
-        ...process.env,
-        TERM: 'xterm-256color',
-        COLORTERM: 'truecolor',
-        LANG: process.env.LANG || 'en_US.UTF-8',
-        // Remove NODE_CHANNEL_FD to prevent child confusion
-        NODE_CHANNEL_FD: undefined,
-      },
-      stdio: ['pipe', 'pipe', 'pipe'],
-    });
+    // Use `script` to allocate a real PTY — gives us prompts, colors, and line editing.
+    // macOS: script -q /dev/null <shell>
+    // Linux: script -qfc "<shell>" /dev/null
+    let proc;
+    const env = {
+      ...process.env,
+      TERM: 'xterm-256color',
+      COLORTERM: 'truecolor',
+      LANG: process.env.LANG || 'en_US.UTF-8',
+    };
+
+    if (process.platform === 'darwin') {
+      proc = spawn('script', ['-q', '/dev/null', shell, '-l'], {
+        cwd,
+        env,
+        stdio: ['pipe', 'pipe', 'pipe'],
+      });
+    } else {
+      // Linux (util-linux script)
+      proc = spawn('script', ['-qfc', `${shell} -l`, '/dev/null'], {
+        cwd,
+        env,
+        stdio: ['pipe', 'pipe', 'pipe'],
+      });
+    }
 
     const session = { proc, ws, id };
     this.sessions.set(id, session);
@@ -116,7 +129,6 @@ export class TerminalManager {
   }
 
   _detectShell() {
-    // Prefer user's shell, fall back to common ones
     if (process.env.SHELL && existsSync(process.env.SHELL)) {
       return process.env.SHELL;
     }