great-cto 3.27.6 → 3.28.0

package/board/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "great-cto",
   "description": "You already have the agent. This is everything around it. great_cto runs Claude Code as a pipeline of 70 specialist agents \u2014 an independent model checks each stage before the next builds on it, spending caps refuse rather than warn, and three decisions stay yours: what gets built, how, and whether it ships.",
-  "version": "3.27.6",
+  "version": "3.28.0",
   "author": {
     "name": "Alexander Velikiy",
     "url": "https://hashnode.com/@Greatcto"

package/board/scripts/lib/cross-model-review.mjs

@@ -112,8 +112,21 @@ export function parseFindings(text) {
     const m = line.match(/^(.+?):(\d+)\s*\|\s*(P[012])\s*\|\s*(.+)$/i);
     if (m) findings.push({ file: m[1].trim(), line: parseInt(m[2], 10), severity: m[3].toUpperCase(), issue: m[4].trim() });
   }
-  // Derive verdict if the model omitted it: any P0 → BLOCK.
-  if (!verdict) verdict = findings.some(f => f.severity === 'P0') ? 'BLOCK' : 'PASS';
+  // Derive a verdict only in the direction that is safe to be wrong about.
+  //
+  // This used to answer PASS whenever no `VERDICT:` line was found and no P0
+  // was parsed. But an empty body, a refusal, a reply in some other format and
+  // a model that genuinely said "looks clean" are the SAME input here — all
+  // four leave `verdict` null and `findings` without a P0. Reading any of them
+  // as PASS reads all of them as PASS, so a review that could not be read
+  // became a review that approved, and the Stop hook downstream ended the turn
+  // on it.
+  //
+  // A derivation that BLOCKS costs a second look. A derivation that PASSES
+  // spends the guarantee. So: a P0 with no verdict line still blocks; nothing
+  // else is turned into a verdict, and `null` means the model never reached
+  // one. Callers must treat null as "no verdict", never as a pass.
+  if (!verdict && findings.some(f => f.severity === 'P0')) verdict = 'BLOCK';
   return { findings, verdict };
 }
 
@@ -216,6 +229,17 @@ async function main(argv) {
   const cost = res.usage && priced ? round4(costForUsage({ model: res.model, usage: res.usage })) : null;
 
   for (const f of findings) console.log(`  ${f.severity} ${f.file}:${f.line} — ${f.issue}`);
+  if (verdict == null) {
+    // The call succeeded and the answer is unusable. `ok` would put it in the
+    // log as a reviewed tree and exit 0 would tell the caller it passed; both
+    // are the claim this tool exists to refuse to make.
+    console.log(`\ncross-model-review (${decision.provider}:${res.model}): the answer carries no verdict `
+      + `(${findings.length} finding(s) parsed). Not a pass — re-run, or say in your answer that the reviewer `
+      + `returned nothing readable.`);
+    log({ provider: decision.provider, model: res.model, state: 'unreadable', verdict: null, findings, cost,
+      error_kind: 'no-verdict' });
+    process.exit(EXIT.SKIPPED);
+  }
   console.log(`\ncross-model-review (${decision.provider}:${res.model}): ${findings.length} finding(s), VERDICT: ${verdict}  (${cost == null ? 'cost unpriced' : '$' + cost})`);
   log({ provider: decision.provider, model: res.model, state: 'ok', verdict, findings, cost });
   process.exit(verdict === 'BLOCK' ? EXIT.BLOCK : EXIT.PASS);

package/board/scripts/lib/second-opinion-for-tree.mjs

@@ -40,6 +40,17 @@ export function secondOpinionForTree(c) {
     const r = paired[paired.length - 1];
     return { ...base, state: 'ok', verdict: r.verdict ?? null, findings: r.findings ?? null, p0: r.p0 ?? null, sha: r.sha, ts: r.ts ?? null, why: '' };
   }
+  // A line that joins this tree but reached no verdict is not "no review line".
+  // It is a review that produced nothing readable, and saying so is the whole
+  // point — falling through to `unmeasured` would tell the operator to run a
+  // review that already ran.
+  const joins = (r) => typeof r.sha === 'string' && r.sha !== '' && head && (r.sha === head || head.startsWith(r.sha) || r.sha.startsWith(head));
+  const noVerdict = rows.filter((r) => joins(r) && r.state === 'unreadable');
+  if (noVerdict.length) {
+    const r = noVerdict[noVerdict.length - 1];
+    return { ...base, state: 'unreadable', sha: r.sha, ts: r.ts ?? null,
+      why: `${tool} answered for this tree and the answer carries no verdict — it is not a pass` };
+  }
   const anyKeyed = rows.some((r) => typeof r.sha === 'string' && r.sha !== '');
   if (!anyKeyed && rows.length) {
     return { ...base, state: 'unreadable', why: `${rows.length} review line(s) predate the join key — none can be paired with this tree` };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "great-cto",
-  "version": "3.27.6",
+  "version": "3.28.0",
   "description": "One command install for the great_cto Claude Code plugin. Auto-detects your stack, picks the right archetype, bootstraps PROJECT.md.",
   "keywords": [
     "claude-code",