great-cto 2.82.2 → 2.82.3

package/board/.claude-plugin/plugin.json

@@ -2,7 +2,7 @@
   "name": "great_cto",
   "id": "great_cto",
   "description": "Engineering process for solo founders and teams up to 50 engineers. Agents do architecture, code review, QA, and security. You make two decisions per feature.",
-  "version": "2.82.2",
+  "version": "2.82.3",
   "author": {
     "name": "Great CTO",
     "url": "https://github.com/avelikiy/great_cto"

package/board/packages/board/lib/alerts.mjs

@@ -171,7 +171,7 @@ function startAlertCron() {
             },
           };
           fireEmailAlert('incident.p0', dedupeKey, p0Payload);
-          addNotification('incident.p0', p0Payload);
+          addNotification('incident.p0', p0Payload, dedupeKey);
           firePushAlert('incident.p0', dedupeKey, p0Payload);
         }
       }
@@ -207,7 +207,7 @@ function startAlertCron() {
           },
         };
         fireEmailAlert('gate.blocked', dedupeKey, blockedPayload);
-        addNotification('gate.blocked', blockedPayload);
+        addNotification('gate.blocked', blockedPayload, dedupeKey);
         firePushAlert('gate.blocked', dedupeKey, blockedPayload);
       }
     } catch (e) { log.warn('cron gate.blocked failed:', e.message); }
@@ -237,7 +237,7 @@ function startAlertCron() {
             kv: { gate: g.id, agent: g.agent || 'unknown', age: `${ageHr.toFixed(1)}h` },
           };
           fireEmailAlert('gate.stale', dedupeKey, stalePayload);
-          addNotification('gate.stale', stalePayload);
+          addNotification('gate.stale', stalePayload, dedupeKey);
           firePushAlert('gate.stale', dedupeKey, stalePayload);
         }
       }
@@ -276,7 +276,7 @@ function startAlertCron() {
             },
           };
           fireEmailAlert('cost.threshold', dedupeKey, costPayload);
-          addNotification('cost.threshold', costPayload);
+          addNotification('cost.threshold', costPayload, dedupeKey);
           firePushAlert('cost.threshold', dedupeKey, costPayload);
         }
       }
@@ -317,7 +317,7 @@ function startAlertCron() {
           },
         };
         await fireEmailAlert('digest.weekly', dedupeKey, weeklyPayload);
-        addNotification('digest.weekly', weeklyPayload);
+        addNotification('digest.weekly', weeklyPayload, dedupeKey);
         await firePushAlert('digest.weekly', dedupeKey, weeklyPayload);
       }
     } catch (e) { log.warn('cron digest.weekly failed:', e.message); }
@@ -384,7 +384,7 @@ function startAlertCron() {
           kv: kvObj,
         };
         await fireEmailAlert('digest.daily', dedupeKey, dailyPayload);
-        addNotification('digest.daily', dailyPayload);
+        addNotification('digest.daily', dailyPayload, dedupeKey);
         await firePushAlert('digest.daily', dedupeKey, dailyPayload);
       }
     } catch (e) { log.warn('cron digest.daily failed:', e.message); }
@@ -423,7 +423,7 @@ function startAlertCron() {
       notify: (current, latest, dedupeKey) => {
         const payload = buildUpdatePayload(current, latest);
         fireEmailAlert('update.available', dedupeKey, payload);
-        addNotification('update.available', payload);
+        addNotification('update.available', payload, dedupeKey);
         firePushAlert('update.available', dedupeKey, payload);
       },
     }).catch(e => log.warn('cron update.available failed:', e.message));

package/board/packages/board/lib/config.mjs

@@ -29,7 +29,7 @@ const PROJECTS_FILE = process.env.GREAT_CTO_PROJECTS_FILE || path.join(GREAT_CTO
 const SHARE_ENDPOINT = 'https://greatcto.systems/r/';
 const VAPID_KEYS_FILE = path.join(GREAT_CTO_DIR, 'vapid-keys.json');
 const PUSH_SUBS_FILE = path.join(GREAT_CTO_DIR, 'push-subscriptions.json');
-const NOTIF_HISTORY_FILE = path.join(GREAT_CTO_DIR, 'notif-history.json');
+const NOTIF_HISTORY_FILE = process.env.GREAT_CTO_NOTIF_HISTORY_FILE || path.join(GREAT_CTO_DIR, 'notif-history.json');
 const VAPID_SUBJECT = 'mailto:hi@updates.greatcto.systems';
 
 export {

package/board/packages/board/lib/notifications.mjs

@@ -25,7 +25,15 @@ function saveNotifHistory() {
  * Record a notification, broadcast via SSE, and persist.
  * Called alongside fireEmailAlert / firePushAlert at every trigger point.
  */
-function addNotification(event, payload) {
+function addNotification(event, payload, dedupeKey = null) {
+  // Idempotent per dedupeKey: the alert crons tick every 5 min and a persistent
+  // condition (open P0, blocked/stale gate, cost over threshold, the daily
+  // digest during its whole UTC hour) would otherwise add a fresh in-app
+  // notification on every tick — spamming the bell. Email/push already dedupe
+  // via alerts-fired.json; this makes the in-app notification dedupe the same.
+  if (dedupeKey && notifHistory.some(n => n.dedupeKey === dedupeKey)) {
+    return null;
+  }
   const notif = {
     id: crypto.randomUUID(),
     event,
@@ -36,6 +44,7 @@ function addNotification(event, payload) {
     project: payload.project || '',
     ts: new Date().toISOString(),
     read: false,
+    ...(dedupeKey ? { dedupeKey } : {}),
   };
   notifHistory.unshift(notif);
   if (notifHistory.length > MAX_NOTIF_HISTORY) notifHistory.length = MAX_NOTIF_HISTORY;

package/board/packages/board/public/index.html

@@ -4039,14 +4039,18 @@ function renderDashboard(m) {
   const avgMin = m.avg_completion_min ?? 0;
   const cycleStat = m.cycle_time_stat === 'median_30d' ? 'Median cycle (30d)' : 'Avg cycle time';
 
-  // Honest cost model (matches share report):
-  // AI spend  = real LLM tokens from verdicts (preferred), else time-based estimate
-  // Human est = done × 4h per feature × $150/hr (industry baseline)
-  // Savings   = humanEst / aiSpend (trustworthy when AI = real tokens, independent of human rate)
+  // Honest cost model — the backend is the source of truth:
+  //   cost.savings_x  = MEASURED savings, only set when real verdict cost data
+  //                     exists. NULL for the time-based (tasks) estimate, because
+  //                     that ratio is just the hardcoded rate ratio, not a real
+  //                     measurement — showing it would fabricate a number.
+  //   cost.human_usd  = the backend's conservative human-cost estimate.
+  // The frontend must NOT recompute its own human/savings figures (that produced
+  // an inflated "×" that contradicted the API); it displays the backend fields.
   const aiSpend = realLlmUsd > 0 ? realLlmUsd : llmUsd;
-  const humanEst = done * 4 * 150;
-  const savingsX = (aiSpend > 0 && humanEst > 0)
-    ? Math.round(humanEst / aiSpend)
+  const humanEst = m.cost?.human_usd ?? 0;
+  const savingsX = (typeof planSavingsX === 'number' && planSavingsX > 1)
+    ? planSavingsX
     : null;
 
   const llmTrend = realLlmUsd > 0
@@ -4067,28 +4071,21 @@ function renderDashboard(m) {
           v: savingsX.toLocaleString(),
           sub: '×',
           label: 'Cost savings vs FTE',
-          trend: `human est. $${humanEst.toLocaleString()} (${done}× 4h × $150)`,
+          trend: humanEst > 0 ? `measured · human est. $${fmtMoney(humanEst)}` : 'measured savings',
           cls: 'green',
         }
       : {
+          // No MEASURED savings yet (no verdict cost data). Don't fabricate a
+          // multiplier from the time-based estimate — show it's not measured.
           v: '—',
           sub: '',
           label: 'Cost savings vs FTE',
-          trend: done > 0 ? 'no spend recorded yet' : 'no tasks done yet',
+          trend: aiSpend > 0
+            ? 'estimate only · run pipelines for measured savings'
+            : (done > 0 ? 'no spend recorded yet' : 'no tasks done yet'),
           cls: '',
         },
   ];
-
-  // Prefer planSavingsX when available (from PLAN-*.md) — explicit override
-  if (planSavingsX != null && planSavingsX > 0) {
-    hero[2] = {
-      v: planSavingsX,
-      sub: '×',
-      label: 'Cost savings vs FTE',
-      trend: `from PLAN-*.md figures`,
-      cls: 'green',
-    };
-  }
   document.getElementById('mp-hero').innerHTML = hero.map(s => `
     <div class="metric-card ${s.cls || ''}">
       <div class="metric-num">${s.v}${s.sub ? `<small>${s.sub}</small>` : ''}</div>

package/dist/update-check.js

@@ -134,7 +134,7 @@ export function isCacheFresh(cache, now = Date.now(), freshMs = CACHE_FRESH_MS)
     const checkedAtMs = Date.parse(cache.checkedAt);
     if (Number.isNaN(checkedAtMs))
         return false;
-    return now - checkedAtMs < freshMs;
+    return now - checkedAtMs <= freshMs;
 }
 /** Pure function: does `latest` represent a newer version than `current`? */
 export function isNewerVersion(current, latest) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "great-cto",
-  "version": "2.82.2",
+  "version": "2.82.3",
   "description": "One command install for the great_cto Claude Code plugin. Auto-detects your stack, picks the right archetype, bootstraps PROJECT.md.",
   "keywords": [
     "claude-code",