graphql 16.0.0 → 16.2.0

package/type/validate.js

@@ -136,19 +136,24 @@ function validateRootTypes(context) {
 function getOperationTypeNode(schema, operation) {
   var _flatMap$find;
 
-  // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
   return (_flatMap$find = [schema.astNode, ...schema.extensionASTNodes]
-    .flatMap((schemaNode) => {
-      var _schemaNode$operation;
-
-      return (_schemaNode$operation =
-        schemaNode === null || schemaNode === void 0
-          ? void 0
-          : schemaNode.operationTypes) !== null &&
-        _schemaNode$operation !== void 0
-        ? _schemaNode$operation
-        : [];
-    })
+    .flatMap(
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
+      (schemaNode) => {
+        var _schemaNode$operation;
+
+        return (
+          /* c8 ignore next */
+          (_schemaNode$operation =
+            schemaNode === null || schemaNode === void 0
+              ? void 0
+              : schemaNode.operationTypes) !== null &&
+            _schemaNode$operation !== void 0
+            ? _schemaNode$operation
+            : []
+        );
+      },
+    )
     .find((operationNode) => operationNode.operation === operation)) === null ||
     _flatMap$find === void 0
     ? void 0
@@ -422,11 +427,10 @@ function validateTypeImplementsInterface(context, type, iface) {
             `${type.name}.${fieldName}(${argName}:) is type ` +
             `${(0, _inspect.inspect)(typeArg.type)}.`,
           [
-            // istanbul ignore next (TODO need to write coverage tests)
             (_ifaceArg$astNode = ifaceArg.astNode) === null ||
             _ifaceArg$astNode === void 0
               ? void 0
-              : _ifaceArg$astNode.type, // istanbul ignore next (TODO need to write coverage tests)
+              : _ifaceArg$astNode.type,
             (_typeArg$astNode = typeArg.astNode) === null ||
             _typeArg$astNode === void 0
               ? void 0
@@ -552,7 +556,7 @@ function validateInputFields(context, inputObj) {
       context.reportError(
         `Required input field ${inputObj.name}.${field.name} cannot be deprecated.`,
         [
-          getDeprecatedDirectiveNode(field.astNode), // istanbul ignore next (TODO need to write coverage tests)
+          getDeprecatedDirectiveNode(field.astNode),
           (_field$astNode3 = field.astNode) === null ||
           _field$astNode3 === void 0
             ? void 0
@@ -616,16 +620,19 @@ function createInputObjectCircularRefsValidator(context) {
 function getAllImplementsInterfaceNodes(type, iface) {
   const { astNode, extensionASTNodes } = type;
   const nodes =
-    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // FIXME: https://github.com/graphql/graphql-js/issues/2203
 
   return nodes
     .flatMap((typeNode) => {
       var _typeNode$interfaces;
 
-      return (_typeNode$interfaces = typeNode.interfaces) !== null &&
-        _typeNode$interfaces !== void 0
-        ? _typeNode$interfaces
-        : [];
+      return (
+        /* c8 ignore next */
+        (_typeNode$interfaces = typeNode.interfaces) !== null &&
+          _typeNode$interfaces !== void 0
+          ? _typeNode$interfaces
+          : []
+      );
     })
     .filter((ifaceNode) => ifaceNode.name.value === iface.name);
 }
@@ -633,16 +640,19 @@ function getAllImplementsInterfaceNodes(type, iface) {
 function getUnionMemberTypeNodes(union, typeName) {
   const { astNode, extensionASTNodes } = union;
   const nodes =
-    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // FIXME: https://github.com/graphql/graphql-js/issues/2203
 
   return nodes
     .flatMap((unionNode) => {
       var _unionNode$types;
 
-      return (_unionNode$types = unionNode.types) !== null &&
-        _unionNode$types !== void 0
-        ? _unionNode$types
-        : [];
+      return (
+        /* c8 ignore next */
+        (_unionNode$types = unionNode.types) !== null &&
+          _unionNode$types !== void 0
+          ? _unionNode$types
+          : []
+      );
     })
     .filter((typeNode) => typeNode.name.value === typeName);
 }
@@ -650,7 +660,6 @@ function getUnionMemberTypeNodes(union, typeName) {
 function getDeprecatedDirectiveNode(definitionNode) {
   var _definitionNode$direc;
 
-  // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
   return definitionNode === null || definitionNode === void 0
     ? void 0
     : (_definitionNode$direc = definitionNode.directives) === null ||

package/type/validate.mjs

@@ -134,19 +134,24 @@ function validateRootTypes(context) {
 function getOperationTypeNode(schema, operation) {
   var _flatMap$find;
 
-  // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
   return (_flatMap$find = [schema.astNode, ...schema.extensionASTNodes]
-    .flatMap((schemaNode) => {
-      var _schemaNode$operation;
-
-      return (_schemaNode$operation =
-        schemaNode === null || schemaNode === void 0
-          ? void 0
-          : schemaNode.operationTypes) !== null &&
-        _schemaNode$operation !== void 0
-        ? _schemaNode$operation
-        : [];
-    })
+    .flatMap(
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
+      (schemaNode) => {
+        var _schemaNode$operation;
+
+        return (
+          /* c8 ignore next */
+          (_schemaNode$operation =
+            schemaNode === null || schemaNode === void 0
+              ? void 0
+              : schemaNode.operationTypes) !== null &&
+            _schemaNode$operation !== void 0
+            ? _schemaNode$operation
+            : []
+        );
+      },
+    )
     .find((operationNode) => operationNode.operation === operation)) === null ||
     _flatMap$find === void 0
     ? void 0
@@ -404,11 +409,10 @@ function validateTypeImplementsInterface(context, type, iface) {
             `${type.name}.${fieldName}(${argName}:) is type ` +
             `${inspect(typeArg.type)}.`,
           [
-            // istanbul ignore next (TODO need to write coverage tests)
             (_ifaceArg$astNode = ifaceArg.astNode) === null ||
             _ifaceArg$astNode === void 0
               ? void 0
-              : _ifaceArg$astNode.type, // istanbul ignore next (TODO need to write coverage tests)
+              : _ifaceArg$astNode.type,
             (_typeArg$astNode = typeArg.astNode) === null ||
             _typeArg$astNode === void 0
               ? void 0
@@ -531,7 +535,7 @@ function validateInputFields(context, inputObj) {
       context.reportError(
         `Required input field ${inputObj.name}.${field.name} cannot be deprecated.`,
         [
-          getDeprecatedDirectiveNode(field.astNode), // istanbul ignore next (TODO need to write coverage tests)
+          getDeprecatedDirectiveNode(field.astNode),
           (_field$astNode3 = field.astNode) === null ||
           _field$astNode3 === void 0
             ? void 0
@@ -592,16 +596,19 @@ function createInputObjectCircularRefsValidator(context) {
 function getAllImplementsInterfaceNodes(type, iface) {
   const { astNode, extensionASTNodes } = type;
   const nodes =
-    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // FIXME: https://github.com/graphql/graphql-js/issues/2203
 
   return nodes
     .flatMap((typeNode) => {
       var _typeNode$interfaces;
 
-      return (_typeNode$interfaces = typeNode.interfaces) !== null &&
-        _typeNode$interfaces !== void 0
-        ? _typeNode$interfaces
-        : [];
+      return (
+        /* c8 ignore next */
+        (_typeNode$interfaces = typeNode.interfaces) !== null &&
+          _typeNode$interfaces !== void 0
+          ? _typeNode$interfaces
+          : []
+      );
     })
     .filter((ifaceNode) => ifaceNode.name.value === iface.name);
 }
@@ -609,16 +616,19 @@ function getAllImplementsInterfaceNodes(type, iface) {
 function getUnionMemberTypeNodes(union, typeName) {
   const { astNode, extensionASTNodes } = union;
   const nodes =
-    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+    astNode != null ? [astNode, ...extensionASTNodes] : extensionASTNodes; // FIXME: https://github.com/graphql/graphql-js/issues/2203
 
   return nodes
     .flatMap((unionNode) => {
       var _unionNode$types;
 
-      return (_unionNode$types = unionNode.types) !== null &&
-        _unionNode$types !== void 0
-        ? _unionNode$types
-        : [];
+      return (
+        /* c8 ignore next */
+        (_unionNode$types = unionNode.types) !== null &&
+          _unionNode$types !== void 0
+          ? _unionNode$types
+          : []
+      );
     })
     .filter((typeNode) => typeNode.name.value === typeName);
 }
@@ -626,7 +636,6 @@ function getUnionMemberTypeNodes(union, typeName) {
 function getDeprecatedDirectiveNode(definitionNode) {
   var _definitionNode$direc;
 
-  // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
   return definitionNode === null || definitionNode === void 0
     ? void 0
     : (_definitionNode$direc = definitionNode.directives) === null ||

package/utilities/TypeInfo.js

@@ -276,6 +276,8 @@ class TypeInfo {
         this._enumValue = enumValue;
         break;
       }
+
+      default: // Ignore other nodes
     }
   }
 
@@ -329,6 +331,8 @@ class TypeInfo {
       case _kinds.Kind.ENUM:
         this._enumValue = null;
         break;
+
+      default: // Ignore other nodes
     }
   }
 }

package/utilities/TypeInfo.mjs

@@ -264,6 +264,8 @@ export class TypeInfo {
         this._enumValue = enumValue;
         break;
       }
+
+      default: // Ignore other nodes
     }
   }
 
@@ -317,6 +319,8 @@ export class TypeInfo {
       case Kind.ENUM:
         this._enumValue = null;
         break;
+
+      default: // Ignore other nodes
     }
   }
 }

package/utilities/assertValidName.js

@@ -12,11 +12,12 @@ var _GraphQLError = require('../error/GraphQLError.js');
 
 var _assertName = require('../type/assertName.js');
 
+/* c8 ignore start */
+
 /**
  * Upholds the spec rules about naming.
  * @deprecated Please use `assertName` instead. Will be removed in v17
  */
-// istanbul ignore next (Deprecated code)
 function assertValidName(name) {
   const error = isValidNameError(name);
 
@@ -30,7 +31,6 @@ function assertValidName(name) {
  * Returns an Error if a name is invalid.
  * @deprecated Please use `assertName` instead. Will be removed in v17
  */
-// istanbul ignore next (Deprecated code)
 
 function isValidNameError(name) {
   typeof name === 'string' ||
@@ -48,3 +48,4 @@ function isValidNameError(name) {
     return error;
   }
 }
+/* c8 ignore stop */

package/utilities/assertValidName.mjs

@@ -1,11 +1,12 @@
 import { devAssert } from '../jsutils/devAssert.mjs';
 import { GraphQLError } from '../error/GraphQLError.mjs';
 import { assertName } from '../type/assertName.mjs';
+/* c8 ignore start */
+
 /**
  * Upholds the spec rules about naming.
  * @deprecated Please use `assertName` instead. Will be removed in v17
  */
-// istanbul ignore next (Deprecated code)
 
 export function assertValidName(name) {
   const error = isValidNameError(name);
@@ -20,7 +21,6 @@ export function assertValidName(name) {
  * Returns an Error if a name is invalid.
  * @deprecated Please use `assertName` instead. Will be removed in v17
  */
-// istanbul ignore next (Deprecated code)
 
 export function isValidNameError(name) {
   typeof name === 'string' || devAssert(false, 'Expected name to be a string.');
@@ -37,3 +37,4 @@ export function isValidNameError(name) {
     return error;
   }
 }
+/* c8 ignore stop */

package/utilities/astFromValue.js

@@ -115,7 +115,7 @@ function astFromValue(value, type) {
       kind: _kinds.Kind.OBJECT,
       fields: fieldNodes,
     };
-  } // istanbul ignore else (See: 'https://github.com/graphql/graphql-js/issues/2618')
+  }
 
   if ((0, _definition.isLeafType)(type)) {
     // Since value is an internally represented value, it must be serialized
@@ -171,7 +171,9 @@ function astFromValue(value, type) {
     throw new TypeError(
       `Cannot convert value to AST: ${(0, _inspect.inspect)(serialized)}.`,
     );
-  } // istanbul ignore next (Not reachable. All possible input types have been considered)
+  }
+  /* c8 ignore next 3 */
+  // Not reachable, all possible types have been considered.
 
   false ||
     (0, _invariant.invariant)(

package/utilities/astFromValue.mjs

@@ -108,7 +108,7 @@ export function astFromValue(value, type) {
       kind: Kind.OBJECT,
       fields: fieldNodes,
     };
-  } // istanbul ignore else (See: 'https://github.com/graphql/graphql-js/issues/2618')
+  }
 
   if (isLeafType(type)) {
     // Since value is an internally represented value, it must be serialized
@@ -162,7 +162,9 @@ export function astFromValue(value, type) {
     }
 
     throw new TypeError(`Cannot convert value to AST: ${inspect(serialized)}.`);
-  } // istanbul ignore next (Not reachable. All possible input types have been considered)
+  }
+  /* c8 ignore next 3 */
+  // Not reachable, all possible types have been considered.
 
   false || invariant(false, 'Unexpected input type: ' + inspect(type));
 }

package/utilities/buildClientSchema.js

@@ -151,6 +151,8 @@ function buildClientSchema(introspection, options) {
   function buildType(type) {
     // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     if (type != null && type.name != null && type.kind != null) {
+      // FIXME: Properly type IntrospectionType, it's a breaking change so fix in v17
+      // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check
       switch (type.kind) {
         case _introspection.TypeKind.SCALAR:
           return buildScalarDef(type);

package/utilities/buildClientSchema.mjs

@@ -141,6 +141,8 @@ export function buildClientSchema(introspection, options) {
   function buildType(type) {
     // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     if (type != null && type.name != null && type.kind != null) {
+      // FIXME: Properly type IntrospectionType, it's a breaking change so fix in v17
+      // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check
       switch (type.kind) {
         case TypeKind.SCALAR:
           return buildScalarDef(type);

package/utilities/coerceInputValue.js

@@ -140,7 +140,7 @@ function coerceInputValueImpl(inputValue, type, onError, path) {
     }
 
     return coercedValue;
-  } // istanbul ignore else (See: 'https://github.com/graphql/graphql-js/issues/2618')
+  }
 
   if ((0, _definition.isLeafType)(type)) {
     let parseResult; // Scalars and Enums determine if a input value is valid via parseValue(),
@@ -179,7 +179,9 @@ function coerceInputValueImpl(inputValue, type, onError, path) {
     }
 
     return parseResult;
-  } // istanbul ignore next (Not reachable. All possible input types have been considered)
+  }
+  /* c8 ignore next 3 */
+  // Not reachable, all possible types have been considered.
 
   false ||
     (0, _invariant.invariant)(

package/utilities/coerceInputValue.mjs

@@ -125,7 +125,7 @@ function coerceInputValueImpl(inputValue, type, onError, path) {
     }
 
     return coercedValue;
-  } // istanbul ignore else (See: 'https://github.com/graphql/graphql-js/issues/2618')
+  }
 
   if (isLeafType(type)) {
     let parseResult; // Scalars and Enums determine if a input value is valid via parseValue(),
@@ -164,7 +164,9 @@ function coerceInputValueImpl(inputValue, type, onError, path) {
     }
 
     return parseResult;
-  } // istanbul ignore next (Not reachable. All possible input types have been considered)
+  }
+  /* c8 ignore next 3 */
+  // Not reachable, all possible types have been considered.
 
   false || invariant(false, 'Unexpected input type: ' + inspect(type));
 }

package/utilities/extendSchema.js

@@ -229,11 +229,13 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
 
     if ((0, _definition.isEnumType)(type)) {
       return extendEnumType(type);
-    } // istanbul ignore else (See: 'https://github.com/graphql/graphql-js/issues/2618')
+    }
 
     if ((0, _definition.isInputObjectType)(type)) {
       return extendInputObjectType(type);
-    } // istanbul ignore next (Not reachable. All possible types have been considered)
+    }
+    /* c8 ignore next 3 */
+    // Not reachable, all possible type definition nodes have been considered.
 
     false ||
       (0, _invariant.invariant)(
@@ -391,8 +393,9 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     for (const node of nodes) {
       var _node$operationTypes;
 
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       const operationTypesNodes =
+        /* c8 ignore next */
         (_node$operationTypes = node.operationTypes) !== null &&
         _node$operationTypes !== void 0
           ? _node$operationTypes
@@ -463,8 +466,9 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     for (const node of nodes) {
       var _node$fields;
 
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       const nodeFields =
+        /* c8 ignore next */
         (_node$fields = node.fields) !== null && _node$fields !== void 0
           ? _node$fields
           : [];
@@ -493,8 +497,10 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
   }
 
   function buildArgumentMap(args) {
-    // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
-    const argsNodes = args !== null && args !== void 0 ? args : [];
+    // FIXME: https://github.com/graphql/graphql-js/issues/2203
+    const argsNodes =
+      /* c8 ignore next */
+      args !== null && args !== void 0 ? args : [];
     const argConfigMap = Object.create(null);
 
     for (const arg of argsNodes) {
@@ -526,8 +532,9 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     for (const node of nodes) {
       var _node$fields2;
 
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       const fieldsNodes =
+        /* c8 ignore next */
         (_node$fields2 = node.fields) !== null && _node$fields2 !== void 0
           ? _node$fields2
           : [];
@@ -565,8 +572,9 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     for (const node of nodes) {
       var _node$values;
 
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       const valuesNodes =
+        /* c8 ignore next */
         (_node$values = node.values) !== null && _node$values !== void 0
           ? _node$values
           : [];
@@ -595,18 +603,21 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     // validation with validateSchema() will produce more actionable results.
     // @ts-expect-error
     return nodes.flatMap(
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       (node) => {
         var _node$interfaces$map, _node$interfaces;
 
-        return (_node$interfaces$map =
-          (_node$interfaces = node.interfaces) === null ||
-          _node$interfaces === void 0
-            ? void 0
-            : _node$interfaces.map(getNamedType)) !== null &&
-          _node$interfaces$map !== void 0
-          ? _node$interfaces$map
-          : [];
+        return (
+          /* c8 ignore next */
+          (_node$interfaces$map =
+            (_node$interfaces = node.interfaces) === null ||
+            _node$interfaces === void 0
+              ? void 0
+              : _node$interfaces.map(getNamedType)) !== null &&
+            _node$interfaces$map !== void 0
+            ? _node$interfaces$map
+            : []
+        );
       },
     );
   }
@@ -617,17 +628,20 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
     // validation with validateSchema() will produce more actionable results.
     // @ts-expect-error
     return nodes.flatMap(
-      // istanbul ignore next (See: 'https://github.com/graphql/graphql-js/issues/2203')
+      // FIXME: https://github.com/graphql/graphql-js/issues/2203
       (node) => {
         var _node$types$map, _node$types;
 
-        return (_node$types$map =
-          (_node$types = node.types) === null || _node$types === void 0
-            ? void 0
-            : _node$types.map(getNamedType)) !== null &&
-          _node$types$map !== void 0
-          ? _node$types$map
-          : [];
+        return (
+          /* c8 ignore next */
+          (_node$types$map =
+            (_node$types = node.types) === null || _node$types === void 0
+              ? void 0
+              : _node$types.map(getNamedType)) !== null &&
+            _node$types$map !== void 0
+            ? _node$types$map
+            : []
+        );
       },
     );
   }
@@ -745,13 +759,7 @@ function extendSchemaImpl(schemaConfig, documentAST, options) {
           extensionASTNodes,
         });
       }
-    } // istanbul ignore next (Not reachable. All possible type definition nodes have been considered)
-
-    false ||
-      (0, _invariant.invariant)(
-        false,
-        'Unexpected type definition node: ' + (0, _inspect.inspect)(astNode),
-      );
+    }
   }
 }