graphql 14.5.4 → 14.5.8

package/execution/values.js

@@ -86,9 +86,7 @@ function coerceVariableValues(schema, varDefNodes, inputs, onError) {
     if (!hasOwnProperty(inputs, varName)) {
       if (varDefNode.defaultValue) {
         coercedValues[varName] = (0, _valueFromAST.valueFromAST)(varDefNode.defaultValue, varType);
-      }
-
-      if ((0, _definition.isNonNullType)(varType)) {
+      } else if ((0, _definition.isNonNullType)(varType)) {
         var _varTypeStr = (0, _inspect.default)(varType);
 
         onError(new _GraphQLError.GraphQLError("Variable \"$".concat(varName, "\" of required type \"").concat(_varTypeStr, "\" was not provided."), varDefNode));

package/execution/values.js.flow

@@ -96,9 +96,7 @@ function coerceVariableValues(
     if (!hasOwnProperty(inputs, varName)) {
       if (varDefNode.defaultValue) {
         coercedValues[varName] = valueFromAST(varDefNode.defaultValue, varType);
-      }
-
-      if (isNonNullType(varType)) {
+      } else if (isNonNullType(varType)) {
         const varTypeStr = inspect(varType);
         onError(
           new GraphQLError(

package/execution/values.mjs

@@ -65,9 +65,7 @@ function coerceVariableValues(schema, varDefNodes, inputs, onError) {
     if (!hasOwnProperty(inputs, varName)) {
       if (varDefNode.defaultValue) {
         coercedValues[varName] = valueFromAST(varDefNode.defaultValue, varType);
-      }
-
-      if (isNonNullType(varType)) {
+      } else if (isNonNullType(varType)) {
         var _varTypeStr = inspect(varType);
 
         onError(new GraphQLError("Variable \"$".concat(varName, "\" of required type \"").concat(_varTypeStr, "\" was not provided."), varDefNode));

package/language/lexer.js

@@ -393,6 +393,12 @@ function readNumber(source, start, firstCode, line, col, prev) {
     }
 
     position = readDigits(source, position, code);
+    code = body.charCodeAt(position);
+  } // Numbers cannot be followed by . or e
+
+
+  if (code === 46 || code === 69 || code === 101) {
+    throw (0, _syntaxError.syntaxError)(source, position, "Invalid number, expected digit but got: ".concat(printCharCode(code), "."));
   }
 
   return new Tok(isFloat ? _tokenKind.TokenKind.FLOAT : _tokenKind.TokenKind.INT, start, position, line, col, prev, body.slice(start, position));

package/language/lexer.js.flow

@@ -444,6 +444,16 @@ function readNumber(source, start, firstCode, line, col, prev): Token {
       code = body.charCodeAt(++position);
     }
     position = readDigits(source, position, code);
+    code = body.charCodeAt(position);
+  }
+
+  // Numbers cannot be followed by . or e
+  if (code === 46 || code === 69 || code === 101) {
+    throw syntaxError(
+      source,
+      position,
+      `Invalid number, expected digit but got: ${printCharCode(code)}.`,
+    );
   }
 
   return new Tok(

package/language/lexer.mjs

@@ -379,6 +379,12 @@ function readNumber(source, start, firstCode, line, col, prev) {
     }
 
     position = readDigits(source, position, code);
+    code = body.charCodeAt(position);
+  } // Numbers cannot be followed by . or e
+
+
+  if (code === 46 || code === 69 || code === 101) {
+    throw syntaxError(source, position, "Invalid number, expected digit but got: ".concat(printCharCode(code), "."));
   }
 
   return new Tok(isFloat ? TokenKind.FLOAT : TokenKind.INT, start, position, line, col, prev, body.slice(start, position));

package/language/printLocation.js

@@ -62,7 +62,7 @@ function printPrefixedLines(lines) {
   return existingLines.map(function (_ref3) {
     var prefix = _ref3[0],
         line = _ref3[1];
-    return lpad(padLen, prefix) + ' | ' + line;
+    return lpad(padLen, prefix) + (line ? ' | ' + line : ' |');
   }).join('\n');
 }
 

package/language/printLocation.js.flow

@@ -72,7 +72,9 @@ function printPrefixedLines(lines: $ReadOnlyArray<[string, string]>): string {
 
   const padLen = Math.max(...existingLines.map(([prefix]) => prefix.length));
   return existingLines
-    .map(([prefix, line]) => lpad(padLen, prefix) + ' | ' + line)
+    .map(
+      ([prefix, line]) => lpad(padLen, prefix) + (line ? ' | ' + line : ' |'),
+    )
     .join('\n');
 }
 

package/language/printLocation.mjs

@@ -53,7 +53,7 @@ function printPrefixedLines(lines) {
   return existingLines.map(function (_ref3) {
     var prefix = _ref3[0],
         line = _ref3[1];
-    return lpad(padLen, prefix) + ' | ' + line;
+    return lpad(padLen, prefix) + (line ? ' | ' + line : ' |');
   }).join('\n');
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql",
-  "version": "14.5.4",
+  "version": "14.5.8",
   "description": "A Query Language and Runtime which can target any service.",
   "license": "MIT",
   "main": "index",

package/type/definition.d.ts

@@ -424,6 +424,7 @@ export type GraphQLTypeResolver<
   value: TSource,
   context: TContext,
   info: GraphQLResolveInfo,
+  abstractType: GraphQLAbstractType,
 ) => PromiseOrValue<
   Maybe<GraphQLObjectType<TSource, TContext, TArgs> | string>
 >;

package/type/directives.d.ts

@@ -67,6 +67,4 @@ export const GraphQLDeprecatedDirective: GraphQLDirective;
  */
 export const specifiedDirectives: ReadonlyArray<GraphQLDirective>;
 
-export function isSpecifiedDirective(
-  directive: any,
-): directive is GraphQLDirective;
+export function isSpecifiedDirective(directive: any): boolean;

package/type/scalars.d.ts

@@ -8,4 +8,4 @@ export const GraphQLID: GraphQLScalarType;
 
 export const specifiedScalarTypes: ReadonlyArray<GraphQLScalarType>;
 
-export function isSpecifiedScalarType(type: any): type is GraphQLScalarType;
+export function isSpecifiedScalarType(type: any): boolean;

package/utilities/findBreakingChanges.js

@@ -17,12 +17,20 @@ var _invariant = _interopRequireDefault(require("../jsutils/invariant"));
 
 var _printer = require("../language/printer");
 
+var _visitor = require("../language/visitor");
+
 var _definition = require("../type/definition");
 
 var _astFromValue = require("./astFromValue");
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(source, true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(source).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 var BreakingChangeType = Object.freeze({
   TYPE_REMOVED: 'TYPE_REMOVED',
   TYPE_CHANGED_KIND: 'TYPE_CHANGED_KIND',
@@ -342,6 +350,9 @@ function findArgChanges(oldType, oldField, newField) {
           description: "".concat(oldType.name, ".").concat(oldField.name, " arg ").concat(_oldArg.name, " defaultValue was removed.")
         });
       } else {
+        // Since we looking only for client's observable changes we should
+        // compare default values in the same representation as they are
+        // represented inside introspection.
         var oldValueStr = stringifyValue(_oldArg.defaultValue, _oldArg.type);
         var newValueStr = stringifyValue(newArg.defaultValue, newArg.type);
 
@@ -447,7 +458,17 @@ function stringifyValue(value, type) {
 
   /* istanbul ignore next */
   ast != null || (0, _invariant.default)(0);
-  return (0, _printer.print)(ast);
+  var sortedAST = (0, _visitor.visit)(ast, {
+    ObjectValue: function ObjectValue(objectNode) {
+      var fields = [].concat(objectNode.fields).sort(function (fieldA, fieldB) {
+        return fieldA.name.value.localeCompare(fieldB.name.value);
+      });
+      return _objectSpread({}, objectNode, {
+        fields: fields
+      });
+    }
+  });
+  return (0, _printer.print)(sortedAST);
 }
 
 function diff(oldArray, newArray) {

package/utilities/findBreakingChanges.js.flow

@@ -7,6 +7,7 @@ import inspect from '../jsutils/inspect';
 import invariant from '../jsutils/invariant';
 
 import { print } from '../language/printer';
+import { visit } from '../language/visitor';
 
 import { type GraphQLSchema } from '../type/schema';
 import {
@@ -395,6 +396,9 @@ function findArgChanges(
           description: `${oldType.name}.${oldField.name} arg ${oldArg.name} defaultValue was removed.`,
         });
       } else {
+        // Since we looking only for client's observable changes we should
+        // compare default values in the same representation as they are
+        // represented inside introspection.
         const oldValueStr = stringifyValue(oldArg.defaultValue, oldArg.type);
         const newValueStr = stringifyValue(newArg.defaultValue, newArg.type);
 
@@ -518,7 +522,17 @@ function typeKindName(type: GraphQLNamedType): string {
 function stringifyValue(value: mixed, type: GraphQLInputType): string {
   const ast = astFromValue(value, type);
   invariant(ast != null);
-  return print(ast);
+
+  const sortedAST = visit(ast, {
+    ObjectValue(objectNode) {
+      const fields = [...objectNode.fields].sort((fieldA, fieldB) =>
+        fieldA.name.value.localeCompare(fieldB.name.value),
+      );
+      return { ...objectNode, fields };
+    },
+  });
+
+  return print(sortedAST);
 }
 
 function diff<T: { name: string, ... }>(

package/utilities/findBreakingChanges.mjs

@@ -1,8 +1,15 @@
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(source, true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(source).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
+function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
+
 import objectValues from '../polyfills/objectValues';
 import keyMap from '../jsutils/keyMap';
 import inspect from '../jsutils/inspect';
 import invariant from '../jsutils/invariant';
 import { print } from '../language/printer';
+import { visit } from '../language/visitor';
 import { isScalarType, isObjectType, isInterfaceType, isUnionType, isEnumType, isInputObjectType, isNonNullType, isListType, isNamedType, isRequiredArgument, isRequiredInputField } from '../type/definition';
 import { astFromValue } from './astFromValue';
 export var BreakingChangeType = Object.freeze({
@@ -321,6 +328,9 @@ function findArgChanges(oldType, oldField, newField) {
           description: "".concat(oldType.name, ".").concat(oldField.name, " arg ").concat(_oldArg.name, " defaultValue was removed.")
         });
       } else {
+        // Since we looking only for client's observable changes we should
+        // compare default values in the same representation as they are
+        // represented inside introspection.
         var oldValueStr = stringifyValue(_oldArg.defaultValue, _oldArg.type);
         var newValueStr = stringifyValue(newArg.defaultValue, newArg.type);
 
@@ -426,7 +436,17 @@ function stringifyValue(value, type) {
 
   /* istanbul ignore next */
   ast != null || invariant(0);
-  return print(ast);
+  var sortedAST = visit(ast, {
+    ObjectValue: function ObjectValue(objectNode) {
+      var fields = [].concat(objectNode.fields).sort(function (fieldA, fieldB) {
+        return fieldA.name.value.localeCompare(fieldB.name.value);
+      });
+      return _objectSpread({}, objectNode, {
+        fields: fields
+      });
+    }
+  });
+  return print(sortedAST);
 }
 
 function diff(oldArray, newArray) {

package/validation/ValidationContext.js.flow

@@ -149,7 +149,7 @@ export class SDLValidationContext extends ASTValidationContext {
   constructor(
     ast: DocumentNode,
     schema: ?GraphQLSchema,
-    onError: (err: GraphQLError) => void,
+    onError?: (err: GraphQLError) => void,
   ): void {
     super(ast, onError);
     this._schema = schema;

package/version.js

@@ -13,7 +13,7 @@ exports.versionInfo = exports.version = void 0;
 /**
  * A string containing the version of the GraphQL.js library
  */
-var version = '14.5.4';
+var version = '14.5.8';
 /**
  * An object containing the components of the GraphQL.js version string
  */
@@ -22,7 +22,7 @@ exports.version = version;
 var versionInfo = Object.freeze({
   major: 14,
   minor: 5,
-  patch: 4,
+  patch: 8,
   preReleaseTag: null
 });
 exports.versionInfo = versionInfo;

package/version.js.flow

@@ -8,7 +8,7 @@
 /**
  * A string containing the version of the GraphQL.js library
  */
-export const version = '14.5.4';
+export const version = '14.5.8';
 
 /**
  * An object containing the components of the GraphQL.js version string
@@ -16,6 +16,6 @@ export const version = '14.5.4';
 export const versionInfo = Object.freeze({
   major: 14,
   minor: 5,
-  patch: 4,
+  patch: 8,
   preReleaseTag: null,
 });

package/version.mjs

@@ -6,7 +6,7 @@
 /**
  * A string containing the version of the GraphQL.js library
  */
-export var version = '14.5.4';
+export var version = '14.5.8';
 /**
  * An object containing the components of the GraphQL.js version string
  */
@@ -14,6 +14,6 @@ export var version = '14.5.4';
 export var versionInfo = Object.freeze({
   major: 14,
   minor: 5,
-  patch: 4,
+  patch: 8,
   preReleaseTag: null
 });