graphdb-workbench-tests 4.0.0-TR7 → 4.0.0-TR9

package/e2e-legacy/explore/graphs-overview/graphs.overview.spec.js

@@ -18,7 +18,7 @@ describe('Graphs overview screen validation', () => {
         cy.window();
 
         cy.fixture('graph/rdf.txt').then((rdf) => {
-            return new Cypress.Promise((resolve, reject) => {
+            return new Cypress.Promise((resolve) => {
                 cy.importRDFTextSnippet(repositoryId, rdf, {format: "application/x-trig"});
                 resolve();
             });
@@ -76,6 +76,7 @@ describe('Graphs overview screen validation', () => {
         it('Should switch pages', () => {
             // Makes this less flaky - is it possible the page elements don't have an event attached
             // yet when this fails? It looks like the click has never happened
+            // eslint-disable-next-line cypress/no-unnecessary-waiting
             cy.wait(100);
 
             // Switch through pages and verify that the respective pager button is active.
@@ -111,6 +112,31 @@ describe('Graphs overview screen validation', () => {
         verifyGraphExistence('urn:11', false);
     });
 
+    it('Should give the controls on the page accessible names', () => {
+        // Then the search field should have a visible label
+        GraphsOverviewSteps.getGraphsSearchLabel()
+            .should('be.visible')
+            .and('contain.text', 'Search Graphs');
+        GraphsOverviewSteps.getGraphsSearchInput().should('have.attr', 'id', 'search-graphs');
+        // And the table and the header controls should have accessible names
+        GraphsOverviewSteps.getResultsElement().should('have.attr', 'aria-label', 'Graphs')
+            .and('not.have.attr', 'aria-describedby');
+        GraphsOverviewSteps.getSelectAllGraphsCheckbox().should('have.attr', 'aria-label', 'Select all graphs');
+        GraphsOverviewSteps.getExportSelectedGraphsButton().should('have.attr', 'aria-label', 'Export selected graphs');
+        GraphsOverviewSteps.getDeleteSelectedGraphsButton().should('have.attr', 'aria-label', 'Removes all data from the selected graphs');
+        GraphsOverviewSteps.getActionsColumnHeader().should('contain.text', 'Actions');
+        // And no empty label should wrap the checkbox
+        GraphsOverviewSteps.getResultsHeader().find('label').should('not.exist');
+        // And the controls in each row should include the graph name
+        GraphsOverviewSteps.getSelectGraphCheckbox('urn:9').should('have.attr', 'aria-label', 'Select graph urn:9');
+        GraphsOverviewSteps.getExportGraphButton('urn:9').should('have.attr', 'aria-label', 'Export graph urn:9');
+        GraphsOverviewSteps.getDeleteGraphButton('urn:9').should('have.attr', 'aria-label', 'Remove all data from graph urn:9');
+        GraphsOverviewSteps.getGraphRow('urn:9').find('label').should('not.exist');
+        // And the default graph row should use the translated graph name
+        GraphsOverviewSteps.getDefaultGraphRow().find('.select-graph-checkbox')
+            .should('have.attr', 'aria-label', 'Select graph The default graph');
+    });
+
     it('Delete graph', () => {
         let graphToDelete = 'urn:9';
         cy.get(`${EXPORT_GRAPHS_TABLE_ID} tbody a[title="${graphToDelete}"]`)
@@ -125,7 +151,8 @@ describe('Graphs overview screen validation', () => {
         verifyVisibleGraphsCount(1);
         verifyGraphExistence('The default graph');
         // open default graph through the link and verify that the table view is rendered
-        cy.getByTestId('graph-is-not-shaql').contains('The default graph').trigger('mouseover').click();
+        cy.getByTestId('graph-is-not-shaql').contains('The default graph').trigger('mouseover');
+        cy.getByTestId('graph-is-not-shaql').contains('The default graph').click();
         cy.url().should('contain', Cypress.config('baseUrl') + '/resource');
         YasrSteps.getResultTableHeader().should('be.visible');
         YasrSteps.getResultTableHeaderColumns().should('have.length', 5);

package/e2e-legacy/import/import-user-data-file-upload.spec.js

@@ -152,6 +152,32 @@ describe('Import user data: File upload', () => {
         ImportUserDataSteps.getResources().should('have.length', 1);
     });
 
+    it('Should give the controls on the page accessible names', () => {
+        // Given I have uploaded a file without importing it
+        const file = ImportUserDataSteps.createFile(testFiles[0], bnodes);
+        ImportUserDataSteps.selectFile(file);
+        ImportSettingsDialogSteps.uploadOnly();
+        ImportUserDataSteps.getResources().should('have.length', 1);
+        // Then the icon-only buttons and the row checkbox should have accessible names
+        ImportUserDataSteps.getHelpToggleButton().should('have.attr', 'aria-label', 'Get help on import');
+        ImportUserDataSteps.getStatusSelectMenuToggle().should('have.attr', 'aria-label', 'Select resources by status');
+        ImportUserDataSteps.getResourceSelectCheckbox('bnodes.ttl').should('have.attr', 'aria-label', 'Select bnodes.ttl');
+        ImportUserDataSteps.getResourceImportButton('bnodes.ttl').should('have.attr', 'aria-label', 'Import bnodes.ttl');
+        ImportUserDataSteps.getResourceRemoveButton('bnodes.ttl').should('have.attr', 'aria-label', 'Remove bnodes.ttl');
+        // And no empty context link should be rendered
+        ImportUserDataSteps.getResourceContextLink('bnodes.ttl').should('not.exist');
+        // And the filter field should have a visible label
+        ImportUserDataSteps.getFilterFieldLabel()
+            .should('be.visible')
+            .and('contain.text', 'Filter by name');
+        // When I import the file
+        ImportUserDataSteps.importFile(0);
+        ImportSettingsDialogSteps.import();
+        ImportUserDataSteps.checkImportedResourceByIndex(0, 'bnodes.ttl');
+        // Then the reset status button should have an accessible name
+        ImportUserDataSteps.getResourceResetButton('bnodes.ttl').should('have.attr', 'aria-label', 'Reset status of bnodes.ttl');
+    });
+
     it('Should be able to upload multiple unique files', () => {
         // Given there are no files uploaded yet
         ImportUserDataSteps.getResourcesTable().should('be.hidden');

package/e2e-legacy/reactodia/reactodia-restrictions.spec.js

@@ -0,0 +1,200 @@
+import {ReactodiaSteps} from '../../steps/reactodia-steps.js';
+import {PageRestrictionsSteps} from '../../steps/page-restrictions-steps.js';
+import {RepositoryPickerListSteps} from '../../steps/repository-picker-list-steps.js';
+import {LicenseStubs} from '../../stubs/license-stubs.js';
+import {RepositorySteps} from '../../steps/repository-steps.js';
+
+const NO_REPOSITORY_MESSAGE = 'you are not connected to any repository';
+const INVALID_LICENSE_MESSAGE = 'your license is not valid';
+const SELECT_OR_CREATE_REPOSITORY_MESSAGE = 'Select a repository below or create a new one.';
+const SELECT_REPOSITORY_MESSAGE = 'Select a repository below.';
+
+describe('Reactodia view restrictions', () => {
+    let repositoryId;
+
+    beforeEach(() => {
+        repositoryId = 'reactodia-view-restrictions-' + Date.now();
+        cy.createRepository({id: repositoryId});
+    });
+
+    afterEach(() => {
+        cy.deleteRepository(repositoryId);
+    });
+
+    it('should show the repository picker when no repository is selected', () => {
+        // GIVEN no repository is selected
+
+        // WHEN I open the Reactodia view
+        ReactodiaSteps.visit();
+        // THEN I expect the repository restriction is shown
+        PageRestrictionsSteps.getMessages().should('have.length', 1);
+        PageRestrictionsSteps.getMessage(NO_REPOSITORY_MESSAGE).should('be.visible');
+        // AND the existing repository is available in the picker
+        RepositoryPickerListSteps.getRepositoryRow(repositoryId).should('be.visible');
+        // AND the graph is not rendered
+        ReactodiaSteps.getComponent().should('not.exist');
+    });
+
+    it('should render the graph when a repository is selected from the picker', () => {
+        // GIVEN the Reactodia view is open with no repository selected
+        ReactodiaSteps.visit();
+
+        // WHEN I select a repository
+        RepositoryPickerListSteps.selectRepository(repositoryId);
+        // THEN I expect the restriction is removed and the graph is rendered
+        PageRestrictionsSteps.getRestrictions().should('not.exist');
+        ReactodiaSteps.getWorkspace().should('exist');
+    });
+
+    it('should not restrict the view when the license is valid and a repository is selected', () => {
+        // GIVEN a valid license and a selected repository
+        cy.presetRepository(repositoryId);
+
+        // WHEN I open the Reactodia view
+        ReactodiaSteps.visit();
+        // THEN I expect the view is not restricted
+        ReactodiaSteps.getWorkspace().should('exist');
+        PageRestrictionsSteps.getRestrictions().should('not.exist');
+    });
+
+    context('when the license is invalid', () => {
+        beforeEach(() => {
+            LicenseStubs.stubNoValidLicense();
+        });
+
+        it('should show the license restriction when a repository is selected', () => {
+            // GIVEN an invalid license and a selected repository
+            cy.presetRepository(repositoryId);
+
+            // WHEN I open the Reactodia view
+            ReactodiaSteps.visit();
+            // THEN I expect the license restriction is shown
+            PageRestrictionsSteps.getMessages().should('have.length', 1);
+            PageRestrictionsSteps.getMessage(INVALID_LICENSE_MESSAGE).should('be.visible');
+            // AND the "Set a new license" link is displayed
+            PageRestrictionsSteps.getInternalLink()
+                .should('contain.text', 'Set a new license')
+                .and('have.attr', 'href')
+                .and('include', '/license');
+            // AND the repository picker and graph are not rendered
+            RepositoryPickerListSteps.getRepositoryPickerList().should('not.exist');
+            ReactodiaSteps.getComponent().should('not.exist');
+        });
+
+        it('should show both restrictions when no repository is selected', () => {
+            // GIVEN an invalid license and no repository selected
+
+            // WHEN I open the Reactodia view
+            ReactodiaSteps.visit();
+            // THEN both restrictions are shown
+            PageRestrictionsSteps.getMessages().should('have.length', 2);
+            PageRestrictionsSteps.getMessage(INVALID_LICENSE_MESSAGE).should('be.visible');
+            PageRestrictionsSteps.getMessage(NO_REPOSITORY_MESSAGE)
+                .should('be.visible')
+                .and('not.contain.text', 'create a new one');
+            // AND the existing repository is available, but repository creation is not
+            RepositoryPickerListSteps.getRepositoryRow(repositoryId).should('be.visible');
+            RepositoryPickerListSteps.getCreateRepositoryButton().should('not.exist');
+            // AND the graph is not rendered
+            ReactodiaSteps.getComponent().should('not.exist');
+        });
+    });
+
+    context('with security enabled', () => {
+        const readOnlyUser = 'reactodia-reader-' + Date.now();
+        const repoManagerUser = 'reactodia-repo-manager-' + Date.now();
+        const repoMaintainerUser = 'reactodia-repo-maintainer-' + Date.now();
+        const password = 'root';
+
+        beforeEach(() => {
+            cy.createUser({
+                username: readOnlyUser,
+                password,
+                grantedAuthorities: ['ROLE_USER', `READ_REPO_${repositoryId}`]
+            });
+            cy.createUser({
+                username: repoManagerUser,
+                password,
+                grantedAuthorities: ['ROLE_USER', 'ROLE_REPO_MANAGER']
+            });
+            cy.createUser({
+                username: repoMaintainerUser,
+                password,
+                grantedAuthorities: [
+                    'ROLE_USER',
+                    `READ_REPO_${repositoryId}`,
+                    `WRITE_REPO_${repositoryId}`,
+                    `MAINTAIN_REPO_${repositoryId}`
+                ]
+            });
+            cy.switchOnSecurity();
+        });
+
+        afterEach(() => {
+            cy.loginAsAdmin().then(() => {
+                cy.deleteUser(readOnlyUser, true);
+                cy.deleteUser(repoManagerUser, true);
+                cy.deleteUser(repoMaintainerUser, true);
+                cy.switchOffSecurity(true);
+            });
+        });
+
+        it('should not restrict the view for a user without write permission', () => {
+            // GIVEN a user with read-only access to the selected repository
+            cy.loginAs(readOnlyUser, password);
+            cy.presetRepository(repositoryId);
+
+            // WHEN I open the Reactodia view
+            ReactodiaSteps.visit();
+            // THEN I expect the view is not restricted
+            ReactodiaSteps.getWorkspace().should('exist');
+            PageRestrictionsSteps.getRestrictions().should('not.exist');
+        });
+
+        it('should offer repository creation to the administrator', () => {
+            // GIVEN the administrator is logged in with no repository selected
+            cy.loginAs('admin', password);
+
+            // WHEN I open the Reactodia view
+            ReactodiaSteps.visit();
+            // THEN I expect the option to select or create a repository is displayed
+            PageRestrictionsSteps.getMessage(SELECT_OR_CREATE_REPOSITORY_MESSAGE).should('be.visible');
+            RepositoryPickerListSteps.getRepositoryRow(repositoryId).should('be.visible');
+            RepositoryPickerListSteps.getCreateRepositoryButton().should('be.visible');
+        });
+
+        it('should offer repository creation to a repository manager', () => {
+            // GIVEN a repository manager is logged in with no repository selected
+            cy.loginAs(repoManagerUser, password);
+
+            // WHEN I open the Reactodia view
+            ReactodiaSteps.visit();
+            // THEN the option to select or create a repository is displayed
+            PageRestrictionsSteps.getMessage(SELECT_OR_CREATE_REPOSITORY_MESSAGE).should('be.visible');
+            RepositoryPickerListSteps.getRepositoryRow(repositoryId).should('be.visible');
+
+            // WHEN I click the create repository button
+            RepositoryPickerListSteps.clickCreateRepositoryButton();
+            // THEN the create repository view is opened
+            RepositorySteps.verifyRepositoryCreateViewUrl().and('include', 'previous=%2Freactodia');
+        });
+
+        [
+            {role: 'a read-only user', username: readOnlyUser},
+            {role: 'a repository maintainer', username: repoMaintainerUser},
+        ].forEach(({role, username}) => {
+            it(`should not offer repository creation to ${role}`, () => {
+                // GIVEN a user without repository management rights is logged in with no repository selected
+                cy.loginAs(username, password);
+
+                // WHEN I open the Reactodia view
+                ReactodiaSteps.visit();
+                // THEN only the option to select a repository is displayed
+                PageRestrictionsSteps.getMessage(SELECT_REPOSITORY_MESSAGE).should('be.visible');
+                PageRestrictionsSteps.getMessages().should('not.contain.text', 'create a new one');
+                RepositoryPickerListSteps.getRepositoryRow(repositoryId).should('be.visible');
+                RepositoryPickerListSteps.getCreateRepositoryButton().should('not.exist');
+            });
+        });
+    });
+});

package/e2e-legacy/reactodia/reactodia.spec.js

@@ -2,6 +2,8 @@ import {ReactodiaSteps} from '../../steps/reactodia-steps.js';
 import {LanguageSelectorSteps} from '../../steps/language-selector-steps.js';
 import {RepositorySelectorSteps} from '../../steps/repository-selector-steps.js';
 import {MainMenuSteps} from '../../steps/main-menu-steps.js';
+import {YasqeSteps} from '../../steps/yasgui/yasqe-steps.js';
+import {ToasterSteps} from '../../steps/toaster-steps.js';
 
 const FILE_TO_IMPORT = 'resource-test-data.ttl';
 const SEED_RESOURCE_ENCODED = 'http:%2F%2Fexample.com%2Fontology%23CustomerLoyalty';
@@ -86,6 +88,12 @@ describe('Reactodia graph explorer', () => {
         MainMenuSteps.clickOnSparqlMenu();
         ReactodiaSteps.getComponent().should('not.exist');
 
+        // Wait for the SPARQL Query & Update view to be loaded before continuing.
+        // Without this wait, Cypress may try to click the Reactodia menu item before the page is fully loaded,
+        // causing the test to fail intermittently with the error:
+        // "This element `<li.sub-menu-item>` is not visible because it has CSS property: `display: none`"
+        // when trying to click the Reactodia submenu.
+        YasqeSteps.getEditor().should('be.visible');
         // And I return to the reactodia view via the navigation bar.
         MainMenuSteps.clickOnReactodia();
 
@@ -94,6 +102,119 @@ describe('Reactodia graph explorer', () => {
         ReactodiaSteps.getElements().should('not.exist');
     });
 
+    // These run against the in-code REST stub. TODO: GDB-15242 switch to intercepts when the endpoints are available.
+    describe('Settings', () => {
+        it('should open the settings popover', () => {
+            // Given I open the reactodia view.
+            ReactodiaSteps.visit();
+
+            // When I click the Settings button.
+            ReactodiaSteps.openSettings();
+
+            // Then I expect the settings popover to be open.
+            ReactodiaSteps.getSettingsPopover().should('be.visible');
+            ReactodiaSteps.getBrowseButton().should('contain', 'Browse');
+        });
+
+        it('should not offer reset when the default settings are in use', () => {
+            // Given I open the settings of a repository without uploaded settings.
+            ReactodiaSteps.visit();
+            ReactodiaSteps.openSettings();
+
+            // Then I expect no reset action, because there is nothing to reset to.
+            ReactodiaSteps.getSettingsPopover().should('be.visible');
+            ReactodiaSteps.getResetButton().should('not.exist');
+        });
+
+        it('should cancel a selected file', () => {
+            // Given I have selected a settings file.
+            ReactodiaSteps.visit();
+            ReactodiaSteps.openSettings();
+            ReactodiaSteps.selectSettingsFile();
+            ReactodiaSteps.getSelectedSettingsFile().should('exist');
+
+            // When I cancel it.
+            ReactodiaSteps.clickCancelFile();
+
+            // Then I expect the file to be removed.
+            ReactodiaSteps.getSettingsPopover().should('not.contain', 'settings.ttl');
+            ReactodiaSteps.getUploadButton().should('be.disabled');
+        });
+
+        it('should ask for confirmation before uploading', () => {
+            // Given I have selected a settings file.
+            ReactodiaSteps.visit();
+            ReactodiaSteps.openSettings();
+            ReactodiaSteps.selectSettingsFile();
+
+            // When I upload it.
+            ReactodiaSteps.clickUpload();
+
+            // Then I expect a confirmation that warns the diagram may behave unexpectedly.
+            ReactodiaSteps.getConfirmDialog().should('be.visible')
+                .and('contain', 'The diagram might behave unexpectedly with the new settings.');
+
+            // When I cancel.
+            ReactodiaSteps.cancelDialog();
+
+            // Then I expect the popover to stay open with the file still selected.
+            ReactodiaSteps.getSettingsPopover().should('be.visible');
+            ReactodiaSteps.getSelectedSettingsFile().should('exist');
+
+            // When I upload and confirm.
+            ReactodiaSteps.clickUpload();
+            ReactodiaSteps.confirmDialog();
+
+            // Then I expect a success message and the diagram to be rendered.
+            ToasterSteps.verifySuccess('The settings were uploaded');
+            ReactodiaSteps.getWorkspace().should('exist');
+        });
+
+        it('should ask for confirmation before resetting', () => {
+            // Given the repository has uploaded settings.
+            ReactodiaSteps.visit();
+            ReactodiaSteps.openSettings();
+            ReactodiaSteps.selectSettingsFile();
+            ReactodiaSteps.clickUpload();
+            ReactodiaSteps.confirmDialog();
+            ToasterSteps.verifySuccess('The settings were uploaded');
+
+            // When I click outside the settings.
+            ReactodiaSteps.closeSettings();
+
+            // Then I expect the popover to close.
+            ReactodiaSteps.getSettingsPopover().should('not.exist');
+
+            // When I reset them.
+            ReactodiaSteps.openSettings();
+            ReactodiaSteps.getResetButton().should('be.visible');
+            ReactodiaSteps.clickReset();
+
+            // Then I expect a confirmation that warns the diagram may behave unexpectedly.
+            ReactodiaSteps.getConfirmDialog().should('be.visible')
+                .and('contain', 'The diagram might behave unexpectedly with the default settings.');
+
+            // When I confirm.
+            ReactodiaSteps.confirmDialog();
+
+            // Then I expect a success message and the diagram to be rendered.
+            ToasterSteps.verifySuccess('The settings were reset to the defaults');
+            ReactodiaSteps.getWorkspace().should('exist');
+        });
+
+        it('should export the current settings as a .ttl file', () => {
+            // Given I open the settings.
+            ReactodiaSteps.visit();
+            ReactodiaSteps.openSettings();
+
+            // When I export them.
+            ReactodiaSteps.clickExport();
+
+            // Then I expect a .ttl file named after the repository to be downloaded.
+            ReactodiaSteps.verifyFileDownloaded(`graph-navigator-settings-${repositoryId}.ttl`);
+        });
+    });
+
     describe('Repository switch', () => {
         let secondRepositoryId;
 

package/e2e-legacy/setup/settings/my-settings.spec.js

@@ -3,6 +3,7 @@ import {YasqeSteps} from '../../../steps/yasgui/yasqe-steps';
 import {SecurityStubs} from '../../../stubs/security-stubs';
 import {VisualGraphSteps} from '../../../steps/visual-graph-steps';
 import {ToasterSteps} from '../../../steps/toaster-steps';
+import {SettingsSteps} from '../../../steps/setup/settings-steps';
 
 describe('My Settings', () => {
 
@@ -32,16 +33,12 @@ describe('My Settings', () => {
         //turn off inference, sameAs and count total results
         clickLabelBtn('#sameas-on')
             .then(() => {
-                cy.get('#sameas-on')
-                    .find('.switch:checkbox')
-                    .should('not.be.visible');
+                SettingsSteps.getSameAsToggle().should('not.be.checked');
             });
 
         clickLabelBtn('#inference-on')
             .then(() => {
-                cy.get('#inference-on')
-                    .find('.switch:checkbox')
-                    .should('not.be.visible');
+                SettingsSteps.getInferenceToggle().should('not.be.checked');
             });
 
         cy.get('#defaultCount:checkbox').uncheck();
@@ -95,9 +92,7 @@ describe('My Settings', () => {
         visitSettingsView();
 
         clickLabelBtn('#schema-on').then(() => {
-            cy.get('#schema-on')
-                .find('.switch:checkbox')
-                .should('not.be.visible');
+            SettingsSteps.getSchemaToggle().should('not.be.checked');
         });
 
         getSaveButton()
@@ -152,14 +147,29 @@ describe('My Settings', () => {
     it('sameAs button should be disabled if inference is turned off', () => {
         clickLabelBtn('#inference-on')
             .then(() => {
-                cy.get('#inference-on')
-                    .find('.switch:checkbox')
-                    .should('not.be.visible');
+                SettingsSteps.getInferenceToggle().should('not.be.checked');
             });
 
-        cy.get('#sameas-on')
-            .find('.switch:checkbox')
-            .should('not.be.visible');
+        SettingsSteps.getSameAsToggle()
+            .should('be.disabled')
+            .and('not.be.checked');
+    });
+
+    it('should give the settings form controls accessible names', () => {
+        SettingsSteps.getUsernameLabel().should('contain', 'Username');
+
+        SettingsSteps.getSameAsToggleLabel().should('contain', 'Expand results over owl:SameAs');
+        SettingsSteps.getInferenceToggleLabel().should('contain', 'Enable inference');
+        SettingsSteps.getSchemaToggleLabel().should('contain', 'Show schema');
+
+        SettingsSteps.getAnyRepositoryReadCheckbox()
+            .should('have.attr', 'aria-label', 'Read access to Global (any data repository)');
+        SettingsSteps.getAnyRepositoryWriteCheckbox()
+            .should('have.attr', 'aria-label', 'Write access to Global (any data repository)');
+        SettingsSteps.getAnyRepositoryMaintainCheckbox()
+            .should('have.attr', 'aria-label', 'Maintain access to Global (any data repository)');
+        SettingsSteps.getAnyRepositoryGraphqlCheckbox()
+            .should('have.attr', 'aria-label', 'Restrict Global (any data repository) to GraphQL');
     });
 
     function getSaveButton() {