graphdb-workbench-tests 4.0.0-TR11 → 4.0.0-TR12

package/e2e-legacy/monitor/global-operation-statuses-component.spec.js

@@ -63,7 +63,7 @@ describe('Operations Status Component', () => {
 
     });
 
-    it('should redirect to query and update view wen click on queries operation element', () => {
+    it('should link the queries operation element to its view in a new window', () => {
         // When I visit some page and there are running operations.
         GlobalOperationsStatusesStub.stubGlobalOperationsStatusesResponse(repositoryId);
         HomeSteps.visitAndWaitLoader();
@@ -71,14 +71,13 @@ describe('Operations Status Component', () => {
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
         OperationsStatusesComponentSteps.openOperationStatusesDialog();
-        // When I click on "Running query" operation element.
-        // Then I expect to be redirected to "Query and Update monitoring" view.
+        // Then I expect "Running query" operation element to link to "Query and Update monitoring" view in a new window.
         checkOperationElementUrl('monitor/queries', 3);
         // Then I expect "Global Operations Component" to still be displayed.
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
     });
 
-    it('should redirect to query and update view wen click on updates operation element', () => {
+    it('should link the updates operation element to its view in a new window', () => {
         // When I visit some page and there are running operations.
         GlobalOperationsStatusesStub.stubGlobalOperationsStatusesResponse(repositoryId);
         HomeSteps.visitAndWaitLoader();
@@ -86,14 +85,13 @@ describe('Operations Status Component', () => {
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
         OperationsStatusesComponentSteps.openOperationStatusesDialog();
-        // When I click on "Running updates" operation element.
-        // Then I expect to be redirected to "Query and Update monitoring" view.
+        // Then I expect "Running updates" operation element to link to "Query and Update monitoring" view in a new window.
         checkOperationElementUrl('monitor/queries', 4);
         // Then I expect "Global Operations Component" to still be displayed.
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
     });
 
-    it('should redirect to query and update view wen click on imports operation element', () => {
+    it('should link the imports operation element to its view in a new window', () => {
         // When I visit some page and there are running operations.
         GlobalOperationsStatusesStub.stubGlobalOperationsStatusesResponse(repositoryId);
         HomeSteps.visitAndWaitLoader();
@@ -101,14 +99,13 @@ describe('Operations Status Component', () => {
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
         OperationsStatusesComponentSteps.openOperationStatusesDialog();
-        // When I click on "Running imports" operation element.
-        // Then I expect to be redirected to "Query and Update monitoring" view.
+        // Then I expect "Running imports" operation element to link to "Import" view in a new window.
         checkOperationElementUrl('import', 2);
         // Then I expect "Global Operations Component" to still be displayed.
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
     });
 
-    it('should redirect to query and update view wen click on backup and restore operation element', () => {
+    it('should link the backup and restore operation element to its view in a new window', () => {
         // When I visit some page and there are running operations.
         GlobalOperationsStatusesStub.stubGlobalOperationsStatusesResponse(repositoryId);
         HomeSteps.visitAndWaitLoader();
@@ -116,15 +113,14 @@ describe('Operations Status Component', () => {
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
         OperationsStatusesComponentSteps.openOperationStatusesDialog();
-        // When I click on "Creating backup" operation element.
-        // Then I expect to be redirected to "Backup and Restore" view.
+        // Then I expect "Creating backup" operation element to link to "Backup and Restore" view in a new window.
         checkOperationElementUrl('monitor/backup-and-restore', 1);
         // Then I expect "Global Operations Component" to still be displayed.
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
     });
 
-    it('should redirect to query and update view wen click on cluster operation element', () => {
+    it('should link the cluster operation element to its view in a new window', () => {
         // When I visit some page and there are running operations.
         GlobalOperationsStatusesStub.stubGlobalOperationsStatusesResponse(repositoryId);
         HomeSteps.visitAndWaitLoader();
@@ -132,8 +128,7 @@ describe('Operations Status Component', () => {
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
 
         OperationsStatusesComponentSteps.openOperationStatusesDialog();
-        // When I click on "Unavailable nodes" operation element.
-        // Then I expect to be redirected to "Cluster Monitoring" view.
+        // Then I expect "Unavailable nodes" operation element to link to "Cluster Monitoring" view in a new window.
         checkOperationElementUrl('cluster', 0);
         // Then I expect "Global Operations Component" to still be displayed.
         OperationsStatusesComponentSteps.getOperationsStatusesComponent().should('exist');
@@ -141,8 +136,9 @@ describe('Operations Status Component', () => {
     });
 
     function checkOperationElementUrl(expectedUrl, operationIndex = 0) {
-        BrowserStubs.spyNavigateToUrl();
+        BrowserStubs.captureLinkClicks();
         OperationsStatusesComponentSteps.getOperationStatuses().eq(operationIndex).click();
-        cy.get(BrowserStubs.NAVIGATE_TO_URL_ALIAS()).should('have.been.calledWithMatch', expectedUrl)
+        // The page must leave the click to the browser, which opens the link in a new window.
+        cy.get(BrowserStubs.LINK_CLICKS_ALIAS()).should('deep.equal', [{href: expectedUrl, target: '_blank', defaultPrevented: false}]);
     }
 });

package/e2e-legacy/repository/repository-picker-tooltip.spec.js

@@ -0,0 +1,72 @@
+import {GraphNavigatorSteps} from '../../steps/graph-navigator-steps.js';
+import {RepositoryPickerListSteps} from '../../steps/repository-picker-list-steps.js';
+import {RepositoriesStubs} from '../../stubs/repositories/repositories-stubs.js';
+
+describe('Repository picker repository information', () => {
+    let runningRepositoryId;
+    let notRunningRepositoryId;
+
+    beforeEach(() => {
+        runningRepositoryId = 'picker-tooltip-running-' + Date.now();
+        notRunningRepositoryId = 'picker-tooltip-not-running-' + Date.now();
+        cy.createRepository({id: runningRepositoryId});
+        cy.createRepository({id: notRunningRepositoryId});
+        // A new repository is not running. Requesting its size starts it.
+        cy.initializeRepository(runningRepositoryId);
+        RepositoriesStubs.spyGetRepositorySize(runningRepositoryId, 'runningRepositorySize');
+        RepositoriesStubs.spyGetRepositorySizeCalls(notRunningRepositoryId, 'notRunningRepositorySize');
+        // No repository is selected, so the view shows the repository picker with both repositories.
+        GraphNavigatorSteps.visit();
+    });
+
+    afterEach(() => {
+        cy.deleteRepository(runningRepositoryId);
+        cy.deleteRepository(notRunningRepositoryId);
+    });
+
+    it('should show the repository id and the statement counts of a running repository', () => {
+        // When I move the keyboard focus to a running repository in the picker
+        RepositoryPickerListSteps.focusRepository(runningRepositoryId);
+
+        // Then I expect the repository information to show the repository id
+        RepositoryPickerListSteps.getRepositoryInfoPart('title').should('have.text', runningRepositoryId);
+        // And the statement counts, loaded from the server
+        cy.wait('@runningRepositorySize');
+        RepositoryPickerListSteps.getRepositoryInfoPart('total').should('contain.text', 'Total statements');
+        RepositoryPickerListSteps.getRepositoryInfoPart('explicit').should('be.visible');
+        RepositoryPickerListSteps.getRepositoryInfoPart('inferred').should('be.visible');
+        RepositoryPickerListSteps.getRepositoryInfoPart('expansion-ratio').should('be.visible');
+        RepositoryPickerListSteps.getRepositoryInfoPart('inactive').should('not.exist');
+    });
+
+    it('should show that the statement counts are not available when the size request fails', () => {
+        // Given the server fails to return the size of the running repository
+        RepositoriesStubs.stubGetRepositorySizeError(runningRepositoryId, 'runningRepositorySizeError');
+
+        // When I move the keyboard focus to the running repository in the picker
+        RepositoryPickerListSteps.focusRepository(runningRepositoryId);
+
+        // Then I expect the repository information to show the repository id
+        RepositoryPickerListSteps.getRepositoryInfoPart('title').should('have.text', runningRepositoryId);
+        // And, after the request has failed, that the statement counts are not available
+        cy.wait('@runningRepositorySizeError');
+        RepositoryPickerListSteps.getRepositoryInfoPart('not-available')
+            .should('contain.text', 'Size info not available.');
+        // And neither the spinner nor the statement counts
+        RepositoryPickerListSteps.getRepositoryInfoPart('loading').should('not.exist');
+        RepositoryPickerListSteps.getRepositoryInfoPart('total').should('not.exist');
+    });
+
+    it('should show the activation message and not request the size of a repository that is not running', () => {
+        // When I move the keyboard focus to a repository that is not running in the picker
+        RepositoryPickerListSteps.focusRepository(notRunningRepositoryId);
+
+        // Then I expect the repository information to show the repository id and the activation message
+        RepositoryPickerListSteps.getRepositoryInfoPart('title').should('have.text', notRunningRepositoryId);
+        RepositoryPickerListSteps.getRepositoryInfoPart('inactive')
+            .should('contain.text', 'Activate the repository to view statement information');
+        RepositoryPickerListSteps.getRepositoryInfoPart('total').should('not.exist');
+        // And the size of the repository is not requested, because that would start the repository
+        cy.get('@notRunningRepositorySize').should('not.have.been.called');
+    });
+});

package/e2e-legacy/repository/repository-selector-tooltip.spec.js

@@ -0,0 +1,55 @@
+import HomeSteps from '../../steps/home-steps.js';
+import {RepositorySelectorSteps} from '../../steps/repository-selector-steps.js';
+import {RepositoriesStubs} from '../../stubs/repositories/repositories-stubs.js';
+
+describe('Repository selector tooltip', () => {
+    let runningRepositoryId;
+    let notRunningRepositoryId;
+
+    beforeEach(() => {
+        runningRepositoryId = 'selector-tooltip-running-' + Date.now();
+        notRunningRepositoryId = 'selector-tooltip-not-running-' + Date.now();
+        cy.createRepository({id: runningRepositoryId});
+        cy.createRepository({id: notRunningRepositoryId});
+        // A new repository is not running. Requesting its size starts it.
+        cy.initializeRepository(runningRepositoryId);
+        RepositoriesStubs.spyGetRepositorySize(runningRepositoryId, 'runningRepositorySize');
+        RepositoriesStubs.spyGetRepositorySizeCalls(notRunningRepositoryId, 'notRunningRepositorySize');
+        // No repository is selected, so both repositories are in the menu of the selector.
+        HomeSteps.visit();
+        RepositorySelectorSteps.openRepositorySelectors();
+    });
+
+    afterEach(() => {
+        cy.deleteRepository(runningRepositoryId);
+        cy.deleteRepository(notRunningRepositoryId);
+    });
+
+    it('should show the repository id and the statement counts of a running repository', () => {
+        // When I hover a running repository in the selector
+        RepositorySelectorSteps.hoverRepositoryItem(runningRepositoryId);
+
+        // Then I expect the tooltip to show the repository id
+        RepositorySelectorSteps.getRepositoryTooltipPart('title').should('have.text', runningRepositoryId);
+        // And the statement counts, loaded from the server
+        cy.wait('@runningRepositorySize');
+        RepositorySelectorSteps.getRepositoryTooltipPart('total').should('contain.text', 'Total statements');
+        RepositorySelectorSteps.getRepositoryTooltipPart('explicit').should('be.visible');
+        RepositorySelectorSteps.getRepositoryTooltipPart('inferred').should('be.visible');
+        RepositorySelectorSteps.getRepositoryTooltipPart('expansion-ratio').should('be.visible');
+        RepositorySelectorSteps.getRepositoryTooltipPart('inactive').should('not.exist');
+    });
+
+    it('should show the activation message and not request the size of a repository that is not running', () => {
+        // When I hover a repository that is not running in the selector
+        RepositorySelectorSteps.hoverRepositoryItem(notRunningRepositoryId);
+
+        // Then I expect the tooltip to show the repository id and the activation message
+        RepositorySelectorSteps.getRepositoryTooltipPart('title').should('have.text', notRunningRepositoryId);
+        RepositorySelectorSteps.getRepositoryTooltipPart('inactive')
+            .should('contain.text', 'Activate the repository to view statement information');
+        RepositorySelectorSteps.getRepositoryTooltipPart('total').should('not.exist');
+        // And the size of the repository is not requested, because that would start the repository
+        cy.get('@notRunningRepositorySize').should('not.have.been.called');
+    });
+});

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "4.0.0-TR11",
+  "version": "4.0.0-TR12",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "graphdb-workbench-tests",
-      "version": "4.0.0-TR11",
+      "version": "4.0.0-TR12",
       "license": "Apache-2.0",
       "devDependencies": {
         "@bahmutov/cypress-code-coverage": "^2.7.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "4.0.0-TR11",
+  "version": "4.0.0-TR12",
   "description": "Cypress tests for GraphDB workbench",
   "type": "module",
   "scripts": {

package/steps/cookie-policy/cookie-consent-banner-steps.js

@@ -4,7 +4,7 @@ export class CookieConsentBannerSteps {
     }
 
     static getCookieConsentButton() {
-        return this.getCookieConsentBanner().find('button');
+        return this.getCookieConsentBanner().find('#accept-cookie-policy');
     }
 
     static giveCookieConsent() {
@@ -12,7 +12,7 @@ export class CookieConsentBannerSteps {
     }
 
     static getCookiePolicyLink() {
-        return cy.get('.cookie-consent-content a');
+        return cy.get('#cookie-policy-link');
     }
 
     static clickCookiePolicyLink() {

package/steps/repository-picker-list-steps.js

@@ -24,6 +24,22 @@ export class RepositoryPickerListSteps extends BaseSteps {
         return this.getRepositoryRow(repositoryId).find(this.buildTestIdAttr('repository-picker-repository-location'));
     }
 
+    static getSelectRepositoryButton(repositoryId) {
+        return this.getRepositoryRow(repositoryId).find(this.buildTestIdAttr('repository-picker-select-btn'));
+    }
+
+    static focusRepository(repositoryId) {
+        this.getSelectRepositoryButton(repositoryId).focus();
+    }
+
+    static getRepositoryInfo() {
+        return cy.get('.repository-info-popover-content onto-repository-info');
+    }
+
+    static getRepositoryInfoPart(name) {
+        return this.getRepositoryInfo().find(this.buildTestIdAttr(`repository-info-${name}`));
+    }
+
     static selectRepository(repositoryId) {
         this.getRepositoryRow(repositoryId).click();
     }

package/steps/repository-selector-steps.js

@@ -23,4 +23,20 @@ export class RepositorySelectorSteps {
     static getSelectedRepository() {
         return RepositorySelectorSteps.getRepositorySelectorDropdown().find('.active-repository');
     }
+
+    static getRepositoryItem(repositoryId) {
+        return RepositorySelectorSteps.getRepositorySelectorButton(repositoryId).closest('.onto-dropdown-menu-item');
+    }
+
+    static hoverRepositoryItem(repositoryId) {
+        RepositorySelectorSteps.getRepositoryItem(repositoryId).realHover();
+    }
+
+    static getRepositoryTooltip() {
+        return cy.get('.onto-tooltip-box onto-repository-info');
+    }
+
+    static getRepositoryTooltipPart(name) {
+        return RepositorySelectorSteps.getRepositoryTooltip().find(`[data-test="repository-info-${name}"]`);
+    }
 }

package/stubs/browser-stubs.js

@@ -7,6 +7,10 @@ export class BrowserStubs {
         return isDefinition ? 'navigateToUrl' : '@navigateToUrl';
     }
 
+    static LINK_CLICKS_ALIAS = (isDefinition = false) => {
+        return isDefinition ? 'linkClicks' : '@linkClicks';
+    }
+
     static stubWindowOpen() {
         cy.window().then((win) => {
             cy.stub(win, 'open').as(BrowserStubs.WINDOW_OPEN_ALIAS(true))
@@ -18,4 +22,40 @@ export class BrowserStubs {
             cy.spy(win.singleSpa, 'navigateToUrl').as(BrowserStubs.NAVIGATE_TO_URL_ALIAS(true))
         })
     }
+
+    /**
+     * Checks what the browser would do with a clicked link, without following it.
+     *
+     * Use it for plain links (`<a href target="_blank">`) that the browser opens by itself. Such links do not call
+     * `window.open`, so {@link stubWindowOpen} cannot see them, and Cypress cannot follow a new window.
+     *
+     * For every clicked link it records:
+     * - `href`: the link address;
+     * - `target`: the link target, `_blank` for a new window;
+     * - `defaultPrevented`: `true` when the page handled the click itself, for example to navigate in the same window.
+     *   The browser opens the link only when this is `false`.
+     *
+     * Then it stops the click, so the test stays on the same page.
+     *
+     * @example
+     * BrowserStubs.captureLinkClicks();
+     * cy.get('a.my-link').click();
+     * // The browser would open "cluster" in a new window.
+     * cy.get(BrowserStubs.LINK_CLICKS_ALIAS())
+     *     .should('deep.equal', [{href: 'cluster', target: '_blank', defaultPrevented: false}]);
+     */
+    static captureLinkClicks() {
+        cy.window().then((win) => {
+            const clicks = [];
+            win.document.addEventListener('click', (event) => {
+                const link = event.target.closest('a');
+                if (!link) {
+                    return;
+                }
+                clicks.push({href: link.getAttribute('href'), target: link.target, defaultPrevented: event.defaultPrevented});
+                event.preventDefault();
+            });
+            cy.wrap(clicks).as(BrowserStubs.LINK_CLICKS_ALIAS(true));
+        });
+    }
 }

package/stubs/repositories/repositories-stubs.js

@@ -3,6 +3,14 @@ import {REPOSITORIES_URL} from '../../support/repository-commands';
 import {GlobalOperationsStatusesStub} from '../global-operations-statuses-stub.js';
 import repoTemplate from "../../fixtures/repo-template.json";
 
+/**
+ * Returns the pattern that matches the request for the size of a repository, on any host and with any query.
+ *
+ * @param {string} repositoryId The id of the repository.
+ * @return {string} The pattern.
+ */
+const getRepositorySizeUrl = (repositoryId) => `**${REPOSITORIES_URL}/${repositoryId}/size*`;
+
 export class RepositoriesStubs extends Stubs {
     static stubRepositories(withDelay = 0, fixture = '/repositories/get-repositories.json') {
         RepositoriesStubs.stubGetQueryResponse('/rest/repositories/all', fixture, 'get-all-repositories', withDelay);
@@ -24,6 +32,38 @@ export class RepositoriesStubs extends Stubs {
         cy.intercept(`GET`, `${REPOSITORIES_URL}/${id}?location=`).as('getRepository');
     }
 
+    /**
+     * Spies on the request for the size of a repository, without changing its response.
+     *
+     * @param {string} repositoryId The id of the repository.
+     * @param {string} alias The alias of the request, to wait for it with <code>cy.wait('@alias')</code>.
+     */
+    static spyGetRepositorySize(repositoryId, alias = 'getRepositorySize') {
+        cy.intercept('GET', getRepositorySizeUrl(repositoryId)).as(alias);
+    }
+
+    /**
+     * Records the requests for the size of a repository in a spy, without changing their response. Use it to check
+     * that the size was not requested: <code>cy.get('@alias').should('not.have.been.called')</code>.
+     *
+     * @param {string} repositoryId The id of the repository.
+     * @param {string} alias The alias of the spy.
+     */
+    static spyGetRepositorySizeCalls(repositoryId, alias = 'getRepositorySizeCalls') {
+        cy.intercept('GET', getRepositorySizeUrl(repositoryId), cy.spy().as(alias));
+    }
+
+    /**
+     * Makes the request for the size of a repository fail with a server error.
+     *
+     * @param {string} repositoryId The id of the repository.
+     * @param {string} alias The alias of the request, to wait for it with <code>cy.wait('@alias')</code>.
+     */
+    static stubGetRepositorySizeError(repositoryId, alias = 'getRepositorySizeError') {
+        cy.intercept('GET', getRepositorySizeUrl(repositoryId),
+            {statusCode: 500, body: 'Internal Server Error'}).as(alias);
+    }
+
     static stubLocations(withDelay = 0) {
         RepositoriesStubs.stubQueryResponse('/rest/locations', '/repositories/get-locations.json', 'get-locations', withDelay);
     }