graphdb-workbench-tests 4.0.0-TR1 → 4.0.0-TR2

package/e2e-legacy/repository/rename-repository-restrictions.spec.js

@@ -0,0 +1,125 @@
+import {RepositorySteps} from "../../steps/repository-steps";
+import {OntopRepositorySteps} from "../../steps/ontop-repository-steps";
+import {ToasterSteps} from "../../steps/toaster-steps";
+import {ModalDialogSteps} from "../../steps/modal-dialog-steps";
+
+describe('Repository rename restrictions', () => {
+
+    let repositoryId;
+    let memberRepositoryId;
+
+    beforeEach(() => {
+        repositoryId = 'repo-' + Date.now();
+        memberRepositoryId = 'member-' + Date.now();
+    });
+
+    afterEach(() => {
+        cy.deleteRepository(repositoryId);
+        cy.deleteRepository(memberRepositoryId);
+    });
+
+    it('should allow renaming of a GraphDB repository', () => {
+        // Given there is a GraphDB repository.
+        cy.createRepository({id: repositoryId});
+
+        // When I open its edit page.
+        RepositorySteps.visitEditPage(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should be available.
+        RepositorySteps.getRepositoryIdEditElement().should('be.visible');
+    });
+
+    it('should not allow renaming of an Ontop repository', () => {
+        // Given there is an Ontop repository.
+        createOntopRepository(repositoryId);
+
+        // When I open its edit page.
+        RepositorySteps.visit();
+        RepositorySteps.editRepository(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should not be available, because
+        // renaming is allowed only for GraphDB repositories.
+        RepositorySteps.getRepositoryIdEditElement().should('not.exist');
+
+        // When the repository id is changed despite the field being disabled,
+        forceChangeRepositoryId('renamed-' + repositoryId);
+        // and I try to save the configuration.
+        RepositorySteps.clickSaveEditedRepo();
+
+        // Then I expect to see an error message,
+        ToasterSteps.verifyError('Can not change the name of ontop repository');
+        // and the repository should keep its original id.
+        RepositorySteps.visit();
+        RepositorySteps.getRepositoryFromList(repositoryId).should('be.visible');
+    });
+
+    it('should not allow renaming of a FedX repository', () => {
+        // Given there is a FedX repository.
+        cy.createRepository({id: memberRepositoryId});
+        createFedxRepository(repositoryId, memberRepositoryId);
+
+        // When I open its edit page.
+        RepositorySteps.visit();
+        RepositorySteps.editRepository(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should not be available, because
+        // renaming is allowed only for GraphDB repositories.
+        RepositorySteps.getRepositoryIdEditElement().should('not.exist');
+
+        // When I save the configuration.
+        RepositorySteps.getSaveRepositoryButton().click();
+        ModalDialogSteps.clickOnConfirmButton();
+
+        // Then the repository should keep its original id.
+        RepositorySteps.visit();
+        RepositorySteps.getRepositoryFromList(repositoryId).should('be.visible');
+    });
+
+    /**
+     * Changes the repository id field although it is disabled in order to verify that the restriction is
+     * enforced by the controller too and not only by the view.
+     *
+     * @param {string} newRepositoryId The new repository id.
+     */
+    const forceChangeRepositoryId = (newRepositoryId) => {
+        RepositorySteps.getGDBIdInput()
+            .clear({force: true})
+            .type(newRepositoryId, {force: true})
+            .should('have.value', newRepositoryId);
+    };
+
+    const createOntopRepository = (repositoryId) => {
+        OntopRepositorySteps.visitCreate();
+        RepositorySteps.typeRepositoryId(repositoryId);
+        OntopRepositorySteps.selectOracleDatabase();
+        OntopRepositorySteps.typeHostName('localhost');
+        OntopRepositorySteps.typePort(5423);
+        OntopRepositorySteps.typeDatabaseName('database-name');
+        OntopRepositorySteps.clickObdaFileUploadButton();
+        OntopRepositorySteps.uploadObdaFile('fixtures/ontop/university-complete.obda');
+        // Wait the OBDA edit button to become visible to ensure that the file is uploaded.
+        OntopRepositorySteps.getOBDAFileFieldEditButton().should('be.visible');
+        OntopRepositorySteps.clickOnCreateRepositoryButton();
+    };
+
+    const createFedxRepository = (repositoryId, memberRepositoryId) => {
+        RepositorySteps.visit();
+        RepositorySteps.createRepository();
+        RepositorySteps.createFedexRepositoryType();
+        RepositorySteps.typeRepositoryId(repositoryId);
+        RepositorySteps.selectFedexMember(memberRepositoryId);
+        RepositorySteps.saveRepository();
+    };
+});

package/e2e-legacy/setup/settings/my-settings-initial-state.spec.js

@@ -2,7 +2,7 @@ import {MainMenuSteps} from "../../../steps/main-menu-steps";
 import HomeSteps from "../../../steps/home-steps";
 import {SettingsSteps} from "../../../steps/setup/settings-steps";
 
-function verifyInitialState(repositoryId) {
+function verifyInitialState() {
   // Password change field is for admin.
   // explicitly state that the fields must be of type password
   SettingsSteps.getPasswordField().should('be.visible')
@@ -43,14 +43,8 @@ function verifyInitialState(repositoryId) {
   // Repository rights
   // - Admin has read and write access to all repositories."
   SettingsSteps.getUserRepositoryTable().should('be.visible');
-  SettingsSteps.getReadRightsCheckbox(repositoryId)
-    .should('be.visible')
-    .and('be.checked')
-    .and('be.disabled');
-  SettingsSteps.getWriteRightsCheckbox(repositoryId)
-    .should('be.visible')
-    .and('be.checked')
-    .and('be.disabled');
+  // And Admin doesn't see the list of the repositories
+  SettingsSteps.getRepositoryRightsRows().should('not.exist');
 }
 
 describe('My Settings initial state', () => {
@@ -69,7 +63,7 @@ describe('My Settings initial state', () => {
     // Given, I visit the My Settings page via URL
     SettingsSteps.visit();
     // Then,
-    verifyInitialState(repositoryId);
+    verifyInitialState();
   });
 
   it('Should display the correct initial state when navigating via the navigation bar', () => {
@@ -77,6 +71,6 @@ describe('My Settings initial state', () => {
     HomeSteps.visit();
     MainMenuSteps.clickOnMySettings();
     // Then,
-    verifyInitialState(repositoryId);
+    verifyInitialState();
   });
 });

package/e2e-legacy/setup/users-and-access/user-and-access.spec.js

@@ -318,6 +318,8 @@ describe('User and Access', () => {
             verifyDisabledUserAuth('*', {read: false, write: false, maintain: true, graphql: true});
             verifyCheckedUserAuth(repoName, {read: false, write: false, maintain: false, graphql: false});
             verifyDisabledUserAuth(repoName, {read: false, write: false, maintain: false, graphql: true});
+            // The GraphQL checkbox is disabled for the lack of read/write rights, not because of the role
+            UserAndAccessSteps.getGraphqlAnyRoleTooltip().should('not.exist');
         });
 
         context('for non user roles', () => {
@@ -327,8 +329,7 @@ describe('User and Access', () => {
                 verifyCheckedUserAuth('*', {read: true, write: true, maintain: true, graphql: false});
                 verifyDisabledUserAuth('*', {read: true, write: true, maintain: true, graphql: true});
 
-                verifyCheckedUserAuth(repoName, {read: true, write: true, maintain: true, graphql: false});
-                verifyDisabledUserAuth(repoName, {read: true, write: true, maintain: true, graphql: true});
+                UserAndAccessSteps.getRepositoryRightsRows().should('not.exist');
             });
 
             it('repository manager', () => {
@@ -338,8 +339,7 @@ describe('User and Access', () => {
                 verifyCheckedUserAuth('*', {read: true, write: true, maintain: true, graphql: false});
                 verifyDisabledUserAuth('*', {read: true, write: true, maintain: true, graphql: true});
 
-                verifyCheckedUserAuth(repoName, {read: true, write: true, maintain: true, graphql: false});
-                verifyDisabledUserAuth(repoName, {read: true, write: true, maintain: true, graphql: true});
+                UserAndAccessSteps.getRepositoryRightsRows().should('not.exist');
             });
         });
 
@@ -464,6 +464,27 @@ describe('User and Access', () => {
                 createUser(graphqlUser, PASSWORD, ROLE_USER, {read: true, graphql: true, repoName: repositoryId2});
             });
 
+            it('Should not allow GraphQL access for Ontop and FedX repositories', () => {
+                // GIVEN Ontop and FedX repositories alongside a GraphDB one
+                RepositoriesStubs.stubRepositories(0, '/repositories/get-repositories-with-unsupported-graphql-types.json');
+                UserAndAccessSteps.visit();
+                UserAndAccessSteps.clickCreateNewUserButton();
+                // WHEN the user is granted read access to all of them
+                UserAndAccessSteps.toggleReadAccessAny();
+
+                // THEN GraphQL should be available only for the GraphDB repository
+                UserAndAccessSteps.validateGraphqlAccessForRepo('graphdb-repo', {disabled: false});
+                UserAndAccessSteps.getGraphqlRepositoryTypeTooltipForRepo('graphdb-repo').should('not.exist');
+
+                // AND it should be permanently disabled for the Ontop and the FedX ones
+                ['ontop-repo', 'fedx-repo'].forEach((repository) => {
+                    UserAndAccessSteps.validateGraphqlAccessForRepo(repository, {checked: false, disabled: true});
+                    UserAndAccessSteps.hoverGraphQlRightsCheckbox(repository)
+                    UserAndAccessSteps.getAngularTooltip().should('have.text', 'Not available for this repository type');
+                    UserAndAccessSteps.blurGraphQlRightsCheckbox(repository)
+                });
+            });
+
             // Fails for unknown reason only in CI
             it('Can create user with different auth combinations', () => {
                 cy.wait('@getRepositories');

package/e2e-legacy/ttyg/create-agent.spec.js

@@ -172,6 +172,60 @@ describe('TTYG create new agent', () => {
         TTYGViewSteps.getAgent(0).should('contain', 'Test Agent').and('contain', 'starwars');
     });
 
+    it('should create an agent without temperature or topP parameters', () => {
+        // GIVEN: I have opened the Create Agent dialog and filled in the minimum required fields.
+        openCreateAgentDialog(repositoryId)
+        TtygAgentSettingsModalSteps.getDialog().should('be.visible');
+
+        fillAgentName('Test Agent');
+        TtygAgentSettingsModalSteps.enableSparqlExtractionMethod();
+        TtygAgentSettingsModalSteps.selectSparqlMethodSparqlQuery();
+
+        // WHEN: I disable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+
+        // AND: I disable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+
+        // AND: I save the agent.
+        TTYGStubs.stubAgentCreate(1000);
+        TTYGStubs.stubAgentListGet(
+            '/ttyg/agent/get-agent-list-new-agent.json',
+            1000,
+        );
+
+        TtygAgentSettingsModalSteps.saveAgent();
+        TtygAgentSettingsModalSteps.getCreatingAgentLoader().should('be.visible');
+
+        // THEN: I expect the create-agent request not to contain the temperature and topP parameters.
+        cy.wait('@create-agent').then((interception) => {
+            // eslint-disable-next-line no-undef
+            assert.deepEqual(interception.request.body, {
+                id: 'id',
+                name: 'Test Agent',
+                repositoryId: 'starwars',
+                model: 'gpt-4o',
+                contextSize: 128000,
+                seed: 0,
+                assistantsInstructions: {
+                    systemInstruction: '',
+                    userInstruction: 'If you need to write a SPARQL query, use only the classes and properties provided in the schema and don\'t invent or guess any. Always try to return human-readable names or labels and not only the IRIs. If SPARQL fails to provide the necessary information you can try another tool too.',
+                },
+                assistantExtractionMethods: [
+                    {
+                        method: 'sparql_search',
+                        sparqlQuery: 'CONSTRUCT {?s ?p ?o} WHERE {GRAPH <http://example.org/ontology> {?s ?p ?o .}}',
+                        addMissingNamespaces: false,
+                    },
+                ],
+                additionalExtractionMethods: [],
+            });
+        });
+
+        // AND: I expect the modal to be closed.
+        TtygAgentSettingsModalSteps.getDialog().should('not.exist');
+    });
+
     it('Should require FTS to be enabled for selected repository when creating agent with FTS extraction method', () => {
         RepositoriesStubs.stubGetRepositoryConfig(repositoryId, '/repositories/get-repository-config-starwars-disabled-fts.json');
         TTYGStubs.stubChatsListGetNoResults();
@@ -461,6 +515,51 @@ describe('TTYG create new agent', () => {
         TtygAgentSettingsModalSteps.getTemperatureField().should('not.have.class', 'has-warning');
     });
 
+    it('should toggle the temperature setting', () => {
+        // GIVEN: I have opened the Create Agent dialog.
+        openCreateAgentDialog(repositoryId);
+
+        // WHEN: I set a high temperature value.
+        TtygAgentSettingsModalSteps.setTemperature('1.2');
+        // THEN: I expect a warning message to be displayed.
+        TtygAgentSettingsModalSteps.getTemperatureField().should('have.class', 'has-warning');
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '1.2');
+
+        // WHEN: I disable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the high-temperature warning to be hidden.
+        TtygAgentSettingsModalSteps.getTemperatureWarning().should('not.exist');
+        TtygAgentSettingsModalSteps.getTemperatureField().should('not.have.class', 'has-warning');
+        // AND: I expect the temperature controls to be disabled.
+        TtygAgentSettingsModalSteps.getTemperatureField().should('be.disabled');
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('be.disabled');
+
+        // WHEN: I enable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the default temperature value to be restored.
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '0.7');
+    });
+
+    it('should toggle the topP setting', () => {
+        // GIVEN: I have opened the Create Agent dialog.
+        openCreateAgentDialog(repositoryId);
+
+        // WHEN: I set a custom topP value.
+        TtygAgentSettingsModalSteps.setTopP('0.3');
+        // THEN: I expect the topP value to be updated.
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '0.3');
+
+        // WHEN: I disable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the topP control to be disabled.
+        TtygAgentSettingsModalSteps.getTopPField().should('be.disabled');
+
+        // WHEN: I enable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the default topP value to be restored.
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '1');
+    });
+
     it('Should warn the user when he changes the default value of the base instruction', () => {
         RepositoriesStubs.stubGetRepositoryConfig(repositoryId, '/repositories/get-repository-config-starwars-enabled-fts.json');
         TTYGStubs.stubChatsListGetNoResults();
@@ -541,3 +640,13 @@ function fillAgentName(name) {
     TtygAgentSettingsModalSteps.getAgentNameError().should('be.visible').and('contain', 'This field is required');
     TtygAgentSettingsModalSteps.typeAgentName(name);
 }
+
+const openCreateAgentDialog = (repositoryId) => {
+    TTYGStubs.stubChatsListGetNoResults();
+    TTYGStubs.stubAgentListGet('/ttyg/agent/get-agent-list-0.json');
+    ConnectorStubs.stubGetConnectors();
+    TTYGStubs.getSimilarityIndexesForRepo(repositoryId );
+    TTYGViewSteps.visit();
+    cy.wait('@get-all-repositories');
+    TTYGViewSteps.createFirstAgent();
+}

package/fixtures/repositories/get-repositories-with-unsupported-graphql-types.json

@@ -0,0 +1,46 @@
+{
+    "": [
+        {
+            "id": "graphdb-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/graphdb-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/graphdb-repo",
+            "local": true,
+            "type": "graphdb",
+            "sesameType": "graphdb:SailRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        },
+        {
+            "id": "ontop-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/ontop-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/ontop-repo",
+            "local": true,
+            "type": "ontop",
+            "sesameType": "graphdb:OntopRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        },
+        {
+            "id": "fedx-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/fedx-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/fedx-repo",
+            "local": true,
+            "type": "fedx",
+            "sesameType": "graphdb:FedXRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        }
+    ]
+}

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "4.0.0-TR1",
+  "version": "4.0.0-TR2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "graphdb-workbench-tests",
-      "version": "4.0.0-TR1",
+      "version": "4.0.0-TR2",
       "license": "Apache-2.0",
       "devDependencies": {
         "@bahmutov/cypress-code-coverage": "^2.7.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "4.0.0-TR1",
+  "version": "4.0.0-TR2",
   "description": "Cypress tests for GraphDB workbench",
   "type": "module",
   "scripts": {

package/steps/setup/settings-steps.js

@@ -94,6 +94,10 @@ export class SettingsSteps {
         return this.getSettingsPage().find('.user-repositories .table');
     }
 
+    static getRepositoryRightsRows() {
+        return this.getUserRepositoryTable().getByTestId('repository-rights-rows');
+    }
+
     static getUserRepository(name) {
         return this.getUserRepositoryTable().find(`.repository-name:contains('${name}')`).closest('tr');
     }

package/steps/setup/user-and-access-steps.js

@@ -405,11 +405,8 @@ export class UserAndAccessSteps {
     // ============= GraphQL Access Toggles and Validations =============
 
     static getGraphqlAccessForRepo(repoName) {
-        const matchText = (repoName === '*') ? 'Global (any data repository)' : repoName;
-        return cy.get('#user-repos')
-            .contains(matchText)
-            .parent('tr')
-            .find('.graphql')
+        const testId = (repoName === '*') ? 'graphql-any-checkbox' : 'graphql-repository-checkbox';
+        return this.getRepositoryRightsLine(repoName).getByTestId(testId);
     }
 
     static toggleGraphqlAccessForRepo(repoName) {
@@ -421,6 +418,30 @@ export class UserAndAccessSteps {
         this.validateRightsForRepo(repoName, graphqlAccessCheckbox, expectedState);
     }
 
+    static getRepositoryRightsRows() {
+        return cy.getByTestId('repository-rights-rows');
+    }
+
+    static getGraphqlAnyRoleTooltip() {
+        return cy.getByTestId('graphql-any-role-tooltip');
+    }
+
+    static getGraphqlRepositoryTypeTooltipForRepo(repoName) {
+        return this.getRepositoryRightsLine(repoName).getByTestId('graphql-repository-type-tooltip');
+    }
+
+    static hoverGraphQlRightsCheckbox(repoName) {
+        this.getGraphqlRepositoryTypeTooltipForRepo(repoName).trigger('mouseover');
+    }
+
+    static blurGraphQlRightsCheckbox(repoName) {
+        this.getGraphqlRepositoryTypeTooltipForRepo(repoName).trigger('mouseout');
+    }
+
+    static getAngularTooltip() {
+        return cy.get('.angular-tooltip');
+    }
+
     static clickMenuItem(label) {
         return cy.get('.main-menu').contains(label).click({force: true});
     }

package/steps/ttyg/ttyg-agent-settings-modal.steps.js

@@ -451,6 +451,14 @@ export class TtygAgentSettingsModalSteps extends ModalDialogSteps {
         return this.getDialog().find('.temperature');
     }
 
+    static getTemperatureToggle() {
+        return TtygAgentSettingsModalSteps.getTemperatureFormGroup().find('.temperature-toggle label');
+    }
+
+    static toggleTemperature() {
+        TtygAgentSettingsModalSteps.getTemperatureToggle().click();
+    }
+
     static getTemperatureField() {
         return this.getTemperatureFormGroup().find('#temperature');
     }
@@ -477,6 +485,14 @@ export class TtygAgentSettingsModalSteps extends ModalDialogSteps {
         return this.getDialog().find('.top-p');
     }
 
+    static getTopPToggle() {
+        return TtygAgentSettingsModalSteps.getTopPFormGroup().find('.top-p-toggle label');
+    }
+
+    static toggleTop() {
+        TtygAgentSettingsModalSteps.getTopPToggle().click();
+    }
+
     static getTopPField() {
         return this.getTopPFormGroup().find('#topP');
     }