graphdb-workbench-tests 3.5.1 → 4.0.0-SPARQL12-TEST-FIX

package/e2e-legacy/setup/aclmanagement/validate-uri.spec.js

@@ -0,0 +1,152 @@
+import {AclManagementSteps} from "../../../steps/setup/acl-management-steps";
+import {ApplicationSteps} from "../../../steps/application-steps";
+
+describe('ACL Management: IRI validation', () => {
+
+    let repositoryId;
+
+    afterEach(() => {
+        cy.deleteRepository(repositoryId);
+    });
+
+    beforeEach(() => {
+        repositoryId = 'acl-management-' + Date.now();
+        cy.createRepository({id: repositoryId});
+        cy.presetRepository(repositoryId);
+        cy.initializeRepository(repositoryId);
+        cy.enableAutocomplete(repositoryId);
+        AclManagementSteps.visit();
+        ApplicationSteps.getLoader().should('not.exist');
+    });
+
+    /**
+     * Fills in all the fields required for the rule to be otherwise valid, except the subject,
+     * so that only the subject's own validity determines whether the rule can be saved.
+     * @param {number} index
+     */
+    const fillMandatoryFieldsExceptSubject = (index) => {
+        AclManagementSteps.fillRole(index, 'ROLE1');
+        AclManagementSteps.selectPolicy(index, 'allow');
+        AclManagementSteps.selectOperation(index, 'write');
+        AclManagementSteps.fillPredicate(index, '*');
+        AclManagementSteps.fillObject(index, '*');
+        AclManagementSteps.fillContext(index, '*');
+    };
+
+    it('should mark the subject field as invalid and block saving when an absolute http IRI is typed without angle brackets', () => {
+        // When I create a new rule and type an absolute http IRI without wrapping it in angle brackets
+        AclManagementSteps.addRuleInBeginning();
+        fillMandatoryFieldsExceptSubject(0);
+        AclManagementSteps.fillSubject(0, 'http://example.com/John');
+
+        // Then I expect the field to be marked as invalid
+        AclManagementSteps.getSubjectField(0).should('have.class', 'invalid');
+        // And I expect saving the rule to be forbidden
+        AclManagementSteps.checkIfRuleSavingIsForbidden(0);
+    });
+
+    it('should mark the subject field as valid and allow saving once the http IRI is wrapped in angle brackets', () => {
+        // When I create a new rule and type a properly wrapped absolute http IRI
+        AclManagementSteps.addRuleInBeginning();
+        fillMandatoryFieldsExceptSubject(0);
+        AclManagementSteps.fillSubject(0, '<http://example.com/John>');
+
+        // Then I expect the field to be marked as valid
+        AclManagementSteps.getSubjectField(0).should('not.have.class', 'invalid');
+        // And I expect saving the rule to be allowed
+        AclManagementSteps.checkIfRuleSavingIsAllowed(0);
+    });
+
+    it('should mark the subject field as invalid for a urn IRI without angle brackets and valid once wrapped', () => {
+        // When I create a new rule and type a urn IRI without angle brackets
+        AclManagementSteps.addRuleInBeginning();
+        fillMandatoryFieldsExceptSubject(0);
+        AclManagementSteps.fillSubject(0, 'urn:John');
+
+        // Then I expect the field to be marked as invalid
+        AclManagementSteps.getSubjectField(0).should('have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsForbidden(0);
+
+        // When I wrap the same urn IRI in angle brackets
+        AclManagementSteps.fillSubject(0, '<urn:John>');
+
+        // Then I expect the field to become valid
+        AclManagementSteps.getSubjectField(0).should('not.have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsAllowed(0);
+    });
+
+    it('should keep the wildcard (*) value valid', () => {
+        // When I create a new rule and use the wildcard value for the subject
+        AclManagementSteps.addRuleInBeginning();
+        fillMandatoryFieldsExceptSubject(0);
+        AclManagementSteps.fillSubject(0, '*');
+
+        // Then I expect the field to remain valid
+        AclManagementSteps.getSubjectField(0).should('not.have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsAllowed(0);
+    });
+
+    it('should still query autocomplete suggestions for an absolute IRI typed without angle brackets', () => {
+        // Given I intercept the autocomplete suggestions requests
+        cy.intercept('GET', '**/rest/autocomplete/query*').as('autocompleteQuery');
+
+        // When I create a new rule and type an absolute http IRI without angle brackets
+        AclManagementSteps.addRuleInBeginning();
+        fillMandatoryFieldsExceptSubject(0);
+        AclManagementSteps.fillSubject(0, 'http://example.com/resource/John');
+
+        // Then I expect the autocomplete request to still be triggered, searching only by the
+        // local name within the detected namespace (namespace and local name joined by ";")
+        cy.wait('@autocompleteQuery');
+        cy.get('@autocompleteQuery.all').then((interceptions) => {
+            const lastCall = interceptions[interceptions.length - 1];
+            const url = new URL(lastCall.request.url);
+            expect(url.searchParams.get('q')).to.eq('http://example.com/resource/;John');
+        });
+    });
+
+    it('should reject a triple term value for a plain field validated only as an IRI', () => {
+        // Predicate only allows validate-uri/validate-default-value, so a triple term is not a valid value there
+        AclManagementSteps.addRuleInBeginning();
+        AclManagementSteps.fillRole(0, 'ROLE1');
+        AclManagementSteps.selectPolicy(0, 'allow');
+        AclManagementSteps.selectOperation(0, 'write');
+        AclManagementSteps.fillSubject(0, '*');
+        AclManagementSteps.fillObject(0, '*');
+        AclManagementSteps.fillContext(0, '*');
+        AclManagementSteps.fillPredicate(0, '<<(<http://example.com/a> <http://example.com/b> "c")>>');
+
+        AclManagementSteps.getPredicateField(0).should('have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsForbidden(0);
+    });
+
+    it('should accept a triple term value for the object field, where it is allowed', () => {
+        // Only the object field is configured with validate-triple-term-value="true"
+        AclManagementSteps.addRuleInBeginning();
+        AclManagementSteps.fillRole(0, 'ROLE1');
+        AclManagementSteps.selectPolicy(0, 'allow');
+        AclManagementSteps.selectOperation(0, 'write');
+        AclManagementSteps.fillSubject(0, '*');
+        AclManagementSteps.fillPredicate(0, '*');
+        AclManagementSteps.fillContext(0, '*');
+        AclManagementSteps.fillObject(0, '<<(<http://example.com/a> <http://example.com/b> "c")>>');
+
+        AclManagementSteps.getObjectField(0).should('not.have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsAllowed(0);
+    });
+
+    it('should reject a malformed triple term value (missing closing brackets) for the object field', () => {
+        AclManagementSteps.addRuleInBeginning();
+        AclManagementSteps.fillRole(0, 'ROLE1');
+        AclManagementSteps.selectPolicy(0, 'allow');
+        AclManagementSteps.selectOperation(0, 'write');
+        AclManagementSteps.fillSubject(0, '*');
+        AclManagementSteps.fillPredicate(0, '*');
+        AclManagementSteps.fillContext(0, '*');
+        AclManagementSteps.fillObject(0, '<<(<http://example.com/a> <http://example.com/b> "c")');
+
+        AclManagementSteps.getObjectField(0).should('have.class', 'invalid');
+        AclManagementSteps.checkIfRuleSavingIsForbidden(0);
+    });
+});
+

package/e2e-legacy/setup/users-and-access/user-and-access.spec.js

@@ -280,7 +280,7 @@ describe('User and Access', () => {
                 LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
                 UserAndAccessSteps.getUsersTable().should('be.visible');
 
-                cy.visit('/login?r=%252Fsparql');
+                cy.visit('/login?r=%2Fsparql');
                 cy.reload();
                 UserAndAccessSteps.getUrl().should('include', '/sparql');
             });
@@ -976,14 +976,14 @@ describe('User and Access', () => {
     };
 
     const MENU_ITEMS_WITHOUT_GRAPHQL = [
-        // 1) Import
+        // Import
         {
             path: ['Import'],
             expectedUrl: '/import',
             checks: noAuthChecks,
         },
 
-        // 2) Explore
+        // Explore
         {
             path: ['Explore', 'Graphs overview'],
             expectedUrl: '/graphs',
@@ -1011,7 +1011,7 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 3) SPARQL
+        // SPARQL
         {
             path: ['SPARQL'],
             expectedTitle: 'SPARQL Query & Update',
@@ -1019,9 +1019,16 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 4) GraphQL
+        // TTYG
+        {
+            path: ['Talk to Your Graph'],
+            expectedUrl: '/ttyg',
+            checks: noAuthChecks,
+        },
+
+        // GraphQL
 
-        // 5) Monitor
+        // Monitor
         {
             path: ['Monitor', 'Queries and Updates'],
             expectedUrl: '/monitor/queries',
@@ -1029,7 +1036,7 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 6) Setup
+        // Setup
         {
             path: ['Setup', 'My Settings'],
             expectedUrl: '/settings',
@@ -1081,14 +1088,7 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 7) Lab
-        {
-            path: ['Lab', 'Talk to Your Graph'],
-            expectedUrl: '/ttyg',
-            checks: noAuthChecks,
-        },
-
-        // 8) Help
+        // Help
         {
             path: ['Help', 'REST API'],
             expectedUrl: '/webapi',
@@ -1128,14 +1128,14 @@ describe('User and Access', () => {
     ];
 
     const FREE_ACCESS_MENU_ITEMS_WITHOUT_GRAPHQL = [
-        // 1) Import
+        // Import
         {
             path: ['Import'],
             expectedUrl: '/import',
             checks: noAuthChecks,
         },
 
-        // 2) Explore
+        // Explore
         {
             path: ['Explore', 'Graphs overview'],
             expectedUrl: '/graphs',
@@ -1163,7 +1163,7 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 3) SPARQL
+        // SPARQL
         {
             path: ['SPARQL'],
             expectedTitle: 'SPARQL Query & Update',
@@ -1171,7 +1171,7 @@ describe('User and Access', () => {
             checks: noAuthChecks,
         },
 
-        // 6) Setup
+        // Setup
         {
             path: ['Setup', 'Connectors'],
             expectedUrl: '/connectors',

package/e2e-legacy/sparql-editor/yasr/download-as.spec.js

@@ -44,13 +44,10 @@ describe('Download results', () => {
 
             // Then expect follow options to be present.
             YasrSteps.getDownloadAsOption(0).contains('JSON');
-            YasrSteps.getDownloadAsOption(1).contains( 'JSON*');
-            YasrSteps.getDownloadAsOption(2).contains( 'XML');
-            YasrSteps.getDownloadAsOption(3).contains( 'XML*');
-            YasrSteps.getDownloadAsOption(4).contains( 'CSV');
-            YasrSteps.getDownloadAsOption(5).contains( 'TSV');
-            YasrSteps.getDownloadAsOption(6).contains( 'TSV*');
-            YasrSteps.getDownloadAsOption(7).contains( 'Binary RDF Results');
+            YasrSteps.getDownloadAsOption(1).contains( 'XML');
+            YasrSteps.getDownloadAsOption(2).contains( 'CSV');
+            YasrSteps.getDownloadAsOption(3).contains( 'TSV');
+            YasrSteps.getDownloadAsOption(4).contains( 'Binary RDF Results');
         });
 
         it('should download as JSON-LD after a CONSTRUCT query', () => {

package/e2e-legacy/ttyg/edit-agent.spec.js

@@ -109,6 +109,14 @@ describe('TTYG edit an agent', () => {
 
         // THEN: The Save Agent button should be disabled
         TtygAgentSettingsModalSteps.getSaveAgentButton().should('be.disabled');
+        // AND: The panel of the FTS extraction method should be expanded, so that the reason is visible
+        TtygAgentSettingsModalSteps.getFtsDisabledHelp().should('be.visible');
+
+        // WHEN: I try to collapse the panel of the FTS extraction method
+        TtygAgentSettingsModalSteps.toggleFTSExtractionMethodPanel();
+        // THEN: The panel should remain expanded, because the precondition error is not resolved yet
+        TtygAgentSettingsModalSteps.getFtsDisabledHelp().should('be.visible');
+        TtygAgentSettingsModalSteps.getSaveAgentButton().should('be.disabled');
     });
 
     it('should be able to edit Autocomplete extraction method option', () => {

package/e2e-legacy/ttyg/ttyg-initial-state-with-configured-api-key.spec.js

@@ -39,7 +39,7 @@ describe('TTYG initial state with API key', () => {
     it('Should display the correct initial state when navigating via the navigation menu', () => {
         // Given, I visit the TTYG page via the navigation menu
         HomeSteps.visit();
-        MainMenuSteps.clickOnTTYG();
+        MainMenuSteps.clickOnMenuTTYG();
         // Then,
         verifyStateWithApiKey();
     });

package/e2e-legacy/ttyg/ttyg-initial-state-with-selected-repository.spec.js

@@ -38,7 +38,7 @@ describe.skip('TTYG initial state with selected repository', () => {
     it('Should display the correct initial state when navigating via the navigation menu', () => {
         // Given, I visit the TTYG page via the navigation menu with a repository selected
         HomeSteps.visit();
-        MainMenuSteps.clickOnTTYG();
+        MainMenuSteps.clickOnMenuTTYG();
         // Then,
         verifyStateWithSelectedRepository();
     });

package/e2e-legacy/ttyg/ttyg-initial-state-without-repositories.spec.js

@@ -14,7 +14,7 @@ describe('TTYG initial state without selected repository', () => {
     it('Should display the correct initial state when navigating via the navigation menu', () => {
         // Given, I visit the TTYG page via the navigation menu without a repository selected
         HomeSteps.visit();
-        MainMenuSteps.clickOnTTYG();
+        MainMenuSteps.clickOnMenuTTYG();
         // Then,
         ErrorSteps.verifyNoConnectedRepoMessage();
     });

package/eslint.config.js

@@ -35,6 +35,11 @@ export default [
         rules: {
             ...pluginJs.configs.recommended.rules,
             ...pluginCypress.configs.recommended.rules,
+            // Exclusive tests (.only) silently skip the rest of the suite, so they must never be committed.
+            'no-restricted-syntax': ['error', {
+                selector: "MemberExpression[computed=false][property.name='only'][object.name=/^(describe|context|it|specify|test|suite)$/]",
+                message: 'Exclusive tests are not allowed: remove ".only" before committing.'
+            }],
         },
     },
 ];