graphdb-workbench-tests 3.5.1-TR1 → 4.0.0-TR2

package/cypress-guides.config.js

@@ -0,0 +1,45 @@
+import { defineConfig } from 'cypress';
+import setupPlugins from './plugins/index.js';
+
+const isCoverage = process.env.COVERAGE === 'true';
+
+const loadCodeCoverage = async (on, config) => {
+    const mod = await import('@bahmutov/cypress-code-coverage/plugin');
+    const plugin = ('default' in mod) ? mod.default : mod;
+    plugin(on, config);
+};
+
+export default defineConfig({
+    projectId: 'v35btb',
+    fixturesFolder: 'fixtures',
+    screenshotsFolder: 'report/screenshots',
+    videosFolder: 'report/videos',
+    video: true,
+    defaultCommandTimeout: 25000,
+    numTestsKeptInMemory: 10,
+    viewportWidth: 1600,
+    viewportHeight: 1200,
+    e2e: {
+        retries: {
+            runMode: 2,
+            openMode: 0
+        },
+        async setupNodeEvents(on, config) {
+            setupPlugins(on, config);
+            if (isCoverage) {
+                await loadCodeCoverage(on, config);
+            }
+            return config;
+        },
+        baseUrl: 'http://localhost:9000',
+        specPattern: 'e2e-legacy/guides/**/*.{js,jsx,ts,tsx}',
+        supportFile: 'support/e2e.js',
+        reporter: "cypress-multi-reporters",
+        reporterOptions: {
+            configFile: 'cypress-reporter-config.json'
+        }
+    },
+    env: {
+        set_default_user_data: true
+    }
+});

package/e2e-legacy/guides/ttyg/configure-agent/configure-agent-guide.spec.js

@@ -9,8 +9,7 @@ import {GuidesStubs} from "../../../../stubs/guides/guides-stubs.js";
 import {TTYGStubs} from "../../../../stubs/ttyg/ttyg-stubs.js";
 import {RepositoriesStubs} from "../../../../stubs/repositories/repositories-stubs.js";
 
-// TODO: there is some issue with the context side field focus that breaks the test. Should be fixed soon
-describe.skip('ttyg configure agent guide', () => {
+describe('ttyg configure agent guide', () => {
     let repositoryId;
 
     beforeEach(() => {

package/e2e-legacy/repository/rename-repository-restrictions.spec.js

@@ -0,0 +1,125 @@
+import {RepositorySteps} from "../../steps/repository-steps";
+import {OntopRepositorySteps} from "../../steps/ontop-repository-steps";
+import {ToasterSteps} from "../../steps/toaster-steps";
+import {ModalDialogSteps} from "../../steps/modal-dialog-steps";
+
+describe('Repository rename restrictions', () => {
+
+    let repositoryId;
+    let memberRepositoryId;
+
+    beforeEach(() => {
+        repositoryId = 'repo-' + Date.now();
+        memberRepositoryId = 'member-' + Date.now();
+    });
+
+    afterEach(() => {
+        cy.deleteRepository(repositoryId);
+        cy.deleteRepository(memberRepositoryId);
+    });
+
+    it('should allow renaming of a GraphDB repository', () => {
+        // Given there is a GraphDB repository.
+        cy.createRepository({id: repositoryId});
+
+        // When I open its edit page.
+        RepositorySteps.visitEditPage(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should be available.
+        RepositorySteps.getRepositoryIdEditElement().should('be.visible');
+    });
+
+    it('should not allow renaming of an Ontop repository', () => {
+        // Given there is an Ontop repository.
+        createOntopRepository(repositoryId);
+
+        // When I open its edit page.
+        RepositorySteps.visit();
+        RepositorySteps.editRepository(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should not be available, because
+        // renaming is allowed only for GraphDB repositories.
+        RepositorySteps.getRepositoryIdEditElement().should('not.exist');
+
+        // When the repository id is changed despite the field being disabled,
+        forceChangeRepositoryId('renamed-' + repositoryId);
+        // and I try to save the configuration.
+        RepositorySteps.clickSaveEditedRepo();
+
+        // Then I expect to see an error message,
+        ToasterSteps.verifyError('Can not change the name of ontop repository');
+        // and the repository should keep its original id.
+        RepositorySteps.visit();
+        RepositorySteps.getRepositoryFromList(repositoryId).should('be.visible');
+    });
+
+    it('should not allow renaming of a FedX repository', () => {
+        // Given there is a FedX repository.
+        cy.createRepository({id: memberRepositoryId});
+        createFedxRepository(repositoryId, memberRepositoryId);
+
+        // When I open its edit page.
+        RepositorySteps.visit();
+        RepositorySteps.editRepository(repositoryId);
+
+        // Then the repository id should be rendered as read only,
+        RepositorySteps.getGDBIdInput()
+            .should('have.value', repositoryId)
+            .and('be.disabled');
+        // and the action which unlocks the repository id field should not be available, because
+        // renaming is allowed only for GraphDB repositories.
+        RepositorySteps.getRepositoryIdEditElement().should('not.exist');
+
+        // When I save the configuration.
+        RepositorySteps.getSaveRepositoryButton().click();
+        ModalDialogSteps.clickOnConfirmButton();
+
+        // Then the repository should keep its original id.
+        RepositorySteps.visit();
+        RepositorySteps.getRepositoryFromList(repositoryId).should('be.visible');
+    });
+
+    /**
+     * Changes the repository id field although it is disabled in order to verify that the restriction is
+     * enforced by the controller too and not only by the view.
+     *
+     * @param {string} newRepositoryId The new repository id.
+     */
+    const forceChangeRepositoryId = (newRepositoryId) => {
+        RepositorySteps.getGDBIdInput()
+            .clear({force: true})
+            .type(newRepositoryId, {force: true})
+            .should('have.value', newRepositoryId);
+    };
+
+    const createOntopRepository = (repositoryId) => {
+        OntopRepositorySteps.visitCreate();
+        RepositorySteps.typeRepositoryId(repositoryId);
+        OntopRepositorySteps.selectOracleDatabase();
+        OntopRepositorySteps.typeHostName('localhost');
+        OntopRepositorySteps.typePort(5423);
+        OntopRepositorySteps.typeDatabaseName('database-name');
+        OntopRepositorySteps.clickObdaFileUploadButton();
+        OntopRepositorySteps.uploadObdaFile('fixtures/ontop/university-complete.obda');
+        // Wait the OBDA edit button to become visible to ensure that the file is uploaded.
+        OntopRepositorySteps.getOBDAFileFieldEditButton().should('be.visible');
+        OntopRepositorySteps.clickOnCreateRepositoryButton();
+    };
+
+    const createFedxRepository = (repositoryId, memberRepositoryId) => {
+        RepositorySteps.visit();
+        RepositorySteps.createRepository();
+        RepositorySteps.createFedexRepositoryType();
+        RepositorySteps.typeRepositoryId(repositoryId);
+        RepositorySteps.selectFedexMember(memberRepositoryId);
+        RepositorySteps.saveRepository();
+    };
+});

package/eslint.config.js

@@ -35,6 +35,11 @@ export default [
         rules: {
             ...pluginJs.configs.recommended.rules,
             ...pluginCypress.configs.recommended.rules,
+            // Exclusive tests (.only) silently skip the rest of the suite, so they must never be committed.
+            'no-restricted-syntax': ['error', {
+                selector: "MemberExpression[computed=false][property.name='only'][object.name=/^(describe|context|it|specify|test|suite)$/]",
+                message: 'Exclusive tests are not allowed: remove ".only" before committing.'
+            }],
         },
     },
 ];

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "3.5.1-TR1",
+  "version": "4.0.0-TR2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "graphdb-workbench-tests",
-      "version": "3.5.1-TR1",
+      "version": "4.0.0-TR2",
       "license": "Apache-2.0",
       "devDependencies": {
         "@bahmutov/cypress-code-coverage": "^2.7.2",
@@ -2082,9 +2082,9 @@
       }
     },
     "node_modules/@eslint/eslintrc/node_modules/js-yaml": {
-      "version": "4.3.1",
-      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.1.tgz",
-      "integrity": "sha512-CY6crGq313MX8GkwvB7tzgp99vjQxY1++5y10/BKN/GUfHqWaOGQMNZkBvqSzsZKWk/ijwHlWzzkLulsGHhjWQ==",
+      "version": "4.3.0",
+      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.0.tgz",
+      "integrity": "sha512-1td788aAnnZ5qs7V2QIRl1owjtYpbKt749Y3xauqQgwIIGF/xXWz1wMTEBx5O3LK3lXLVuqXPdPxj2BoFHaW9Q==",
       "dev": true,
       "funding": [
         {
@@ -7776,9 +7776,9 @@
       }
     },
     "node_modules/mocha/node_modules/js-yaml": {
-      "version": "4.3.1",
-      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.1.tgz",
-      "integrity": "sha512-CY6crGq313MX8GkwvB7tzgp99vjQxY1++5y10/BKN/GUfHqWaOGQMNZkBvqSzsZKWk/ijwHlWzzkLulsGHhjWQ==",
+      "version": "4.3.0",
+      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.3.0.tgz",
+      "integrity": "sha512-1td788aAnnZ5qs7V2QIRl1owjtYpbKt749Y3xauqQgwIIGF/xXWz1wMTEBx5O3LK3lXLVuqXPdPxj2BoFHaW9Q==",
       "dev": true,
       "funding": [
         {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphdb-workbench-tests",
-  "version": "3.5.1-TR1",
+  "version": "4.0.0-TR2",
   "description": "Cypress tests for GraphDB workbench",
   "type": "module",
   "scripts": {
@@ -10,7 +10,8 @@
     "cy:open-legacy": "cypress open  --config-file cypress-legacy.config.js",
     "cy:open-security": "cypress open  --config-file cypress-security.config.js",
     "cy:open-flaky": "cypress open --config-file cypress-flaky.config.js",
-    "cy:guides": "cypress run --config-file cypress-legacy.config.js --spec \"e2e-legacy/guides/**/*.spec.js\" --browser chrome",
+    "cy:open-guides": "cypress open --config-file cypress-guides.config.js",
+    "cy:run-guides": "cypress run --config-file cypress-guides.config.js",
     "cy:run": "npm run cy:run-legacy && cypress run",
     "cy:run:partial": "cypress run --config-file cypress-legacy.config.js --spec \"e2e-legacy/ttyg/**/*.spec.js\" --browser chrome",
     "cy:run-legacy": "cypress run --config-file cypress-legacy.config.js --browser chrome",