graphdb-workbench-tests 3.5.0 → 3.5.1-RC1

package/e2e-legacy/cluster/cluster-configuration/cluster-configuration-multi-region.spec.js

@@ -42,7 +42,9 @@ describe('Cluster configuration', () => {
         });
 
         ClusterStubs.stubClusterGroupStatusWithTag();
+        ClusterStubs.stubClusterConfigWithTag();
         cy.wait('@3-nodes-cluster-group-status-tag');
+        cy.wait('@cluster-config-with-tag');
         // Assert the tags table contains the expected tag
         ClusterConfigurationSteps.getTagsTable().should('be.visible');
         ClusterConfigurationSteps.getTagsTableRows().should('contain.text', tagName);
@@ -62,6 +64,31 @@ describe('Cluster configuration', () => {
         cy.wait('@delete-tag').then((interception) => {
             expect(interception.request.body).to.deep.equal({tag: tagName});
         });
+        ClusterStubs.stubClusterGroupStatus();
+        ClusterStubs.stubClusterConfig();
+        cy.wait('@3-nodes-cluster-group-status');
+        cy.wait('@cluster-config');
+        ClusterConfigurationSteps.getTagsTable().should('not.exist');
+    });
+
+    it('should show an alert when there is no elected leader in the cluster', () => {
+        // Given there is no elected leader in the cluster
+        ClusterStubs.stubClusterGroupStatusWithoutLeader();
+
+        // When I have opened the cluster management page
+        ClusterPageSteps.visit();
+        // And I click on edit properties and open Multi-region tab
+        ClusterPageSteps.previewClusterConfig();
+        ClusterConfigurationSteps.selectMultiRegionConfigTab();
+
+        // Then I expect to see an alert that the leader is not elected
+        ClusterConfigurationSteps.getNoLeaderAlert().should('be.visible')
+            .and('contain.text', 'Leader is not elected');
+        // And no primary or secondary cluster configuration should be rendered
+        ClusterConfigurationSteps.getMultiRegionHeader().should('not.exist');
+        ClusterConfigurationSteps.getAddTagButton().should('not.exist');
+        ClusterConfigurationSteps.getEnableSecondaryModeButton().should('not.exist');
+        ClusterConfigurationSteps.getTagsTable().should('not.exist');
     });
 
     it('should be able to switch modes', () => {

package/e2e-legacy/cluster/edit-cluster-nodes-modal.spec.js

@@ -460,7 +460,7 @@ describe('Cluster management', () => {
                 "verificationTimeout": 1500,
                 "transactionLogMaximumSizeGB": 50.0,
                 "batchUpdateInterval": 5000,
-                "nodes": ['http://pc-desktop:7200', 'http://pc-desktop:7203']
+                "nodes": ['http://pc-desktop:7200', 'http://pc-desktop:7203'],
             });
         });
         // And expect success message to be displayed.

package/e2e-legacy/setup/settings/my-settings-initial-state.spec.js

@@ -2,7 +2,7 @@ import {MainMenuSteps} from "../../../steps/main-menu-steps";
 import HomeSteps from "../../../steps/home-steps";
 import {SettingsSteps} from "../../../steps/setup/settings-steps";
 
-function verifyInitialState(repositoryId) {
+function verifyInitialState() {
   // Password change field is for admin.
   // explicitly state that the fields must be of type password
   SettingsSteps.getPasswordField().should('be.visible')
@@ -43,14 +43,8 @@ function verifyInitialState(repositoryId) {
   // Repository rights
   // - Admin has read and write access to all repositories."
   SettingsSteps.getUserRepositoryTable().should('be.visible');
-  SettingsSteps.getReadRightsCheckbox(repositoryId)
-    .should('be.visible')
-    .and('be.checked')
-    .and('be.disabled');
-  SettingsSteps.getWriteRightsCheckbox(repositoryId)
-    .should('be.visible')
-    .and('be.checked')
-    .and('be.disabled');
+  // And Admin doesn't see the list of the repositories
+  SettingsSteps.getRepositoryRightsRows().should('not.exist');
 }
 
 describe('My Settings initial state', () => {
@@ -69,7 +63,7 @@ describe('My Settings initial state', () => {
     // Given, I visit the My Settings page via URL
     SettingsSteps.visit();
     // Then,
-    verifyInitialState(repositoryId);
+    verifyInitialState();
   });
 
   it('Should display the correct initial state when navigating via the navigation bar', () => {
@@ -77,6 +71,6 @@ describe('My Settings initial state', () => {
     HomeSteps.visit();
     MainMenuSteps.clickOnMySettings();
     // Then,
-    verifyInitialState(repositoryId);
+    verifyInitialState();
   });
 });

package/e2e-legacy/setup/users-and-access/user-and-access.spec.js

@@ -128,7 +128,6 @@ describe('User and Access', () => {
                 UserAndAccessSteps.getCustomRoleFieldError().should('not.be.visible');
 
                 // When I create the user with a valid custom role
-                UserAndAccessSteps.toggleWriteAccessAny();
                 SecurityStubs.spyOnUserCreate();
                 UserAndAccessSteps.confirmUserCreate();
                 // Then the user should be created with that custom role
@@ -318,6 +317,8 @@ describe('User and Access', () => {
             verifyDisabledUserAuth('*', {read: false, write: false, maintain: true, graphql: true});
             verifyCheckedUserAuth(repoName, {read: false, write: false, maintain: false, graphql: false});
             verifyDisabledUserAuth(repoName, {read: false, write: false, maintain: false, graphql: true});
+            // The GraphQL checkbox is disabled for the lack of read/write rights, not because of the role
+            UserAndAccessSteps.getGraphqlAnyRoleTooltip().should('not.exist');
         });
 
         context('for non user roles', () => {
@@ -327,8 +328,7 @@ describe('User and Access', () => {
                 verifyCheckedUserAuth('*', {read: true, write: true, maintain: true, graphql: false});
                 verifyDisabledUserAuth('*', {read: true, write: true, maintain: true, graphql: true});
 
-                verifyCheckedUserAuth(repoName, {read: true, write: true, maintain: true, graphql: false});
-                verifyDisabledUserAuth(repoName, {read: true, write: true, maintain: true, graphql: true});
+                UserAndAccessSteps.getRepositoryRightsRows().should('not.exist');
             });
 
             it('repository manager', () => {
@@ -338,8 +338,7 @@ describe('User and Access', () => {
                 verifyCheckedUserAuth('*', {read: true, write: true, maintain: true, graphql: false});
                 verifyDisabledUserAuth('*', {read: true, write: true, maintain: true, graphql: true});
 
-                verifyCheckedUserAuth(repoName, {read: true, write: true, maintain: true, graphql: false});
-                verifyDisabledUserAuth(repoName, {read: true, write: true, maintain: true, graphql: true});
+                UserAndAccessSteps.getRepositoryRightsRows().should('not.exist');
             });
         });
 
@@ -464,6 +463,27 @@ describe('User and Access', () => {
                 createUser(graphqlUser, PASSWORD, ROLE_USER, {read: true, graphql: true, repoName: repositoryId2});
             });
 
+            it('Should not allow GraphQL access for Ontop and FedX repositories', () => {
+                // GIVEN Ontop and FedX repositories alongside a GraphDB one
+                RepositoriesStubs.stubRepositories(0, '/repositories/get-repositories-with-unsupported-graphql-types.json');
+                UserAndAccessSteps.visit();
+                UserAndAccessSteps.clickCreateNewUserButton();
+                // WHEN the user is granted read access to all of them
+                UserAndAccessSteps.toggleReadAccessAny();
+
+                // THEN GraphQL should be available only for the GraphDB repository
+                UserAndAccessSteps.validateGraphqlAccessForRepo('graphdb-repo', {disabled: false});
+                UserAndAccessSteps.getGraphqlRepositoryTypeTooltipForRepo('graphdb-repo').should('not.exist');
+
+                // AND it should be permanently disabled for the Ontop and the FedX ones
+                ['ontop-repo', 'fedx-repo'].forEach((repository) => {
+                    UserAndAccessSteps.validateGraphqlAccessForRepo(repository, {checked: false, disabled: true});
+                    UserAndAccessSteps.hoverGraphQlRightsCheckbox(repository)
+                    UserAndAccessSteps.getAngularTooltip().should('have.text', 'Not available for this repository type');
+                    UserAndAccessSteps.blurGraphQlRightsCheckbox(repository)
+                });
+            });
+
             // Fails for unknown reason only in CI
             it('Can create user with different auth combinations', () => {
                 cy.wait('@getRepositories');

package/e2e-legacy/ttyg/create-agent.spec.js

@@ -172,6 +172,60 @@ describe('TTYG create new agent', () => {
         TTYGViewSteps.getAgent(0).should('contain', 'Test Agent').and('contain', 'starwars');
     });
 
+    it('should create an agent without temperature or topP parameters', () => {
+        // GIVEN: I have opened the Create Agent dialog and filled in the minimum required fields.
+        openCreateAgentDialog(repositoryId)
+        TtygAgentSettingsModalSteps.getDialog().should('be.visible');
+
+        fillAgentName('Test Agent');
+        TtygAgentSettingsModalSteps.enableSparqlExtractionMethod();
+        TtygAgentSettingsModalSteps.selectSparqlMethodSparqlQuery();
+
+        // WHEN: I disable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+
+        // AND: I disable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+
+        // AND: I save the agent.
+        TTYGStubs.stubAgentCreate(1000);
+        TTYGStubs.stubAgentListGet(
+            '/ttyg/agent/get-agent-list-new-agent.json',
+            1000,
+        );
+
+        TtygAgentSettingsModalSteps.saveAgent();
+        TtygAgentSettingsModalSteps.getCreatingAgentLoader().should('be.visible');
+
+        // THEN: I expect the create-agent request not to contain the temperature and topP parameters.
+        cy.wait('@create-agent').then((interception) => {
+            // eslint-disable-next-line no-undef
+            assert.deepEqual(interception.request.body, {
+                id: 'id',
+                name: 'Test Agent',
+                repositoryId: 'starwars',
+                model: 'gpt-4o',
+                contextSize: 128000,
+                seed: 0,
+                assistantsInstructions: {
+                    systemInstruction: '',
+                    userInstruction: 'If you need to write a SPARQL query, use only the classes and properties provided in the schema and don\'t invent or guess any. Always try to return human-readable names or labels and not only the IRIs. If SPARQL fails to provide the necessary information you can try another tool too.',
+                },
+                assistantExtractionMethods: [
+                    {
+                        method: 'sparql_search',
+                        sparqlQuery: 'CONSTRUCT {?s ?p ?o} WHERE {GRAPH <http://example.org/ontology> {?s ?p ?o .}}',
+                        addMissingNamespaces: false,
+                    },
+                ],
+                additionalExtractionMethods: [],
+            });
+        });
+
+        // AND: I expect the modal to be closed.
+        TtygAgentSettingsModalSteps.getDialog().should('not.exist');
+    });
+
     it('Should require FTS to be enabled for selected repository when creating agent with FTS extraction method', () => {
         RepositoriesStubs.stubGetRepositoryConfig(repositoryId, '/repositories/get-repository-config-starwars-disabled-fts.json');
         TTYGStubs.stubChatsListGetNoResults();
@@ -461,6 +515,53 @@ describe('TTYG create new agent', () => {
         TtygAgentSettingsModalSteps.getTemperatureField().should('not.have.class', 'has-warning');
     });
 
+    it('should toggle the temperature setting', () => {
+        // GIVEN: I have opened the Create Agent dialog.
+        openCreateAgentDialog(repositoryId);
+
+        // WHEN: I set a high temperature value.
+        TtygAgentSettingsModalSteps.setTemperature('1.2');
+        // THEN: I expect a warning message to be displayed.
+        TtygAgentSettingsModalSteps.getTemperatureField().should('have.class', 'has-warning');
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '1.2');
+
+        // WHEN: I disable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the high-temperature warning to be hidden.
+        TtygAgentSettingsModalSteps.getTemperatureWarning().should('not.exist');
+        TtygAgentSettingsModalSteps.getTemperatureField().should('not.have.class', 'has-warning');
+        // AND: I expect the temperature controls to be disabled.
+        TtygAgentSettingsModalSteps.getTemperatureField().should('be.disabled');
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('be.disabled');
+
+        // WHEN: I enable the temperature setting.
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the last set temperature value to be restored instead of the default one.
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '1.2');
+        // AND: I expect the high-temperature warning to be displayed again.
+        TtygAgentSettingsModalSteps.getTemperatureField().should('have.class', 'has-warning');
+    });
+
+    it('should toggle the topP setting', () => {
+        // GIVEN: I have opened the Create Agent dialog.
+        openCreateAgentDialog(repositoryId);
+
+        // WHEN: I set a custom topP value.
+        TtygAgentSettingsModalSteps.setTopP('0.3');
+        // THEN: I expect the topP value to be updated.
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '0.3');
+
+        // WHEN: I disable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the topP control to be disabled.
+        TtygAgentSettingsModalSteps.getTopPField().should('be.disabled');
+
+        // WHEN: I enable the topP setting.
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the last set topP value to be restored instead of the default one.
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '0.3');
+    });
+
     it('Should warn the user when he changes the default value of the base instruction', () => {
         RepositoriesStubs.stubGetRepositoryConfig(repositoryId, '/repositories/get-repository-config-starwars-enabled-fts.json');
         TTYGStubs.stubChatsListGetNoResults();
@@ -541,3 +642,13 @@ function fillAgentName(name) {
     TtygAgentSettingsModalSteps.getAgentNameError().should('be.visible').and('contain', 'This field is required');
     TtygAgentSettingsModalSteps.typeAgentName(name);
 }
+
+const openCreateAgentDialog = (repositoryId) => {
+    TTYGStubs.stubChatsListGetNoResults();
+    TTYGStubs.stubAgentListGet('/ttyg/agent/get-agent-list-0.json');
+    ConnectorStubs.stubGetConnectors();
+    TTYGStubs.getSimilarityIndexesForRepo(repositoryId );
+    TTYGViewSteps.visit();
+    cy.wait('@get-all-repositories');
+    TTYGViewSteps.createFirstAgent();
+}

package/e2e-legacy/ttyg/edit-agent.spec.js

@@ -45,6 +45,55 @@ describe('TTYG edit an agent', () => {
         ToasterSteps.verifySuccess('The agent \'agent-1\' was saved successfully.');
     });
 
+    it('should preserve the temperature and topP values of the edited agent', () => {
+        TTYGStubs.stubChatsListGet();
+        TTYGStubs.stubAgentListGet();
+        TTYGStubs.stubChatGet();
+        // GIVEN: I have opened the ttyg page
+        TTYGViewSteps.visit();
+        cy.wait('@get-chat-list');
+        cy.wait('@get-agent-list');
+        cy.wait('@get-chat');
+
+        // WHEN: I open the settings of an agent whose temperature and topP differ from the default values
+        TTYGViewSteps.openAgentSettingsModalForAgent(0);
+
+        // THEN: I expect the values of the agent to be loaded instead of the default ones
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '0');
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '0');
+
+        // WHEN: I disable the temperature setting
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the temperature controls to be disabled
+        TtygAgentSettingsModalSteps.getTemperatureField().should('be.disabled');
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('be.disabled');
+
+        // WHEN: I enable the temperature setting again
+        TtygAgentSettingsModalSteps.toggleTemperature();
+        // THEN: I expect the temperature value of the agent to be restored instead of the default one
+        TtygAgentSettingsModalSteps.getTemperatureSliderField().should('have.value', '0');
+
+        // WHEN: I disable the topP setting
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the topP control to be disabled
+        TtygAgentSettingsModalSteps.getTopPField().should('be.disabled');
+
+        // WHEN: I enable the topP setting again
+        TtygAgentSettingsModalSteps.toggleTop();
+        // THEN: I expect the topP value of the agent to be restored instead of the default one
+        TtygAgentSettingsModalSteps.getTopPField().should('have.value', '0');
+
+        // WHEN: I save the agent
+        TTYGStubs.stubAgentEdit();
+        TtygAgentSettingsModalSteps.saveAgent();
+        // THEN: I expect the values of the agent to be sent instead of the default ones
+        cy.wait('@edit-agent').then((interception) => {
+            expect(interception.request.body.temperature).to.equal(0);
+            expect(interception.request.body.topP).to.equal(0);
+        });
+        ToasterSteps.verifySuccess('The agent \'agent-1\' was saved successfully.');
+    });
+
     it('should not be able to edit an agent if an extraction method is selected but the precondition has failed', () => {
         TTYGStubs.stubChatsListGet();
         TTYGStubs.stubAgentListGet();

package/fixtures/cluster/3-nodes-cluster-group-status-no-leader.json

@@ -0,0 +1,41 @@
+[
+    {
+        "address": "pc-desktop:7300",
+        "nodeState": "FOLLOWER",
+        "term": 2,
+        "syncStatus": {},
+        "lastLogTerm": 0,
+        "lastLogIndex": 0,
+        "endpoint": "http://pc-desktop:7200",
+        "recoveryStatus": {},
+        "topologyStatus": {
+            "state": "PRIMARY_NODE"
+        }
+    },
+    {
+        "address": "pc-desktop:7301",
+        "nodeState": "FOLLOWER",
+        "term": 2,
+        "syncStatus": {},
+        "lastLogTerm": 0,
+        "lastLogIndex": 0,
+        "endpoint": "http://pc-desktop:7201",
+        "recoveryStatus": {},
+        "topologyStatus": {
+            "state": "PRIMARY_NODE"
+        }
+    },
+    {
+        "address": "pc-desktop:7302",
+        "nodeState": "FOLLOWER",
+        "term": 2,
+        "syncStatus": {},
+        "lastLogTerm": 0,
+        "lastLogIndex": 0,
+        "endpoint": "http://pc-desktop:7202",
+        "recoveryStatus": {},
+        "topologyStatus": {
+            "state": "PRIMARY_NODE"
+        }
+    }
+]

package/fixtures/cluster/cluster-config-with-tag.json

@@ -0,0 +1,17 @@
+{
+    "electionMinTimeout": 8000,
+    "electionRangeTimeout": 6000,
+    "heartbeatInterval": 2000,
+    "messageSizeKB": 64,
+    "verificationTimeout": 1500,
+    "transactionLogMaximumSizeGB": 50.0,
+    "batchUpdateInterval": 5000,
+    "nodes": [
+        "pc-desktop:7302",
+        "pc-desktop:7300",
+        "pc-desktop:7301"
+    ],
+    "primaryTags": [
+        "test"
+    ]
+}

package/fixtures/repositories/get-repositories-with-unsupported-graphql-types.json

@@ -0,0 +1,46 @@
+{
+    "": [
+        {
+            "id": "graphdb-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/graphdb-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/graphdb-repo",
+            "local": true,
+            "type": "graphdb",
+            "sesameType": "graphdb:SailRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        },
+        {
+            "id": "ontop-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/ontop-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/ontop-repo",
+            "local": true,
+            "type": "ontop",
+            "sesameType": "graphdb:OntopRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        },
+        {
+            "id": "fedx-repo",
+            "title": "",
+            "uri": "http://localhost:8080/graphdb/repositories/fedx-repo",
+            "externalUrl": "http://localhost:8080/graphdb/repositories/fedx-repo",
+            "local": true,
+            "type": "fedx",
+            "sesameType": "graphdb:FedXRepository",
+            "location": "",
+            "readable": true,
+            "writable": true,
+            "unsupported": false,
+            "state": "RUNNING"
+        }
+    ]
+}