graphdb-workbench-tests 3.4.3-TR1 → 3.5.0-RC1

package/e2e-legacy/guides/welcome/welcome-guide.spec.js

@@ -21,7 +21,7 @@ describe('Welcome', () => {
         cy.deleteRepository(repositoryId);
     });
 
-    it.only('Should shows welcome steps', () => {
+    it('Should shows welcome steps', () => {
         GuideDialogSteps.assertDialogWithTitleIsVisible('Welcome to Welcome — 1/2');
         GuideDialogSteps.assertDialogWithContentIsVisible('Throughout the guide you will see boxes like this one that will provide instructions on what to do.');
         GuideDialogSteps.clickOnNextButton();

package/e2e-legacy/home/solr-banner/solr-banner.spec.js

@@ -0,0 +1,137 @@
+import HomeSteps from '../../../steps/home-steps.js';
+import {DeprecationSteps} from '../../../steps/deprecation-steps.js';
+import {LoginSteps} from '../../../steps/login-steps.js';
+import {GuidesStubs} from '../../../stubs/guides/guides-stubs.js';
+import {GuideSteps} from '../../../steps/guides/guide-steps.js';
+import {GuideDialogSteps} from '../../../steps/guides/guide-dialog-steps.js';
+
+describe('Solr deprecation banner', () => {
+    context('Security disabled', () => {
+        it('should keep the Solr deprecation banner hidden after the anonymous user dismisses it', () => {
+            // GIVEN: I have opened the application with security disabled.
+            HomeSteps.visit();
+
+            // THEN: I expect the Solr deprecation banner to be visible.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+
+            // WHEN: I dismiss the Solr deprecation banner.
+            DeprecationSteps.closeBanner();
+            // THEN: I expect the Solr deprecation banner to be hidden.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: I reload the application.
+            HomeSteps.visit();
+            // THEN: I expect the Solr deprecation banner to remain hidden.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+        });
+    });
+
+    context('Security enabled', () => {
+        const PASSWORD = 'root';
+        const USER_USERNAME = 'username';
+
+        beforeEach(() => {
+            cy.createUser({
+                username: USER_USERNAME,
+                password: PASSWORD
+            });
+
+            cy.switchOnSecurity()
+                .then(() => cy.loginAsAdmin())
+                .then(() => cy.switchOnFreeAccess(true));
+        });
+
+        afterEach(() => {
+            cy.loginAsAdmin()
+                .then(() => {
+                    cy.deleteUser(USER_USERNAME, true);
+                    cy.switchOffFreeAccess(true);
+                    cy.switchOffSecurity(true);
+                });
+        });
+
+        it('should persist separate Solr banner states for anonymous and logged-in users', () => {
+            // GIVEN: Security and free access are enabled, and no user is logged in.
+            HomeSteps.visit();
+
+            // THEN: I expect the Solr deprecation banner to be visible for the anonymous user.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+
+            // WHEN: The anonymous user dismisses the banner.
+            DeprecationSteps.closeBanner();
+            // THEN: I expect the banner to be hidden for the anonymous user.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: I log in as a user who has not dismissed the banner.
+            cy.loginAs(USER_USERNAME, PASSWORD);
+            HomeSteps.visit();
+
+            // THEN: I expect the banner to be visible for the logged-in user.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+
+            // WHEN: The logged-in user dismisses the banner.
+            DeprecationSteps.closeBanner();
+            // THEN: I expect the banner to be hidden for the logged-in user.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: The user logs out.
+            LoginSteps.logout();
+            // THEN: I expect the banner to remain hidden because the anonymous user has already dismissed it.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: I log in as the administrator, who has not dismissed the banner.
+            cy.loginAs('admin', 'root');
+            HomeSteps.visit();
+            // THEN: I expect the banner to be visible for the administrator.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+
+            // WHEN: The administrator logs out.
+            LoginSteps.logout();
+            // THEN: I expect the banner to remain hidden because the anonymous user has already dismissed it.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: I log in again as the user who previously dismissed the banner.
+            cy.loginAs(USER_USERNAME, PASSWORD);
+            HomeSteps.visit();
+            // THEN: I expect the banner to remain hidden for the logged-in user.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+        });
+    });
+
+    context('User guides', () => {
+        it('should hide the Solr deprecation banner while a guide is running', () => {
+            // GIVEN: The guides are loaded and ready to be started.
+            GuidesStubs.stubMainMenuGuide();
+            GuideSteps.visit();
+            GuideSteps.verifyGuidesListExists();
+            cy.wait('@getGuides');
+
+            // WHEN: I am on an application page, and the Solr deprecation banner has not been dismissed by the current user.
+            // THEN: I expect the Solr deprecation banner to be visible because it has not been dismissed by the current user.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+
+            // WHEN: I start a guide.
+            GuideSteps.runFirstGuide();
+            // THEN: I expect the Solr deprecation banner to be hidden while the guide is running.
+            DeprecationSteps.getDeprecationBanner().should('not.exist');
+
+            // WHEN: I cancel the guide.
+            GuideDialogSteps.clickOnCancelButton();
+            GuideDialogSteps.clickConfirmCancelDialogExitButton();
+            // THEN: I expect the Solr deprecation banner to be visible again.
+            DeprecationSteps.getDeprecationBanner()
+                .should('be.visible')
+                .should('contain.text', 'The Solr connector is deprecated and will be removed in GraphDB 12');
+        });
+    });
+});

package/e2e-legacy/repository/ontop-repository.spec.js

@@ -241,4 +241,136 @@ describe('Ontop repositories', () => {
         // Then I expect url to be calculated properly
         OntopRepositorySteps.getUrlInput().should('have.value', 'jdbc:snowflake://someHostName.snowflakecomputing.com:1234/?warehouse=test_database');
     });
+
+    context('Repository maintenance permission', () => {
+
+        const PASSWORD = 'root';
+        const REPOSITORY_MAINTAINER_USERNAME = 'repoMaintainer';
+        const REPOSITORY_MANAGER_USERNAME = 'repoManager';
+
+        beforeEach(() => {
+            cy.createUser({
+                username: REPOSITORY_MAINTAINER_USERNAME,
+                password: PASSWORD,
+                grantedAuthorities: [
+                    `READ_REPO_${repositoryId}`,
+                    `MAINTAIN_REPO_${repositoryId}`,
+                    `WRITE_REPO_${repositoryId}`
+                ]
+            });
+            cy.createUser({
+                username: REPOSITORY_MANAGER_USERNAME,
+                password: PASSWORD,
+                grantedAuthorities: [
+                    'ROLE_USER',
+                    'ROLE_MONITORING',
+                    'ROLE_REPO_MANAGER'
+                ]
+            });
+            cy.switchOnSecurity();
+        });
+
+        afterEach(() => {
+            cy.loginAsAdmin()
+                .then(() => {
+                    cy.deleteUser(REPOSITORY_MAINTAINER_USERNAME, true);
+                    cy.deleteUser(REPOSITORY_MANAGER_USERNAME, true);
+                    cy.switchOffSecurity(true);
+                });
+        });
+        it('should allow a repository maintainer to edit an Ontop repository', () => {
+            RepositoryStubs.spyGetJDBCProperties();
+            // GIVEN: An Ontop repository exists
+            cy.loginAs(REPOSITORY_MANAGER_USERNAME, PASSWORD);
+            OntopRepositorySteps.visitCreate();
+            createOntopRepository(repositoryId);
+
+            // WHEN: I log in as a user with maintenance permission
+            cy.loginAs(REPOSITORY_MAINTAINER_USERNAME, PASSWORD);
+            RepositorySteps.visit(false);
+
+            // THEN: The repository is visible because the user can maintain it
+            RepositorySteps.getRepositoryFromList(repositoryId).should('exist');
+
+            // WHEN: I edit the repository
+            RepositorySteps.editRepository(repositoryId);
+            cy.wait('@getJDBCProperties');
+            RepositorySteps.getUsernameFieldEditRepo()
+                .should('have.value', '')
+                .type('username');
+
+            // Uploading an OBDA file verifies that the repository maintainer can access rest/repositories/file/upload
+            OntopRepositorySteps.clickObdaFileUploadButton();
+            OntopRepositorySteps.uploadObdaFile('fixtures/ontop/university-complete_edited.obda');
+
+            // Saving the form verifies that the repository maintainer can access rest/repositories/ontop/jdbc-properties
+            OntopRepositorySteps.getAdditionalJDBCProperties()
+                .should('have.value', '')
+                .type('ontop.cardinalityMode=LOOSE');
+
+            RepositorySteps.clickSaveEditedRepo();
+            ModalDialogSteps.clickOnConfirmButton();
+
+            // THEN: The changes are persisted
+            RepositorySteps.visit(false);
+            RepositorySteps.getRepositoryFromList(repositoryId).should('exist');
+            RepositorySteps.editRepository(repositoryId);
+            cy.wait('@getJDBCProperties');
+
+            OntopRepositorySteps.getOntopSaveButton().should('be.visible');
+            RepositorySteps.getUsernameFieldEditRepo()
+                .should('have.value', 'username');
+
+            // Loading the saved properties verifies GET access to rest/repositories/ontop/jdbc-properties
+            OntopRepositorySteps.getAdditionalJDBCProperties()
+                .should('contain.value', 'ontop.cardinalityMode=LOOSE');
+            // Saving of the OBDA file verifies that the repository maintainer can access rest/repositories/file/upload
+            OntopRepositorySteps.editOBDAFile();
+            ModalDialogSteps.getDialogBody()
+                .find('textarea')
+                .invoke('val')
+                .should('include', 'edited ODBA file');
+            ModalDialogSteps.close();
+
+            // WHEN: I edit and save the OBDA file
+            // Opening the editor verifies access to rest/repositories/file,
+            // while saving verifies access to rest/repositories/file/update.
+            OntopRepositorySteps.editOBDAFile();
+            ModalDialogSteps.getDialogHeader()
+                .should('contain', 'Edit "OBDA or R2RML file" contents');
+
+            ModalDialogSteps.getDialogBody()
+                .find('textarea')
+                .type('{moveToStart}Add commentary for testing purpose');
+
+            ModalDialogSteps.clickOKButton();
+            RepositorySteps.clickSaveEditedRepo();
+            ModalDialogSteps.clickOnConfirmButton();
+
+            // THEN: The OBDA file changes are persisted
+            RepositorySteps.visit(false);
+            RepositorySteps.getRepositoryFromList(repositoryId).should('exist');
+            RepositorySteps.editRepository(repositoryId);
+            cy.wait('@getJDBCProperties');
+            OntopRepositorySteps.editOBDAFile();
+
+            ModalDialogSteps.getDialogBody()
+                .find('textarea')
+                .invoke('val')
+                .should('include', 'Add commentary for testing purpose');
+        });
+    });
 });
+
+const createOntopRepository = (repositoryId) => {
+    RepositorySteps.typeRepositoryId(repositoryId);
+    OntopRepositorySteps.selectOracleDatabase();
+    OntopRepositorySteps.typeHostName('localhost');
+    OntopRepositorySteps.typePort(5423);
+    OntopRepositorySteps.typeDatabaseName('database-name');
+    OntopRepositorySteps.clickObdaFileUploadButton();
+    OntopRepositorySteps.uploadObdaFile('fixtures/ontop/university-complete.obda');
+    // Wait edit OBDA edit button be visible to ensure that file is uploaded.
+    OntopRepositorySteps.getOBDAFileFieldEditButton().should('be.visible');
+    OntopRepositorySteps.clickOnCreateRepositoryButton();
+};

package/e2e-legacy/repository/url-with-repository-id-parameter.spec.js

@@ -171,7 +171,7 @@ describe('URL with Repository ID parameter', () => {
             // Given I am on the 404 page which is in the new workbench
             ErrorPageSteps.visit404();
             ErrorPageSteps.get404Page().should('be.visible');
-            cy.url().should('not.include', 'repositoryId=');
+            cy.url().should('include', `repositoryId=${repositoryId}`);
             // When I navigate to some legacy page
             MainMenuSteps.clickOnSparqlMenu();
             // Then repositoryId parameter should be preserved in the URL

package/e2e-legacy/setup/aclmanagement/create-rule.spec.js

@@ -19,7 +19,7 @@ describe('ACL Management: create rule', () => {
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });

package/e2e-legacy/setup/aclmanagement/delete-rule.spec.js

@@ -19,7 +19,7 @@ describe('ACL Management: delete rule', () => {
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });

package/e2e-legacy/setup/aclmanagement/edit-rule.spec.js

@@ -18,7 +18,7 @@ describe('ACL Management: edit rule', () => {
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });

package/e2e-legacy/setup/aclmanagement/render-rules.spec.js

@@ -17,7 +17,7 @@ describe('ACL Management: render rules', () => {
             cy.presetRepository(repositoryId);
             cy.initializeRepository(repositoryId);
             AclManagementSteps.visit();
-            ApplicationSteps.geLoader().should('not.exist');
+            ApplicationSteps.getLoader().should('not.exist');
         });
 
         it('Should render empty ACL rules table', () => {

package/e2e-legacy/setup/aclmanagement/reorder-rules.spec.js

@@ -17,7 +17,7 @@ describe('ACL Management: reorder rules', () => {
         cy.initializeRepository(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });

package/e2e-legacy/setup/aclmanagement/revert-rules.spec.js

@@ -18,7 +18,7 @@ describe('ACL Management: revert rules', () => {
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });

package/e2e-legacy/setup/aclmanagement/scopes.spec.js

@@ -16,7 +16,7 @@ describe('ACL Management: rule scopes', () => {
         cy.initializeRepository(repositoryId);
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
     });
 
 
@@ -171,7 +171,7 @@ describe('ACL Management: rule scopes', () => {
             expect(interception.request.body).to.deep.eq(expectedPayload);
         });
 
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // Then I expect the ACL to be saved
         ApplicationSteps.getSuccessNotifications().should('be.visible');
 

package/e2e-legacy/setup/aclmanagement/update-rules.spec.js

@@ -18,7 +18,7 @@ describe('ACL Management: update rules', () => {
         cy.enableAutocomplete(repositoryId);
         AclManagementSteps.importRules(repositoryId);
         AclManagementSteps.visit();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // ensure rules are rendered
         AclManagementSteps.getAclRules().should('have.length.gt', 0);
     });
@@ -51,7 +51,7 @@ describe('ACL Management: update rules', () => {
         ModalDialogSteps.clickOnConfirmButton();
         // And I save the ACL list
         AclManagementSteps.saveAcl();
-        ApplicationSteps.geLoader().should('not.exist');
+        ApplicationSteps.getLoader().should('not.exist');
         // Then I expect the ACL to be saved
         ApplicationSteps.getSuccessNotifications().should('be.visible');
         AclManagementSteps.getAclRules().should('have.length', 5);

package/e2e-legacy/setup/jdbc/jdbc-create.spec.js

@@ -64,7 +64,7 @@ describe('JDBC configuration', () => {
         JdbcCreateSteps.clickOnPreviewButton();
 
         // Then I expect to see loader,
-        ApplicationSteps.geLoader().should('contain', 'Preview of first 100 rows of table');
+        ApplicationSteps.getLoader().should('contain', 'Preview of first 100 rows of table');
         // and see the generated preview.
         YasrSteps.getResults().should('be.visible');
     });

package/e2e-legacy/setup/settings/my-settings-initial-state.spec.js

@@ -20,14 +20,10 @@ function verifyInitialState(repositoryId) {
   SettingsSteps.getSparqlEditorPanel().should('be.visible');
   SettingsSteps.getSameAsToggle().should('be.checked');
   SettingsSteps.getSameAsLabel().should('be.visible')
-    .and('contain', 'Expand results over owl:SameAs is')
-    .find('.tag').should('be.visible')
-    .and('contain', 'ON');
+    .and('contain', 'Expand results over owl:SameAs');
   SettingsSteps.getInferenceToggle().should('be.checked');
   SettingsSteps.getInferenceLabel().should('be.visible')
-    .and('contain', 'Inference is')
-    .find('.tag').should('be.visible')
-    .and('contain', 'ON');
+    .and('contain', 'Enable inference');
   SettingsSteps.getCountCheckbox().should('be.checked');
   SettingsSteps.getIgnoreSharedCheckbox().should('not.be.checked');
 

package/e2e-legacy/setup/settings/my-settings.spec.js

@@ -188,7 +188,7 @@ describe('My Settings', () => {
         cy.get('.login-credentials').should('be.visible');
         cy.get('#wb-user-username').should('be.visible')
             .and('have.value', 'admin')
-            .and('have.attr', 'readonly', 'readonly');
+            .and('be.disabled');
     }
 
     function clickLabelBtn(btnId) {