graphdb-workbench-tests 3.4.0-TR2 → 3.4.0-TR4

package/{e2e-legacy/setup/users-and-access → integration/setup}/user-and-access.spec.js

@@ -1,37 +1,34 @@
-import {UserAndAccessSteps} from '../../../steps/setup/user-and-access-steps';
-import {RepositoriesStubs} from '../../../stubs/repositories/repositories-stubs';
-import {RepositorySelectorSteps} from '../../../steps/repository-selector-steps';
-import {ModalDialogSteps} from '../../../steps/modal-dialog-steps';
-import {ToasterSteps} from '../../../steps/toaster-steps';
-import HomeSteps from '../../../steps/home-steps';
-import {LoginSteps} from '../../../steps/login-steps';
-import {MainMenuSteps} from '../../../steps/main-menu-steps';
-import {SecurityStubs} from '../../../stubs/security-stubs.js';
+import {UserAndAccessSteps} from "../../steps/setup/user-and-access-steps";
+import {RepositoriesStubs} from "../../stubs/repositories/repositories-stubs";
+import {RepositorySelectorSteps} from "../../steps/repository-selector-steps";
+import {ModalDialogSteps} from "../../steps/modal-dialog-steps";
+import {ToasterSteps} from "../../steps/toaster-steps";
+import HomeSteps from "../../steps/home-steps";
+import {LoginSteps} from "../../steps/login-steps";
+
 
 describe('User and Access', () => {
 
-    const PASSWORD = 'password';
-    const ROLE_USER = '#roleUser';
-    const ROLE_REPO_MANAGER = '#roleRepoAdmin';
-    const ROLE_CUSTOM_ADMIN = '#roleAdmin';
-    const DEFAULT_ADMIN_PASSWORD = 'root';
+    const PASSWORD = "password";
+    const ROLE_USER = "#roleUser";
+    const ROLE_REPO_MANAGER = "#roleRepoAdmin";
+    const ROLE_CUSTOM_ADMIN = "#roleAdmin";
+    const DEFAULT_ADMIN_PASSWORD = "root";
 
-    // eslint-disable-next-line no-undef
     context('', () => {
-        const user = 'user';
+        const user = "user";
 
         beforeEach(() => {
             UserAndAccessSteps.visit();
+            cy.window();
             // Users table should be visible
             UserAndAccessSteps.getUsersTable().should('be.visible');
-            cy.switchOffSecurity(true);
         });
 
         afterEach(() => {
-            cy.loginAsAdmin().then(() => {
+            cy.loginAsAdmin().then(()=> {
                 cy.deleteUser(user, true);
                 cy.switchOffSecurity(true);
-                cy.switchOffFreeAccess(false);
             });
         });
 
@@ -87,57 +84,22 @@ describe('User and Access', () => {
             // Then the 'create' button should be disabled
             UserAndAccessSteps.getConfirmUserCreateButton().should('be.disabled');
             // And the field should show an error
-            UserAndAccessSteps.getCustomRoleFieldError().should('contain.text', 'Must be at least 2 symbols long');
+            UserAndAccessSteps.getFieldError().should('contain.text', 'Must be at least 2 symbols long');
             // When I add more text to the custom role tag
             UserAndAccessSteps.addTextToCustomRoleField('A{enter}');
             // Then the 'create' button should be enabled
             UserAndAccessSteps.getConfirmUserCreateButton().should('be.enabled');
             // And the field error should not exist
-            UserAndAccessSteps.getCustomRoleFieldError().should('not.be.visible');
+            UserAndAccessSteps.getFieldError().should('not.be.visible');
 
             // When I type an invalid tag
             UserAndAccessSteps.addTextToCustomRoleField('B{enter}');
             // And the field shows an error
-            UserAndAccessSteps.getCustomRoleFieldError().should('contain.text', 'Must be at least 2 symbols long');
+            UserAndAccessSteps.getFieldError().should('contain.text', 'Must be at least 2 symbols long');
             // When I delete the invalid text
             UserAndAccessSteps.addTextToCustomRoleField('{backspace}');
             // Then the error should not be visible
-            UserAndAccessSteps.getCustomRoleFieldError().should('not.be.visible');
-
-            // When I create the user with a valid custom role
-            UserAndAccessSteps.clickWriteAccessAny();
-            SecurityStubs.spyOnUserCreate()
-            UserAndAccessSteps.confirmUserCreate();
-            // Then the user should be created with that custom role
-            cy.wait('@create-user').its('request.body').then((body) => {
-                expect(body).to.deep.eq({
-                    "password": "password",
-                    "grantedAuthorities": [
-                        "ROLE_USER",
-                        "CUSTOM_AA",
-                        "WRITE_REPO_*",
-                        "READ_REPO_*"
-                    ],
-                    "appSettings": {
-                        "DEFAULT_VIS_GRAPH_SCHEMA": true,
-                        "DEFAULT_INFERENCE": true,
-                        "DEFAULT_SAMEAS": true,
-                        "IGNORE_SHARED_QUERIES": false,
-                        "EXECUTE_COUNT": true
-                    }
-                })
-            });
-
-            cy.url().should('include', '/users');
-            UserAndAccessSteps.findUserInTable(user).should('be.visible');
-            UserAndAccessSteps.getUserCustomRoles('@user')
-                .should('have.length', 1)
-                .eq(0).and('have.text', 'AA');
-            // And when I open the edit page for that user, the custom role should be visible in the field without the prefix
-            UserAndAccessSteps.openEditUserPage(user);
-            UserAndAccessSteps.getCustomRoleField().find('.tag-item span')
-                .should('have.length', 1)
-                .eq(0).and('have.text', 'AA');
+            UserAndAccessSteps.getFieldError().should('not.be.visible');
         });
 
         it('Adding a role with a CUSTOM_ prefix shows a warning message', () => {
@@ -155,63 +117,8 @@ describe('User and Access', () => {
             UserAndAccessSteps.getUsersTable().should('be.visible');
             UserAndAccessSteps.getSplashLoader().should('not.be.visible');
         });
+    })
 
-        it('should toggle free access after Admin has logged in', () => {
-            // Given I have available repositories to allow Free Access for
-            RepositoriesStubs.stubRepositories();
-            RepositoriesStubs.stubFreeAccess();
-            // When I enable security
-            UserAndAccessSteps.toggleSecurity();
-            // When I log in as an Admin
-            LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
-            // Then the page should load
-            UserAndAccessSteps.getSplashLoader().should('not.be.visible');
-            UserAndAccessSteps.getUsersTable().should('be.visible');
-            // The Free Access toggle should be OFF
-            UserAndAccessSteps.getFreeAccessSwitchInput().should('not.be.checked');
-            // When I toggle Free Access ON
-            UserAndAccessSteps.toggleFreeAccess();
-            // And I allow free access to a repository
-            ModalDialogSteps.getDialog().should('be.visible');
-            // Then I click OK in the modal
-            ModalDialogSteps.clickOKButton();
-            // Then the toggle button should be ON
-            UserAndAccessSteps.getFreeAccessSwitchInput().should('be.checked');
-            // And I should see a success message
-            ToasterSteps.verifySuccess('Free access has been enabled.');
-            ToasterSteps.getToast().should('not.exist');
-            UserAndAccessSteps.getUsersTable().should('be.visible');
-            // When I toggle Free Access OFF
-            UserAndAccessSteps.toggleFreeAccess();
-            // Then I should see a success message
-            ToasterSteps.getToast().should('exist');
-            ToasterSteps.getToasterMessage().should('contain', 'Free access has been disabled.');
-        });
-
-        it('should redirect to previous page after logout and then login', () => {
-            UserAndAccessSteps.toggleSecurity();
-            LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
-            MainMenuSteps.clickOnSparqlMenu();
-            cy.url().should('include', '/sparql');
-
-            LoginSteps.logout();
-            cy.url().should('include', '/login');
-            LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
-            cy.url().should('include', '/sparql');
-        });
-
-        it('should redirect to correct return url when user is authenticated and on login page', () => {
-            UserAndAccessSteps.visit();
-            UserAndAccessSteps.toggleSecurity();
-            LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
-            UserAndAccessSteps.getUsersTable().should('be.visible');
-
-            cy.visit('/login?r=%252Fsparql');
-            cy.reload();
-            UserAndAccessSteps.getUrl().should('include', '/sparql');
-        });
-    });
-    // eslint-disable-next-line no-undef
     context('GraphQL only', () => {
         let repositoryId1;
         let repositoryId2;
@@ -239,7 +146,6 @@ describe('User and Access', () => {
                 cy.deleteRepository(repositoryId2, true);
                 cy.deleteRepository(repositoryId3, true);
                 cy.deleteUser(graphqlUser, true);
-                cy.switchOffFreeAccess(true);
                 cy.switchOffSecurity(true);
             });
 
@@ -250,8 +156,7 @@ describe('User and Access', () => {
             createUser(graphqlUser, PASSWORD, ROLE_USER, {read: true, graphql: true, repoName: repositoryId2});
         });
 
-        // Fails for unknown reason only in CI
-        it.skip('Can create user with different auth combinations', () => {
+        it('Can create user with different auth combinations', () => {
             cy.wait('@getRepositories');
             // WHEN I create a user with read + GraphQL for repository #2
             createUser(graphqlUser, PASSWORD, ROLE_USER, {read: true, graphql: true, repoName: repositoryId2});
@@ -292,8 +197,7 @@ describe('User and Access', () => {
             assertUserAuths(graphqlUser, {repo: repositoryId3, read: false, write: true, graphql: true});
         });
 
-        // TODO remove skipped flag from all tests after merge of https://github.com/Ontotext-AD/graphdb-workbench/pull/2042
-        it.skip('Should have access to 5 pages when have graphql only rights', () => {
+        it('Should have access to 5 pages when have graphql only rights', () => {
             cy.wait('@getRepositories');
             // WHEN I create a user with read + GraphQL for repository #2
             createUser(graphqlUser, PASSWORD, ROLE_USER, {readWrite: true, graphql: true, repoName: repositoryId1});
@@ -311,7 +215,7 @@ describe('User and Access', () => {
             });
         });
 
-        it.skip('Should not have access endpoints management when have read graphql only rights', () => {
+        it('Should not have access endpoints management when have read graphql only rights', () => {
             cy.wait('@getRepositories');
             // WHEN I create a user with read + GraphQL for repository #2
             createUser(graphqlUser, PASSWORD, ROLE_USER, {read: true, graphql: true, repoName: repositoryId1});
@@ -329,7 +233,7 @@ describe('User and Access', () => {
             });
         });
 
-        it.skip('Should have all access to endpoints management when have REPO_MANAGER role', () => {
+        it('Should have all access to endpoints management when have REPO_MANAGER role', () => {
             cy.wait('@getRepositories');
             createUser(graphqlUser, PASSWORD, ROLE_REPO_MANAGER);
             //enable security
@@ -345,12 +249,12 @@ describe('User and Access', () => {
             });
         });
 
-        it.skip('Can have Free Access and GraphQL working together', () => {
+        it('Can have Free Access and GraphQL working together', () => {
             cy.wait('@getRepositories');
             //enable security
             UserAndAccessSteps.toggleSecurity();
             //login with the admin
-            LoginSteps.loginWithUser('admin', DEFAULT_ADMIN_PASSWORD);
+            LoginSteps.loginWithUser("admin", DEFAULT_ADMIN_PASSWORD);
             // The Free Access toggle should be OFF
             UserAndAccessSteps.getFreeAccessSwitchInput().should('not.be.checked');
             // When I toggle Free Access ON
@@ -374,14 +278,14 @@ describe('User and Access', () => {
             //  I change the repository to this with GraphQL only rights
             RepositorySelectorSteps.selectRepository(repositoryId3);
             // Then I should have GraphQL only rights
-            FREE_ACCESS_MENU_ITEMS_WITHOUT_GRAPHQL.forEach(({path, expectedUrl, checks, expectedTitle}) => {
+            FREE_ACCESS_MENU_ITEMS_WITHOUT_GRAPHQL.forEach(({path, expectedUrl,  checks, expectedTitle}) => {
                 navigateMenuPath(path, expectedUrl, expectedTitle);
                 if (checks) {
                     runChecks(checks);
                 }
             });
             // Turn free access off
-            cy.loginAsAdmin().then(() => {
+            cy.loginAsAdmin().then(()=> {
                 cy.switchOffFreeAccess(true);
             });
         });
@@ -391,7 +295,7 @@ describe('User and Access', () => {
         if (repoName === '*') {
             UserAndAccessSteps.clickGraphqlAccessAny();
         } else {
-            UserAndAccessSteps.clickGraphqlAccessRepo(repoName);
+           UserAndAccessSteps.clickGraphqlAccessRepo(repoName);
         }
     }
 
@@ -419,7 +323,7 @@ describe('User and Access', () => {
         UserAndAccessSteps.selectRoleRadioButton(role);
         UserAndAccessSteps.getRoleRadioButton(role).should('be.checked');
 
-        if (role === '#roleUser') {
+        if (role === "#roleUser") {
             setRoles(opts);
             UserAndAccessSteps.confirmUserCreate();
         } else if (role === ROLE_CUSTOM_ADMIN && opts.noPassword) {
@@ -457,7 +361,6 @@ describe('User and Access', () => {
     function testForUser(name, isAdmin) {
         //enable security
         UserAndAccessSteps.toggleSecurity();
-        LoginSteps.visitLoginPageWithReturnUrl('/users');
         //login new user
         LoginSteps.loginWithUser(name, PASSWORD);
         //verify permissions
@@ -465,7 +368,7 @@ describe('User and Access', () => {
         if (isAdmin) {
             UserAndAccessSteps.getUsersTable().should('be.visible');
         } else {
-            UserAndAccessSteps.getPermissionError().should('contain',
+            UserAndAccessSteps.getError().should('contain',
                 'You have no permission to access this functionality with your current credentials.');
         }
     }
@@ -473,7 +376,7 @@ describe('User and Access', () => {
     function assertUserAuths(username, {repo, read = false, write = false, graphql = false} = {}) {
         UserAndAccessSteps.findUserRowAlias(username, 'userRow');
 
-        if (!read && !write) {
+        if(!read && !write) {
             return UserAndAccessSteps.getRepoLine('@userRow', repo).should('not.exist');
         }
 
@@ -516,9 +419,9 @@ describe('User and Access', () => {
     function navigateMenuPath(pathArray, expectedUrl, expectedTitle) {
         pathArray.forEach((label, index) => {
             if (index === 0) {
-                MainMenuSteps.clickOnMenu(label);
+                UserAndAccessSteps.clickMenuItem(label);
             } else {
-                MainMenuSteps.clickOnSubMenu(label);
+                UserAndAccessSteps.clickSubmenuItem(label);
                 const title = expectedTitle ? expectedTitle : label;
                 cy.get('h1').should('contain', title);
             }
@@ -531,7 +434,6 @@ describe('User and Access', () => {
 
     function runChecks(checks = {}) {
         Object.entries(checks).forEach(([selector, assertions]) => {
-            // eslint-disable-next-line cypress/no-assigning-return-values
             let chain = cy.get(selector);
 
             // assertions is an array, e.g. ["exist", ["contain.text", "Hello"], "be.visible"]
@@ -559,59 +461,59 @@ describe('User and Access', () => {
 
     const noAuthChecks = {
         'div[role="main]': [
-            'not.exist',
+            'not.exist'
         ],
         '.no-authority-panel .alert-warning': [
             'be.visible',
             ['contains.text', 'Some functionalities are not available because'],
-            ['contains.text', 'you do not have the required repository permissions.'],
-        ],
-    };
+            ['contains.text', 'you do not have the required repository permissions.']
+        ]
+    }
 
     const hasAuthChecks = {
         'div[role="main"]': [
             'exist',
-            'be.visible',
+            'be.visible'
         ],
         '.no-authority-panel .alert-warning': [
-            'not.exist',
-        ],
-    };
+            'not.exist'
+        ]
+    }
 
     const MENU_ITEMS_WITHOUT_GRAPHQL = [
         // 1) Import
         {
             path: ['Import'],
             expectedUrl: '/import',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 2) Explore
         {
             path: ['Explore', 'Graphs overview'],
             expectedUrl: '/graphs',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Class hierarchy'],
             expectedUrl: '/hierarchy',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Class relationships'],
             expectedUrl: '/relationships',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Visual graph'],
             expectedUrl: '/graphs-visualizations',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Similarity'],
             expectedTitle: 'Similarity indexes',
             expectedUrl: '/similarity',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 3) SPARQL
@@ -619,7 +521,7 @@ describe('User and Access', () => {
             path: ['SPARQL'],
             expectedTitle: 'SPARQL Query & Update',
             expectedUrl: '/sparql',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 4) GraphQL
@@ -629,7 +531,7 @@ describe('User and Access', () => {
             path: ['Monitor', 'Queries and Updates'],
             expectedUrl: '/monitor/queries',
             expectedTitle: 'Query and Update monitoring',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 6) Setup
@@ -637,58 +539,58 @@ describe('User and Access', () => {
             path: ['Setup', 'My Settings'],
             expectedUrl: '/settings',
             expectedTitle: 'Settings',
-            checks: hasAuthChecks,
+            checks: hasAuthChecks
         },
         {
             path: ['Setup', 'Connectors'],
             expectedUrl: '/connectors',
             expectedTitle: 'Connector management',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Cluster'],
             expectedUrl: '/cluster',
             expectedTitle: 'Cluster management',
-            checks: hasAuthChecks,
+            checks: hasAuthChecks
         },
         {
             path: ['Setup', 'Plugins'],
             expectedUrl: '/plugins',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Namespaces'],
             expectedUrl: '/namespaces',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Autocomplete'],
             expectedUrl: '/autocomplete',
             expectedTitle: 'Autocomplete index',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'RDF Rank'],
             expectedUrl: '/rdfrank',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'JDBC'],
             expectedUrl: '/jdbc',
             expectedTitle: 'JDBC configuration',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'SPARQL Templates'],
             expectedUrl: '/sparql-templates',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 7) Lab
         {
             path: ['Lab', 'Talk to Your Graph'],
             expectedUrl: '/ttyg',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 8) Help
@@ -696,38 +598,38 @@ describe('User and Access', () => {
             path: ['Help', 'REST API'],
             expectedUrl: '/webapi',
             expectedTitle: 'REST API documentation',
-            checks: hasAuthChecks,
-        },
+            checks: hasAuthChecks
+        }
     ];
 
     const GRAPHQL_READ_MENU_ITEMS = [
         {
             path: ['GraphQL', 'GraphQL Playground'],
             expectedUrl: '/graphql/playground',
-            checks: hasAuthChecks,
-        },
+            checks: hasAuthChecks
+        }
     ];
     const GRAPHQL_REPO_MANAGER_MENU_ITEMS = [
         {
             path: ['GraphQL', 'Endpoint Management'],
             expectedUrl: '/graphql/endpoints',
-            checks: hasAuthChecks,
+            checks: hasAuthChecks
         },
         {
             path: ['GraphQL', 'GraphQL Playground'],
             expectedUrl: '/graphql/playground',
-            checks: hasAuthChecks,
+            checks: hasAuthChecks
         },
         {
             path: ['Monitor', 'Backup and Restore'],
             expectedUrl: '/monitor/backup-and-restore',
-            checks: hasAuthChecks,
+            checks: hasAuthChecks
         },
         {
             path: ['Help', 'Interactive guides'],
             expectedUrl: '/guides',
-            checks: hasAuthChecks,
-        },
+            checks: hasAuthChecks
+        }
     ];
 
     const FREE_ACCESS_MENU_ITEMS_WITHOUT_GRAPHQL = [
@@ -735,35 +637,35 @@ describe('User and Access', () => {
         {
             path: ['Import'],
             expectedUrl: '/import',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 2) Explore
         {
             path: ['Explore', 'Graphs overview'],
             expectedUrl: '/graphs',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Class hierarchy'],
             expectedUrl: '/hierarchy',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Class relationships'],
             expectedUrl: '/relationships',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Visual graph'],
             expectedUrl: '/graphs-visualizations',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Explore', 'Similarity'],
             expectedTitle: 'Similarity indexes',
             expectedUrl: '/similarity',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 3) SPARQL
@@ -771,47 +673,48 @@ describe('User and Access', () => {
             path: ['SPARQL'],
             expectedTitle: 'SPARQL Query & Update',
             expectedUrl: '/sparql',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
+
         // 6) Setup
         {
             path: ['Setup', 'Connectors'],
             expectedUrl: '/connectors',
             expectedTitle: 'Connector management',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Plugins'],
             expectedUrl: '/plugins',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Namespaces'],
             expectedUrl: '/namespaces',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'Autocomplete'],
             expectedUrl: '/autocomplete',
             expectedTitle: 'Autocomplete index',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'RDF Rank'],
             expectedUrl: '/rdfrank',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'JDBC'],
             expectedUrl: '/jdbc',
             expectedTitle: 'JDBC configuration',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
         {
             path: ['Setup', 'SPARQL Templates'],
             expectedUrl: '/sparql-templates',
-            checks: noAuthChecks,
+            checks: noAuthChecks
         },
 
         // 7) Help
@@ -819,7 +722,7 @@ describe('User and Access', () => {
             path: ['Help', 'REST API'],
             expectedUrl: '/webapi',
             expectedTitle: 'REST API documentation',
-            checks: hasAuthChecks,
-        },
+            checks: hasAuthChecks
+        }
     ];
 });