grafast 0.1.1-beta.12 → 0.1.1-beta.13

package/dist/engine/OperationPlan.js

@@ -1118,6 +1118,7 @@ class OperationPlan {
         // PERF: this should be handled in the parent?
         const parentStep = this.stepTracker.getStepById(rawParentStep.id);
         const previousStepCount = this.stepTracker.stepCount;
+        const previousSideEffectStep = layerPlan.latestSideEffectStep;
         if (this.loc !== null)
             this.loc.push(`planField(${path.join(".")})`);
         try {
@@ -1185,6 +1186,7 @@ class OperationPlan {
             }
             try {
                 this.stepTracker.purgeBackTo(previousStepCount);
+                layerPlan.latestSideEffectStep = previousSideEffectStep;
             }
             catch (e2) {
                 console.error(`Cleanup error occurred whilst trying to recover from field planning error: ${e2.stack}`);

package/dist/step.js

@@ -110,23 +110,49 @@ class ExecutableStep extends BaseStep {
         this.implicitSideEffectStep = null;
         this.hasSideEffects ??= false;
         let hasSideEffects = false;
+        const stepTracker = this.layerPlan.operationPlan.stepTracker;
         Object.defineProperty(this, "hasSideEffects", {
             get() {
                 return hasSideEffects;
             },
             set(value) {
-                if (this.id ===
-                    this.layerPlan.operationPlan.stepTracker.stepCount - 1) {
+                /**
+                 * If steps were created after this step, an this step doesn't depend
+                 * on them, then it's no longer safe to change hasSideEffects.
+                 */
+                let nonDependentSteps = null;
+                const maxStepId = stepTracker.stepCount - 1;
+                if (this.id === maxStepId) {
+                    // All good - no more steps were created
+                }
+                else {
+                    // If the step created them during initialization and is dependent on
+                    // them, that's fine too.
+                    for (let id = this.id + 1; id <= maxStepId; id++) {
+                        const step = stepTracker.getStepById(id);
+                        if ((0, utils_js_1.stepADependsOnStepB)(this, step))
+                            continue;
+                        if (nonDependentSteps === null) {
+                            nonDependentSteps = [step];
+                        }
+                        else {
+                            nonDependentSteps.push(step);
+                        }
+                    }
+                }
+                if (nonDependentSteps === null) {
                     hasSideEffects = value;
                     if (value === true) {
                         this.layerPlan.latestSideEffectStep = this;
                     }
                     else if (value !== true && hasSideEffects === true) {
-                        throw new Error(`Cannot mark a step has having no side effects after having set it to have side effects.`);
+                        throw new Error(`Cannot mark ${this} as having no side effects after having set it to have side effects.`);
                     }
                 }
                 else {
-                    throw new Error("You must mark a step as having side effects immediately after creating it, before any other steps are created.");
+                    throw new Error(`Attempted to mark ${this} as having side effects, but other non-dependent steps (${nonDependentSteps
+                        .map(String)
+                        .join(", ")}) have already been created.`);
                 }
             },
             enumerable: true,

package/dist/version.d.ts

@@ -1,2 +1,2 @@
-export declare const version = "0.1.1-beta.12";
+export declare const version = "0.1.1-beta.13";
 //# sourceMappingURL=version.d.ts.map

package/dist/version.js

@@ -2,5 +2,5 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.version = void 0;
 // This file is autogenerated by /scripts/postversion.mjs
-exports.version = "0.1.1-beta.12";
+exports.version = "0.1.1-beta.13";
 //# sourceMappingURL=version.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "grafast",
-  "version": "0.1.1-beta.12",
+  "version": "0.1.1-beta.13",
   "description": "Cutting edge GraphQL planning and execution engine",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",