gowalk-cicd 1.0.97 → 1.0.98

package/CLAUDE.md

@@ -227,6 +227,12 @@ node /path/to/gowalk-cicd/bin/cli.mjs
   is the only place that decides which; every downstream step branches on the
   `project_kind` output rather than re-sniffing the repo. Flutter wins the tie
   because a Flutter app also carries `android/settings.gradle`.
+- Both Android release compilers run through `android_build_diagnostics.py` inside the
+  existing proxy wrapper. It retains at most 64 KiB of private child output and publishes
+  only fixed signal names, phase and exit status in `android_build_failed`. An empty signal
+  list is unclassified, never a guessed cause; matching signals are observations, not a retry
+  decision. Minute progress notices replace raw compiler output. Preserve the actual exit,
+  command arguments, proxy environment, signing and symbol checks.
 - iOS plist stamping reads complete JSON build settings through `resolve_info_plist.py`,
   preserving Xcode's exit status and bounded sanitized stderr. Select exactly the configured
   bundle's application target and resolve paths from that target's source root; never take

package/README.md

@@ -314,6 +314,12 @@ the situation and whose **message** is one line of JSON carrying a versioned
 | `source_maintenance_pending` | `gowalk-cicd/source-maintenance-pending.v1` | `repo`, `base_sha`, `head_sha`, `branch`, `run_id` |
 | `apple_build_upload_failed` (error) | `gowalk-cicd/apple-build-upload-failed.v2` | `category`, `stage`, `receipt_available`, receipt identifiers (`cfBundleVersion`, `upload_id`, `file_id`, `state`, `provider_status`, `provider_code`, `provider_pointer`), `action` |
 | `flutter_download_failed` (error) | `gowalk-cicd/flutter-download-failed.v1` | `phase`, `curl_exit`, `http_status`, `proxy_status`, `attempts`, `retained_bytes` |
+| `android_build_failed` (error) | `gowalk-cicd/android-build-failed.v1` | `phase`, `exit_code`, `signals` (fixed observed patterns; empty means unclassified) |
+
+Android release compilers retain only a bounded private output window. Their failure signals
+describe observed error patterns, not retry permission or a unique root cause. Silent builds
+emit `android_build_progress` notices (`gowalk-cicd/android-build-progress.v1`) every minute
+with `phase` and `elapsed_seconds`; successful compiler output is not republished.
 
 SDK transfers also emit `flutter_download_progress` notices with schema
 `gowalk-cicd/flutter-download-progress.v1`. Each carries `phase`, `event`, `elapsed_ms`

package/action/.daemux-version

@@ -1 +1 @@
-1.0.97
+1.0.98

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.97
+1.0.98

package/android-action/action.yml

@@ -178,7 +178,9 @@ runs:
             *) echo "::error::dart-defines entry '$define' is not KEY=VALUE"; exit 1 ;;
           esac
         done
-        python3 "${{ github.action_path }}/scripts/play_store_proxy.py" -- flutter "${args[@]}"
+        python3 "${{ github.action_path }}/scripts/play_store_proxy.py" -- \
+          python3 "${{ github.action_path }}/scripts/android_build_diagnostics.py" --phase flutter_bundle -- \
+          flutter "${args[@]}"
         if ! ls "$DART_SYMBOLS_DIR"/*.symbols >/dev/null 2>&1; then
           echo "::error::flutter build wrote no Dart symbol files to $DART_SYMBOLS_DIR;" \
                "a crash from this obfuscated build could never be read. Refusing to ship it."
@@ -267,6 +269,7 @@ runs:
       run: |
         chmod +x ./gradlew
         python3 "${{ github.action_path }}/scripts/play_store_proxy.py" -- \
+          python3 "${{ github.action_path }}/scripts/android_build_diagnostics.py" --phase gradle_bundle -- \
           ./gradlew "${ANDROID_GRADLE_MODULE}:bundleRelease" \
           --init-script "${{ github.action_path }}/scripts/version_override.init.gradle" \
           --console=plain --stacktrace

package/android-action/scripts/android_build_diagnostics.py

@@ -0,0 +1,80 @@
+"""Run one Android compiler with bounded private output and fixed failure signals."""
+import argparse
+import json
+import subprocess
+import sys
+import threading
+import time
+
+LIMIT = 65536
+SIGNALS = {
+    "tls_verification": ("PKIX path building failed", "CERTIFICATE_VERIFY_FAILED", "certificate verify failed"),
+    "dependency_resolution": ("Could not resolve all files", "Could not resolve all artifacts", "Could not GET '"),
+    "connection_timeout": ("Connect timed out", "Read timed out", "Connection timed out"),
+    "kotlin_compilation": ("Compilation error. See log for more details", "Kotlin compilation failed"),
+    "dart_compilation": ("Target kernel_snapshot_program failed", "Target kernel_snapshot failed"),
+    "android_resources": ("Android resource linking failed", "Android resource compilation failed"),
+    "r8_missing_classes": ("Missing classes detected while running R8",),
+    "duplicate_classes": ("Duplicate class ",),
+    "manifest_merge": ("Manifest merger failed",),
+    "signing_configuration": ("Keystore was tampered with", "Keystore file ", "Failed to read key "),
+    "out_of_memory": ("java.lang.OutOfMemoryError", "Java heap space", "GC overhead limit exceeded"),
+    "gradle_daemon_lost": ("Gradle build daemon disappeared unexpectedly",),
+    "disk_full": ("No space left on device",),
+}
+
+
+def signals(output: bytes) -> list[str]:
+    text = output.decode("utf-8", errors="replace")
+    return sorted(name for name, patterns in SIGNALS.items() if any(pattern in text for pattern in patterns))
+
+
+def emit(title: str, level: str, **fields) -> None:
+    print(f"::{level} title={title}::" + json.dumps(fields, separators=(",", ":")), flush=True)
+
+
+def drain(stream, tail: bytearray) -> None:
+    while chunk := stream.read1(8192):
+        tail[:] = (tail + chunk)[-LIMIT:]
+
+
+def run(phase: str, command: list[str], *, interval: float = 60) -> int:
+    started, tail = time.monotonic(), bytearray()
+    try:
+        child = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+    except OSError:
+        emit("android_build_failed", "error", schema="gowalk-cicd/android-build-failed.v1",
+             phase=phase, exit_code=127, signals=["command_start_failed"])
+        return 127
+    reader = threading.Thread(target=drain, args=(child.stdout, tail), daemon=True)
+    reader.start()
+    while True:
+        try:
+            code = child.wait(timeout=interval)
+            break
+        except subprocess.TimeoutExpired:
+            emit("android_build_progress", "notice", schema="gowalk-cicd/android-build-progress.v1",
+                 phase=phase, elapsed_seconds=int(time.monotonic() - started))
+    # A descendant retaining stdout must not hold a finished compiler's result indefinitely.
+    reader.join(timeout=1)
+    if not reader.is_alive():
+        child.stdout.close()
+    if code:
+        emit("android_build_failed", "error", schema="gowalk-cicd/android-build-failed.v1",
+             phase=phase, exit_code=code, signals=signals(bytes(tail)))
+    return code if code >= 0 else 128 - code
+
+
+def main(argv: list[str]) -> int:
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument("--phase", required=True, choices=("flutter_bundle", "gradle_bundle"))
+    parser.add_argument("command", nargs=argparse.REMAINDER)
+    args = parser.parse_args(argv)
+    command = args.command[1:] if args.command[:1] == ["--"] else args.command
+    if not command:
+        parser.error("a build command is required")
+    return run(args.phase, command)
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv[1:]))

package/android-action/scripts/test_android_build_diagnostics.py

@@ -0,0 +1,108 @@
+"""Exercise real child failures without publishing child output or altering its environment."""
+import contextlib
+import io
+import json
+import os
+from pathlib import Path
+import subprocess
+import sys
+import tempfile
+import unittest
+from unittest import mock
+
+import android_build_diagnostics as diagnostics
+import yaml
+from test_jvm_proxy_relay import upstream
+
+
+class BuildDiagnosticsTests(unittest.TestCase):
+    def invoke(self, script, **kwargs):
+        output = io.StringIO()
+        with contextlib.redirect_stdout(output):
+            code = diagnostics.run("flutter_bundle", [sys.executable, "-c", script], **kwargs)
+        rows = [json.loads(line.split("::", 2)[2]) for line in output.getvalue().splitlines()]
+        return code, rows, output.getvalue()
+
+    def test_child_failure_keeps_exit_and_only_fixed_signals(self):
+        code, rows, output = self.invoke(
+            "import sys; print('secret=do-not-publish https://user:password@example.test');"
+            "print('Missing classes detected while running R8'); sys.exit(42)"
+        )
+        self.assertEqual(code, 42)
+        self.assertEqual(rows, [{"schema": "gowalk-cicd/android-build-failed.v1", "phase": "flutter_bundle",
+                                 "exit_code": 42, "signals": ["r8_missing_classes"]}])
+        self.assertNotIn("password", output)
+        self.assertNotIn("do-not-publish", output)
+
+    def test_unknown_failure_never_guesses_or_echoes_output(self):
+        code, rows, output = self.invoke("import sys; print('private provider exception'); sys.exit(1)")
+        self.assertEqual(code, 1)
+        self.assertEqual(rows[0]["signals"], [])
+        self.assertNotIn("private provider", output)
+
+    def test_success_preserves_environment_and_arguments_without_echoing_them(self):
+        with mock.patch.dict(os.environ, {"HTTPS_PROXY": "http://private.invalid:9", "NO_PROXY": ""}):
+            code, rows, output = self.invoke(
+                "import os; assert os.environ['HTTPS_PROXY']=='http://private.invalid:9';"
+                "assert os.environ['NO_PROXY']==''; print('secret successful compiler output')"
+            )
+        self.assertEqual((code, rows, output), (0, [], ""))
+
+    def test_large_output_stays_bounded_and_recent_failures_are_retained(self):
+        tail = bytearray()
+        content = b"secret" * diagnostics.LIMIT + b"Android resource linking failed"
+        with io.BufferedReader(io.BytesIO(content)) as stream:
+            diagnostics.drain(stream, tail)
+        self.assertEqual(len(tail), diagnostics.LIMIT)
+        self.assertEqual(diagnostics.signals(tail), ["android_resources"])
+
+    def test_long_silent_build_emits_only_safe_progress(self):
+        code, rows, _ = self.invoke("import time; time.sleep(.12)", interval=.03)
+        self.assertEqual(code, 0)
+        self.assertTrue(rows)
+        for row in rows:
+            self.assertEqual(row["schema"], "gowalk-cicd/android-build-progress.v1")
+            self.assertEqual(row["phase"], "flutter_bundle")
+
+    def test_missing_program_has_typed_failure_without_argv(self):
+        output = io.StringIO()
+        with contextlib.redirect_stdout(output):
+            code = diagnostics.run("gradle_bundle", ["/missing/private-program"])
+        self.assertEqual(code, 127)
+        self.assertNotIn("private-program", output.getvalue())
+        self.assertIn('"signals":["command_start_failed"]', output.getvalue())
+
+    def test_cli_forwards_exact_argument_vector(self):
+        with mock.patch.object(diagnostics, "run", return_value=7) as run:
+            self.assertEqual(diagnostics.main(["--phase", "gradle_bundle", "--", "./gradlew", "a b"]), 7)
+        run.assert_called_once_with("gradle_bundle", ["./gradlew", "a b"])
+
+    def test_real_release_step_keeps_proxy_and_compiler_arguments_on_failure(self):
+        root = Path(__file__).resolve().parents[1]
+        action = yaml.safe_load((root / "action.yml").read_text())
+        step = next(row for row in action["runs"]["steps"] if row["name"] == "Build release Android App Bundle")
+        with tempfile.TemporaryDirectory() as directory, upstream() as (proxy, _seen):
+            cwd = Path(directory)
+            flutter = cwd / "flutter"
+            flutter.write_text(f"#!{sys.executable}\nimport os,sys,json\nfrom pathlib import Path\n"
+                               "assert os.environ['HTTPS_PROXY'].startswith('http://127.0.0.1:')\n"
+                               "assert os.environ['NO_PROXY']==''\n"
+                               "Path('arguments.json').write_text(json.dumps(sys.argv[1:]))\n"
+                               "print('Missing classes detected while running R8: private-class')\nsys.exit(41)\n")
+            flutter.chmod(0o700)
+            env = {**os.environ, "GOOGLE_STORE_PROXY_URL": proxy, "PATH": directory + os.pathsep + os.environ["PATH"],
+                   "ANDROID_BUILD_NUMBER": "17", "BUILD_NAME": "", "DART_DEFINES": "",
+                   "DART_SYMBOLS_DIR": str(cwd / "symbols"), "NO_PROXY": "*", "HTTPS_PROXY": "http://wrong.invalid"}
+            script = step["run"].replace("${{ github.action_path }}", str(root))
+            result = subprocess.run(["bash", "-eo", "pipefail", "-c", script], cwd=cwd, env=env,
+                                    capture_output=True, text=True, timeout=20)
+            args = json.loads((cwd / "arguments.json").read_text())
+        self.assertEqual(result.returncode, 41, result.stdout + result.stderr)
+        self.assertIn("--obfuscate", args)
+        self.assertIn("--split-debug-info", args)
+        self.assertIn('"signals":["r8_missing_classes"]', result.stdout)
+        self.assertNotIn("private-class", result.stdout + result.stderr)
+
+
+if __name__ == "__main__":
+    unittest.main()

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.97
+1.0.98

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.97",
+  "version": "1.0.98",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {