gowalk-cicd 1.0.89 → 1.0.91

package/CLAUDE.md

@@ -156,11 +156,13 @@ node /path/to/gowalk-cicd/bin/cli.mjs
   consumer autoupdate changes the action directory. The installer delivers this development
   tooling for native iOS repositories too; it does not require an Android app.
 - Flutter manifest/archive GET recovery is scoped to the two pinned setup invocations through `BASH_ENV`.
-  It retains the account proxy and allows four attempts within 60 seconds for manifests or 600 seconds
-  for archives. Interrupted archives resume private partial bytes with HTTP Range; an origin ignoring
+  It retains the account proxy and allows four attempts within 60 seconds for manifests or 20 minutes
+  for archives, with an 8 GiB archive bound. Interrupted archives resume private bytes with HTTP Range; an origin ignoring
   Range permits a bounded full restart. Only complete JSON or an archive matching the selected official
   manifest's SHA-256 enters action outputs. Authentication/certificate refusals remain terminal.
   `flutter_download_failed` emits fixed transport codes and retained-byte counts, never curl stderr.
+  Archive progress emits retained byte counts every minute and safe results after each attempt;
+  the transfer deadline leaves room for a failure receipt before a 30-minute validation job ends.
 - Web Release selects bundled renderer resources with `--no-web-resources-cdn` inside
   the existing proxied build command. This is not a font or integration offline guarantee;
   preserve app-authored font declarations, bootstrap configuration and other build inputs.

package/README.md

@@ -299,6 +299,13 @@ the situation and whose **message** is one line of JSON carrying a versioned
 | `apple_build_upload_failed` (error) | `gowalk-cicd/apple-build-upload-failed.v2` | `category`, `stage`, `receipt_available`, receipt identifiers (`cfBundleVersion`, `upload_id`, `file_id`, `state`, `provider_status`, `provider_code`, `provider_pointer`), `action` |
 | `flutter_download_failed` (error) | `gowalk-cicd/flutter-download-failed.v1` | `phase`, `curl_exit`, `http_status`, `proxy_status`, `attempts`, `retained_bytes` |
 
+SDK transfers also emit `flutter_download_progress` notices with schema
+`gowalk-cicd/flutter-download-progress.v1`. Each carries `phase`, `event`, `elapsed_ms`
+and `retained_bytes`; `attempt_finished` adds `attempt`, `curl_exit`, `http_status`
+and `proxy_status`. In-progress notices arrive each minute; elapsed time belongs to
+the current attempt. Archives have a 20-minute total transfer budget so a failure
+receipt precedes a 30-minute validation job's deadline. Progress is not a success receipt.
+
 Add a field by bumping the schema version; never change the meaning of an
 existing one.
 
@@ -1071,7 +1078,7 @@ reservation is never reused; delete such a reservation only after reading it bac
 All requests and parts still use the Apple proxy.
 
 Flutter SDK setup retries interrupted manifest and archive GETs on the assigned proxy, with four attempts
-within 60 seconds for manifests or 600 seconds for archives. Archive retries resume retained private bytes
+within 60 seconds for manifests or 30 minutes for archives, with an 8 GiB archive bound. Retries resume private bytes
 with HTTP Range; if the origin ignores Range, a bounded full restart is permitted. The completed archive
 must match the selected official manifest's SHA-256 before extraction. Authentication and certificate
 refusals remain terminal. Exhausted transfers emit `flutter_download_failed` with fixed status codes and

package/action/.daemux-version

@@ -1 +1 @@
-1.0.89
+1.0.91

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.89
+1.0.91

package/android-action/scripts/flutter_download.py

@@ -7,8 +7,10 @@ import re
 import shutil
 import subprocess
 import sys
+import time
 
-MAX_ARCHIVE_BYTES = 2147483648
+MAX_ARCHIVE_BYTES = 8 * 1024 * 1024 * 1024
+PROGRESS_SECONDS = 60
 
 
 def archive_digest() -> str:
@@ -20,19 +22,45 @@ def archive_digest() -> str:
 
 def transfer(url: str, destination: Path, kind: str, remaining: float, env: dict) -> tuple[int, int, int]:
     resume = kind == "archive" and destination.stat().st_size > 0
+    budget = min(20 if kind == "manifest" else 600, remaining)
     command = ["curl", "--disable", "--silent", "--show-error", "--fail", "--retry", "0",
-               "--connect-timeout", "15", "--max-time", str(min(20 if kind == "manifest" else 300, remaining)),
+               "--connect-timeout", "15", "--max-time", str(budget),
                "--max-filesize", str(16777216 if kind == "manifest" else MAX_ARCHIVE_BYTES),
                "--output", str(destination), "--write-out", "%{http_code} %{http_connect}"]
     if resume:
         command += ["--continue-at", "-"]
-    try:
-        result = subprocess.run([*command, url], capture_output=True, timeout=remaining, env=env)
-        status = result.stdout.split()
-        http, proxy = (map(int, status) if len(status) == 2 and all(part.isdigit() for part in status) else (0, 0))
-        return result.returncode, http, proxy
-    except subprocess.TimeoutExpired:
-        return 28, 0, 0
+    with subprocess.Popen([*command, url], stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env) as process:
+        try:
+            return wait_transfer(process, destination, kind, budget)
+        finally:
+            if process.poll() is None:
+                process.kill()
+                process.communicate()
+
+
+def wait_transfer(process, destination: Path, kind: str, budget: float) -> tuple[int, int, int]:
+    started = time.monotonic()
+    while True:
+        left = budget - (time.monotonic() - started)
+        if left <= 0:
+            return 28, 0, 0
+        try:
+            output, _private_error = process.communicate(timeout=min(PROGRESS_SECONDS, left))
+            status = output.split()
+            http, proxy = (map(int, status) if len(status) == 2
+                           and all(part.isdigit() for part in status) else (0, 0))
+            return process.returncode, http, proxy
+        except subprocess.TimeoutExpired:
+            if kind == "archive":
+                progress(destination, started, "transferring")
+
+
+def progress(destination: Path, started: float, event: str, **fields) -> None:
+    note = {"schema": "gowalk-cicd/flutter-download-progress.v1", "phase": "archive", "event": event,
+            "elapsed_ms": round((time.monotonic() - started) * 1000),
+            "retained_bytes": destination.stat().st_size, **fields}
+    print("::notice title=flutter_download_progress::" + json.dumps(note, separators=(",", ":")),
+          file=sys.stderr, flush=True)
 
 
 def publish(destination: Path, kind: str) -> None:

package/android-action/scripts/flutter_manifest.py

@@ -22,7 +22,7 @@ def download(arguments: list[str], directory: Path) -> int:
     if kind == "archive":
         flutter_download.archive_digest()
     child_env = {**os.environ, "NO_PROXY": "", "no_proxy": ""}
-    deadline, code, http, proxy_http = time.monotonic() + (60 if kind == "manifest" else 600), 1, 0, 0
+    deadline, code, http, proxy_http = time.monotonic() + (60 if kind == "manifest" else 1200), 1, 0, 0
     destination = directory / "download"
     destination.touch(mode=0o600, exist_ok=False)
     destination.chmod(0o600)
@@ -32,7 +32,11 @@ def download(arguments: list[str], directory: Path) -> int:
         if remaining <= 0:
             break
         attempted = attempt
+        started = time.monotonic()
         code, http, proxy_http = flutter_download.transfer(arguments[-1], destination, kind, remaining, child_env)
+        if kind == "archive":
+            flutter_download.progress(destination, started, "attempt_finished", attempt=attempt,
+                                      curl_exit=code, http_status=http, proxy_status=proxy_http)
         if code == 0 and http in ({200, 206} if kind == "archive" else {200}):
             flutter_download.publish(destination, kind)
             if attempt > 1:

package/android-action/scripts/flutter_manifest_fixture.py

@@ -42,11 +42,12 @@ def response(server, mode, headers, path):
         start = int(requested[6:-1])
         extra = f"Content-Range: bytes {start}-{len(complete) - 1}/{len(complete)}\r\n".encode()
         complete, status = complete[start:], b"206 Partial Content"
-    body = complete[:31] if mode in {"partial", "range_partial"} else complete
+    body = complete[:31] if mode in {"partial", "range_partial", "large_partial", "too_large"} else complete
     if mode == "range_corrupt":
         body = bytes([body[0] ^ 1]) + body[1:]
+    size = {"large_partial": 2 * 1024 ** 3 + 1, "too_large": 9 * 1024 ** 3}.get(mode, len(complete))
     return (b"HTTP/1.1 " + status + b"\r\n" + extra + b"Content-Length: "
-            + str(len(complete)).encode() + b"\r\nConnection: close\r\n\r\n" + body)
+            + str(size).encode() + b"\r\nConnection: close\r\n\r\n" + body)
 
 
 class Proxy(socketserver.StreamRequestHandler):

package/android-action/scripts/test_flutter_archive_size.py

@@ -0,0 +1,28 @@
+"""Current multi-gigabyte SDK response sizes remain recoverable through the real curl transport."""
+from pathlib import Path
+import tempfile
+import unittest
+
+import test_flutter_archive as archive_fixture
+from flutter_manifest_fixture import tls_proxy
+
+
+class ArchiveSizeTests(unittest.TestCase):
+    def test_advertised_sdk_size_above_two_gib_does_not_prevent_recovery(self):
+        with tempfile.TemporaryDirectory() as directory:
+            root = Path(directory)
+            with tls_proxy(root, ["large_partial", "range"], archive_fixture.ARCHIVE) as (server, cert):
+                result = archive_fixture.ArchiveRecoveryTests().invoke(root, server, cert)
+                self.assertEqual((result.returncode, result.stdout), (0, archive_fixture.ARCHIVE))
+                self.assertEqual(server.ranges, ["", "bytes=31-"])
+
+    def test_archive_size_limit_still_refuses_oversized_transfers(self):
+        with tempfile.TemporaryDirectory() as directory:
+            root = Path(directory)
+            with tls_proxy(root, ["too_large"], archive_fixture.ARCHIVE) as (server, cert):
+                result = archive_fixture.ArchiveRecoveryTests().invoke(root, server, cert)
+                self.assertEqual((result.returncode, result.stdout, server.connects), (63, b"", 1))
+
+
+if __name__ == "__main__":
+    unittest.main()

package/android-action/scripts/test_flutter_download_budget.py

@@ -0,0 +1,42 @@
+"""Archive failure remains observable before the consumer's 30-minute validation job expires."""
+import contextlib
+import io
+import json
+import os
+from pathlib import Path
+import tempfile
+import unittest
+from unittest.mock import patch
+
+import flutter_manifest
+
+
+class DownloadBudgetTests(unittest.TestCase):
+    def test_failed_archive_reports_before_the_outer_job_cancels_it(self):
+        elapsed = [0.0]
+
+        def transfer(_url, destination, _kind, remaining, _env):
+            elapsed[0] += min(600, remaining)
+            with destination.open("ab") as output:
+                output.write(b"partial")
+            return 28, 200, 200
+
+        with tempfile.TemporaryDirectory() as directory, contextlib.redirect_stderr(io.StringIO()) as error:
+            with patch.dict(os.environ, HTTPS_PROXY="http://fixture-user:fixture-secret@localhost:1",
+                            GOWALK_FLUTTER_ARCHIVE_SHA256="a" * 64):
+                with patch.object(flutter_manifest.time, "monotonic", side_effect=lambda: elapsed[0]), \
+                        patch.object(flutter_manifest.time, "sleep", side_effect=lambda seconds: None), \
+                        patch.object(flutter_manifest.flutter_download, "transfer", side_effect=transfer):
+                    result = flutter_manifest.download(["--connect-timeout", "15", "--retry", "5",
+                        "https://fixture.invalid/flutter_infra_release/releases/stable/linux/sdk.tar.xz"],
+                        Path(directory))
+        self.assertEqual(result, 28)
+        self.assertLess(elapsed[0], 1800 - 60, "A failure receipt must precede the enclosing job deadline")
+        receipt = next(line.split("::", 2)[2] for line in error.getvalue().splitlines()
+                       if line.startswith("::error title=flutter_download_failed::"))
+        self.assertGreater(json.loads(receipt)["retained_bytes"], 0)
+        self.assertNotIn("fixture-secret", error.getvalue())
+
+
+if __name__ == "__main__":
+    unittest.main()

package/android-action/scripts/test_flutter_transfer_progress.py

@@ -0,0 +1,81 @@
+"""Private child transfers expose byte progress and terminate within their own deadline."""
+import contextlib
+import io
+import json
+import os
+from pathlib import Path
+import subprocess
+import sys
+import tempfile
+import time
+import unittest
+from unittest.mock import patch
+
+import flutter_download
+
+
+class TransferProgressTests(unittest.TestCase):
+    def invoke(self, script, remaining):
+        children = []
+        popen = subprocess.Popen
+        with tempfile.TemporaryDirectory() as directory, contextlib.redirect_stderr(io.StringIO()) as error:
+            destination = Path(directory) / "archive"
+            destination.touch()
+
+            def child(_command, **kwargs):
+                process = popen([sys.executable, "-c", script, str(destination)], **kwargs)
+                children.append(process)
+                return process
+
+            with patch.object(flutter_download.subprocess, "Popen", side_effect=child), \
+                    patch.object(flutter_download, "PROGRESS_SECONDS", .03):
+                result = flutter_download.transfer("https://fixture.invalid/sdk.tar.xz", destination,
+                                                   "archive", remaining, dict(os.environ))
+            data = destination.read_bytes()
+        self.assertTrue(all(process.poll() is not None for process in children))
+        self.assertNotIn("fixture-secret", error.getvalue())
+        notices = [json.loads(line.split("::", 2)[2]) for line in error.getvalue().splitlines()]
+        self.assertTrue(notices)
+        self.assertTrue(any(note["retained_bytes"] > 0 for note in notices))
+        self.assertTrue(all(note["event"] == "transferring" for note in notices))
+        return result, data
+
+    def test_progress_does_not_publish_private_child_stderr_or_partial_archive(self):
+        script = ("import pathlib,sys,time; p=pathlib.Path(sys.argv[1]); p.write_bytes(b'partial'); "
+                  "sys.stderr.write('fixture-secret'); time.sleep(.2); p.write_bytes(b'complete'); "
+                  "print('206 200',end='')")
+        result, data = self.invoke(script, 2)
+        self.assertEqual((result, data), ((0, 206, 200), b"complete"))
+
+    def test_deadline_kills_only_the_owned_transfer_and_preserves_resume_bytes(self):
+        script = ("import pathlib,sys,time; pathlib.Path(sys.argv[1]).write_bytes(b'partial'); "
+                  "sys.stderr.write('fixture-secret'); time.sleep(5)")
+        started = time.monotonic()
+        result, data = self.invoke(script, .2)
+        self.assertLess(time.monotonic() - started, 2)
+        self.assertEqual((result, data), ((28, 0, 0), b"partial"))
+
+    def test_progress_failure_does_not_leave_the_owned_child_running(self):
+        popen, children = subprocess.Popen, []
+
+        def child(_command, **kwargs):
+            process = popen([sys.executable, "-c", "import time; time.sleep(5)"], **kwargs)
+            children.append(process)
+            return process
+
+        started = time.monotonic()
+        with tempfile.TemporaryDirectory() as directory:
+            destination = Path(directory) / "archive"
+            destination.touch()
+            with patch.object(flutter_download.subprocess, "Popen", side_effect=child), \
+                    patch.object(flutter_download, "PROGRESS_SECONDS", .03), \
+                    patch.object(flutter_download, "progress", side_effect=OSError("closed output")):
+                with self.assertRaises(OSError):
+                    flutter_download.transfer("https://fixture.invalid/sdk.tar.xz", destination,
+                                              "archive", 2, dict(os.environ))
+        self.assertLess(time.monotonic() - started, 2)
+        self.assertTrue(all(process.poll() is not None for process in children))
+
+
+if __name__ == "__main__":
+    unittest.main()

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.89
+1.0.91

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.89",
+  "version": "1.0.91",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {