gowalk-cicd 1.0.86 → 1.0.87

package/CLAUDE.md

@@ -125,6 +125,7 @@ node /path/to/gowalk-cicd/bin/cli.mjs
   `certificate-cap-policy` accepts only `fail`; a full cap requires registry reconciliation.
   A certificate POST's HTTP 409 alone does not prove a full cap. `certificate_failure.py`
   emits fixed reason/code evidence in `apple_certificate_rejected`; raw provider details stay private.
+  Certificate creation sends the complete PEM CSR in `csrContent`, including its framing and newlines.
 - Keep preinstalled Android SDK/NDKs. Every Gradle test/build and SDK download runs
   under `play_store_proxy.py --`, whose owned loopback relay gives Java an explicit
   authenticated account exit without credentials in JVM options. The child HTTP_PROXY

package/README.md

@@ -852,6 +852,7 @@ common ones:
 | `ai-metadata` | `false` to disable AI auto-fill of empty ASC metadata |
 | `ai-metadata-model` | GitHub Models model id (default `openai/gpt-4o`) |
 
+Certificate creation sends the complete PEM CSR in Apple's `csrContent` field, including its framing and newlines.
 Certificate creation refusals emit `apple_certificate_rejected` with schema
 `gowalk-cicd/apple-certificate-rejected.v1`, `operation`, `http_status`, `reason` and `error_codes`.
 HTTP 409 is classified as `certificate_limit` only when Apple's returned detail identifies the limit;

package/action/.daemux-version

@@ -1 +1 @@
-1.0.86
+1.0.87

package/action/scripts/cert_factory.py

@@ -35,11 +35,11 @@ def certificate_cap_policy() -> str:
 
 
 def generate_key_and_csr() -> tuple[rsa.RSAPrivateKey, bytes]:
-    """Generate a fresh 2048-bit RSA key + PEM CSR (base64 body only).
+    """Generate a fresh 2048-bit RSA key and complete PEM CSR.
 
     Returns the private key (kept in memory; the caller serialises it
-    into the PKCS12) and the CSR with PEM headers stripped, ready for
-    Apple's ``csrContent`` field.
+    into the PKCS12) and the PEM CSR, including its framing and newlines,
+    for Apple's ``csrContent`` field.
     """
     private_key = rsa.generate_private_key(public_exponent=65537, key_size=2048)
     csr = (
@@ -55,20 +55,17 @@ def generate_key_and_csr() -> tuple[rsa.RSAPrivateKey, bytes]:
         .sign(private_key, hashes.SHA256())
     )
     csr_pem = csr.public_bytes(serialization.Encoding.PEM)
-    csr_payload = b"".join(
-        line for line in csr_pem.splitlines() if not line.startswith(b"-----")
-    )
-    return private_key, csr_payload
+    return private_key, csr_pem
 
 
-def create_distribution_cert(token: str, csr_b64: str) -> tuple[str, bytes]:
+def create_distribution_cert(token: str, csr_pem: str) -> tuple[str, bytes]:
     """POST one CSR; a full team cap preserves every existing certificate."""
     certificate_cap_policy()
     body = {
         "data": {
             "type": "certificates",
             "attributes": {
-                "csrContent": csr_b64,
+                "csrContent": csr_pem,
                 "certificateType": "DISTRIBUTION",
             },
         }

package/action/scripts/prepare_signing.py

@@ -103,9 +103,9 @@ def _load_or_create_cert(
         )
     creds_store.invalidate_cache(creds_dir)
 
-    private_key, csr_b64 = cert_factory.generate_key_and_csr()
+    private_key, csr_pem = cert_factory.generate_key_and_csr()
     cert_id, cert_der = cert_factory.create_distribution_cert(
-        token, csr_b64.decode()
+        token, csr_pem.decode("ascii")
     )
     password = creds_store.P12_PASSWORD
     p12_bytes = cert_factory.serialize_p12(private_key, cert_der, password)

package/action/scripts/test_certificate_request.py

@@ -0,0 +1,62 @@
+"""Verify Apple's PEM request boundary with real CSR, certificate and PKCS12 bytes."""
+from __future__ import annotations
+
+import base64
+import datetime as dt
+import json
+import unittest
+from contextlib import redirect_stdout
+from io import StringIO
+from unittest import mock
+
+import requests
+from cryptography import x509
+from cryptography.hazmat.primitives import hashes, serialization
+from cryptography.hazmat.primitives.serialization import pkcs12
+
+import cert_factory
+
+
+class CertificateRequestTests(unittest.TestCase):
+    def test_generated_pem_has_a_valid_signature_and_matching_public_key(self):
+        key, content = cert_factory.generate_key_and_csr()
+        csr = x509.load_pem_x509_csr(content)
+        self.assertTrue(csr.is_signature_valid)
+        self.assertEqual(csr.public_key().public_numbers(), key.public_key().public_numbers())
+
+    def test_posted_pem_and_returned_certificate_preserve_the_signing_identity(self):
+        key, content = cert_factory.generate_key_and_csr()
+        received = []
+
+        def apple_post(method, path, token, *, json_body, allow_status):
+            self.assertEqual((method, path), ("POST", "/certificates"))
+            attributes = json_body["data"]["attributes"]
+            self.assertEqual(attributes["certificateType"], "DISTRIBUTION")
+            csr = x509.load_pem_x509_csr(attributes["csrContent"].encode("ascii"))
+            self.assertTrue(csr.is_signature_valid)
+            now = dt.datetime.now(dt.timezone.utc)
+            cert = (x509.CertificateBuilder().subject_name(csr.subject).issuer_name(csr.subject)
+                    .public_key(csr.public_key()).serial_number(x509.random_serial_number())
+                    .not_valid_before(now - dt.timedelta(minutes=1))
+                    .not_valid_after(now + dt.timedelta(days=1)).sign(key, hashes.SHA256()))
+            received.append(cert)
+            response = requests.Response()
+            response.status_code = 201
+            response._content = json.dumps({"data": {"id": "TESTCERT", "attributes": {
+                "certificateContent": base64.b64encode(cert.public_bytes(serialization.Encoding.DER)).decode()
+            }}}).encode()
+            return response
+
+        with mock.patch.object(cert_factory, "request", side_effect=apple_post) as request:
+            with redirect_stdout(StringIO()):
+                cert_id, der = cert_factory.create_distribution_cert("test-token", content.decode("ascii"))
+        request.assert_called_once()
+        self.assertEqual(cert_id, "TESTCERT")
+        p12 = cert_factory.serialize_p12(key, der, "test-only-password")
+        restored_key, restored_cert, _ = pkcs12.load_key_and_certificates(p12, b"test-only-password")
+        self.assertEqual(restored_key.public_key().public_numbers(), key.public_key().public_numbers())
+        self.assertEqual(restored_cert.fingerprint(hashes.SHA256()), received[0].fingerprint(hashes.SHA256()))
+
+
+if __name__ == "__main__":
+    unittest.main()

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.86
+1.0.87

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.86
+1.0.87

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.86",
+  "version": "1.0.87",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {