gowalk-cicd 1.0.33 → 1.0.35

package/README.md

@@ -184,11 +184,11 @@ sent for review from the Google Play Console UI.
 ```
 
 That fails the whole upload, so the bundle you just built never reaches Play at
-all. The retry re-uploads with `changesNotSentForReview`, which lands the bundle
-and leaves it waiting, then emits a `::warning::` naming the package. Someone
-then presses **Send changes for review** on that app's Publishing overview page.
-There is no API for that press — it is the one step Google deliberately reserves
-for a human, and no amount of tooling removes it.
+all. After an ordinary fresh-edit retry, the final retry re-uploads with
+`changesNotSentForReview`, which lands the bundle and leaves it waiting, then
+emits a `::warning::` naming the package. The delivery system can then complete
+the console-only **Send changes for review** action through the app's leased
+AdsPower profile.
 
 In the ordinary case the first upload submits normally and the retry is skipped.
 
@@ -204,8 +204,10 @@ long enough outlives one:
 
 Neither says anything about the build, which is signed and retained by that
 point. The upload step therefore runs with `continue-on-error` and a second
-attempt follows when the first fails — a fresh edit succeeds. Both attempts
-failing still fails the job.
+ordinary attempt follows when the first fails. This preserves automatic review
+submission while opening a fresh edit. Only when that retry also fails does a
+third attempt use `changesNotSentForReview`; setting that flag on an ordinary
+app is itself a Play validation error.
 
 One caveat this makes explicit: **nothing else should hold an edit open on the
 same package while a deploy runs.** A script that polls `edits.insert` /
@@ -437,6 +439,13 @@ The iOS composite action runs on `macos-15` and:
 
 The iOS action requires only the p8. Everything else is derived.
 
+Feature-branch runs installed from the standard workflow still archive and
+upload to TestFlight, but pass `manage-app-store-version: 'false'`. This keeps
+branch validation independent of the editable App Store release slot, so a
+build can upload while the current release is locked in review. Default-branch
+runs retain version creation and metadata automation. Direct action callers
+keep the historical behavior because the new input defaults to `true`.
+
 ### App ID capabilities
 
 A provisioning profile carries only the capabilities enabled on its App ID.
@@ -570,6 +579,7 @@ common ones:
 | `uses-non-exempt-encryption` | Value for `ITSAppUsesNonExemptEncryption` |
 | `archive` | `false` to build-only (PR runs without secrets) |
 | `upload` | `false` to archive but not upload to TestFlight |
+| `manage-app-store-version` | `false` to upload without creating/editing the App Store release slot |
 | `app-store-whats-new` | Inline "What's New" text (overrides files) |
 | `ai-metadata` | `false` to disable AI auto-fill of empty ASC metadata |
 | `ai-metadata-model` | GitHub Models model id (default `openai/gpt-4o`) |

package/action/.daemux-version

@@ -1 +1 @@
-1.0.33
+1.0.35

package/action/action.yml

@@ -71,6 +71,13 @@ inputs:
       secrets. When 'false', `upload` is ignored.
     required: false
     default: "true"
+  manage-app-store-version:
+    description: >
+      Set to 'false' to archive and upload a TestFlight build without creating
+      or editing an App Store version. App Store metadata automation is skipped.
+      This is useful for feature-branch validation while a release is in review.
+    required: false
+    default: "true"
   run-tests:
     description: "Set to 'false' to skip the simulator test stage"
     required: false
@@ -289,7 +296,7 @@ runs:
           | tee -a "$GITHUB_ENV"
 
     - name: Resolve App Store version slot (REUSE or CREATE)
-      if: ${{ inputs.archive == 'true' }}
+      if: ${{ inputs.archive == 'true' && inputs.manage-app-store-version == 'true' }}
       shell: bash
       env:
         APP_STORE_APPLE_ID: ${{ inputs.app-store-apple-id || env.CFG_APP_STORE_APPLE_ID }}
@@ -335,6 +342,18 @@ runs:
         echo "APP_STORE_VERSION_ID=$APP_STORE_VERSION_ID" >> "$GITHUB_ENV"
         echo "Using marketing version $MARKETING_VERSION build $BUILD_NUMBER (decision=$DECISION_JSON)"
 
+    - name: Resolve TestFlight build number
+      if: ${{ inputs.archive == 'true' && inputs.manage-app-store-version == 'false' }}
+      shell: bash
+      env:
+        APP_STORE_APPLE_ID: ${{ inputs.app-store-apple-id || env.CFG_APP_STORE_APPLE_ID }}
+      run: |
+        set -o pipefail
+        BUILD_NUMBER=$(python3 "${{ github.action_path }}/scripts/next_build_number.py")
+        echo "BUILD_NUMBER=$BUILD_NUMBER" >> "$GITHUB_ENV"
+        echo "APP_STORE_VERSION_ID=" >> "$GITHUB_ENV"
+        echo "Using marketing version $MARKETING_VERSION build $BUILD_NUMBER without an App Store version slot"
+
     - name: Notice on deprecated profile-name input
       if: ${{ inputs.archive == 'true' && inputs.profile-name != '' }}
       shell: bash
@@ -714,7 +733,9 @@ runs:
 
     - name: Detect empty ASC metadata fields
       id: detect_metadata
-      if: ${{ inputs.archive == 'true' && inputs.upload == 'true' && inputs.ai-metadata != 'false' }}
+      if: >-
+        ${{ inputs.archive == 'true' && inputs.upload == 'true'
+            && inputs.manage-app-store-version == 'true' && inputs.ai-metadata != 'false' }}
       shell: bash
       env:
         APP_STORE_APPLE_ID: ${{ inputs.app-store-apple-id || env.CFG_APP_STORE_APPLE_ID }}
@@ -969,6 +990,7 @@ runs:
     # with the default (CFG_WHATS_NEW), preserving any AI-generated notes.
     - name: Set App Store "What's New"
       if: ${{ inputs.archive == 'true' && inputs.upload == 'true'
+            && inputs.manage-app-store-version == 'true'
             && (inputs.app-store-whats-new != '' || env.CFG_WHATS_NEW != '') }}
       shell: bash
       env:

package/action/scripts/test_testflight_version_slot_wiring.py

@@ -0,0 +1,50 @@
+import re
+import unittest
+from pathlib import Path
+
+
+ACTION_YAML = Path(__file__).resolve().parents[1] / "action.yml"
+
+
+def step_block(source: str, name: str) -> str:
+    pattern = rf"    - name: {re.escape(name)}\n(?P<body>.*?)(?=\n    - name:|\Z)"
+    match = re.search(pattern, source, re.DOTALL)
+    if match is None:
+        raise AssertionError(f"missing action step: {name}")
+    return match.group("body")
+
+
+class TestTestFlightVersionSlotWiring(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls) -> None:
+        cls.source = ACTION_YAML.read_text(encoding="utf-8")
+
+    def test_opt_out_is_backward_compatible(self) -> None:
+        self.assertRegex(
+            self.source,
+            r"(?m)^  manage-app-store-version:\n(?:    .*\n)*?    default: \"true\"$",
+        )
+
+    def test_opt_out_skips_store_version_but_keeps_build_number(self) -> None:
+        store_slot = step_block(self.source, "Resolve App Store version slot (REUSE or CREATE)")
+        testflight = step_block(self.source, "Resolve TestFlight build number")
+
+        self.assertIn("inputs.manage-app-store-version == 'true'", store_slot)
+        self.assertIn("inputs.manage-app-store-version == 'false'", testflight)
+        self.assertIn(
+            "APP_STORE_APPLE_ID: ${{ inputs.app-store-apple-id || env.CFG_APP_STORE_APPLE_ID }}",
+            testflight,
+        )
+        self.assertIn("next_build_number.py", testflight)
+        self.assertNotIn("manage_marketing_version.py", testflight)
+
+    def test_metadata_requires_a_managed_store_version(self) -> None:
+        detector = step_block(self.source, "Detect empty ASC metadata fields")
+        whats_new = step_block(self.source, 'Set App Store "What\'s New"')
+
+        self.assertIn("inputs.manage-app-store-version == 'true'", detector)
+        self.assertIn("inputs.manage-app-store-version == 'true'", whats_new)
+
+
+if __name__ == "__main__":
+    unittest.main()

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.33
+1.0.35

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.33
+1.0.35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.33",
+  "version": "1.0.35",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {

package/templates/deploy.yml

@@ -113,6 +113,11 @@ jobs:
           workspace: ${{ steps.flutter.outputs.enabled == 'true' && 'ios/Runner.xcworkspace' || '' }}
           scheme: ${{ steps.flutter.outputs.enabled == 'true' && 'Runner' || '' }}
           run-tests: 'false'  # tests belong to the CI gate, not the deploy path
+          # A feature-branch TestFlight build must not create or mutate a live
+          # App Store version. That also lets it upload while the current version
+          # is locked in review. Default-branch deploys retain metadata automation.
+          manage-app-store-version: >-
+            ${{ github.ref_name == github.event.repository.default_branch && 'true' || 'false' }}
 
   android:
     name: Android Google Play
@@ -358,20 +363,40 @@ jobs:
             ${{ vars.GOOGLE_PLAY_STATUS == 'inProgress' && (vars.GOOGLE_PLAY_USER_FRACTION || '0.2') || '' }}
           whatsNewDirectory: ${{ hashFiles('distribution/whatsnew/**') != '' && 'distribution/whatsnew' || '' }}
 
-      # The retry serves two different failures, and both need a fresh edit:
-      #   * the edit expired mid-upload (a large bundle on a slow runner), and
-      #   * Play refused to auto-submit: "Changes cannot be sent for review
-      #     automatically. Please set changesNotSentForReview to true." Play returns
-      #     this once an app has changes a human must submit — after a policy
-      #     rejection, for instance — and it fails the whole upload, so the built
-      #     bundle never lands at all.
-      - name: Retry Google Play upload without auto-submit
-        id: play-upload-retry
+      # A failed action does not expose a machine-readable Play error code. Retry once
+      # with the ordinary review mode first: that opens a fresh edit and repairs an edit
+      # that expired during a slow upload without changing submission semantics.
+      - name: Retry Google Play upload with a fresh edit
+        id: play-upload-fresh-retry
+        continue-on-error: true
         if: >-
           ${{ steps.mode.outputs.mode == 'local'
               && steps.play.outputs.ready == 'true'
               && steps.play-upload.outcome == 'failure' }}
         uses: r0adkll/upload-google-play@e738b9dd8f2476ea806d921b64aacd24f34515a5 # v1.1.5
+        with:
+          serviceAccountJson: ${{ steps.android.outputs.play-service-account }}
+          packageName: ${{ steps.android.outputs.package-name }}
+          releaseFiles: ${{ steps.android.outputs.bundle-path }}
+          tracks: ${{ vars.GOOGLE_PLAY_TRACK || 'internal' }}
+          status: ${{ vars.GOOGLE_PLAY_STATUS || 'completed' }}
+          userFraction: >-
+            ${{ vars.GOOGLE_PLAY_STATUS == 'inProgress' && (vars.GOOGLE_PLAY_USER_FRACTION || '0.2') || '' }}
+          whatsNewDirectory: >-
+            ${{ hashFiles('distribution/whatsnew/**') != '' && 'distribution/whatsnew' || '' }}
+
+      # If the ordinary fresh-edit retry also fails, Play may be requiring the
+      # changesNotSentForReview mode used after a policy rejection. A third, fresh edit
+      # is intentionally reserved for that case. Setting the flag on the edit-expiry
+      # retry is invalid for apps whose changes are submitted automatically.
+      - name: Retry Google Play upload without auto-submit
+        id: play-upload-review-retry
+        if: >-
+          ${{ steps.mode.outputs.mode == 'local'
+              && steps.play.outputs.ready == 'true'
+              && steps.play-upload.outcome == 'failure'
+              && steps.play-upload-fresh-retry.outcome == 'failure' }}
+        uses: r0adkll/upload-google-play@e738b9dd8f2476ea806d921b64aacd24f34515a5 # v1.1.5
         with:
           serviceAccountJson: ${{ steps.android.outputs.play-service-account }}
           packageName: ${{ steps.android.outputs.package-name }}
@@ -385,7 +410,7 @@ jobs:
           changesNotSentForReview: true
 
       - name: Say what still needs a human
-        if: ${{ always() && steps.play-upload-retry.outcome == 'success' }}
+        if: ${{ always() && steps.play-upload-review-retry.outcome == 'success' }}
         shell: bash
         run: |
           echo "::warning::Play would not accept this release for review automatically, so it was \