gowalk-cicd 1.0.172 → 1.0.173

package/README.md

@@ -887,9 +887,10 @@ preserving each app's custom checks and artifact retention settings. An isolated
    override via action inputs only if auto-detection fails.
 2. **Reads the ASC key** from `creds/AuthKey_*.p8` and uses it to authenticate
    to App Store Connect via JWT.
-3. **Decides the marketing version**: either reuses the current `PREPARE_FOR_SUBMISSION`
-   version on App Store Connect, or creates a new version if the highest
-   declared version is already live.
+3. **Decides the marketing version**: either reuses the current editable
+   version on App Store Connect (`PREPARE_FOR_SUBMISSION`, a `READY_FOR_REVIEW`
+   draft you have not submitted yet, or a rejected state), or creates a new
+   version if the highest declared version is already live.
 4. **Computes the next build number** by querying ASC for the latest uploaded
    build and incrementing.
 5. **Provisions signing** at runtime: reconciles the App ID's capabilities with

package/action/scripts/asc_common.py

@@ -33,9 +33,13 @@ ASC_BASE = "https://api.appstoreconnect.apple.com/v1"
 #                developer's manual release click). Auto-roll is forbidden:
 #                advancing past either state would race the review process or
 #                bypass the developer's release decision.
-#   editable  -- PREPARE_FOR_SUBMISSION / REJECTED / METADATA_REJECTED /
-#                DEVELOPER_REJECTED / INVALID_BINARY. REUSE the row's id
-#                (developer-actionable; mutating is safe).
+#   editable  -- PREPARE_FOR_SUBMISSION / READY_FOR_REVIEW / REJECTED /
+#                METADATA_REJECTED / DEVELOPER_REJECTED / INVALID_BINARY.
+#                REUSE the row's id (developer-actionable; mutating is safe).
+#                READY_FOR_REVIEW is App Store Connect's "indicated that you
+#                intend to submit it for review, but haven't submitted it
+#                yet": the developer still holds the row (only images and
+#                videos are locked), so a build for that version joins it.
 #   unknown   -- any state in NONE of the above. Round-12 fail-closed: the
 #                classifier rejects rather than guessing, so a future ASC
 #                state cannot silently 409 on CREATE or interfere with
@@ -53,6 +57,7 @@ ASC_BASE = "https://api.appstoreconnect.apple.com/v1"
 # App Store version states that allow editing the current draft.
 EDITABLE_STATES = {
     "PREPARE_FOR_SUBMISSION",
+    "READY_FOR_REVIEW",
     "WAITING_FOR_REVIEW",
     "IN_REVIEW",
     "REJECTED",
@@ -68,8 +73,15 @@ EDITABLE_STATES = {
 # such a row would silently interfere with App Review. REJECTED /
 # METADATA_REJECTED / INVALID_BINARY come back from Apple Review and are
 # explicitly developer-actionable, so mutating them is safe.
+# READY_FOR_REVIEW sits in a review submission the developer has not sent
+# (App Store Connect: "haven't submitted it yet"; editable except images and
+# videos). Apple is not reviewing it, and a new build for the same version is
+# exactly what its owner uploads before submitting; the fail-closed
+# "unrecognized state" exit refused that build before compilation
+# (CI run 37116771417).
 REUSABLE_STATES = {
     "PREPARE_FOR_SUBMISSION",
+    "READY_FOR_REVIEW",
     "DEVELOPER_REJECTED",
     "REJECTED",
     "METADATA_REJECTED",

package/action/scripts/manage_marketing_version.py

@@ -25,7 +25,8 @@ Algorithm:
   4. If the target row already exists in /appStoreVersions:
        - any terminal match -> auto-roll or SystemExit(2); the slot is
          taken by a shipped row.
-       - editable-only match -> REUSE its id (steady-state TestFlight
+       - editable-only match (PREPARE_FOR_SUBMISSION, READY_FOR_REVIEW,
+         the rejected states) -> REUSE its id (steady-state TestFlight
          iteration at unchanged MARKETING_VERSION).
   5. CREATE path: floor-check (strict, target > floor); PATCH-rename any
      stale editable to target; or POST a new row.

package/action/scripts/set_app_store_whats_new.py

@@ -52,9 +52,13 @@ SKIP_VERSIONS = {"1.0", "1.0.0", "0.0", "0.0.0"}
 
 # Apple permits editing appStoreVersionLocalizations.whatsNew only while the
 # version is in an editable state. WAITING_FOR_REVIEW / IN_REVIEW /
-# READY_FOR_SALE etc. are not editable -- skip non-fatally.
+# READY_FOR_SALE etc. are not editable -- skip non-fatally. READY_FOR_REVIEW
+# (added to a review submission the developer has not sent) keeps text
+# metadata editable; a localization Apple still locks answers 409
+# STATE_ERROR, which _patch_localization skips.
 WHATSNEW_EDITABLE_STATES = {
     "PREPARE_FOR_SUBMISSION",
+    "READY_FOR_REVIEW",
     "REJECTED",
     "METADATA_REJECTED",
     "DEVELOPER_REJECTED",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.172",
+  "version": "1.0.173",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {