gowalk-cicd 1.0.170 → 1.0.171

package/docs/CONFIGURATION.md

@@ -99,3 +99,12 @@ An unknown layout or overlapping custom code edit returns a JSON
 `gowalk-cicd/migration-repair.v1` receipt with its code, file and YAML path. The
 receipt never includes the conflicting value. Resolve that specific customization
 in the same repository; unrelated repositories can continue upgrading.
+
+1.0.168 deleted the Android `mode` step (Bitrise delivery). No app enabled Bitrise, so it
+always answered `local`; a deleted step answers null. An upgrade therefore drops a
+`steps.mode.outputs.mode == 'local'` (or `!= 'bitrise'`) conjunct from an app's
+`jobs.android` step `if`, and an `if` left empty goes. Any other use of `steps.mode` in a
+`jobs.android` step `if` returns `android_mode_condition_requires_edit`: a Bitrise-only step
+never ran (delete it), and beside `always()`, `failure()` or `cancelled()` the conjunct also
+meant that the steps before `mode` succeeded (restate that). `env`, `run` and job outputs are
+not checked; there `steps.mode` renders empty.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.170",
+  "version": "1.0.171",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {

package/src/config/merge.mjs

@@ -86,9 +86,53 @@ function iosChange(file, before, after, change) {
   return change;
 }
 
+// 1.0.168 deleted the Android step `mode`, which answered 'local' on every app (none enabled
+// Bitrise). A missing step answers null, so an app step still guarded by
+// `steps.mode.outputs.mode == 'local'` silently stopped running. That always-true conjunct is
+// dropped (&& binds tighter than ||, so any isolated conjunct can go); any other use refuses.
+// Beside always(), failure() or cancelled() it also meant "nothing before mode failed", so it refuses.
+const MODE = /^steps\.mode\.outputs\.mode\s*(?:==\s*'local'|!=\s*'bitrise')$/;
+const USES_MODE = /\bsteps\.mode(?![\w-])/, STATUS = /\b(?:always|failure|cancelled)\(/;
+
+function conjuncts(body) {
+  const terms = [];
+  let depth = 0, quoted = false, start = 0;
+  for (let index = 0; index < body.length; index++) {
+    const char = body[index];
+    if (char === "'") quoted = !quoted;
+    else if (!quoted && (char === '(' || char === ')')) depth += char === '(' ? 1 : -1;
+    else if (!quoted && !depth && body.startsWith('&&', index)) {
+      terms.push(body.slice(start, index).trim());
+      start = ++index + 1;
+    }
+  }
+  return [...terms, body.slice(start).trim()];
+}
+
+function modeChange(file, change, ownMode) {
+  const [jobs, job, steps, items, name, key] = change.path;
+  if (file !== 'deploy.yml' || jobs !== 'jobs' || job !== 'android' || steps !== 'steps' || items !== 'items'
+      || ownMode) return change;
+  const step = change.path.length === 5 && change.value && typeof change.value === 'object';
+  const condition = step ? change.value.if : change.path.length === 6 && key === 'if' ? change.value : null;
+  if (typeof condition !== 'string' || !USES_MODE.test(condition)) return change;
+  const terms = conjuncts(condition.trim().replace(/^\$\{\{([\s\S]*)\}\}$/, '$1').trim())
+    .filter(term => !MODE.test(term));
+  if (terms.some(term => USES_MODE.test(term) || STATUS.test(term))) {
+    throw new MigrationRepair('android_mode_condition_requires_edit', file, change.path);
+  }
+  console.log(`  Migrated ${file} android step ${name}: dropped steps.mode (step deleted in 1.0.168)`);
+  const migrated = terms.length ? `\${{ ${terms.join(' && ')} }}` : undefined;
+  if (!step) return migrated === undefined ? { path: change.path, remove: true } : { ...change, value: migrated };
+  return { ...change, value: Object.fromEntries(Object.entries(change.value).flatMap(([field, value]) =>
+    field !== 'if' ? [[field, value]] : migrated === undefined ? [] : [[field, migrated]])) };
+}
+
 export function mergeChanges(base, incoming, changes, file) {
   const result = structuredClone(incoming);
-  for (const change of changes) {
+  const ownMode = changes.some(change => equal(change.path, ['jobs', 'android', 'steps', 'items', 'id:mode']));
+  for (const raw of changes) {
+    const change = modeChange(file, raw, ownMode);
     const before = at(base, change.path), after = at(incoming, change.path);
     if (change.path.at(-1) === 'order' && Array.isArray(before) && Array.isArray(after)) {
       assign(result, { path: change.path, value: mergeOrder(before, change.value, after, file, change.path) });