gowalk-cicd 1.0.157 → 1.0.158

package/action/.daemux-version

@@ -1 +1 @@
-1.0.157
+1.0.158

package/action/scripts/delivery_preflight.py

@@ -67,6 +67,14 @@ UNIVERSAL_IDIOMS = frozenset({"universal"})
 #: runtime documentation nests it under NSExtensionAttributes and the delivery
 #: validator reads it directly under NSExtension, so a bundle that satisfies only
 #: the documented location is delivered and then refused as "not specified".
+#: A `forbidden` row names a key the validator refuses to SEE. A WidgetKit
+#: extension has no principal class: it enters through its @main WidgetBundle,
+#: Xcode's own template ships NSExtensionPointIdentifier alone, and a bundle
+#: that adds NSExtensionPrincipalClass is delivered and then refused with
+#: "Validation failed (409) Unexpected Info.plist key. Unexpected key
+#: NSExtensionPrincipalClass found in extension Info.plist for
+#: Payload/<App>.app/PlugIns/<Widget>.appex". Demanding the key here refused
+#: every correct WidgetKit build (Sunnah 1.0.1 (16)) for a binary Apple accepts.
 EXTENSION_KEYS = {
     "com.apple.broadcast-services-upload": (
         {"key": "RPBroadcastProcessMode", "path": (),
@@ -77,7 +85,9 @@ EXTENSION_KEYS = {
         {"key": "NSExtensionPrincipalClass", "path": (), "values": (), "itms": "ITMS-90362"},
     ),
     "com.apple.widgetkit-extension": (
-        {"key": "NSExtensionPrincipalClass", "path": (), "values": (), "itms": "ITMS-90362"},
+        {"key": "NSExtensionPrincipalClass", "path": (), "forbidden": True,
+         "reason": "a WidgetKit extension enters through its @main WidgetBundle",
+         "itms": "Unexpected Info.plist key"},
     ),
 }
 
@@ -335,10 +345,21 @@ def check_extension_keys(ctx: dict) -> list[dict]:
             for step in rule["path"]:
                 node = node.get(step) if isinstance(node, dict) else None
             value = node.get(rule["key"]) if isinstance(node, dict) else None
+            where = "NSExtension" + "".join("." + step for step in rule["path"])
+            if rule.get("forbidden"):
+                if value is None:
+                    continue
+                failures.append({
+                    "itms": rule["itms"],
+                    "message": (f"{name}: {where}.{rule['key']} is present; Apple's delivery "
+                                f"validator refuses it for {point} as an unexpected Info.plist key."),
+                    "next": (f"Remove {where}.{rule['key']} from the extension's Info.plist; "
+                             f"{rule['reason']}."),
+                })
+                continue
             legal = rule["values"]
             if value is not None and (not legal or value in legal):
                 continue
-            where = "NSExtension" + "".join("." + step for step in rule["path"])
             elsewhere = ""
             attributes = extension.get("NSExtensionAttributes")
             if isinstance(attributes, dict) and rule["key"] in attributes and not rule["path"]:

package/action/scripts/test_delivery_preflight.py

@@ -200,6 +200,27 @@ class BundleTests(unittest.TestCase):
         self.assertEqual(self.codes(answer), ["ITMS-90362"])
         self.assertIn("not an accepted value", answer["failures"][0]["message"])
 
+    def test_a_widgetkit_extension_with_only_its_point_identifier_passes(self):
+        self.write_info()
+        self.extension("SunnahWidget.appex", {
+            "NSExtensionPointIdentifier": "com.apple.widgetkit-extension",
+        })
+        answer = preflight.inspect(self.app, only={"extension_keys"})
+        self.assertTrue(answer["ok"], answer["failures"])
+
+    def test_a_widgetkit_principal_class_is_refused_and_explained(self):
+        self.write_info()
+        self.extension("SunnahWidget.appex", {
+            "NSExtensionPointIdentifier": "com.apple.widgetkit-extension",
+            "NSExtensionPrincipalClass": "$(PRODUCT_MODULE_NAME).SunnahWidgetBundle",
+        })
+        answer = preflight.inspect(self.app, only={"extension_keys"})
+        self.assertEqual(self.codes(answer), ["Unexpected Info.plist key"])
+        failure = answer["failures"][0]
+        self.assertIn("NSExtension.NSExtensionPrincipalClass is present", failure["message"])
+        self.assertIn("Remove NSExtension.NSExtensionPrincipalClass", failure["next"])
+        self.assertIn("@main WidgetBundle", failure["next"])
+
     def test_an_unknown_extension_point_is_left_alone(self):
         self.write_info()
         self.extension("Other.appex", {"NSExtensionPointIdentifier": "com.example.unknown"})

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.157
+1.0.158

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.157
+1.0.158

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.157",
+  "version": "1.0.158",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {