gowalk-cicd 1.0.130 → 1.0.132

package/CLAUDE.md

@@ -417,6 +417,11 @@ node /path/to/gowalk-cicd/bin/cli.mjs
   recorded immediately in repository deployment receipts; retries reuse their prior-run evidence.
   An uncertain upload never starts another binary automatically. Preserve its signed artifact,
   complete exact provider readback/recovery through scoped tooling, then reconcile its receipt.
+  The local Android workflow supplies `mobileReleaseIntentScript` to the upload wrapper instead
+  of marking `uploading` before acquiring Play ownership. A refused owner leaves the release
+  record at `building`; the wrapper records intent inside its acquired lease before provider
+  dispatch. Adopt both the action and workflow wiring; action-only updates preserve older
+  workflows' intent handling. Never clear an existing `uploading` marker on an owner refusal.
   Actions without `MOBILE_RELEASE_DEPLOYMENT_ID` preserve legacy consumer behavior. All new
   receipt helper reads are fixed-origin GitHub requests; Apple/Google still use their assigned exits.
 

package/action/.daemux-version

@@ -1 +1 @@
-1.0.130
+1.0.132

package/action/scripts/prepare_crashlytics_build.py

@@ -67,13 +67,17 @@ def commands(script: str) -> list[list[str]] | None:
         current = []
         target = False
         for token in tokens:
-            if target:                      # the file a redirect writes, not a command
+            if target:
                 target = False
                 continue
             if token.startswith("#"):
                 break
             if token and set(token) <= OPERATOR:
-                if set(token) & REDIRECT:   # a redirect belongs to the command it follows
+                if set(token) & REDIRECT:
+                    # Only the deferred uploader's effects belong to the removed operation.
+                    # A redirected builtin/assignment can produce another required build input.
+                    if not uploads_symbols(current):
+                        return None
                     target = True
                     continue
                 if current:

package/action/scripts/test_crashlytics_phase_effects.py

@@ -0,0 +1,30 @@
+"""An upload-only rewrite must preserve commands that also produce other build inputs."""
+import copy
+import unittest
+
+import prepare_crashlytics_build as build
+
+
+class PhaseEffectTests(unittest.TestCase):
+    def test_redirected_builtins_are_build_work_even_without_another_executable(self):
+        for command in ('echo public > Generated.swift', 'echo enabled >> build.env',
+                        ': > generated.config', 'BUILD=release > generated.config'):
+            with self.subTest(command=command):
+                script = command + '\nupload-symbols -gsp app.plist -p ios symbols'
+                self.assertFalse(build.dedicated(script))
+                document = {'objects': {'phase': {'isa': 'PBXShellScriptBuildPhase',
+                            'name': 'Crashlytics and generated input', 'shellScript': script}}}
+                original = copy.deepcopy(document)
+                with self.assertRaisesRegex(ValueError, 'shares the build phase'):
+                    build.rewrite(document)
+                self.assertEqual(document, original)
+
+    def test_supported_generated_guards_remain_upload_only(self):
+        self.assertTrue(build.dedicated(
+            'if [ -f "$PODS_ROOT/FirebaseCrashlytics/upload-symbols" ]; then\n'
+            '"$PODS_ROOT/FirebaseCrashlytics/upload-symbols" -gsp app.plist -p ios symbols\n'
+            'else echo "warning: upload-symbols absent"; fi'))
+
+
+if __name__ == '__main__':
+    unittest.main()

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.130
+1.0.132

package/android-action/play-upload/action.yml

@@ -23,6 +23,9 @@ inputs:
   inAppUpdatePriority:
     description: In-app update priority.
     default: '0'
+  mobileReleaseIntentScript:
+    description: Committed mobile_release.cjs path, invoked after acquiring the package owner and before upload.
+    default: ''
 outputs:
   review-pending:
     description: True only after a successful explicitly requested review-hold retry.

package/android-action/play-upload/release_intent.cjs

@@ -0,0 +1,21 @@
+// The workflow supplies its committed release helper; Play ownership precedes the write marker.
+const {spawn} = require('node:child_process');
+
+function begin(env) {
+  const script = env.INPUT_MOBILERELEASEINTENTSCRIPT;
+  // Older workflows record their own intent. Unwired consumers retain that behavior.
+  if (!script || !env.MOBILE_RELEASE_DEPLOYMENT_ID) return;
+  return new Promise((resolve, reject) => {
+    const child = spawn(process.execPath, [script, 'begin-upload', 'android'], {env, stdio: 'ignore'});
+    // Keep the owner cancellation handler responsive while its bounded marker write settles.
+    const timer = setTimeout(() => child.kill('SIGKILL'), 120000);
+    child.once('error', () => { clearTimeout(timer); reject(Error('mobile_release_intent_unconfirmed')); });
+    child.once('close', (code, signal) => {
+      clearTimeout(timer);
+      if (code !== 0 || signal) reject(Error('mobile_release_intent_unconfirmed'));
+      else resolve();
+    });
+  });
+}
+
+module.exports = {begin};

package/android-action/play-upload/run.cjs

@@ -5,6 +5,7 @@ const source = require('./source.cjs');
 const processRunner = require('./process.cjs');
 const owner = require('./owner.cjs');
 const diagnostics = require('./diagnostics.cjs');
+const releaseIntent = require('./release_intent.cjs');
 
 async function upload(program, env, directory, execute = processRunner.execute, timeout = 3600000,
   cancelled = () => false, report = () => {}) {
@@ -40,14 +41,17 @@ async function main() {
     if (!env.RUNNER_TEMP || !env.GITHUB_OUTPUT) throw new Error('runner_context_required');
     directory = mkdtempSync(join(env.RUNNER_TEMP, 'gowalk-play-upload-'));
     const program = await source.prepare(directory);
-    receipt = await owner.withOwner(env, env.INPUT_PACKAGENAME, cancelled =>
-      upload(program, env, directory, processRunner.execute, 3600000, cancelled,
-        (attempt, result) => console.log(diagnostics.annotation(attempt, result))));
+    receipt = await owner.withOwner(env, env.INPUT_PACKAGENAME, async cancelled => {
+      if (cancelled()) return {ok: false, code: 'upload_cancelled', attempts: 0, review_pending: false};
+      await releaseIntent.begin(env);
+      return upload(program, env, directory, processRunner.execute, 3600000, cancelled,
+        (attempt, result) => console.log(diagnostics.annotation(attempt, result)));
+    });
   } catch (error) {
     if (owner.codes.includes(error.message)) console.log(owner.annotation(error.message, undefined,
       error.detail || (typeof error.releaseUnverified === 'string' ? error.releaseUnverified : undefined)));
     const allowed = ['assigned_proxy_required', 'runner_context_required', 'uploader_integrity_refused',
-      'uploader_source_unavailable', ...owner.codes];
+      'uploader_source_unavailable', 'mobile_release_intent_unconfirmed', ...owner.codes];
     receipt = {ok: false, code: allowed.includes(error.message) ? error.message : 'uploader_failed',
       attempts: 0, review_pending: false};
     if (owner.codes.includes(error.message) && error.operationResult) {

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.130
+1.0.132

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.130",
+  "version": "1.0.132",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {

package/templates/deploy.yml

@@ -550,9 +550,6 @@ jobs:
       # The wrapper verifies the unchanged pinned official uploader and classifies
       # its immediate result. Only explicit expired/deleted edits retry normally;
       # only Play's explicit review-hold refusal changes the review flag.
-      - name: Record Android upload intent
-        if: ${{ steps.mode.outputs.mode == 'local' && steps.play.outputs.ready == 'true' }}
-        run: node .github/actions/swift-app/scripts/mobile_release.cjs begin-upload android
       - name: Upload Android release to Google Play
         id: play-upload
         if: ${{ steps.mode.outputs.mode == 'local' && steps.play.outputs.ready == 'true' }}
@@ -561,6 +558,7 @@ jobs:
           GOOGLE_STORE_PROXY_URL: ${{ secrets.GOOGLE_STORE_PROXY_URL }}
           GITHUB_TOKEN: ${{ github.token }}
         with:
+          mobileReleaseIntentScript: ${{ github.workspace }}/.github/actions/swift-app/scripts/mobile_release.cjs
           serviceAccountJson: ${{ steps.android.outputs.play-service-account }}
           packageName: ${{ steps.android.outputs.package-name }}
           releaseFiles: ${{ steps.android.outputs.bundle-path }}