gowalk-cicd 1.0.117 → 1.0.118

package/action/.daemux-version

@@ -1 +1 @@
-1.0.117
+1.0.118

package/android-action/.daemux-version

@@ -1 +1 @@
-1.0.117
+1.0.118

package/android-action/scripts/flutter_manifest.py

@@ -37,6 +37,14 @@ import flutter_release_cache
 
 RETRY_CODES = {5, 6, 7, 18, 28, 35, 52, 55, 56, 92, 95}
 RETRY_HTTP = {408, 429, 500, 502, 503, 504}
+#: Attempts each kind of transfer may make. The archive's deadline already
+#: bounds its pass, so four stands there. The MANIFEST is the one that gave up
+#: early: the account exit refused four TLS handshakes in ten seconds (curl 35,
+#: proxy_status 200) and the iOS release failed with fifty seconds of its own
+#: sixty-second budget unspent — an hour after the same fetch had succeeded
+#: (obd-scanner, 2026-09-09). It is a few KB, so riding out an exit that is
+#: briefly refusing costs one small request each time and nothing else.
+MAX_ATTEMPTS = {"manifest": 12, "archive": 4}
 
 
 def download(arguments: list[str], directory: Path) -> int:
@@ -55,7 +63,8 @@ def download(arguments: list[str], directory: Path) -> int:
     if flutter_archive_cache.reuse_complete(destination, kind):
         return 0
     attempted = 0
-    for attempt in range(1, 5):
+    limit = MAX_ATTEMPTS[kind]
+    for attempt in range(1, limit + 1):
         remaining = deadline - time.monotonic()
         if remaining <= 0:
             break
@@ -71,7 +80,7 @@ def download(arguments: list[str], directory: Path) -> int:
             if attempt > 1:
                 print(f"flutter_{kind}_recovered attempts={attempt}", file=sys.stderr)
             return 0
-        if attempt == 4 or proxy_http in {401, 403, 407} or http in {401, 403}:
+        if attempt == limit or proxy_http in {401, 403, 407} or http in {401, 403}:
             break
         restart = kind == "archive" and code == 33 and http == 200
         if (not restart and code not in RETRY_CODES and http not in RETRY_HTTP
@@ -81,7 +90,13 @@ def download(arguments: list[str], directory: Path) -> int:
             destination.write_bytes(b"")
         if destination.stat().st_size > flutter_download.MAX_ARCHIVE_BYTES:
             raise ValueError("flutter_archive_size_exceeded")
-        time.sleep(min(2 ** (attempt - 1), max(0, deadline - time.monotonic())))
+        left = max(0.0, deadline - time.monotonic())
+        # The manifest waits a flat second between tries: it is riding out an
+        # exit that is refusing right now, and an exponential backoff would
+        # spend its sixty-second window sleeping instead of retrying. The
+        # archive keeps the growing wait — its attempts are minutes long.
+        pause = 1 if kind == "manifest" else 2 ** (attempt - 1)
+        time.sleep(min(pause, left))
     flutter_download.failure(kind, code, http, proxy_http, attempted, destination.stat().st_size)
     return code or 1
 

package/android-action/scripts/test_flutter_download_budget.py

@@ -80,5 +80,66 @@ class ArchiveBudgetTests(unittest.TestCase):
         self.assertEqual(elapsed[0], 2100)
 
 
+
+
+class ManifestRetryTests(unittest.TestCase):
+    def test_a_briefly_refusing_exit_is_retried_until_the_deadline(self):
+        """The iOS release lost its manifest to four TLS refusals in ten seconds
+        (curl 35, proxy_status 200) with fifty seconds of budget unspent, an hour
+        after the same fetch succeeded."""
+        elapsed, attempts = [0.0], []
+
+        def transfer(_url, destination, _kind, _remaining, _env):
+            attempts.append(elapsed[0])
+            elapsed[0] += 2.5          # a TLS refusal fails fast
+            destination.write_bytes(b"")
+            return 35, 0, 200
+
+        with tempfile.TemporaryDirectory() as directory, contextlib.redirect_stderr(io.StringIO()) as error:
+            with patch.dict(os.environ, HTTPS_PROXY="http://fixture:secret@localhost:1"):
+                with patch.object(flutter_manifest.time, "monotonic", side_effect=lambda: elapsed[0]), \
+                        patch.object(flutter_manifest.time, "sleep",
+                                     side_effect=lambda seconds: elapsed.__setitem__(0, elapsed[0] + seconds)), \
+                        patch.object(flutter_manifest.flutter_download, "transfer", side_effect=transfer):
+                    result = flutter_manifest.download(["--silent", "--connect-timeout", "15", "--retry", "5",
+                        "https://fixture.invalid/flutter_infra_release/releases/releases_macos.json"],
+                        Path(directory))
+        self.assertEqual(result, 35)
+        # It used the manifest's whole 60 s window instead of giving up at 10 s.
+        self.assertGreater(len(attempts), 4)
+        self.assertLessEqual(len(attempts), flutter_manifest.MAX_ATTEMPTS["manifest"])
+        self.assertGreater(elapsed[0], 30)
+        # The deadline bounds the pass; the last attempt may end just past it.
+        self.assertLess(elapsed[0], 70)
+        self.assertIn("attempts=%d" % len(attempts), error.getvalue())
+        self.assertNotIn("secret", error.getvalue())
+
+    def test_an_exit_that_recovers_mid_window_still_publishes(self):
+        elapsed, calls = [0.0], []
+
+        def transfer(_url, destination, _kind, _remaining, _env):
+            calls.append(1)
+            elapsed[0] += 2.5
+            if len(calls) < 6:
+                destination.write_bytes(b"")
+                return 35, 0, 200
+            destination.write_bytes(b'{"releases": []}')
+            return 0, 200, 200
+
+        with tempfile.TemporaryDirectory() as directory, contextlib.redirect_stderr(io.StringIO()) as error:
+            with patch.dict(os.environ, HTTPS_PROXY="http://fixture:secret@localhost:1"):
+                with patch.object(flutter_manifest.time, "monotonic", side_effect=lambda: elapsed[0]), \
+                        patch.object(flutter_manifest.time, "sleep",
+                                     side_effect=lambda seconds: elapsed.__setitem__(0, elapsed[0] + seconds)), \
+                        patch.object(flutter_manifest.flutter_download, "publish", side_effect=lambda *a: None), \
+                        patch.object(flutter_manifest.flutter_download, "transfer", side_effect=transfer):
+                    result = flutter_manifest.download(["--silent", "--connect-timeout", "15", "--retry", "5",
+                        "https://fixture.invalid/flutter_infra_release/releases/releases_macos.json"],
+                        Path(directory))
+        self.assertEqual(result, 0)
+        self.assertEqual(len(calls), 6)
+        self.assertIn("flutter_manifest_recovered attempts=6", error.getvalue())
+
+
 if __name__ == "__main__":
     unittest.main()

package/android-action/scripts/test_flutter_manifest.py

@@ -5,6 +5,8 @@ import subprocess
 import tempfile
 import unittest
 
+import flutter_manifest
+
 from flutter_manifest_fixture import HOST, MANIFEST, official_setup, tls_proxy
 
 ROOT = Path(__file__).parent
@@ -47,7 +49,7 @@ class ManifestRecoveryTests(unittest.TestCase):
             env.update(HOME=str(self.root / "absent-home"), NO_PROXY="", no_proxy="")
         args = ["bash", str(self.setup), "-p", "-n", "3.44.0", "-a", "x64", "-k", "custom-:version:-:hash:"]
         result = subprocess.run([*args, *(["-t"] if test_mode else []), "stable"], env=env,
-                                capture_output=True, text=True, timeout=20)
+                                capture_output=True, text=True, timeout=120)
         self.assertNotIn("fixture-secret", result.stdout + result.stderr)
         self.assertFalse(list(self.root.glob("flutter-manifest-*")))
         return result
@@ -99,12 +101,18 @@ class ManifestRecoveryTests(unittest.TestCase):
         self.assertIn("attempts=1", result.stderr)
         self.assertEqual(result.stdout, "")
 
-    def test_repeated_tls_resets_stop_after_four_private_attempts(self):
-        with tls_proxy(self.root, ["reset"] * 4) as (server, cert):
+    def test_repeated_tls_resets_are_retried_across_the_manifest_window(self):
+        """An exit that refuses TLS is retried until the manifest's own deadline,
+        not abandoned after four handshakes: obd-scanner's iOS release lost its
+        manifest to four refusals in ten seconds with fifty seconds of its
+        sixty-second budget unspent, an hour after the same fetch succeeded
+        (2026-09-09). Nothing is ever sent to the origin."""
+        limit = flutter_manifest.MAX_ATTEMPTS["manifest"]
+        with tls_proxy(self.root, ["reset"] * limit) as (server, cert):
             result = self.invoke(server, cert)
             self.assertEqual(result.returncode, 35)
-            self.assertEqual((server.connects, server.requests), (4, []))
-        self.assertIn("attempts=4", result.stderr)
+            self.assertEqual((server.connects, server.requests), (limit, []))
+        self.assertIn(f"attempts={limit}", result.stderr)
         self.assertEqual(result.stdout, "")
 
     def test_missing_proxy_refuses_before_any_connection(self):

package/android-action/scripts/test_flutter_proxy_retry.py

@@ -7,6 +7,8 @@ import sys
 import tempfile
 import unittest
 
+import flutter_manifest
+
 from flutter_manifest_fixture import HOST, MANIFEST, tls_proxy
 
 ROOT = Path(__file__).parent
@@ -35,7 +37,7 @@ class ProxyRetryTests(unittest.TestCase):
             args.insert(0, "--silent")
         result = subprocess.run([sys.executable, str(ROOT / "flutter_manifest.py"), *args,
                                  f"https://{HOST}/flutter_infra_release/releases/{path}"],
-                                env=env, capture_output=True, timeout=20)
+                                env=env, capture_output=True, timeout=120)
         self.assertNotIn(b"fixture-secret", result.stdout + result.stderr)
         self.assertFalse(list(self.root.glob("flutter-manifest-*")))
         return result
@@ -48,12 +50,17 @@ class ProxyRetryTests(unittest.TestCase):
                 self.assertEqual((server.connects, len(server.requests)), (2, 1))
                 self.assertIn(b"flutter_manifest_recovered attempts=2", result.stderr)
 
-    def test_repeated_connect_failure_stops_after_four_attempts_without_origin_request(self):
-        with tls_proxy(self.root, ["proxy_502"] * 4) as (server, cert):
+    def test_repeated_connect_failure_never_reaches_the_origin(self):
+        """A refusing proxy is retried across the manifest's own window and the
+        origin request is never sent — the attempt count follows the manifest
+        limit, not a fixed four (see test_flutter_manifest)."""
+        limit = flutter_manifest.MAX_ATTEMPTS["manifest"]
+        with tls_proxy(self.root, ["proxy_502"] * limit) as (server, cert):
             result = self.invoke(server, cert)
             self.assertNotEqual(result.returncode, 0)
-            self.assertEqual((result.stdout, server.connects, server.requests), (b"", 4, []))
-            self.assertIn(b"http_status=0 proxy_status=502 attempts=4 retained_bytes=0", result.stderr)
+            self.assertEqual((result.stdout, server.connects, server.requests), (b"", limit, []))
+            self.assertIn(f"http_status=0 proxy_status=502 attempts={limit} retained_bytes=0".encode(),
+                          result.stderr)
 
     def test_connect_failure_preserves_partial_archive_for_a_verified_range_resume(self):
         with tls_proxy(self.root, ["partial", "proxy_502", "range"], ARCHIVE) as (server, cert):

package/backend-action/.daemux-version

@@ -1 +1 @@
-1.0.117
+1.0.118

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gowalk-cicd",
-  "version": "1.0.117",
+  "version": "1.0.118",
   "description": "Zero-config GitHub Actions delivery for iOS TestFlight and Android Google Play.",
   "type": "module",
   "bin": {