got 14.4.7 → 14.4.9

package/dist/source/core/index.js

@@ -449,10 +449,22 @@ export default class Request extends Duplex {
         const { options } = this;
         const { url } = options;
         this._nativeResponse = response;
-        if (options.decompress) {
+        const statusCode = response.statusCode;
+        const { method } = options;
+        // Skip decompression for responses that must not have bodies per RFC 9110:
+        // - HEAD responses (any status code)
+        // - 1xx (Informational): 100, 101, 102, 103, etc.
+        // - 204 (No Content)
+        // - 205 (Reset Content)
+        // - 304 (Not Modified)
+        const hasNoBody = method === 'HEAD'
+            || (statusCode >= 100 && statusCode < 200)
+            || statusCode === 204
+            || statusCode === 205
+            || statusCode === 304;
+        if (options.decompress && !hasNoBody) {
             response = decompressResponse(response);
         }
-        const statusCode = response.statusCode;
         const typedResponse = response;
         typedResponse.statusMessage = typedResponse.statusMessage ?? http.STATUS_CODES[statusCode];
         typedResponse.url = options.url.toString();

package/dist/source/core/options.d.ts

@@ -337,6 +337,8 @@ Delays between retries counts with function `1000 * Math.pow(2, retry) + Math.ra
 The `calculateDelay` property is a `function` that receives an object with `attemptCount`, `retryOptions`, `error` and `computedValue` properties for current retry count, the retry options, error and default computed value.
 The function must return a delay in milliseconds (or a Promise resolving with it) (`0` return value cancels retry).
 
+__Note:__ When you provide `calculateDelay`, you take full control of retry decisions. The `limit` option is not automatically enforced - you must check `attemptCount` yourself or return `0` when `computedValue` is `0` to respect the default retry logic.
+
 By default, it retries *only* on the specified methods, status codes, and on these network errors:
 - `ETIMEDOUT`: One of the [timeout](#timeout) limits were reached.
 - `ECONNRESET`: Connection was forcibly closed by a peer.
@@ -1005,6 +1007,8 @@ export default class Options {
     The `calculateDelay` property is a `function` that receives an object with `attemptCount`, `retryOptions`, `error` and `computedValue` properties for current retry count, the retry options, error and default computed value.
     The function must return a delay in milliseconds (or a Promise resolving with it) (`0` return value cancels retry).
 
+    __Note:__ When you provide `calculateDelay`, you take full control of retry decisions. The `limit` option is not automatically enforced - you must check `attemptCount` yourself or return `0` when `computedValue` is `0` to respect the default retry logic.
+
     By default, it retries *only* on the specified methods, status codes, and on these network errors:
 
     - `ETIMEDOUT`: One of the [timeout](#timeout) limits were reached.
@@ -1173,7 +1177,7 @@ export default class Options {
         passphrase: string | undefined;
         pfx: PfxType;
         rejectUnauthorized: boolean | undefined;
-        checkServerIdentity: typeof checkServerIdentity | CheckServerIdentityFunction;
+        checkServerIdentity: CheckServerIdentityFunction | typeof checkServerIdentity;
         ciphers: string | undefined;
         honorCipherOrder: boolean | undefined;
         minVersion: import("tls").SecureVersion | undefined;

package/dist/source/core/options.js

@@ -359,7 +359,10 @@ export default class Options {
             return;
         }
         if (options instanceof Options) {
-            for (const init of options._init) {
+            // Create a copy of the _init array to avoid infinite loop
+            // when merging an Options instance with itself
+            const initArray = [...options._init];
+            for (const init of initArray) {
                 this.merge(init);
             }
             return;
@@ -1258,6 +1261,8 @@ export default class Options {
     The `calculateDelay` property is a `function` that receives an object with `attemptCount`, `retryOptions`, `error` and `computedValue` properties for current retry count, the retry options, error and default computed value.
     The function must return a delay in milliseconds (or a Promise resolving with it) (`0` return value cancels retry).
 
+    __Note:__ When you provide `calculateDelay`, you take full control of retry decisions. The `limit` option is not automatically enforced - you must check `attemptCount` yourself or return `0` when `computedValue` is `0` to respect the default retry logic.
+
     By default, it retries *only* on the specified methods, status codes, and on these network errors:
 
     - `ETIMEDOUT`: One of the [timeout](#timeout) limits were reached.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "got",
-	"version": "14.4.7",
+	"version": "14.4.9",
 	"description": "Human-friendly and powerful HTTP request library for Node.js",
 	"license": "MIT",
 	"repository": "sindresorhus/got",

package/readme.md

@@ -164,7 +164,7 @@ By default, Got will retry on failure. To disable this option, set [`options.ret
 | Cookies (out-of-the-box) | :heavy_check_mark: | :x:                | :x:                      | :x:                | :x:                    |
 | Follows redirects     | :heavy_check_mark:  | :heavy_check_mark:   | :heavy_check_mark:       | :heavy_check_mark: | :heavy_check_mark:     |
 | Retries on failure    | :heavy_check_mark:  | :x:                  | :heavy_check_mark:       | :x:                | :heavy_check_mark:     |
-| Progress events       | :heavy_check_mark:  | :x:                  | :heavy_check_mark:\*\*\* | Browser only       | :heavy_check_mark:     |
+| Progress events       | :heavy_check_mark:  | :x:                  | :heavy_check_mark: | Browser only       | :heavy_check_mark:     |
 | Handles gzip/deflate  | :heavy_check_mark:  | :heavy_check_mark:   | :heavy_check_mark:       | :heavy_check_mark: | :heavy_check_mark:     |
 | Advanced timeouts     | :heavy_check_mark:  | :x:                  | :x:                      | :x:                | :x:                    |
 | Timings               | :heavy_check_mark:  | :x:                  | :x:                      | :x:                | :x:                    |
@@ -187,7 +187,6 @@ By default, Got will retry on failure. To disable this option, set [`options.ret
 
 \* It's almost API compatible with the browser `fetch` API.\
 \*\* Need to switch the protocol manually. Doesn't accept PUSH streams and doesn't reuse HTTP/2 sessions.\
-\*\*\* Currently, only `DownloadProgress` event is supported, `UploadProgress` event is not supported.\
 ¹ Requires Node.js 15.10.0 or above.\
 :sparkle: Almost-stable feature, but the API may change. Don't hesitate to try it out!\
 :grey_question: Feature in early stage of development. Very experimental.