google-spreadsheet-translation-sync 1.5.3 → 1.5.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "google-spreadsheet-translation-sync",
-  "version": "1.5.3",
+  "version": "1.5.4",
   "description": "A plugin to read and write i18n translationsfrom and to google spreadsheets ",
   "main": "index.js",
   "scripts": {

package/src/handlers/wordpress.js

@@ -4,6 +4,7 @@ const fs = require('fs');
 const withoutError = require('../helpers').withoutError
 const gettextParser = require("gettext-parser");
 const constraints = require('../util/constraints');
+const stringUtils = require('../util/string-utils');
 
 
 module.exports.loadTranslationFile = function (filePath, callback) {
@@ -133,14 +134,14 @@ module.exports.updateTranslations = function (translationData, translationRootFo
                         phpContent += 'return [\n';
 
                         Object.keys(parsedObj.headers).forEach((header) => {
-                            phpContent += `  "${header.toLocaleLowerCase()}" => ${JSON.stringify(parsedObj.headers[header])},\n`;
+                            phpContent += `  '${stringUtils.escapeSingleQuotes(header.toLocaleLowerCase())}' => '${stringUtils.escapeSingleQuotes(parsedObj.headers[header])}',\n`;
                         })
 
                         phpContent += `  "messages" => [\n`;
 
                         Object.keys(parsedObj.translations['']).forEach((key) => {
                             if (key) {
-                                phpContent += `    "${key}" => ${JSON.stringify(parsedObj.translations[''][key].msgstr[0])},\n`;
+                                phpContent += `    '${stringUtils.escapeSingleQuotes(key)}' => '${stringUtils.escapeSingleQuotes(parsedObj.translations[''][key].msgstr[0])}',\n`;
                             }
                         });
 

package/src/util/string-utils.js

@@ -0,0 +1,3 @@
+module.exports.escapeSingleQuotes = function(str) {
+    return str.replace(/'/g, "\\'");
+};

package/test/data/wp-expected-en.txt

@@ -0,0 +1,23 @@
+<?php
+return [
+  'content-type' => 'text/plain; charset=utf-8',
+  'plural-forms' => 'nplurals=2; plural=(n!=1);',
+  'x-generator' => 'node-google-spreadsheet-translation-sync',
+  'project-id-version' => 'karmapa-chenno',
+  'language' => 'en',
+  "messages" => [
+    'add_address' => 'Add new address',
+    'add_as_favourite' => 'Add to Quick Contacts',
+    'add_center' => 'Add Center',
+    'add_contact' => 'Add contact',
+    'add_phone_number' => 'Add new phone',
+    'additional.news' => 'Additional News',
+    'administration' => 'Administration',
+    'administration_info' => 'This page allows you to access functions connected to Members, Centers, Roles and Groups.',
+    'all' => 'All',
+    'all_centers' => 'All Centers',
+    'all_contacts' => 'All contacts',
+    'key_with_special_chars' => 'Test \'quote\' or "quote"',
+    'some.key' => 'a Key 370',
+  ]
+];

package/test/test.js

@@ -411,29 +411,9 @@ const tests = [
           expect(translationsPl.add_address).to.be.undefined;
 
           const phpContent = fs.readFileSync(testFilePhp).toString();
+          const expectedContent = fs.readFileSync(path.resolve('./test/data/wp-expected-en.txt')).toString();
 
-          expect(phpContent).to.equal('<?php\n' +
-              'return [\n' +
-              '  "content-type" => "text/plain; charset=utf-8",\n' +
-              '  "plural-forms" => "nplurals=2; plural=(n!=1);",\n' +
-              '  "x-generator" => "node-google-spreadsheet-translation-sync",\n' +
-              '  "project-id-version" => "karmapa-chenno",\n' +
-              '  "language" => "en",\n' +
-              '  "messages" => [\n' +
-              '    "add_address" => "Add new address",\n' +
-              '    "add_as_favourite" => "Add to Quick Contacts",\n' +
-              '    "add_center" => "Add Center",\n' +
-              '    "add_contact" => "Add contact",\n' +
-              '    "add_phone_number" => "Add new phone",\n' +
-              '    "additional.news" => "Additional News",\n' +
-              '    "administration" => "Administration",\n' +
-              '    "administration_info" => "This page allows you to access functions connected to Members, Centers, Roles and Groups.",\n' +
-              '    "all" => "All",\n' +
-              '    "all_centers" => "All Centers",\n' +
-              '    "all_contacts" => "All contacts",\n' +
-              '    "some.key" => "a Key 370",\n' +
-              '  ]\n' +
-              '];\n');
+          expect(phpContent).to.equal(expectedContent);
 
         }