google-closure-compiler 20180716.0.1 → 20181008.0.0

package/README.md

@@ -148,7 +148,7 @@ const closureCompiler = new ClosureCompiler({
   compilation_level: 'ADVANCED'
 });
 
-const compilerProcess = closureCompiler.run(function(exitCode, stdOut, stdErr) {
+const compilerProcess = closureCompiler.run((exitCode, stdOut, stdErr) => {
   //compilation complete
 });
 ```
@@ -164,13 +164,13 @@ const closureCompiler = new ClosureCompiler({
   compilation_level: 'ADVANCED'
 });
 
-const compilerProcess = closureCompiler.run(function(exitCode, stdOut, stdErr) {
-  //compilation complete
-}, [{
+const compilerProcess = closureCompiler.run([{
  path: 'file-one.js',
  src: 'alert("hello world")',
  sourceMap: null // optional input source map
-}]);
+}], (exitCode, stdOut, stdErr) => {
+  //compilation complete
+});
 ```
 
 ## License

package/cli.js

@@ -1,9 +1,34 @@
 #!/usr/bin/env node
 'use strict';
 const fs = require('fs');
-const {getNativeImagePath, getFirstSupportedPlatform, parseCliFlags} = require('./lib/utils');
+const path = require('path');
+const {getNativeImagePath, getFirstSupportedPlatform} = require('./lib/utils');
+const parseArgs = require('minimist');
 
-const compilerFlags = parseCliFlags(process.argv.slice(2));
+/** @see https://stackoverflow.com/a/40686853/1211524 */
+function mkDirByPathSync(targetDir, {isRelativeToScript = false} = {}) {
+  const sep = path.sep;
+  const initDir = path.isAbsolute(targetDir) ? sep : '';
+  const baseDir = isRelativeToScript ? __dirname : '.';
+
+  targetDir.split(sep).reduce((parentDir, childDir) => {
+    const curDir = path.resolve(baseDir, parentDir, childDir);
+    try {
+      fs.mkdirSync(curDir);
+    } catch (err) {
+      if (err.code !== 'EEXIST') {
+        throw err;
+      }
+    }
+
+    return curDir;
+  }, initDir);
+}
+
+const compilerFlags = parseArgs(process.argv.slice(2));
+
+// The platform flag is only used by this cli script - it is not natively supported by any compiler version.
+// If it exists, use the value, but then delete it so that it's not actually passed to the compiler.
 let platform;
 if (compilerFlags.hasOwnProperty('platform')) {
   platform = compilerFlags.platform;
@@ -12,6 +37,35 @@ if (compilerFlags.hasOwnProperty('platform')) {
   platform = getFirstSupportedPlatform(['native', 'java', 'javascript']);
 }
 
+// The compiler treats default arguments as if they were --js args.
+// Minimist parses default arguments and puts them under the '_' key.
+// Move the '_' key to the 'js' key.
+if (compilerFlags.hasOwnProperty('_') && compilerFlags['_'].length > 0) {
+  let existingJsFlags = [];
+  if (compilerFlags.js) {
+    if (Array.isArray(compilerFlags.js)) {
+      existingJsFlags = compilerFlags.js;
+    } else {
+      existingJsFlags = [compilerFlags.js];
+    }
+  }
+  compilerFlags.js = existingJsFlags.concat(compilerFlags['_']);
+  delete compilerFlags['_'];
+} else {
+  delete compilerFlags['_'];
+}
+
+// Boolean arguments can in some cases be parsed as strings.
+// Since its highly unlikely that an argument actually needs to be the strings 'true' or 'false',
+// convert them to true booleans.
+Object.keys(compilerFlags).forEach(flag => {
+  if (compilerFlags[flag] === 'true') {
+    compilerFlags[flag] = true;
+  } else if (compilerFlags[flag] === 'false') {
+    compilerFlags[flag] = false;
+  }
+});
+
 if (platform !== 'javascript') {
   const Compiler = require('./lib/node/closure-compiler');
   let args = process.argv.slice(2);
@@ -39,101 +93,86 @@ if (platform !== 'javascript') {
   });
 } else {
   if (compilerFlags.help === true) {
-    console.log('Sample usage: --compilation_level (-O) VAL --externs VAL --js VAL --js_output_file VAL --warning_level (-W) [QUIET | DEFAULT | VERBOSE]');
-    console.log('See https://github.com/google/closure-compiler/wiki/Flags-and-Options for the full list of flags');
+    process.stdout.write('Sample usage: --compilation_level (-O) VAL --externs VAL --js VAL --js_output_file VAL --warning_level (-W) [QUIET | DEFAULT | VERBOSE]\n');
+    process.stdout.write('See https://github.com/google/closure-compiler/wiki/Flags-and-Options for the full list of flags`);\n');
     process.exit(0);
   }
 
   if (compilerFlags.version === true) {
     const {version} = require('./package.json');
-    console.log(`Version: ${version}`);
+    process.stdout.write(`Version: ${version}\n`);
     process.exit(0);
   }
 
-  let inputFilePromises = [];
   let waitOnStdIn = true;
   if (compilerFlags.js) {
     waitOnStdIn = false;
-    if (!Array.isArray(compilerFlags.js)) {
-      compilerFlags.js = [compilerFlags.js];
-    }
-    inputFilePromises = compilerFlags.js.map(path =>
-        new Promise((resolve, reject) =>
-            fs.readFile(path, 'utf8', (err, src) => err ? reject(err) : resolve({src, path})))
-        .catch(e => {
-          process.exitCode = 1;
-          console.error(e);
-        }));
-
-    delete compilerFlags.js;
-  }
-  let externFilePromises = [];
-  if (compilerFlags.externs) {
-    if (!Array.isArray(compilerFlags.externs)) {
-      compilerFlags.externs = [compilerFlags.externs];
-    }
-    externFilePromises = compilerFlags.externs.map(path =>
-        new Promise((resolve, reject) =>
-            fs.readFile(path, 'utf8', (err, src) => err ? reject(err) : resolve({src, path})))
-        .catch(e => {
-          process.exitCode = 1;
-          console.error(e);
-        }));
-
-    delete compilerFlags.externs;
   }
 
-  Promise.all([...inputFilePromises, ...externFilePromises])
-    .then(files => {
-      const inputFiles = files.slice(0, inputFilePromises.length);
-      const externs = files.slice(inputFilePromises.length);
-      if (externs.length > 0) {
-        compilerFlags.externs = externs;
-      } else {
-        delete compilerFlags.externs;
+  // Mimic the behavior of the java version and wait for input from standard if there
+  // are no --js flags
+  const getFilesFromStdin = !waitOnStdIn ? Promise.resolve([]) : new Promise(resolve => {
+    let stdInData = '';
+    const waitingTimeout = setTimeout(() => {
+      process.stderr.write('The compiler is waiting for input via stdin.\n');
+    }, 1000);
+    process.stdin.setEncoding('utf8');
+    process.stdin.on('readable', () => {
+      const chunk = process.stdin.read();
+      if (chunk !== null) {
+        stdInData += chunk;
+        clearTimeout(waitingTimeout);
       }
-
-      if (!waitOnStdIn) {
-        return inputFiles;
+    });
+    process.stdin.on('error', (err) => {
+      process.exitCode = 1;
+      console.error(err);
+      clearTimeout(waitingTimeout);
+    });
+    process.stdin.on('end', () => {
+      if (stdInData.length > 0) {
+        resolve([{
+          path: 'stdin',
+          src: stdInData
+        }]);
       } else {
-        return new Promise(resolve => {
-          let stdInData = '';
-          process.stdin.setEncoding('utf8');
-          process.stdin.on('readable', () => {
-            const chunk = process.stdin.read();
-            if (chunk !== null) {
-              stdInData += chunk;
-            }
-          });
-          process.stdin.on('error', (err) => {
-            process.exitCode = 1;
-            console.error(err);
-          });
-          process.stdin.on('end', () => {
-            if (stdInData.length > 0) {
-              inputFiles.push({
-                path: 'stdin',
-                src: stdInData
-              });
-            }
-            resolve(inputFiles);
-          });
-        });
+        resolve([]);
       }
-    })
-    .then(inputFiles => {
+      clearTimeout(waitingTimeout);
+    });
+  });
+
+  getFilesFromStdin.then(inputFiles => {
       const Compiler = require('./lib/node/closure-compiler-js');
+      const logErrors = require('./lib/logger');
       const compiler = new Compiler(compilerFlags);
-      compiler.run(inputFiles, (exitCode, compiledFiles, errors) => {
-        if (errors && errors.length > 0) {
-          console.error(errors);
-        }
-        if (compiledFiles.length === 1 && compiledFiles[0].path === 'compiled.js' && !compilerFlags['js_output_file']) {
-          console.log(compiledFiles[0].src);
+      const output = compiler.run(inputFiles);
+      if (output.errors.length > 0) {
+        process.exitCode = process.exitCode || 1;
+      }
+      logErrors(output, inputFiles);
+      if (output.compiledFiles.length > 0) {
+        // If a --js_output_file or --chunk flag was provided, the output should be written to disk
+        if (compilerFlags['js_output_file'] || compilerFlags['chunk']) {
+          let srcMapPattern = '%outname%.map';
+          // Unfortunately the JS version of the compiler supported the `--create_source_map` flag as a boolean.
+          // We now support it both as a boolean and as a string path pattern.
+          if (compilerFlags.create_source_map && typeof compilerFlags.create_source_map === 'string') {
+            srcMapPattern = compilerFlags.create_source_map;
+          }
+          output.compiledFiles.forEach(compiledFile => {
+            mkDirByPathSync(path.dirname(compiledFile.path));
+            fs.writeFileSync(compiledFile.path, compiledFile.src, 'utf8');
+            if (compiledFile.sourceMap) {
+              const srcMapPath = srcMapPattern.replace('%outname%', compiledFile.path);
+              mkDirByPathSync(path.dirname(srcMapPath));
+              fs.writeFileSync(srcMapPath, compiledFile.sourceMap, 'utf8');
+            }
+          });
+        } else {
+          process.stdout.write(`${output.compiledFiles[0].src}\n`);
         }
-
-        process.exitCode = process.exitCode || exitCode;
-      });
+      }
     })
     .catch(e => {
       console.error(e);

package/contrib/externs/angular-1.5-http-promise_templated.js

@@ -30,7 +30,7 @@
 angular.HttpCallback;
 
 /**
- * @constructor
+ * @interface
  * @template T
  */
 angular.$http.Response = function() {};
@@ -54,7 +54,7 @@ angular.$http.Response.prototype.headers = function(name) {};
 angular.$http.Response.prototype.config;
 
 /**
- * @constructor
+ * @interface
  * @extends {angular.$q.Promise.<!angular.$http.Response.<T>>}
  * @template T
  */

package/contrib/externs/angular-1.5-q_templated.js

@@ -28,14 +28,14 @@
  *****************************************************************************/
 
 /**
- * @constructor
+ * @interface
  */
 angular.$q = function() {};
 
 /**
- * @constructor
+ * @interface
  * @template T
- * @implements {IThenable<T>}
+ * @extends {IThenable<T>}
  */
 angular.$q.Promise = function() {};
 
@@ -80,7 +80,7 @@ angular.$q.Promise.prototype.finally =
     function(callback, opt_notifyCallback) {};
 
 /**
- * @constructor
+ * @interface
  * @template T
  */
 angular.$q.Deferred = function() {};

package/contrib/externs/angular-1.6.js

@@ -2373,6 +2373,31 @@ angular.$route.Route.prototype.regexp;
 /** @typedef {function(string):string} */
 angular.$sanitize;
 
+/******************************************************************************
+ * $sanitizeProvider Service
+ *****************************************************************************/
+
+/** @interface */
+angular.$sanitizeProvider = function() {};
+
+/**
+ * @param {boolean=} enableSvg
+ * @return {boolean|!angular.$sanitizeProvider}
+ */
+angular.$sanitizeProvider.prototype.enableSvg = function(enableSvg) {};
+
+/**
+ * @param {!Array<string>|!Object} elements
+ * @return {!angular.$sanitizeProvider}
+ */
+angular.$sanitizeProvider.prototype.addValidElements = function(elements) {};
+
+/**
+ * @param {!Array<string>} attrs
+ * @return {!angular.$sanitizeProvider}
+ */
+angular.$sanitizeProvider.prototype.addValidAttrs = function(attrs) {};
+
 /******************************************************************************
  * $sce Service
  *****************************************************************************/

package/contrib/externs/angular-material-1.1.js

@@ -1017,6 +1017,7 @@ md.$panel = function() {};
  *   onDomRemoved: (Function|undefined),
  *   origin: (!angular.JQLite|!Element|undefined),
  *   onCloseSuccess: (function(!md.$panel.MdPanelRef, string)|undefined),
+ *   groupName: (string|!Array<string>|undefined),
  * }}
  */
 md.$panel.config;
@@ -1039,6 +1040,23 @@ md.$panel.prototype.newPanelPosition = function() {};
 /** @return {!md.$panel.MdPanelAnimation} */
 md.$panel.prototype.newPanelAnimation = function() {};
 
+/**
+ * @param {string} groupName
+ * @param {{maxOpen: (number|undefined)}=} opt_config
+ * @return {{
+ *   panels: !Array<!md.$panel.MdPanelRef>,
+ *   openPanels: !Array<!md.$panel.MdPanelRef>,
+ *   maxOpen: number,
+ * }}
+ */
+md.$panel.prototype.newPanelGroup = function(groupName, opt_config) {};
+
+/**
+ * @param {string} groupName
+ * @param {number} maxOpen
+ */
+md.$panel.prototype.setGroupMaxOpen = function(groupName, maxOpen) {};
+
 /**
  * Possible values of xPosition.
  * @enum {string}
@@ -1280,3 +1298,15 @@ md.$panel.MdPanelAnimation.prototype.closeTo = function(closeTo) {};
  * @return {!md.$panel.MdPanelAnimation}
  */
 md.$panel.MdPanelAnimation.prototype.withAnimation = function(cssClass) {};
+
+/******************************************************************************
+ * DatePickerCtrl
+ *****************************************************************************/
+
+/** @interface */
+md.DatePickerCtrl = function() {};
+
+/**
+ * @param {Date=} opt_date
+ */
+md.DatePickerCtrl.prototype.updateErrorState = function(opt_date) {};

package/contrib/externs/angular-material.js

@@ -939,7 +939,8 @@ md.$panel = function() {};
  *   onRemoving: (Function|undefined),
  *   onDomRemoved: (Function|undefined),
  *   origin: (!angular.JQLite|!Element|undefined),
- *   onCloseSuccess: (function(md.$panel.MdPanelRef, string)|undefined)
+ *   onCloseSuccess: (function(md.$panel.MdPanelRef, string)|undefined),
+ *   groupName: (string|!Array<string>|undefined),
  * }}
  */
 md.$panel.config;
@@ -962,6 +963,23 @@ md.$panel.prototype.newPanelPosition = function() {};
 /** @return {!md.$panel.MdPanelAnimation} */
 md.$panel.prototype.newPanelAnimation = function() {};
 
+/**
+ * @param {string} groupName
+ * @param {{maxOpen: (number|undefined)}=} opt_config
+ * @return {{
+ *   panels: !Array<!md.$panel.MdPanelRef>,
+ *   openPanels: !Array<!md.$panel.MdPanelRef>,
+ *   maxOpen: number,
+ * }}
+ */
+md.$panel.prototype.newPanelGroup = function(groupName, opt_config) {};
+
+/**
+ * @param {string} groupName
+ * @param {number} maxOpen
+ */
+md.$panel.prototype.setGroupMaxOpen = function(groupName, maxOpen) {};
+
 /**
  * Possible values of xPosition.
  * @enum {string}
@@ -1052,6 +1070,27 @@ md.$panel.MdPanelRef.prototype.removeClass = function(classToRemove) {};
 /** @param {string} classToToggle */
 md.$panel.MdPanelRef.prototype.toggleClass = function(classToToggle) {};
 
+/**
+ * @param {string} type
+ * @param {function(): !angular.$q.Promise<*>} callback
+ * @return {!md.$panel.MdPanelRef}
+ */
+md.$panel.MdPanelRef.prototype.registerInterceptor =
+    function(type, callback) {};
+
+/**
+ * @param {string} type
+ * @param {function(): !angular.$q.Promise<*>} callback
+ * @return {!md.$panel.MdPanelRef}
+ */
+md.$panel.MdPanelRef.prototype.removeInterceptor = function(type, callback) {};
+
+/**
+ * @param {string=} opt_type
+ * @return {!md.$panel.MdPanelRef}
+ */
+md.$panel.MdPanelRef.prototype.removeAllInterceptors = function(opt_type) {};
+
 /**
  * @param {!angular.$window} $window
  * @constructor