google-ads-api 9.0.0 → 10.0.2

package/README.md

@@ -7,7 +7,7 @@
 </p>
 <p align="center">
   <a href="https://developers.google.com/google-ads/api/docs/release-notes">
-    <img src="https://img.shields.io/badge/google%20ads-v9.1.0-009688.svg?style=flat-square">
+    <img src="https://img.shields.io/badge/google%20ads-v10.0.0-009688.svg?style=flat-square">
   </a>
   <a href="https://www.npmjs.com/package/google-ads-api">
     <img src="https://img.shields.io/npm/v/google-ads-api.svg?style=flat-square">
@@ -15,14 +15,11 @@
   <a>
     <img src="https://img.shields.io/npm/dm/google-ads-api.svg?style=flat-square">
     </a>
-  <a>
-    <img src="https://img.shields.io/david/opteo/google-ads-api.svg?style=flat-square">
-  </a>
 </p>
 
 <p align="center">
   <a href="https://opteo.com">
-    <img src="https://app.opteo.com/icons/logo.svg">
+    <img src="https://app.opteo.com/img/opteo-icon-120.png">
   </a>
 </p>
 
@@ -102,7 +99,7 @@ const customer = client.Customer({
 
 ## List accessible customers
 
-This is a special client method for listing the accessible customers for a given refresh token, and is equivalent to [CustomerService.listAccessibleCustomers](https://developers.google.com/google-ads/api/reference/rpc/v9/CustomerService#listaccessiblecustomers). It returns the resource names of available customer accounts.
+This is a special client method for listing the accessible customers for a given refresh token, and is equivalent to [CustomerService.listAccessibleCustomers](https://developers.google.com/google-ads/api/reference/rpc/v10/CustomerService#listaccessiblecustomers). It returns the resource names of available customer accounts.
 
 ```ts
 const client = new GoogleAdsApi({
@@ -566,9 +563,9 @@ const customer = client.Customer({
 
 ## Error handling
 
-All errors, apart from GRPC specific cases (such as a connection problem or timeout, [see more here](https://github.com/grpc/grpc/blob/master/doc/statuscodes.md)), are instances of a [GoogleAdsFailure](https://developers.google.com/google-ads/api/reference/rpc/v9/GoogleAdsFailure).
+All errors, apart from GRPC specific cases (such as a connection problem or timeout, [see more here](https://github.com/grpc/grpc/blob/master/doc/statuscodes.md)), are instances of a [GoogleAdsFailure](https://developers.google.com/google-ads/api/reference/rpc/v10/GoogleAdsFailure).
 
-You can find a list of all error types for a specific version in [the official documentation](https://developers.google.com/google-ads/api/reference/rpc/v9/AccessInvitationErrorEnum.AccessInvitationError), as well as more information about [handling errors here](https://developers.google.com/google-ads/api/docs/best-practices/error-types).
+You can find a list of all error types for a specific version in [the official documentation](https://developers.google.com/google-ads/api/reference/rpc/v10/AccessInvitationErrorEnum.AccessInvitationError), as well as more information about [handling errors here](https://developers.google.com/google-ads/api/docs/best-practices/error-types).
 
 ```ts
 import { errors } from "google-ads-api";

package/build/src/parser.js

@@ -37,12 +37,17 @@ function parse(_a) {
     var queryFields = reportOptions
         ? getReportOptionFields(reportOptions)
         : getGAQLFields(gaqlString);
-    var allFields = __spreadArrays(queryFields, protos_1.fields.resourceNames);
+    // Add in all relevant resource_name fields, which are always returned by API
+    var entities = queryFields.map(function (field) { return field.split(".")[0]; });
+    var resourceNameFields = protos_1.fields.resourceNames.filter(function (resourceNameField) {
+        return entities.includes(resourceNameField.split(".")[0]);
+    });
+    var allFields = __spreadArrays(queryFields, resourceNameFields);
     return parseRows(results, allFields);
 }
 exports.parse = parse;
 // This function assumes that a gaql query is of the format "select * * * from * ...".
-// Queries that are no in this format should have thrown an error when called.
+// Queries that are not in this format should have thrown an error when called.
 function getGAQLFields(gaqlString) {
     var normalisedQuery = utils_1.normaliseQuery(gaqlString);
     var fields = normalisedQuery
@@ -65,15 +70,19 @@ function getReportOptionFields(reportOptions) {
 }
 exports.getReportOptionFields = getReportOptionFields;
 function parseRows(rows, fields) {
+    var fieldsPreSplit = {};
+    // pre-split all the field strings for performance reasons (increases speed by ~5x for large number of rows)
+    for (var _i = 0, fields_1 = fields; _i < fields_1.length; _i++) {
+        var field = fields_1[_i];
+        fieldsPreSplit[field] = field.split(".");
+    }
     var newRows = [];
     for (var r = 0; r < rows.length; r++) {
         var newRow = {};
         var originalRow = protos_1.services.GoogleAdsRow.fromObject(rows[r]);
-        for (var f = 0; f < fields.length; f++) {
-            var field = fields[f];
-            var split = field.split(".");
+        for (var split in fieldsPreSplit) {
             // @ts-expect-error These are the best we can do for these types
-            var parent_1 = split[0], children = split.slice(1);
+            var _a = fieldsPreSplit[split], parent_1 = _a[0], children = _a.slice(1);
             // Ignore null fields (unspecified resource names)
             if (!originalRow[parent_1]) {
                 continue;