google-ads-api 19.0.1 → 19.0.2

package/CHANGELOG.md

@@ -11,6 +11,10 @@ While these changes are inconvenient, the performance of the REST api is signifi
 
 To prepare for this change, we recommend you use the install the `19.0.0-rest-beta` version of this library and test your application with it.
 
+### 19.0.2
+
+- Fix issue with reportCount() not giving the correct total results count.
+
 ## 19.0.1
 
 - Fix issue with type interface for search_settings not showing any valid fields.

package/README.md

@@ -444,7 +444,7 @@ const [summaryRow, ...response] = await customer.report({
   entity: "campaign",
   metrics: ["metrics.clicks", "metrics.all_conversions"],
   search_settings: {
-    return_summary_row: enums.SummaryRowSetting.SUMMARY_ROW_WITH_RESULTS,
+    return_summary_row: true,
   },
 });
 ```
@@ -456,7 +456,7 @@ const stream = customer.reportStream({
   entity: "campaign",
   metrics: ["metrics.clicks", "metrics.all_conversions"],
   search_settings: {
-    return_summary_row: enums.SummaryRowSetting.SUMMARY_ROW_WITH_RESULTS,
+    return_summary_row: true,
   },
 });
 

package/build/src/customer.d.ts

@@ -3,7 +3,7 @@ import { ClientOptions } from "./client";
 import { Hooks } from "./hooks";
 import { services } from "./protos";
 import ServiceFactory from "./protos/autogen/serviceFactory";
-import { CustomerOptions, MutateOperation, MutateOptions, ReportOptions, RequestOptions } from "./types";
+import { CustomerOptions, MutateOperation, MutateOptions, ReportOptions, ReportOptionsWithTotalResults, RequestOptions } from "./types";
 export declare class Customer extends ServiceFactory {
     constructor(clientOptions: ClientOptions, customerOptions: CustomerOptions, hooks?: Hooks);
     /**
@@ -30,7 +30,7 @@ export declare class Customer extends ServiceFactory {
       @description Get the total row count of a report.
       @hooks none
     */
-    reportCount(options: Readonly<ReportOptions>): Promise<number | undefined>;
+    reportCount(options: Readonly<ReportOptionsWithTotalResults>): Promise<number | undefined>;
     /**
       @description Stream query using ReportOptions. If a generic type is provided, it must be the type of a single row.
       If a summary row is requested then this will be the last emitted row of the stream.

package/build/src/customer.js

@@ -49,9 +49,10 @@ class Customer extends serviceFactory_1.default {
       @hooks none
     */
     async reportCount(options) {
-        const { gaqlQuery, requestOptions } = (0, query_1.buildQuery)({ ...options, limit: 1 }); // must get at least one row
-        // @ts-expect-error we do not allow this field in reportOptions, however it is still a valid request option
-        requestOptions.return_total_results_count = true;
+        // must get at least one row
+        const { gaqlQuery, requestOptions } = (0, query_1.buildQuery)({ ...options, limit: 1 });
+        // We do not allow this field in reportOptions, however it is still a valid request option
+        requestOptions.search_settings = { return_total_results_count: true };
         const useHooks = false; // to avoid cacheing conflicts
         const { totalResultsCount } = await this.querier(gaqlQuery, requestOptions, options, useHooks);
         return totalResultsCount;

package/build/src/query.d.ts

@@ -1,5 +1,5 @@
 import { fields } from "./protos";
-import { ConstraintKey, ConstraintOperation, ConstraintValue, ReportOptions, RequestOptions, SortOrder } from "./types";
+import { ConstraintKey, ConstraintOperation, ConstraintValue, ReportOptions, RequestOptions, RequestOptionsWithTotalResults, SortOrder } from "./types";
 declare enum QueryKeywords {
     SELECT = "SELECT",
     FROM = "FROM",
@@ -57,6 +57,6 @@ export declare function buildOrderClause(order: Readonly<ReportOptions["order"]>
 export declare function buildRequestOptions(reportOptions: Readonly<ReportOptions>): RequestOptions;
 export declare function buildQuery(reportOptions: Readonly<ReportOptions>): {
     gaqlQuery: Query;
-    requestOptions: RequestOptions;
+    requestOptions: RequestOptionsWithTotalResults;
 };
 export {};

package/build/src/types.d.ts

@@ -27,6 +27,20 @@ export interface ReportOptions extends RequestOptions {
     from_date?: string;
     to_date?: string;
 }
+/**
+ * Add back optional return_total_results_count as it is still a valid request option
+ */
+type SearchSettingsWithOptionalTotalCount = {
+    search_settings?: Pick<services.ISearchSettings, "return_total_results_count" | "return_summary_row">;
+};
+/**
+ * Request Options with optional total count in search_settings
+ */
+export type RequestOptionsWithTotalResults = Omit<RequestOptions, "search_settings"> & SearchSettingsWithOptionalTotalCount;
+/**
+ * Report Options with optional total count in search_settings
+ */
+export type ReportOptionsWithTotalResults = Omit<ReportOptions, "search_settings"> & SearchSettingsWithOptionalTotalCount;
 export type DateConstant = "TODAY" | "YESTERDAY" | "LAST_7_DAYS" | "LAST_BUSINESS_WEEK" | "THIS_MONTH" | "LAST_MONTH" | "LAST_14_DAYS" | "LAST_30_DAYS" | "THIS_WEEK_SUN_TODAY" | "THIS_WEEK_MON_TODAY" | "LAST_WEEK_SUN_SAT" | "LAST_WEEK_MON_SUN";
 export declare const dateConstants: DateConstant[];
 export type SortOrder = "ASC" | "DESC";
@@ -58,3 +72,4 @@ export type MutateOperation<T> = {
     exempt_policy_violation_keys?: services.AdGroupCriterionOperation["exempt_policy_violation_keys"];
 } & Partial<Omit<T, "toJSON">>;
 export type PageToken = services.ISearchGoogleAdsResponse["next_page_token"];
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "google-ads-api",
-  "version": "19.0.1",
+  "version": "19.0.2",
   "description": "Google Ads API Client Library for Node.js",
   "repository": "https://github.com/Opteo/google-ads-api",
   "main": "build/src/index.js",