google-ads-api 16.0.0-rest-beta1 → 16.0.0-rest-beta3

package/build/src/customer.js

@@ -162,7 +162,6 @@ class Customer extends serviceFactory_1.default {
           When possible, use the searchStream method to avoid the overhead of pagination.
         */
         if (requestOptions.page_size === undefined &&
-            // @ts-expect-error we do not allow this field in reportOptions, however it is still a valid request option
             requestOptions.return_total_results_count === undefined) {
             // If no pagination or summary options are set, we can use the non-paginated search method.
             const { response } = await this.useStreamToImitateRegularSearch(gaqlQuery, requestOptions);
@@ -171,7 +170,13 @@ class Customer extends serviceFactory_1.default {
         const response = [];
         let nextPageToken = undefined;
         const initialSearch = await this.search(gaqlQuery, requestOptions);
-        const totalResultsCount = initialSearch.totalResultsCount;
+        let totalResultsCount = initialSearch.totalResultsCount;
+        // Sometimes (when no results?) the totalResultsCount field is not included in the response.
+        // In this case, we set it to 0.
+        if (requestOptions.return_total_results_count &&
+            initialSearch.totalResultsCount === undefined) {
+            totalResultsCount = 0;
+        }
         let summaryRow = initialSearch.summaryRow;
         response.push(...initialSearch.response);
         nextPageToken = initialSearch.nextPageToken;
@@ -481,8 +486,6 @@ class Customer extends serviceFactory_1.default {
             headers: {
                 Authorization: `Bearer ${accessToken}`,
                 ...this.callHeaders,
-                "developer-token": this.clientOptions.developer_token ?? "",
-                "login-customer-id": this.credentials.login_customer_id ?? "",
             },
             ...extra,
         };

package/build/src/service.js

@@ -21,7 +21,7 @@ const serviceCache = new ttlcache_1.default({
         await service.close();
     },
 });
-// A global access token cache used by REST calls. Issued tokens expire after 1 hour.
+// A global access token cache used by REST calls. Issued tokens expire after 1 hour, so we cache them for 50 minutes.
 const accessTokenCache = new ttlcache_1.default({
     max: 100_000,
     ttl: 50 * 60 * 1000, // 50 minutes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "google-ads-api",
-  "version": "16.0.0-rest-beta1",
+  "version": "16.0.0-rest-beta3",
   "description": "Google Ads API Client Library for Node.js",
   "repository": "https://github.com/Opteo/google-ads-api",
   "main": "build/src/index.js",