goodiffer 1.2.0 → 1.3.0

package/README.md

@@ -13,7 +13,9 @@ AI-powered git diff analyzer for code review - 基于 AI 的 Git Diff 智能分
 - 🔗 检测代码关联性风险
 - 📋 生成可复制的修复提示词，方便在 Claude Code / Codex 中使用
 - 🌐 支持第三方 API 代理
-- 🔮 **NEW** 支持代码上下文获取 (Tool Use)，AI 可按需读取相关源码
+- 🔮 支持代码上下文获取 (Tool Use)，AI 可按需读取相关源码
+- ⚡ **NEW** LSP 集成 - 提供类型信息、引用查找、符号导航等智能功能
+- 🧠 **NEW** Codex 深度审查 - 基于 GPT-5.2 的 8 维度深度代码审查
 
 ## Installation
 
@@ -79,19 +81,135 @@ goodiffer -c abc123 --context  # 分析指定 commit，启用上下文
 
 ### 代码上下文模式 (--context)
 
-启用 `--context` 选项后，AI 在分析代码时可以：
+启用 `--context` 选项后，AI 在分析代码时可以使用以下工具：
 
+#### 基础工具
 1. **read_file** - 读取项目中的源文件，了解函数/类的具体实现
 2. **find_definition** - 查找函数、类、变量的定义位置
 3. **search_code** - 在项目中搜索代码模式
 4. **list_files** - 列出目录结构
 
+#### LSP 增强工具 (TypeScript/JavaScript)
+5. **get_type_info** - 获取变量、函数的类型信息和文档
+6. **find_references** - 查找符号在整个项目中的所有引用位置
+7. **get_document_symbols** - 获取文件中的所有符号列表（函数、类、变量等）
+8. **go_to_definition** - 使用 LSP 精确定位符号的定义位置
+
+**LSP 工具优势：**
+- ✅ 精确的类型分析（支持 TypeScript/JavaScript）
+- ✅ 跨文件引用查找
+- ✅ 快速了解文件结构
+- ✅ 自动回退到正则搜索
+
 这使得 AI 能够：
 - 验证被调用函数的实现是否正确
 - 检查类型定义和接口
 - 发现潜在的关联影响
+- 了解代码的调用关系和依赖
+
+> **注意**: 此功能需要 Claude 模型（使用 Tool Use API）。LSP 功能自动启用，无需额外配置。
+
+### Codex 深度代码审查 (NEW)
+
+使用 OpenAI Codex (GPT-5.2) 进行深度代码审查，提供 8 维度质量评估和高推理分析。
+
+```bash
+# 使用 Codex 深度审查最近一次 commit
+goodiffer codex
+
+# 审查暂存区
+goodiffer codex -s
+
+# 审查指定 commit
+goodiffer codex -c abc123
+
+# 指定推理强度 (low/medium/high)
+goodiffer codex --reasoning high
+```
+
+#### Codex Review 特性
+
+**8 维度质量评估：**
+1. **Code Style & Formatting** - 代码风格与格式
+2. **Security & Compliance** - 安全性与合规性
+3. **Error Handling & Logging** - 错误处理与日志
+4. **Readability & Maintainability** - 可读性与可维护性
+5. **Performance & Scalability** - 性能与可扩展性
+6. **Testing & Quality Assurance** - 测试与质量保证
+7. **Documentation & Version Control** - 文档与版本控制
+8. **Accessibility & Internationalization** - 可访问性与国际化
+
+**评分系统：**
+- ⭐ **Extraordinary** (90-100) - 卓越质量
+- ✓ **Acceptable** (70-89) - 符合标准
+- ⚠️ **Poor** (0-69) - 需要改进
+
+**高推理模式：**
+- 使用 `reasoning: { effort: "high" }` 进行深度分析
+- 提供置信度评分（0.0-1.0）
+- 生成正确性判断（patch is correct / incorrect）
+
+**结构化输出：**
+- 使用 JSON Schema 定义输出格式（降低 35% 失败率）
+- 精确的文件/行号引用
+- 优先级分级（P0-P3）
+
+**输出示例：**
+```
+╭──────────────────────────────────────────────────────────╮
+│  Codex Deep Code Review Report                          │
+╰──────────────────────────────────────────────────────────╯
+
+📝 Commit: abc1234
+📋 Message: feat: add user authentication
+
+📊 Summary: 添加了用户认证功能...
+
+═══════════════════════════════════════════════════════════
+
+🎯 8-Dimensional Quality Assessment
+
+1. Security & Compliance
+   🌟 Rating: EXTRAORDINARY | Score: 95/100
+   密码加密使用了 bcrypt，符合安全标准
+
+2. Error Handling & Logging
+   ⚠️ Rating: POOR | Score: 60/100
+   缺少异常处理和日志记录
+   ▸ API 调用未处理错误情况
+   ▸ 缺少关键操作的日志
+
+═══════════════════════════════════════════════════════════
+
+⚖️  Overall Assessment
+
+✅ Correctness: PATCH IS CORRECT
+📈 Confidence: 85% (High)
+💡 Explanation: 代码功能正确，但需改进错误处理
+
+═══════════════════════════════════════════════════════════
+
+🔍 Findings (2)
+
+🟠 P1 - URGENT (1)
+
+[A] [P1] API 调用缺少错误处理
+
+   Location: src/auth/api.js:45-52
+   Confidence: 90% (Very High)
+   Dimension: Error Handling & Logging
+
+   在 loginUser 函数中直接调用 API 而未处理可能的网络错误...
+
+   💡 Suggestion: 添加 try-catch 块处理异常
+
+   📋 修复提示词 (复制到 Claude Code/Codex):
+   ┌──────────────────────────────────────────────────┐
+   │ 在 src/auth/api.js:45 添加 try-catch 处理异常   │
+   └──────────────────────────────────────────────────┘
+```
 
-> **注意**: 此功能需要 Claude 模型（使用 Tool Use API），建议在 Claude Code 环境中使用。
+> **推荐使用场景**: 关键代码审查、生产环境发布前、安全敏感功能
 
 ### 配置管理
 

package/bin/goodiffer.js

@@ -11,10 +11,10 @@ import { reportCommand } from '../src/commands/report.js';
 
 program
   .name('goodiffer')
-  .description('AI-powered git diff analyzer for code review')
-  .version('1.1.1');
+  .description('AI-powered git diff analyzer with Codex deep code review')
+  .version('1.2.1');
 
-// 默认命令 - 分析
+// 默认命令 - Codex 深度分析
 program
   .option('-s, --staged', '分析暂存区的更改')
   .option('-c, --commit <sha>', '分析指定的 commit')
@@ -22,7 +22,7 @@ program
   .option('--to <sha>', '结束 commit (与 --from 配合使用)')
   .option('-n <number>', '分析最近 n 条 commit (n <= 10), 或与 -m 配合表示起始位置')
   .option('-m <number>', '与 -n 配合使用，表示结束位置 (m-n <= 10)')
-  .option('--context', '启用代码上下文获取 (需要 Claude Code 环境)')
+  .option('--reasoning <level>', '推理强度: low, medium, high, none (默认 high)', 'high')
   .option('--no-save', '不保存到数据库')
   .action(async (options) => {
     await analyzeCommand(options);
@@ -88,7 +88,7 @@ program
   .option('--since <date>', '开始日期 (YYYY-MM-DD)')
   .option('--until <date>', '结束日期 (YYYY-MM-DD)')
   .option('-o, --output <path>', '输出文件路径')
-  .option('--open', '生成后自动打开')
+  .option('--no-open', '不自动打开浏览器')
   .option('-f, --force', '强制重新生成 (忽略缓存)')
   .action(async (options) => {
     await reportCommand(options);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "goodiffer",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "AI-powered git diff analyzer for code review - 智能代码审查工具",
   "type": "module",
   "bin": {

package/src/commands/analyze.js

@@ -2,25 +2,35 @@ import ora from 'ora';
 import { getConfig, isConfigured } from '../utils/config-store.js';
 import { GitService } from '../services/git.js';
 import { AIClient } from '../services/ai-client.js';
-import { buildReviewPrompt, buildReviewPromptWithTools } from '../prompts/review-prompt.js';
-import { generateReport } from '../services/reporter.js';
+import { buildCodexReviewPrompt } from '../prompts/codex-review-prompt.js';
+import { generateCodexReport } from '../services/codex-reporter.js';
 import { getDatabase } from '../services/database.js';
-import { CodeContextService } from '../services/code-context.js';
-import { MCPClientService } from '../services/mcp-client.js';
 import logger from '../utils/logger.js';
 
-// 解析 AI 响应
-function parseAIResponse(response) {
-  try {
-    let jsonStr = response;
-    const jsonMatch = response.match(/```(?:json)?\s*([\s\S]*?)```/);
-    if (jsonMatch) {
-      jsonStr = jsonMatch[1].trim();
-    }
-    return JSON.parse(jsonStr);
-  } catch {
-    return null;
+/**
+ * 提取统计数据
+ */
+function extractStats(result) {
+  const stats = {
+    p0: 0,
+    p1: 0,
+    p2: 0,
+    p3: 0,
+    risks: 0
+  };
+
+  if (result.findings) {
+    result.findings.forEach(f => {
+      const priority = f.priority || 3;
+      stats[`p${priority}`]++;
+    });
+  }
+
+  if (result.associationRisks) {
+    stats.risks = result.associationRisks.length;
   }
+
+  return stats;
 }
 
 export async function analyzeCommand(options) {
@@ -89,71 +99,49 @@ export async function analyzeCommand(options) {
       process.exit(1);
     }
 
-    // 获取项目信息和分支
+    // 获取项目信息
     const projectName = await git.getProjectName();
     const branch = await git.getCurrentBranch();
+    const changedFiles = await git.getChangedFiles(
+      options.commit || (options.from ? `${options.from}..${options.to}` : 'HEAD~1')
+    );
 
     spinner.succeed('获取 Git 信息完成');
 
-    // 检查是否启用代码上下文模式
-    const useContext = options.context;
-
-    // 如果启用上下文模式，提示信息
-    if (useContext) {
-      if (MCPClientService.isInClaudeCode()) {
-        logger.info('已启用代码上下文模式 (MCP)');
-      } else {
-        logger.info('已启用代码上下文模式 (本地文件读取)');
-      }
-    }
-
-    // 构建提示词
-    const prompt = useContext
-      ? buildReviewPromptWithTools(commitInfo.message, diff)
-      : buildReviewPrompt(commitInfo.message, diff);
+    // 构建 Codex review 提示词
+    const prompt = buildCodexReviewPrompt(commitInfo.message, diff, {
+      repository: projectName,
+      baseSha: options.from || 'HEAD~1',
+      headSha: options.to || commitInfo.sha,
+      changedFiles
+    });
 
     // 调用 AI 分析
-    spinner = ora('AI 正在分析代码...').start();
+    spinner = ora('Codex 深度分析中...').start();
 
     const aiClient = new AIClient(config);
-    let response = '';
+    let result = null;
 
     try {
-      if (useContext) {
-        // 启用代码上下文的分析模式
-        const codeContext = new CodeContextService(process.cwd());
-        await codeContext.initialize(true); // 尝试启用 MCP
-
-        const tools = CodeContextService.getToolDefinitions();
-
-        response = await aiClient.analyzeWithTools(
-          prompt,
-          tools,
-          async (toolName, toolInput) => {
-            return await codeContext.executeTool(toolName, toolInput);
-          },
-          (progress) => {
-            if (progress.type === 'iteration') {
-              spinner.text = `AI 正在分析... (迭代 ${progress.iteration})`;
-            } else if (progress.type === 'tool_calls') {
-              const toolNames = progress.tools.map(t => t.name).join(', ');
-              spinner.text = `AI 正在获取上下文: ${toolNames}`;
-            } else if (progress.type === 'tool_result') {
-              spinner.text = `AI 正在分析... (已获取 ${progress.tool} 结果)`;
-            }
-          },
-          10 // 增加最大迭代次数到 10
-        );
-
-        await codeContext.close();
-      } else {
-        // 普通分析模式
-        response = await aiClient.analyzeStream(prompt, (chunk) => {
-          spinner.text = `AI 正在分析... (${response.length} 字符)`;
-        });
-      }
+      // 使用 Codex 深度分析
+      const reasoningEffort = options.reasoning || 'high';
+
+      result = await aiClient.analyzeWithCodex(prompt, {
+        reasoningEffort: reasoningEffort,
+        onProgress: (progress) => {
+          if (progress.type === 'info') {
+            spinner.text = progress.message;
+          } else if (progress.type === 'analyzing') {
+            spinner.text = '🧠 Codex 深度分析中...';
+          } else if (progress.type === 'complete') {
+            spinner.succeed('✅ 分析完成');
+          } else if (progress.type === 'error') {
+            spinner.fail(`❌ ${progress.message}`);
+          }
+        }
+      });
     } catch (error) {
-      spinner.fail('AI 分析失败');
+      spinner.fail('分析失败');
       if (error.message.includes('401')) {
         logger.error('API Key 无效或已过期');
       } else if (error.message.includes('403')) {
@@ -174,10 +162,8 @@ export async function analyzeCommand(options) {
       process.exit(1);
     }
 
-    spinner.succeed('AI 分析完成');
-
-    // 生成报告
-    generateReport(response, commitInfo);
+    // 生成 Codex 格式报告
+    generateCodexReport(result, commitInfo);
 
     // 保存到数据库 (除非指定 --no-save)
     if (options.save !== false) {
@@ -190,44 +176,8 @@ export async function analyzeCommand(options) {
         // 获取或创建开发者
         const developer = db.getOrCreateDeveloper(author.email, author.name);
 
-        // 解析 AI 响应
-        const parsed = parseAIResponse(response);
-
         // 提取统计数据
-        let summary = '';
-        let commitMatch = false;
-        let commitMatchReason = '';
-        let errorCount = 0;
-        let warningCount = 0;
-        let infoCount = 0;
-        let riskCount = 0;
-        let issues = [];
-        let associationRisks = [];
-
-        if (parsed) {
-          summary = parsed.summary || '';
-          commitMatch = parsed.commitMatch || false;
-          commitMatchReason = parsed.commitMatchReason || '';
-
-          // 支持新格式 findings (按优先级统计)
-          if (parsed.findings && Array.isArray(parsed.findings)) {
-            issues = parsed.findings;
-            errorCount = issues.filter(i => i.priority === 0 || i.priority === 1).length; // P0, P1 算 error
-            warningCount = issues.filter(i => i.priority === 2).length; // P2 算 warning
-            infoCount = issues.filter(i => i.priority === 3 || i.priority === undefined).length; // P3 算 info
-          } else if (parsed.issues && Array.isArray(parsed.issues)) {
-            // 兼容旧格式
-            issues = parsed.issues;
-            errorCount = issues.filter(i => i.level === 'error').length;
-            warningCount = issues.filter(i => i.level === 'warning').length;
-            infoCount = issues.filter(i => i.level === 'info').length;
-          }
-
-          if (parsed.associationRisks && Array.isArray(parsed.associationRisks)) {
-            associationRisks = parsed.associationRisks;
-            riskCount = associationRisks.length;
-          }
-        }
+        const stats = extractStats(result);
 
         // 保存 review 记录
         const reviewId = db.saveReview({
@@ -243,18 +193,20 @@ export async function analyzeCommand(options) {
           filesChanged: diffStats.filesChanged,
           insertions: diffStats.insertions,
           deletions: diffStats.deletions,
-          diffContent: null, // 不存储 diff 内容以节省空间
-          aiResponse: response,
-          summary,
-          commitMatch,
-          commitMatchReason,
-          errorCount,
-          warningCount,
-          infoCount,
-          riskCount,
+          diffContent: null,
+          aiResponse: JSON.stringify(result, null, 2),
+          summary: result.summary || '',
+          commitMatch: result.commitMatch || false,
+          commitMatchReason: result.commitMatchReason || '',
+          errorCount: stats.p0 + stats.p1,
+          warningCount: stats.p2,
+          infoCount: stats.p3,
+          riskCount: stats.risks,
           modelUsed: config.model,
-          issues,
-          associationRisks
+          issues: result.findings || [],
+          associationRisks: result.associationRisks || [],
+          dimensions: result.dimensions || [],
+          overallAssessment: result.overall_assessment || {}
         });
 
         logger.success(`Review #${reviewId} 已保存到数据库`);
@@ -284,7 +236,6 @@ async function analyzeMultipleCommits(options, config, git) {
   }
 
   if (n !== null && m === null) {
-    // 只有 -n，表示分析最近 n 条
     if (n <= 0 || n > 10) {
       logger.error('n 必须在 1-10 之间');
       process.exit(1);
@@ -292,7 +243,6 @@ async function analyzeMultipleCommits(options, config, git) {
   }
 
   if (n !== null && m !== null) {
-    // 同时有 -n 和 -m，表示第 n 条到第 m 条
     if (n <= 0 || m <= 0) {
       logger.error('n 和 m 必须大于 0');
       process.exit(1);
@@ -313,10 +263,8 @@ async function analyzeMultipleCommits(options, config, git) {
     // 获取 commits
     let commits;
     if (m !== null) {
-      // 第 n 条到第 m 条
       commits = await git.getCommitRange(n, m);
     } else {
-      // 最近 n 条
       commits = await git.getRecentCommits(n);
     }
 
@@ -347,10 +295,9 @@ async function analyzeMultipleCommits(options, config, git) {
       const commit = commits[i];
       const shortSha = commit.sha.substring(0, 7);
 
-      spinner = ora(`[${i + 1}/${commits.length}] 分析 commit ${shortSha}...`).start();
+      spinner = ora(`[${i + 1}/${commits.length}] Codex 分析 commit ${shortSha}...`).start();
 
       try {
-        // 获取 diff
         const diff = await git.getCommitDiff(commit.sha);
         if (!diff || diff.trim() === '') {
           spinner.warn(`[${i + 1}/${commits.length}] commit ${shortSha} 没有代码变更，跳过`);
@@ -358,14 +305,26 @@ async function analyzeMultipleCommits(options, config, git) {
         }
 
         const diffStats = await git.getDiffStats(`${commit.sha}~1`, commit.sha);
+        const changedFiles = await git.getChangedFiles(commit.sha);
+
+        // 构建 Codex prompt
+        const prompt = buildCodexReviewPrompt(commit.message, diff, {
+          repository: projectName,
+          baseSha: `${commit.sha}~1`,
+          headSha: commit.sha,
+          changedFiles
+        });
 
-        // 构建提示词并分析
-        const prompt = buildReviewPrompt(commit.message, diff);
-        let response = '';
+        let result = null;
 
         try {
-          response = await aiClient.analyzeStream(prompt, (chunk) => {
-            spinner.text = `[${i + 1}/${commits.length}] 分析 commit ${shortSha}... (${response.length} 字符)`;
+          result = await aiClient.analyzeWithCodex(prompt, {
+            reasoningEffort: options.reasoning || 'high',
+            onProgress: (progress) => {
+              if (progress.type === 'info') {
+                spinner.text = `[${i + 1}/${commits.length}] ${progress.message}`;
+              }
+            }
           });
         } catch (error) {
           spinner.fail(`[${i + 1}/${commits.length}] commit ${shortSha} 分析失败: ${error.message}`);
@@ -375,7 +334,7 @@ async function analyzeMultipleCommits(options, config, git) {
         spinner.succeed(`[${i + 1}/${commits.length}] commit ${shortSha} 分析完成`);
 
         // 生成报告
-        generateReport(response, { sha: commit.sha, message: commit.message });
+        generateCodexReport(result, { sha: commit.sha, message: commit.message });
 
         // 保存到数据库
         if (options.save !== false) {
@@ -383,41 +342,7 @@ async function analyzeMultipleCommits(options, config, git) {
             const db = getDatabase();
             const project = db.getOrCreateProject(projectName, process.cwd());
             const developer = db.getOrCreateDeveloper(commit.author.email, commit.author.name);
-            const parsed = parseAIResponse(response);
-
-            let summary = '';
-            let commitMatch = false;
-            let commitMatchReason = '';
-            let errorCount = 0;
-            let warningCount = 0;
-            let infoCount = 0;
-            let riskCount = 0;
-            let issues = [];
-            let associationRisks = [];
-
-            if (parsed) {
-              summary = parsed.summary || '';
-              commitMatch = parsed.commitMatch || false;
-              commitMatchReason = parsed.commitMatchReason || '';
-
-              // 支持新格式 findings (按优先级统计)
-              if (parsed.findings && Array.isArray(parsed.findings)) {
-                issues = parsed.findings;
-                errorCount = issues.filter(i => i.priority === 0 || i.priority === 1).length;
-                warningCount = issues.filter(i => i.priority === 2).length;
-                infoCount = issues.filter(i => i.priority === 3 || i.priority === undefined).length;
-              } else if (parsed.issues && Array.isArray(parsed.issues)) {
-                issues = parsed.issues;
-                errorCount = issues.filter(i => i.level === 'error').length;
-                warningCount = issues.filter(i => i.level === 'warning').length;
-                infoCount = issues.filter(i => i.level === 'info').length;
-              }
-
-              if (parsed.associationRisks && Array.isArray(parsed.associationRisks)) {
-                associationRisks = parsed.associationRisks;
-                riskCount = associationRisks.length;
-              }
-            }
+            const stats = extractStats(result);
 
             const reviewId = db.saveReview({
               projectId: project.id,
@@ -433,17 +358,19 @@ async function analyzeMultipleCommits(options, config, git) {
               insertions: diffStats.insertions,
               deletions: diffStats.deletions,
               diffContent: null,
-              aiResponse: response,
-              summary,
-              commitMatch,
-              commitMatchReason,
-              errorCount,
-              warningCount,
-              infoCount,
-              riskCount,
+              aiResponse: JSON.stringify(result, null, 2),
+              summary: result.summary || '',
+              commitMatch: result.commitMatch || false,
+              commitMatchReason: result.commitMatchReason || '',
+              errorCount: stats.p0 + stats.p1,
+              warningCount: stats.p2,
+              infoCount: stats.p3,
+              riskCount: stats.risks,
               modelUsed: config.model,
-              issues,
-              associationRisks
+              issues: result.findings || [],
+              associationRisks: result.associationRisks || [],
+              dimensions: result.dimensions || [],
+              overallAssessment: result.overall_assessment || {}
             });
 
             results.push({ commit, reviewId, success: true });

package/src/commands/report.js

@@ -65,7 +65,8 @@ export async function reportCommand(options) {
       console.log();
       logger.success(`报告已保存到: ${outputPath}`);
 
-      if (options.open) {
+      // 自动在浏览器中打开报告
+      if (options.open !== false) {
         await open(outputPath);
       }
 
@@ -137,9 +138,9 @@ export async function reportCommand(options) {
         console.log(`  状态: 使用缓存 (无新数据)`);
       }
 
-      if (options.open) {
+      // 自动在浏览器中打开报告
+      if (options.open !== false) {
         console.log();
-        logger.info('正在打开报告...');
         await open(outputPath);
       }
     }