goke 6.14.0 → 6.14.1

package/dist/daemon.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"daemon.d.ts","sourceRoot":"","sources":["../src/daemon.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AA6IH,UAAU,kBAAkB;IAC1B,8DAA8D;IAC9D,SAAS,CAAC,EAAE,MAAM,CAAA;IAClB,gEAAgE;IAChE,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B;;;;;;;OAOG;IACH,MAAM,CAAC,EAAE,OAAO,CAAA;CACjB;AAED;;;;;;;;;;GAUG;AACH,cAAM,aAAa;;IACjB,uDAAuD;IACvD,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAA;gBAYxB,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,EACnB,IAAI,EAAE,MAAM,EAAE,EACd,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,CAAC;IAc1C;;;;;;OAMG;IACH,UAAU,CAAC,WAAW,EAAE,MAAM,GAAG,aAAa;IAkF9C;;;;;;;;OAQG;IACG,KAAK,CAAC,OAAO,CAAC,EAAE,kBAAkB,GAAG,OAAO,CAAC,IAAI,CAAC;IAoDxD;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB3B;;;;OAIG;IACG,SAAS,IAAI,OAAO,CAAC,OAAO,CAAC;CAcpC;AAED;;;GAGG;AACH,iBAAS,mBAAmB,CAC1B,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,EACnB,IAAI,EAAE,MAAM,EAAE,EACd,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,CAAC,GACvC,aAAa,CAEf;AAED,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,CAAA;AAC7C,YAAY,EAAE,kBAAkB,EAAE,CAAA"}
+{"version":3,"file":"daemon.d.ts","sourceRoot":"","sources":["../src/daemon.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AA6IH,UAAU,kBAAkB;IAC1B,8DAA8D;IAC9D,SAAS,CAAC,EAAE,MAAM,CAAA;IAClB,gEAAgE;IAChE,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;IAC5B;;;;;;;OAOG;IACH,MAAM,CAAC,EAAE,OAAO,CAAA;CACjB;AAED;;;;;;;;;;GAUG;AACH,cAAM,aAAa;;IACjB,uDAAuD;IACvD,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAA;gBAYxB,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,EACnB,IAAI,EAAE,MAAM,EAAE,EACd,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,CAAC;IAc1C;;;;;;OAMG;IACH,UAAU,CAAC,WAAW,EAAE,MAAM,GAAG,aAAa;IAkF9C;;;;;;;;OAQG;IACG,KAAK,CAAC,OAAO,CAAC,EAAE,kBAAkB,GAAG,OAAO,CAAC,IAAI,CAAC;IAoExD;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB3B;;;;OAIG;IACG,SAAS,IAAI,OAAO,CAAC,OAAO,CAAC;CAcpC;AAED;;;GAGG;AACH,iBAAS,mBAAmB,CAC1B,OAAO,EAAE,MAAM,EACf,WAAW,EAAE,MAAM,EACnB,IAAI,EAAE,MAAM,EAAE,EACd,GAAG,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,CAAC,GACvC,aAAa,CAEf;AAED,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,CAAA;AAC7C,YAAY,EAAE,kBAAkB,EAAE,CAAA"}

package/dist/daemon.js

@@ -281,11 +281,38 @@ class DaemonContext {
         const execPath = this.#argv[0];
         const args = this.#argv.slice(1);
         const child = spawn(execPath, args, {
-            detached: true,
+            // Detach only when running in background so the daemon outlives the
+            // parent. In attached mode, keep the child in the same process group
+            // so signals propagate naturally and the parent stays alive.
+            detached: !attach,
             stdio: attach ? ['ignore', 'inherit', 'inherit'] : 'ignore',
             env,
         });
-        child.unref();
+        // Only unref when detached (non-attached) so the parent can exit
+        // immediately. In attached mode, the parent must stay alive to wait for
+        // the child's 'close' event — unref() would let the event loop drain
+        // and the parent would exit before the child finishes.
+        if (!attach) {
+            child.unref();
+        }
+        // Register close/error listeners immediately after spawn, before the
+        // PID file polling loop. If the child exits very quickly (writes PID
+        // file then exits), registering listeners after seeing the PID file
+        // could miss the 'close' event and hang the promise forever.
+        let childDone;
+        if (attach) {
+            childDone = new Promise((resolve, reject) => {
+                child.on('close', (code) => {
+                    if (code && code !== 0) {
+                        reject(new Error(`Daemon "${this.#cliName} ${this.#commandName}" exited with code ${code}`));
+                    }
+                    else {
+                        resolve();
+                    }
+                });
+                child.on('error', reject);
+            });
+        }
         // Brief wait to confirm the daemon started and wrote its PID file
         const startDeadline = Date.now() + 5000;
         while (Date.now() < startDeadline) {
@@ -294,18 +321,7 @@ class DaemonContext {
             if (pidData && isProcessAlive(pidData.pid)) {
                 if (!attach)
                     return;
-                // Attached mode: wait for the daemon process to exit
-                return new Promise((resolve, reject) => {
-                    child.on('close', (code) => {
-                        if (code && code !== 0) {
-                            reject(new Error(`Daemon "${this.#cliName} ${this.#commandName}" exited with code ${code}`));
-                        }
-                        else {
-                            resolve();
-                        }
-                    });
-                    child.on('error', reject);
-                });
+                return childDone;
             }
         }
         throw new Error(`Failed to start daemon for "${this.#cliName} ${this.#commandName}"`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "goke",
-  "version": "6.14.0",
+  "version": "6.14.1",
   "type": "module",
   "description": "Simple yet powerful framework for building command-line apps. Inspired by cac.",
   "repository": {

package/src/daemon.ts

@@ -340,12 +340,39 @@ class DaemonContext {
     const args = this.#argv.slice(1)
 
     const child = spawn(execPath, args, {
-      detached: true,
+      // Detach only when running in background so the daemon outlives the
+      // parent. In attached mode, keep the child in the same process group
+      // so signals propagate naturally and the parent stays alive.
+      detached: !attach,
       stdio: attach ? ['ignore', 'inherit', 'inherit'] : 'ignore',
       env,
     })
 
-    child.unref()
+    // Only unref when detached (non-attached) so the parent can exit
+    // immediately. In attached mode, the parent must stay alive to wait for
+    // the child's 'close' event — unref() would let the event loop drain
+    // and the parent would exit before the child finishes.
+    if (!attach) {
+      child.unref()
+    }
+
+    // Register close/error listeners immediately after spawn, before the
+    // PID file polling loop. If the child exits very quickly (writes PID
+    // file then exits), registering listeners after seeing the PID file
+    // could miss the 'close' event and hang the promise forever.
+    let childDone: Promise<void> | undefined
+    if (attach) {
+      childDone = new Promise<void>((resolve, reject) => {
+        child.on('close', (code) => {
+          if (code && code !== 0) {
+            reject(new Error(`Daemon "${this.#cliName} ${this.#commandName}" exited with code ${code}`))
+          } else {
+            resolve()
+          }
+        })
+        child.on('error', reject)
+      })
+    }
 
     // Brief wait to confirm the daemon started and wrote its PID file
     const startDeadline = Date.now() + 5000
@@ -354,18 +381,7 @@ class DaemonContext {
       const pidData = readPidFile(this.#pidFile)
       if (pidData && isProcessAlive(pidData.pid)) {
         if (!attach) return
-
-        // Attached mode: wait for the daemon process to exit
-        return new Promise<void>((resolve, reject) => {
-          child.on('close', (code) => {
-            if (code && code !== 0) {
-              reject(new Error(`Daemon "${this.#cliName} ${this.#commandName}" exited with code ${code}`))
-            } else {
-              resolve()
-            }
-          })
-          child.on('error', reject)
-        })
+        return childDone
       }
     }