goke 6.10.0 → 6.12.0

package/src/__test__/just-bash.test.ts

@@ -54,7 +54,7 @@ function gokeTestable(name = '', options?: Partial<GokeOptions>) {
 }
 
 describe('injected execution context', () => {
-  test('command action receives injected console and process', () => {
+  test('command action receives injected console and process', async () => {
     const stdout = createTestOutputStream()
     const cli = gokeTestable('mycli', { stdout })
     let seenArgv: string[] | undefined
@@ -66,13 +66,13 @@ describe('injected execution context', () => {
         seenArgv = process.argv
       })
 
-    cli.parse(['node', 'bin', 'status'], { run: true })
+    await cli.parse(['node', 'bin', 'status'], { run: true })
 
     expect(stdout.text).toBe('ready\n')
     expect(seenArgv).toEqual(['node', 'bin', 'status'])
   })
 
-  test('middleware receives injected console and process', () => {
+  test('middleware receives injected console and process', async () => {
     const stdout = createTestOutputStream()
     const cli = gokeTestable('mycli', { stdout })
     let seenArgv: string[] | undefined
@@ -85,7 +85,7 @@ describe('injected execution context', () => {
       .command('build', 'Build')
       .action(() => {})
 
-    cli.parse(['node', 'bin', 'build'], { run: true })
+    await cli.parse(['node', 'bin', 'build'], { run: true })
 
     expect(stdout.text).toBe('middleware\n')
     expect(seenArgv).toEqual(['node', 'bin', 'build'])
@@ -93,14 +93,14 @@ describe('injected execution context', () => {
 })
 
 describe('clone', () => {
-  test('clone creates isolated parse state', () => {
+  test('clone creates isolated parse state', async () => {
     const cli = gokeTestable('mycli')
 
     cli.command('build', 'Build').action(() => {})
 
     const cloned = cli.clone({ exit: () => {} })
 
-    cloned.parse(['node', 'bin', 'build'], { run: false })
+    await cloned.parse(['node', 'bin', 'build'], { run: false })
 
     expect(cloned).not.toBe(cli)
     expect(cloned.matchedCommandName).toBe('build')
@@ -109,7 +109,7 @@ describe('clone', () => {
 })
 
 describe('createExecutionContext', () => {
-  test('returns a context that mirrors the cli defaults when called with no override', () => {
+  test('returns a context that mirrors the cli defaults when called with no override', async () => {
     const stdout = createTestOutputStream()
     const stderr = createTestOutputStream()
     const cli = gokeTestable('mycli', {

package/src/__test__/readme-examples.test.ts

@@ -52,7 +52,7 @@ describe('README smoke tests', () => {
         console.log(`logs ${deploymentId} ${options.lines}`)
       })
 
-    cli.parse(['node', 'bin', '--env', 'production', 'up', '--dry-run'], { run: false })
+    await cli.parse(['node', 'bin', '--env', 'production', 'up', '--dry-run'], { run: false })
     await cli.runMatchedCommand()
 
     expect(stdout.text).toBe(
@@ -61,7 +61,7 @@ describe('README smoke tests', () => {
 
     stdout.lines.length = 0
 
-    cli.parse(['node', 'bin', 'logs', 'dep_123'], { run: false })
+    await cli.parse(['node', 'bin', 'logs', 'dep_123'], { run: false })
     await cli.runMatchedCommand()
 
     expect(stdout.text).toBe('Environment: staging\nlogs dep_123 100\n')
@@ -96,7 +96,7 @@ describe('README smoke tests', () => {
 
     expect(stripAnsi(cli.helpText())).toContain('mycli lint src/**/*.ts')
 
-    cli.parse(['node', 'bin', '--type', 'bun', '--name', 'Tommy', 'build', 'src/index.ts', '--minify'], { run: false })
+    await cli.parse(['node', 'bin', '--type', 'bun', '--name', 'Tommy', 'build', 'src/index.ts', '--minify'], { run: false })
     await cli.runMatchedCommand()
 
     expect(stdout.text).toBe(
@@ -135,7 +135,7 @@ describe('README smoke tests', () => {
         )
       })
 
-    cli.parse(['node', 'bin', '--env', 'staging', '--dry-run'], { run: false })
+    await cli.parse(['node', 'bin', '--env', 'staging', '--dry-run'], { run: false })
     await cli.runMatchedCommand()
 
     expect(stdout.text).toBe(
@@ -144,7 +144,7 @@ describe('README smoke tests', () => {
 
     stdout.lines.length = 0
 
-    cli.parse(['node', 'bin', 'logs', 'abc123', '--follow'], { run: false })
+    await cli.parse(['node', 'bin', 'logs', 'abc123', '--follow'], { run: false })
     await cli.runMatchedCommand()
 
     expect(stdout.text).toBe(
@@ -154,7 +154,7 @@ describe('README smoke tests', () => {
 })
 
 describe('documented command APIs', () => {
-  test('alias runs the same command through a short name', () => {
+  test('alias runs the same command through a short name', async () => {
     const cli = gokeTestable('mycli')
     let seen = ''
 
@@ -162,12 +162,12 @@ describe('documented command APIs', () => {
       seen = 'install'
     })
 
-    cli.parse(['node', 'bin', 'i'], { run: true })
+    await cli.parse(['node', 'bin', 'i'], { run: true })
 
     expect(seen).toBe('install')
   })
 
-  test('command helpText returns command-specific help without printing', () => {
+  test('command helpText returns command-specific help without printing', async () => {
     const stdout = createTestOutputStream()
     const cli = goke('mycli', { stdout })
 
@@ -225,7 +225,7 @@ describe('documented command APIs', () => {
 })
 
 describe('generateDocs', () => {
-  test('generates pages for CLI with multiple commands', () => {
+  test('generates pages for CLI with multiple commands', async () => {
     const cli = gokeTestable('sentry')
       .version('1.0.0')
       .help()
@@ -352,13 +352,13 @@ describe('generateDocs', () => {
     `)
   })
 
-  test('handles CLI with no commands', () => {
+  test('handles CLI with no commands', async () => {
     const cli = gokeTestable('empty')
     const pages = generateDocs({ cli })
     expect(pages).toEqual([])
   })
 
-  test('skips deprecated options', () => {
+  test('skips deprecated options', async () => {
     const cli = gokeTestable('mycli')
     cli
       .command('deploy', 'Deploy the app')

package/src/goke.ts

@@ -1230,7 +1230,7 @@ class Goke<Opts = {}> extends EventEmitter {
     this.stderr = options?.stderr ?? process.stderr
     this.console = createConsole(this.stdout, this.stderr)
     this.columns = options?.columns ?? process.stdout.columns ?? Number.POSITIVE_INFINITY
-    this.exit = options?.exit ?? ((code: number) => process.exit(code))
+    this.exit = options?.exit ?? ((code) => process.exit(code))
     this.#defaultArgv = options?.argv ?? processArgs
     this.globalCommand = new GlobalCommand(this)
     this.globalCommand.usage('<command> [options]')
@@ -1433,7 +1433,7 @@ class Goke<Opts = {}> extends EventEmitter {
    *
    * // main.ts
    * import { selfhostCli } from './selfhost.js'
-   * goke('mycli')
+   * await goke('mycli')
    *   .use(selfhostCli)
    *   .help()
    *   .parse(process.argv)
@@ -1595,7 +1595,7 @@ class Goke<Opts = {}> extends EventEmitter {
    *
    * @example
    * ```ts
-   * goke('mycli')
+   * await goke('mycli')
    *   .help()
    *   .completions()
    *   .command('deploy', 'Deploy the app')
@@ -1740,7 +1740,7 @@ class Goke<Opts = {}> extends EventEmitter {
     })
 
     for (const command of sortedCommands) {
-      const result = command.isMatched(previous as string[])
+      const result = command.isMatched(previous)
       if (result.matched) {
         matchedCommand = command
         consumedArgs = result.consumedArgs
@@ -1890,15 +1890,15 @@ class Goke<Opts = {}> extends EventEmitter {
   }
 
   /**
-   * Parse argv
+   * Parse argv and await the matched command when run is enabled.
    */
-  parse(
+  async parse(
     argv = this.#defaultArgv,
     {
       /** Whether to run the action for matched command */
       run = true,
     } = {}
-  ): ParsedArgv {
+  ): Promise<ParsedArgv> {
     this.rawArgs = argv
     if (!this.name) {
       this.name = argv[1] ? getFileName(argv[1]) : 'cli'
@@ -1964,6 +1964,11 @@ class Goke<Opts = {}> extends EventEmitter {
                 // Don't match default command - let it fall through to "unknown command"
                 continue
               }
+              // Default command defines no positional args but user passed args;
+              // skip matching so unknown args fall through to "unknown command"
+              if (command.args.length === 0) {
+                continue
+              }
             }
             shouldParse = false
             this.setParsedInfo(parsed, command)
@@ -2014,7 +2019,7 @@ class Goke<Opts = {}> extends EventEmitter {
     const parsedArgv = { args: this.args, options: this.options }
 
     if (run) {
-      this.runMatchedCommand()
+      await this.runMatchedCommand()
     }
 
     if (!this.matchedCommand && this.args[0] && !(this.options.help && this.showHelpOnExit)) {

package/src/just-bash.ts

@@ -323,8 +323,7 @@ export function createJustBashCommand(
       cloned.name = name
 
       try {
-        cloned.parse(argv, { run: false })
-        await cloned.runMatchedCommand()
+        await cloned.parse(argv)
         const result = output.getResult()
         return {
           stdout: result.stdout,