gogcli-mcp-sheets 2.6.0 → 2.6.1

package/.claude-plugin/marketplace.json

@@ -7,7 +7,7 @@
   },
   "metadata": {
     "description": "Extended Google Sheets for Claude via gogcli — auth + full Sheets support",
-    "version": "2.6.0"
+    "version": "2.6.1"
   },
   "plugins": [
     {
@@ -15,7 +15,7 @@
       "displayName": "gogcli (Sheets)",
       "source": "./",
       "description": "Extended Google Sheets for Claude via gogcli — auth + full Sheets support",
-      "version": "2.6.0",
+      "version": "2.6.1",
       "author": {
         "name": "Chris Hall"
       },

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "gogcli-mcp-sheets",
   "displayName": "gogcli (Sheets)",
-  "version": "2.6.0",
+  "version": "2.6.1",
   "description": "Extended Google Sheets for Claude via gogcli — auth + full Sheets support",
   "author": {
     "name": "Chris Hall",

package/dist/index.js

@@ -31399,7 +31399,7 @@ function registerSheetsTools(server2) {
 }
 
 // ../gogcli-mcp/src/server.ts
-var VERSION = true ? "2.6.0" : "0.0.0";
+var VERSION = true ? "2.6.1" : "0.0.0";
 function createServer(options) {
   return new McpServer({
     name: options?.name ?? "gogcli",
@@ -31552,7 +31552,7 @@ function registerExtraSheetsTools(server2) {
       account: accountParam
     }
   }, async ({ spreadsheetId, sheet, dimension, start, count, after, inheritFromBefore, account }) => {
-    const effectiveStart = after ? start + 1 : start;
+    const effectiveStart = start + 1;
     const args = ["sheets", "insert", spreadsheetId, sheet, dimension, String(effectiveStart)];
     if (count !== void 0) args.push(`--count=${count}`);
     if (after) args.push("--after");

package/manifest.json

@@ -3,7 +3,7 @@
   "manifest_version": "0.3",
   "name": "gogcli-mcp-sheets",
   "display_name": "gogcli (Sheets)",
-  "version": "2.6.0",
+  "version": "2.6.1",
   "description": "Extended Google Sheets for Claude via gogcli — auth + full Sheets support",
   "author": {
     "name": "Chris Hall",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gogcli-mcp-sheets",
-  "version": "2.6.0",
+  "version": "2.6.1",
   "mcpName": "io.github.chrischall/gogcli-mcp-sheets",
   "description": "Extended Google Sheets MCP server via gogcli — all base tools plus full Sheets support",
   "author": "Claude Code (AI) <https://www.anthropic.com/claude>",

package/server.json

@@ -7,12 +7,12 @@
     "source": "github",
     "subfolder": "packages/gogcli-mcp-sheets"
   },
-  "version": "2.6.0",
+  "version": "2.6.1",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "gogcli-mcp-sheets",
-      "version": "2.6.0",
+      "version": "2.6.1",
       "transport": {
         "type": "stdio"
       },

package/src/tools/sheets-extra.ts

@@ -182,11 +182,12 @@ export function registerExtraSheetsTools(server: McpServer): void {
       account: accountParam,
     },
   }, async ({ spreadsheetId, sheet, dimension, start, count, after, inheritFromBefore, account }) => {
-    // The underlying `gog sheets insert` treats `start` as 1-based with `--after` shifting +1.
-    // To honor our 0-based `start` and make `after:true` actually shift the insertion to start+1
-    // (issue #42), we send `start+1` when `after:true`. With after:false the CLI's `start-1`
-    // conversion lands the insertion at our 0-based start.
-    const effectiveStart = after ? start + 1 : start;
+    // gog's positional `<start>` is 1-based, and it rejects 0 ("start must be >= 1").
+    // Without --after it inserts *before* the position, so API start_index = positional - 1;
+    // with --after it inserts *after*, so API start_index = positional. Our `start` is 0-based,
+    // and the contract is: after:false lands at start_index=start, after:true at start_index=start+1.
+    // Both cases reduce to sending positional = start + 1 (issue #42 + the off-by-one this fixes).
+    const effectiveStart = start + 1;
     const args = ['sheets', 'insert', spreadsheetId, sheet, dimension, String(effectiveStart)];
     if (count !== undefined) args.push(`--count=${count}`);
     if (after) args.push('--after');

package/tests/tools/sheets-extra.test.ts

@@ -114,11 +114,23 @@ describe('gog_sheets_freeze', () => {
 
 // 7. insert
 describe('gog_sheets_insert', () => {
-  it('calls runOrDiagnose with required args', async () => {
+  it('shifts our 0-based start by +1 so the new dimension lands AT start (after:false)', async () => {
+    // gog's positional <start> is 1-based and, without --after, it inserts *before* it,
+    // so API start_index = positional - 1. To land at our 0-based start we send start+1.
+    // start=5 → positional 6 → API start_index 5.
     vi.mocked(lib.runOrDiagnose).mockResolvedValue(toText('{}'));
     const handlers = setupHandlers();
     await handlers.get('gog_sheets_insert')!({ spreadsheetId: 'sid', sheet: 'Sheet1', dimension: 'ROWS', start: 5 });
-    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'Sheet1', 'ROWS', '5'], { account: undefined });
+    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'Sheet1', 'ROWS', '6'], { account: undefined });
+  });
+
+  it('bug: start=1, after:false inserts before 0-based index 1 (new row 2), not at the top', async () => {
+    // Regression for the reported "range.startIndex must be set" / wrong-placement bug.
+    // start=1 → positional 2 → gog API start_index 1 (insert before the 2nd row).
+    vi.mocked(lib.runOrDiagnose).mockResolvedValue(toText('{}'));
+    const handlers = setupHandlers();
+    await handlers.get('gog_sheets_insert')!({ spreadsheetId: 'sid', sheet: 'S1', dimension: 'ROWS', start: 1, count: 1 });
+    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'S1', 'ROWS', '2', '--count=1'], { account: undefined });
   });
 
   it('shifts start by +1 when after:true so the new dimension lands AFTER start', async () => {
@@ -142,14 +154,17 @@ describe('gog_sheets_insert', () => {
     vi.mocked(lib.runOrDiagnose).mockResolvedValue(toText('{}'));
     const handlers = setupHandlers();
     await handlers.get('gog_sheets_insert')!({ spreadsheetId: 'sid', sheet: 'S1', dimension: 'ROWS', start: 0, count: 0 });
-    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'S1', 'ROWS', '0', '--count=0'], { account: undefined });
+    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'S1', 'ROWS', '1', '--count=0'], { account: undefined });
   });
 
-  it('omits --after and does not shift start when after:false', async () => {
+  it('omits --after and sends start+1 so start=0 inserts at the very top (after:false)', async () => {
+    // start=0 → positional 1 → gog API start_index 0. Sending positional 0 would make gog
+    // reject the call outright ("start must be >= 1"), so the +1 shift is what makes a
+    // top-of-sheet insert reachable at all.
     vi.mocked(lib.runOrDiagnose).mockResolvedValue(toText('{}'));
     const handlers = setupHandlers();
     await handlers.get('gog_sheets_insert')!({ spreadsheetId: 'sid', sheet: 'S1', dimension: 'ROWS', start: 0, after: false });
-    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'S1', 'ROWS', '0'], { account: undefined });
+    expect(lib.runOrDiagnose).toHaveBeenCalledWith(['sheets', 'insert', 'sid', 'S1', 'ROWS', '1'], { account: undefined });
   });
 
   it('passes --inherit-from-before=true when set', async () => {