goalbuddy 0.3.6 → 0.3.8

package/{goalbuddy/extend → plugins/goalbuddy/skills/goalbuddy/surfaces}/local-goal-board/test/local-goal-board.test.mjs

@@ -8,9 +8,9 @@ import { createBoardPayload, writeBoardApp } from "../scripts/lib/goal-board.mjs
 import { parseArgs, startBoardServer } from "../scripts/local-goal-board.mjs";
 
 test("normalizes a dense goal into local board columns", () => {
-  const payload = createBoardPayload(resolve("extend/local-goal-board/examples/sample-goal"));
+  const payload = createBoardPayload(resolve("goalbuddy/surfaces/local-goal-board/examples/sample-goal"));
 
-  assert.equal(payload.goal.title, "Local Kanban Board Extension");
+  assert.equal(payload.goal.title, "Local Goal Board Surface");
   assert.equal(payload.goal.activeTask, "");
   assert.equal(payload.counts.total, 14);
   assert.equal(payload.counts.todo, 0);
@@ -24,7 +24,7 @@ test("normalizes a dense goal into local board columns", () => {
 });
 
 test("loads depth-1 subgoal boards into parent task payloads", () => {
-  const payload = createBoardPayload(resolve("goalbuddy/extend/local-goal-board/examples/subgoal-parent"));
+  const payload = createBoardPayload(resolve("goalbuddy/surfaces/local-goal-board/examples/subgoal-parent"));
   const parentTask = payload.tasks.find((task) => task.id === "T004");
 
   assert.equal(parentTask.subgoal.status, "active");
@@ -229,7 +229,7 @@ tasks:
 });
 
 test("writes a minimal GoalBuddy web app into the goal directory", () => {
-  const appDir = writeBoardApp(resolve("extend/local-goal-board/examples/sample-goal"));
+  const appDir = writeBoardApp(resolve("goalbuddy/surfaces/local-goal-board/examples/sample-goal"));
   const html = readFileSync(join(appDir, "index.html"), "utf8");
   const css = readFileSync(join(appDir, "styles.css"), "utf8");
   const js = readFileSync(join(appDir, "app.js"), "utf8");
@@ -393,20 +393,20 @@ test("advertises goalbuddy.localhost while binding to loopback", async () => {
 test("runs when installed under a symlinked temp path", () => {
   const root = mkdtempSync(join(tmpdir(), "goalbuddy-local-board-direct-"));
   try {
-    cpSync("extend/local-goal-board/scripts", join(root, "scripts"), { recursive: true });
-    cpSync("extend/local-goal-board/assets", join(root, "assets"), { recursive: true });
+    cpSync("goalbuddy/surfaces/local-goal-board/scripts", join(root, "scripts"), { recursive: true });
+    cpSync("goalbuddy/surfaces/local-goal-board/assets", join(root, "assets"), { recursive: true });
 
     const result = spawnSync(process.execPath, [
       join(root, "scripts", "local-goal-board.mjs"),
       "--goal",
-      resolve("extend/local-goal-board/examples/sample-goal"),
+      resolve("goalbuddy/surfaces/local-goal-board/examples/sample-goal"),
       "--once",
       "--json",
     ], { encoding: "utf8" });
 
     assert.equal(result.status, 0, result.stderr || result.stdout);
     const report = JSON.parse(result.stdout);
-    assert.equal(report.board.goal.title, "Local Kanban Board Extension");
+    assert.equal(report.board.goal.title, "Local Goal Board Surface");
   } finally {
     rmSync(root, { recursive: true, force: true });
   }
@@ -558,6 +558,33 @@ test("serves multiple local boards from one shared hub URL", async () => {
   }
 });
 
+test("unregistered board paths explain hub reuse instead of stale-port cleanup", async () => {
+  const root = mkdtempSync(join(tmpdir(), "goalbuddy-local-board-unregistered-"));
+  const goalDir = join(root, "first-goal");
+  try {
+    mkdirSync(join(goalDir, "notes"), { recursive: true });
+    writeFileSync(join(goalDir, "state.yaml"), stateYaml("active", { title: "First Goal", slug: "first-goal" }));
+
+    const server = await startBoardServer({ goalDir, host: "127.0.0.1", port: 0 });
+    try {
+      const baseUrl = new URL(server.url).origin;
+      const missingResponse = await fetch(`${baseUrl}/rinova-client-revision-redesign/`);
+      assert.equal(missingResponse.status, 404);
+      const message = await missingResponse.text();
+      assert.match(message, /board path is not registered/i);
+      assert.match(message, /multi-board hub/i);
+      assert.match(message, /Do not stop it just because a \/<slug>\/ board URL returned 404/);
+      assert.match(message, /npx goalbuddy board <goal-dir>/);
+      assert.match(message, /First Goal/);
+      assert.match(message, /\/api\/boards/);
+    } finally {
+      await server.close();
+    }
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
 async function readUntil(reader, pattern) {
   const decoder = new TextDecoder();
   let text = "";

package/plugins/goalbuddy/skills/goalbuddy/templates/goal.md

@@ -15,10 +15,19 @@
 - Authority: `requested | approved | inferred | needs_approval | blocked`
 - Proof type: `test | demo | artifact | metric | review | source_backed_answer | decision`
 - Completion proof: <observable signal that closes the full original outcome>
+- Goal oracle: <live check, walkthrough, artifact, metric, source-backed answer, or decision that keeps pressure on the goal>
 - Likely misfire: <how GoalBuddy could succeed at the wrong thing>
 - Blind spots considered: <risks, unstated choices, or success dimensions surfaced during diagnostic intake>
 - Existing plan facts: <user-provided steps/files/constraints/sequencing to preserve and validate, or none>
 
+## Goal Oracle
+
+The oracle for this goal is:
+
+`<specific observable signal>`
+
+The PM must keep comparing task receipts to this oracle. Planning, discovery, a passing tiny slice, or a clean-looking board is not enough. The goal finishes only when a final Judge/PM audit maps receipts and verification back to this oracle and records `full_outcome_complete: true`.
+
 ## Goal Kind
 
 `specific | open_ended | existing_plan | recovery | audit`

package/plugins/goalbuddy/skills/goalbuddy/templates/state.yaml

@@ -9,6 +9,10 @@ goal:
   kind: open_ended # specific | open_ended | existing_plan | recovery | audit
   tranche: "<continuous execution: complete successive safe verified slices until the full original outcome is complete>"
   status: active # active | blocked | done
+  oracle:
+    signal: "<live check, walkthrough, artifact, metric, source-backed answer, or decision that proves the owner outcome>"
+    cadence: "after each Worker package and at final audit"
+    final_proof: "<receipt-backed evidence required before full_outcome_complete: true>"
   intake:
     original_request: "<shortest faithful user request>"
     interpreted_outcome: "<one sentence>"
@@ -33,6 +37,8 @@ rules:
   missing_input_or_credentials_do_not_stop_goal: true
   preserve_and_validate_existing_plan: true
   intake_misfire_must_be_audited: true
+  goal_pressure_requires_oracle: true
+  no_completion_on_weak_proof: true
   slice_policy:
     max_consecutive_tiny_tasks: 2
     prefer_vertical_slices: true
@@ -47,17 +53,12 @@ agents:
   judge: unknown
 
 visual_board:
-  # none | local | github_projects | both | unknown
+  # none | local | unknown
   selected: unknown
   local:
     status: not_requested # not_requested | starting | live | generated | blocked
     url: null
     command: "npx goalbuddy board docs/goals/<goal-slug>"
-  github_projects:
-    status: not_requested # not_requested | needs_approval | dry_run_ready | synced | blocked
-    url: null
-    command: "npx goalbuddy extend github-projects"
-    missing: []
 
 active_task: T001
 

package/examples/extend-catalog-workflow/goal.md

@@ -1,53 +0,0 @@
-# Extend Catalog Workflow
-
-## Objective
-
-Design and implement Goal Maker's extension catalog workflow so optional features can move through GitHub-hosted extension metadata without requiring frequent npm package releases.
-
-## Goal Kind
-
-`open_ended`
-
-## Current Tranche
-
-Decide the product language and architecture for optional extensions, implement the first catalog-backed `extend` CLI workflow, add a visible root `extend/` surface, clean the skill/package layout, and leave a reviewable completion audit.
-
-## Non-Negotiable Constraints
-
-- `state.yaml` remains the only board truth.
-- Extensions are optional support surfaces, not the control plane.
-- Use `extend` as the repo surface and `extensions` as the item name.
-- Avoid implying bidirectional sync with external services.
-- Keep npm as the stable core; catalog entries should be updateable from GitHub.
-- Keep package-only infrastructure out of the installable skill payload.
-- Do not require provider credentials for discovery or dry-run installation.
-
-## Stop Rule
-
-Stop when the extension/catalog UX is implemented, the repo layout reflects the skill/package boundary, verification passes, and the final audit maps the shipped changes to receipts and commits.
-
-## Canonical Board
-
-Machine truth lives at:
-
-`examples/extend-catalog-workflow/state.yaml`
-
-If this charter and `state.yaml` disagree, `state.yaml` wins for task status, active task, receipts, verification freshness, and completion truth.
-
-## Run Command
-
-```text
-/goal Follow examples/extend-catalog-workflow/goal.md
-```
-
-## PM Loop
-
-On every `/goal` continuation:
-
-1. Read this charter.
-2. Read `state.yaml`.
-3. Work only on the active board task.
-4. Assign Scout, Judge, Worker, or PM according to the task.
-5. Write a compact task receipt.
-6. Update the board.
-7. Select the next active task or finish with a Judge/PM audit receipt.

package/examples/extend-catalog-workflow/notes/T001-extension-model-map.md

@@ -1,47 +0,0 @@
-# T001: Extension Model Map
-
-Task: `T001`
-Kind: `scout`
-Status: `done`
-
-## Summary
-
-The scalable frame is `extend`: optional extension folders live at the repo root under `extend/`, and catalog metadata lives at `extend/catalog.json`. The npm CLI should read the GitHub-hosted catalog so extension discovery can change without publishing a new npm version.
-
-Board publishing is the first likely extension family, but the extension surface should also support unrelated add-ons such as role guidance, reports, intake tools, and external channel publishing.
-
-## Recommended Vocabulary
-
-- Repo surface: `extend/`
-- Items inside `extend/`: extensions
-- Catalog file: `extend/catalog.json`
-- Public action for external surfaces: publish
-- Avoid umbrella words: export, sync, capabilities
-
-## Architecture Notes
-
-Core should own:
-
-- skill installation;
-- agent installation;
-- board checker scripts;
-- extension catalog discovery;
-- checksum-verified extension installation;
-- extension doctor checks.
-
-Extensions should own:
-
-- provider-specific behavior;
-- provider docs;
-- auth requirements;
-- fixtures and tests;
-- optional role or reporting guidance.
-
-No extension may define a second meaning of `state.yaml`.
-
-## Candidate Tasks
-
-- Add a catalog-backed `goal-maker extend` command.
-- Add root `extend/` documentation.
-- Keep package-only CLI/tests out of the installable skill folder.
-- Add repo agent guidance so future improvements consider docs, skill instructions, CLI, tests, examples, and extensions together.

package/examples/extend-catalog-workflow/notes/T002-architecture-decision.md

@@ -1,48 +0,0 @@
-# T002: Architecture Decision
-
-Task: `T002`
-Kind: `judge`
-Status: `done`
-
-## Decision
-
-Use `extend` as the high-level optional surface and call each item an extension. Keep the default catalog GitHub-hosted at:
-
-```text
-https://raw.githubusercontent.com/tolibear/goal-maker/main/extend/catalog.json
-```
-
-The npm package should contain the stable core and CLI. The catalog can change on GitHub without requiring users to update npm for every optional integration.
-
-## CLI Shape
-
-Use one top-level extension command instead of separate browse/list/show verbs:
-
-```bash
-goal-maker extend
-goal-maker extend <extension-id>
-goal-maker extend install <extension-id>
-goal-maker extend doctor [extension-id]
-```
-
-This keeps the UX simple:
-
-- no argument means "show the catalog";
-- an id means "show this extension";
-- `install` copies checksum-verified files into the local Goal Maker install;
-- `doctor` verifies installed extension files and required environment.
-
-## Repo Shape
-
-Keep the root relatively clean:
-
-```text
-goal-maker/   # installable skill payload
-internal/     # package/dev infrastructure
-extend/       # optional extension folders
-examples/     # completed sample runs
-extend/catalog.json  # GitHub-hosted extension catalog
-AGENTS.md     # repo-specific agent guidance
-```
-
-`goal-maker/scripts/` stays inside the skill because installed skill docs call those scripts directly.

package/examples/extend-catalog-workflow/notes/T003-implementation-summary.md

@@ -1,43 +0,0 @@
-# T003: Catalog CLI Implementation
-
-Task: `T003`
-Kind: `worker`
-Status: `done`
-
-## Summary
-
-Implemented the first catalog-backed `goal-maker extend` workflow.
-
-Commit:
-
-- `105850e Add extension catalog workflow`
-
-## Shipped Behavior
-
-- `goal-maker extend` reads the GitHub-hosted catalog and reports available/install/configuration state.
-- `goal-maker extend <id>` shows extension details.
-- `goal-maker extend install <id>` installs checksum-verified extension files.
-- `goal-maker extend doctor [id]` validates installed extension files and required environment.
-- Root `catalog.json` provides an initially empty GitHub-hosted catalog.
-- README documents the extension discovery/install flow.
-
-## Files Touched
-
-At this point in the run, the CLI still lived under `goal-maker/bin/`. A later cleanup task moved it to `internal/cli/`.
-
-- `README.md`
-- `catalog.json`
-- `goal-maker/bin/goal-maker.mjs`
-- `goal-maker/test/goal-maker-cli.test.mjs`
-- `package.json`
-
-## Verification
-
-Commands passed:
-
-```bash
-npm run check
-git diff --check
-node goal-maker/bin/goal-maker.mjs extend --catalog-url catalog.json --json
-npm publish --dry-run --json
-```

package/examples/extend-catalog-workflow/notes/T004-root-extend-folder.md

@@ -1,24 +0,0 @@
-# T004: Root Extend Folder
-
-Task: `T004`
-Kind: `pm`
-Status: `done`
-
-## Summary
-
-Added a visible root `extend/` folder with documentation so GitHub shows the extension surface even before real extensions exist.
-
-Commit:
-
-- `17c65c9 Document extension folder`
-
-## Files Touched
-
-- `README.md`
-- `extend/README.md`
-
-## Receipt Notes
-
-The folder intentionally contains only documentation for now. Git cannot track an empty directory, and the product decision was to avoid bundling sample extensions until a real extension is ready.
-
-The README now says extensions live under `extend/` and move through the GitHub-hosted `extend/catalog.json`.

package/examples/extend-catalog-workflow/notes/T005-layout-cleanup.md

@@ -1,46 +0,0 @@
-# T005: Skill Package Layout Cleanup
-
-Task: `T005`
-Kind: `worker`
-Status: `done`
-
-## Summary
-
-Separated package-only infrastructure from the installable skill payload while keeping the repo root clean.
-
-Commit:
-
-- `6faa5de Clean skill package layout`
-
-## Files Touched
-
-- `AGENTS.md`
-- `CONTRIBUTING.md`
-- `README.md`
-- `extend/README.md`
-- `goal-maker/SKILL.md`
-- `goal-maker/bin/goal-maker.mjs` -> `internal/cli/goal-maker.mjs`
-- `goal-maker/test/*.test.mjs` -> `internal/test/*.test.mjs`
-- `package.json`
-
-## Result
-
-The installable skill payload is now focused:
-
-```text
-goal-maker/
-  SKILL.md
-  agents/
-  scripts/
-  templates/
-```
-
-Package/dev infrastructure is grouped under:
-
-```text
-internal/
-  cli/
-  test/
-```
-
-Root `AGENTS.md` now tells future agents to consider README, SKILL.md, templates, checker behavior, CLI UX, examples, package contents, and extension catalog design when improving this repo.

package/examples/extend-catalog-workflow/notes/T006-catalog-location.md

@@ -1,50 +0,0 @@
-# T006: Catalog Location
-
-Task: `T006`
-Kind: `worker`
-Status: `done`
-
-## Summary
-
-Moved the hosted catalog from the repo root to `extend/catalog.json`.
-
-Commit:
-
-- This example/catalog-location commit.
-
-## Why
-
-The repo root should stay relatively clean, and `catalog.json` is part of the extension surface. Keeping it under `extend/` makes the shape easier to understand:
-
-```text
-extend/
-  README.md
-  catalog.json
-  <extension-id>/
-```
-
-The npm CLI still reads the catalog from GitHub raw, now at:
-
-```text
-https://raw.githubusercontent.com/tolibear/goal-maker/main/extend/catalog.json
-```
-
-## Files Touched
-
-- `catalog.json` -> `extend/catalog.json`
-- `internal/cli/goal-maker.mjs`
-- `README.md`
-- `AGENTS.md`
-- `extend/README.md`
-- `examples/extend-catalog-workflow/`
-
-## Verification
-
-Commands to verify this task:
-
-```bash
-npm run check
-git diff --check
-node internal/cli/goal-maker.mjs extend --catalog-url extend/catalog.json --json
-npm publish --dry-run --json
-```

package/examples/extend-catalog-workflow/notes/T999-completion-audit.md

@@ -1,36 +0,0 @@
-# T999: Completion Audit
-
-Task: `T999`
-Kind: `judge`
-Status: `done`
-
-## Decision
-
-Complete.
-
-## Audit
-
-| Requirement | Evidence | Status |
-|---|---|---|
-| Use `extend` as the high-level surface | `extend/README.md`, `README.md`, `AGENTS.md` | Complete |
-| Items inside `extend` are extensions | `extend/README.md`, `README.md`, catalog terminology | Complete |
-| Avoid frequent npm releases for catalog updates | `extend/catalog.json` and default raw GitHub catalog URL | Complete |
-| Keep extension discovery credential-free | `goal-maker extend` and `goal-maker extend <id>` inspect catalog metadata only | Complete |
-| Verify installed extensions safely | checksum validation and `.installed.json` manifest in CLI implementation | Complete |
-| Keep root reasonably clean | package/dev files grouped under `internal/` | Complete |
-| Keep skill payload clean | `goal-maker/` contains skill, agents, scripts, and templates only | Complete |
-| Teach future agents about improvement surfaces | root `AGENTS.md` and SKILL.md note | Complete |
-
-## Verification
-
-Commands passed during the implementation tranche:
-
-```bash
-npm run check
-git diff --check
-node internal/cli/goal-maker.mjs extend --catalog-url extend/catalog.json --json
-npm publish --dry-run --json
-node goal-maker/scripts/check-goal-state.mjs examples/extend-catalog-workflow/state.yaml
-```
-
-The final state is reviewable and maps to actual commits rather than simulated history.