gnhf 0.1.14 → 0.1.16

package/README.md

@@ -165,6 +165,15 @@ agent: claude
 #   claude: /path/to/custom-claude
 #   codex: /path/to/custom-codex
 
+# Per-agent CLI arg overrides (optional)
+# agentArgsOverride:
+#   codex:
+#     - -m
+#     - gpt-5.4
+#     - -c
+#     - model_reasoning_effort="high"
+#     - --full-auto
+
 # Abort after this many consecutive failures
 maxConsecutiveFailures: 3
 
@@ -177,6 +186,12 @@ If the file does not exist yet, `gnhf` creates it on first run using the resolve
 CLI flags override config file values. `--prevent-sleep` accepts `on`/`off` as well as `true`/`false`; the config file always uses a boolean.
 The iteration and token caps are runtime-only flags and are not persisted in `config.yml`.
 
+`agentArgsOverride.<name>` lets you pass through extra CLI flags for any supported agent.
+
+- Use it for agent-specific options like models, profiles, or reasoning settings without adding a dedicated `gnhf` config field for each one.
+- For `codex` and `claude`, `gnhf` adds its usual non-interactive permission default only when you do not provide your own permission or execution-mode flag. If you set one explicitly, `gnhf` treats that as user-managed and does not add its default on top.
+- Flags that `gnhf` manages itself for a given agent, such as output-shaping or local-server startup flags, are rejected during config loading so you get a clear error instead of duplicate-argument ambiguity.
+
 ### Custom Agent Paths
 
 Use `agentPathOverride` to point any agent at a custom binary — useful for wrappers like Claude Code Switch or custom Codex builds that accept the same flags and arguments as the original:

package/dist/cli.mjs

@@ -20,6 +20,7 @@ const AGENT_NAMES = [
 const DEFAULT_CONFIG = {
 	agent: "claude",
 	agentPathOverride: {},
+	agentArgsOverride: {},
 	maxConsecutiveFailures: 3,
 	preventSleep: true
 };
@@ -32,6 +33,14 @@ function normalizePreventSleep(value) {
 	if (value === "on") return true;
 	if (value === "off") return false;
 }
+function isReservedAgentArg(agent, arg) {
+	switch (agent) {
+		case "claude": return arg === "-p" || arg === "--print" || arg === "--verbose" || arg === "--output-format" || arg.startsWith("--output-format=") || arg === "--json-schema" || arg.startsWith("--json-schema=");
+		case "codex": return arg === "exec" || arg === "--json" || arg === "--output-schema" || arg.startsWith("--output-schema=") || arg === "--color" || arg.startsWith("--color=");
+		case "opencode": return arg === "serve" || arg === "--hostname" || arg.startsWith("--hostname=") || arg === "--port" || arg.startsWith("--port=") || arg === "--print-logs";
+		case "rovodev": return arg === "rovodev" || arg === "serve" || arg === "--disable-session-token";
+	}
+}
 /**
 * Resolve a user-supplied path against the config directory (~/.gnhf).
 * Expands leading `~` or `~/` to the home directory, then resolves relative
@@ -60,6 +69,29 @@ function normalizeAgentPathOverride(value, configDir) {
 	}
 	return result;
 }
+function normalizeAgentExtraArgs(value, label, agent) {
+	if (value === void 0 || value === null) return void 0;
+	if (!Array.isArray(value)) throw new InvalidConfigError(`Invalid config value for ${label}: expected an array of strings`);
+	return value.map((entry, index) => {
+		if (typeof entry !== "string") throw new InvalidConfigError(`Invalid config value for ${label}[${index}]: expected a string`);
+		const trimmed = entry.trim();
+		if (trimmed === "") throw new InvalidConfigError(`Invalid config value for ${label}[${index}]: expected a non-empty string`);
+		if (isReservedAgentArg(agent, trimmed)) throw new InvalidConfigError(`Invalid config value for ${label}[${index}]: "${trimmed}" is managed by gnhf and cannot be overridden`);
+		return trimmed;
+	});
+}
+function normalizeAgentArgsOverride(value) {
+	if (value === void 0 || value === null) return void 0;
+	if (typeof value !== "object" || Array.isArray(value)) throw new InvalidConfigError(`Invalid config value for agentArgsOverride: expected an object`);
+	const validNames = new Set(AGENT_NAMES);
+	const result = {};
+	for (const [key, rawConfig] of Object.entries(value)) {
+		if (!validNames.has(key)) throw new InvalidConfigError(`Invalid agent name in agentArgsOverride: "${key}". Use "claude", "codex", "rovodev", or "opencode".`);
+		const args = normalizeAgentExtraArgs(rawConfig, `agentArgsOverride.${key}`, key);
+		if (args !== void 0) result[key] = args;
+	}
+	return Object.keys(result).length === 0 ? void 0 : result;
+}
 function normalizeConfig(config, configDir) {
 	const normalized = { ...config };
 	const hasPreventSleep = Object.prototype.hasOwnProperty.call(config, "preventSleep");
@@ -74,6 +106,11 @@ function normalizeConfig(config, configDir) {
 		if (agentPathOverride === void 0) delete normalized.agentPathOverride;
 		else normalized.agentPathOverride = agentPathOverride;
 	} else delete normalized.agentPathOverride;
+	if (Object.prototype.hasOwnProperty.call(config, "agentArgsOverride")) {
+		const agentArgsOverride = normalizeAgentArgsOverride(config.agentArgsOverride);
+		if (agentArgsOverride === void 0) delete normalized.agentArgsOverride;
+		else normalized.agentArgsOverride = agentArgsOverride;
+	} else delete normalized.agentArgsOverride;
 	return normalized;
 }
 function isMissingConfigError(error) {
@@ -92,8 +129,17 @@ function serializeAgentPathOverride(agentPathOverride) {
 		sortKeys: false
 	}).trimEnd();
 }
+function serializeAgentArgsOverride(agentArgsOverride) {
+	if (Object.keys(agentArgsOverride).length === 0) return "";
+	return yaml.dump({ agentArgsOverride }, {
+		lineWidth: -1,
+		noRefs: true,
+		sortKeys: false
+	}).trimEnd();
+}
 function serializeConfig(config) {
 	const agentPathOverrideSection = serializeAgentPathOverride(config.agentPathOverride);
+	const agentArgsOverrideSection = serializeAgentArgsOverride(config.agentArgsOverride);
 	const lines = [
 		"# Agent to use by default",
 		`agent: ${config.agent}`,
@@ -104,9 +150,19 @@ function serializeConfig(config) {
 		"# Note: rovodev overrides must point to an acli-compatible binary.",
 		"# agentPathOverride:",
 		"#   claude: /path/to/custom-claude",
-		"#   codex: /path/to/custom-codex"
+		"#   codex: /path/to/custom-codex",
+		"",
+		"# Per-agent CLI arg overrides (optional)",
+		"# agentArgsOverride:",
+		"#   codex:",
+		"#     - -m",
+		"#     - gpt-5.4",
+		"#     - -c",
+		"#     - model_reasoning_effort=\"high\"",
+		"#     - --full-auto"
 	];
 	if (agentPathOverrideSection) lines.push(...agentPathOverrideSection.split("\n"));
+	if (agentArgsOverrideSection) lines.push(...agentArgsOverrideSection.split("\n"));
 	lines.push("", "# Abort after this many consecutive failures", `maxConsecutiveFailures: ${config.maxConsecutiveFailures}`, "", "# Prevent the machine from sleeping during a run", `preventSleep: ${config.preventSleep}`, "");
 	return lines.join("\n");
 }
@@ -433,6 +489,17 @@ function getLastIterationNumber(runInfo) {
 	}
 	return max;
 }
+function toStringArray(value) {
+	if (Array.isArray(value)) return value.filter((v) => typeof v === "string");
+	if (typeof value === "string") {
+		try {
+			const parsed = JSON.parse(value);
+			if (Array.isArray(parsed)) return parsed.filter((v) => typeof v === "string");
+		} catch {}
+		return [value];
+	}
+	return [];
+}
 function formatListSection(title, items) {
 	if (items.length === 0) return "";
 	return `**${title}:**\n${items.map((item) => `- ${item}`).join("\n")}\n`;
@@ -953,29 +1020,37 @@ function terminateClaudeProcess(child, platform) {
 	}
 	child.kill("SIGTERM");
 }
+function buildClaudeArgs(prompt, extraArgs) {
+	const userArgs = extraArgs ?? [];
+	const userSpecifiedPermissionMode = userArgs.some((arg) => arg === "--dangerously-skip-permissions" || arg === "--permission-mode" || arg.startsWith("--permission-mode=") || arg === "--permission-prompt-tool" || arg.startsWith("--permission-prompt-tool="));
+	return [
+		...userArgs,
+		"-p",
+		prompt,
+		"--verbose",
+		"--output-format",
+		"stream-json",
+		"--json-schema",
+		JSON.stringify(AGENT_OUTPUT_SCHEMA),
+		...userSpecifiedPermissionMode ? [] : ["--dangerously-skip-permissions"]
+	];
+}
 var ClaudeAgent = class {
 	name = "claude";
 	bin;
+	extraArgs;
 	platform;
 	constructor(binOrDeps = {}) {
 		const deps = typeof binOrDeps === "string" ? { bin: binOrDeps } : binOrDeps;
 		this.bin = deps.bin ?? "claude";
+		this.extraArgs = deps.extraArgs;
 		this.platform = deps.platform ?? process.platform;
 	}
 	run(prompt, cwd, options) {
 		const { onUsage, onMessage, signal, logPath } = options ?? {};
 		return new Promise((resolve, reject) => {
 			const logStream = logPath ? createWriteStream(logPath) : null;
-			const child = spawn(this.bin, [
-				"-p",
-				prompt,
-				"--verbose",
-				"--output-format",
-				"stream-json",
-				"--json-schema",
-				JSON.stringify(AGENT_OUTPUT_SCHEMA),
-				"--dangerously-skip-permissions"
-			], {
+			const child = spawn(this.bin, buildClaudeArgs(prompt, this.extraArgs), {
 				cwd,
 				shell: shouldUseWindowsShell$2(this.bin, this.platform),
 				stdio: [
@@ -1073,14 +1148,31 @@ function terminateCodexProcess(child, platform) {
 	}
 	child.kill("SIGTERM");
 }
+function buildCodexArgs(prompt, schemaPath, extraArgs) {
+	const userArgs = extraArgs ?? [];
+	const userSpecifiedExecutionMode = userArgs.some((arg) => arg === "--full-auto" || arg === "--dangerously-bypass-approvals-and-sandbox" || arg === "--sandbox" || arg.startsWith("--sandbox=") || arg === "-s" || arg === "--ask-for-approval" || arg.startsWith("--ask-for-approval=") || arg === "-a");
+	return [
+		"exec",
+		...userArgs,
+		prompt,
+		"--json",
+		"--output-schema",
+		schemaPath,
+		...userSpecifiedExecutionMode ? [] : ["--dangerously-bypass-approvals-and-sandbox"],
+		"--color",
+		"never"
+	];
+}
 var CodexAgent = class {
 	name = "codex";
 	bin;
+	extraArgs;
 	platform;
 	schemaPath;
 	constructor(schemaPath, binOrDeps = {}) {
 		const deps = typeof binOrDeps === "string" ? { bin: binOrDeps } : binOrDeps;
 		this.bin = deps.bin ?? "codex";
+		this.extraArgs = deps.extraArgs;
 		this.platform = deps.platform ?? process.platform;
 		this.schemaPath = schemaPath;
 	}
@@ -1088,16 +1180,7 @@ var CodexAgent = class {
 		const { onUsage, onMessage, signal, logPath } = options ?? {};
 		return new Promise((resolve, reject) => {
 			const logStream = logPath ? createWriteStream(logPath) : null;
-			const child = spawn(this.bin, [
-				"exec",
-				prompt,
-				"--json",
-				"--output-schema",
-				this.schemaPath,
-				"--dangerously-bypass-approvals-and-sandbox",
-				"--color",
-				"never"
-			], {
+			const child = spawn(this.bin, buildCodexArgs(prompt, this.schemaPath, this.extraArgs), {
 				cwd,
 				shell: shouldUseWindowsShell$1(this.bin, this.platform),
 				stdio: [
@@ -1197,6 +1280,9 @@ function isAgentAbortError(error) {
 function isAbortError$1(error) {
 	return error instanceof Error && error.name === "AbortError";
 }
+function toNonEmptyString(value) {
+	return typeof value === "string" && value.length > 0 ? value : null;
+}
 function getAvailablePort$1() {
 	return new Promise((resolve, reject) => {
 		const server = createServer();
@@ -1257,6 +1343,7 @@ function withTimeoutSignal$1(signal, timeoutMs) {
 var OpenCodeAgent = class {
 	name = "opencode";
 	bin;
+	extraArgs;
 	fetchFn;
 	getPortFn;
 	killProcessFn;
@@ -1266,6 +1353,7 @@ var OpenCodeAgent = class {
 	closingPromise = null;
 	constructor(deps = {}) {
 		this.bin = deps.bin ?? "opencode";
+		this.extraArgs = deps.extraArgs;
 		this.fetchFn = deps.fetch ?? fetch;
 		this.getPortFn = deps.getPort ?? getAvailablePort$1;
 		this.killProcessFn = deps.killProcess ?? process.kill.bind(process);
@@ -1347,6 +1435,7 @@ var OpenCodeAgent = class {
 		const detached = !isWindows;
 		const child = this.spawnFn(this.bin, [
 			"serve",
+			...this.extraArgs ?? [],
 			"--hostname",
 			"127.0.0.1",
 			"--port",
@@ -1508,51 +1597,6 @@ var OpenCodeAgent = class {
 			appendDebugLog("opencode:stream:no-body", { sessionId });
 			throw new Error("opencode returned no event stream body");
 		}
-		const messagePostStartedAt = Date.now();
-		appendDebugLog("opencode:message-post:start", {
-			sessionId,
-			promptLength: prompt.length
-		});
-		let messageRequestError = null;
-		const messageRequest = (async () => {
-			try {
-				await this.request(server, `/session/${sessionId}/prompt_async`, {
-					method: "POST",
-					body: {
-						role: "user",
-						parts: [{
-							type: "text",
-							text: prompt
-						}],
-						format: STRUCTURED_OUTPUT_FORMAT
-					},
-					signal
-				});
-				appendDebugLog("opencode:message-post:end", {
-					sessionId,
-					elapsedMs: Date.now() - messagePostStartedAt
-				});
-				return {
-					ok: true,
-					body: ""
-				};
-			} catch (error) {
-				messageRequestError = error;
-				appendDebugLog("opencode:message-post:error", {
-					sessionId,
-					elapsedMs: Date.now() - messagePostStartedAt,
-					error: serializeError(error),
-					serverClosed: server.closed,
-					serverStderr: server.stderr.slice(-2048),
-					streamTelemetry: buildTelemetry()
-				});
-				streamAbortController.abort();
-				return {
-					ok: false,
-					error
-				};
-			}
-		})();
 		const usage = {
 			inputTokens: 0,
 			outputTokens: 0,
@@ -1600,6 +1644,51 @@ var OpenCodeAgent = class {
 			currentPhase,
 			sawSessionIdle: (eventCounts["session.idle"] ?? 0) > 0
 		});
+		const messagePostStartedAt = Date.now();
+		appendDebugLog("opencode:message-post:start", {
+			sessionId,
+			promptLength: prompt.length
+		});
+		let messageRequestError = null;
+		const messageRequest = (async () => {
+			try {
+				await this.request(server, `/session/${sessionId}/prompt_async`, {
+					method: "POST",
+					body: {
+						role: "user",
+						parts: [{
+							type: "text",
+							text: prompt
+						}],
+						format: STRUCTURED_OUTPUT_FORMAT
+					},
+					signal
+				});
+				appendDebugLog("opencode:message-post:end", {
+					sessionId,
+					elapsedMs: Date.now() - messagePostStartedAt
+				});
+				return {
+					ok: true,
+					body: ""
+				};
+			} catch (error) {
+				messageRequestError = error;
+				appendDebugLog("opencode:message-post:error", {
+					sessionId,
+					elapsedMs: Date.now() - messagePostStartedAt,
+					error: serializeError(error),
+					serverClosed: server.closed,
+					serverStderr: server.stderr.slice(-2048),
+					streamTelemetry: buildTelemetry()
+				});
+				streamAbortController.abort();
+				return {
+					ok: false,
+					error
+				};
+			}
+		})();
 		const STALL_THRESHOLDS_MS = [
 			6e4,
 			12e4,
@@ -1817,20 +1906,21 @@ var OpenCodeAgent = class {
 				usage
 			};
 		}
-		const outputText = lastFinalAnswerText ?? lastText;
-		if (!outputText) {
+		const outputText = toNonEmptyString(lastFinalAnswerText) ?? toNonEmptyString(lastText);
+		if (outputText === null) {
 			appendDebugLog("opencode:output:missing", {
 				sessionId,
 				hasStructuredOutput: structuredOutputFromSSE !== null
 			});
 			throw new Error("opencode returned no text output");
 		}
+		const finalOutputText = outputText;
 		try {
-			const output = JSON.parse(outputText);
+			const output = JSON.parse(finalOutputText);
 			appendDebugLog("opencode:output:structured", {
 				sessionId,
 				source: lastFinalAnswerText ? "final_answer" : "last_text",
-				outputTextLength: outputText.length
+				outputTextLength: finalOutputText.length
 			});
 			return {
 				output,
@@ -1839,8 +1929,8 @@ var OpenCodeAgent = class {
 		} catch (error) {
 			appendDebugLog("opencode:output:parse-error", {
 				sessionId,
-				outputTextLength: outputText.length,
-				outputTextSample: outputText.slice(0, 512),
+				outputTextLength: finalOutputText.length,
+				outputTextSample: finalOutputText.slice(0, 512),
 				error: serializeError(error)
 			});
 			throw new Error(`Failed to parse opencode output: ${error instanceof Error ? error.message : String(error)}`);
@@ -2046,6 +2136,7 @@ async function delay(ms, signal) {
 var RovoDevAgent = class {
 	name = "rovodev";
 	bin;
+	extraArgs;
 	schemaPath;
 	fetchFn;
 	getPortFn;
@@ -2056,6 +2147,7 @@ var RovoDevAgent = class {
 	closingPromise = null;
 	constructor(schemaPath, deps = {}) {
 		this.bin = deps.bin ?? "acli";
+		this.extraArgs = deps.extraArgs;
 		this.schemaPath = schemaPath;
 		this.fetchFn = deps.fetch ?? fetch;
 		this.getPortFn = deps.getPort ?? getAvailablePort;
@@ -2136,6 +2228,7 @@ var RovoDevAgent = class {
 		const child = this.spawnFn(this.bin, [
 			"rovodev",
 			"serve",
+			...this.extraArgs ?? [],
 			"--disable-session-token",
 			String(port)
 		], {
@@ -2560,12 +2653,24 @@ function withTimeoutSignal(signal, timeoutMs) {
 }
 //#endregion
 //#region src/core/agents/factory.ts
-function createAgent(name, runInfo, pathOverride) {
+function createAgent(name, runInfo, pathOverride, agentArgsOverride) {
 	switch (name) {
-		case "claude": return new ClaudeAgent(pathOverride);
-		case "codex": return new CodexAgent(runInfo.schemaPath, pathOverride);
-		case "opencode": return new OpenCodeAgent({ bin: pathOverride });
-		case "rovodev": return new RovoDevAgent(runInfo.schemaPath, { bin: pathOverride });
+		case "claude": return new ClaudeAgent({
+			bin: pathOverride,
+			extraArgs: agentArgsOverride
+		});
+		case "codex": return new CodexAgent(runInfo.schemaPath, {
+			bin: pathOverride,
+			extraArgs: agentArgsOverride
+		});
+		case "opencode": return new OpenCodeAgent({
+			bin: pathOverride,
+			extraArgs: agentArgsOverride
+		});
+		case "rovodev": return new RovoDevAgent(runInfo.schemaPath, {
+			bin: pathOverride,
+			extraArgs: agentArgsOverride
+		});
 	}
 }
 //#endregion
@@ -2845,7 +2950,7 @@ var Orchestrator = class extends EventEmitter {
 			};
 			return {
 				type: "completed",
-				record: this.recordFailure(`[FAIL] ${result.output.summary}`, result.output.summary, result.output.key_learnings)
+				record: this.recordFailure(`[FAIL] ${result.output.summary}`, result.output.summary, toStringArray(result.output.key_learnings))
 			};
 		} catch (err) {
 			const elapsedMs = Date.now() - agentStartedAt;
@@ -2884,7 +2989,7 @@ var Orchestrator = class extends EventEmitter {
 		}
 	}
 	recordSuccess(output) {
-		appendNotes(this.runInfo.notesPath, this.state.currentIteration, output.summary, output.key_changes_made, output.key_learnings);
+		appendNotes(this.runInfo.notesPath, this.state.currentIteration, output.summary, toStringArray(output.key_changes_made), toStringArray(output.key_learnings));
 		commitAll(`gnhf #${this.state.currentIteration}: ${output.summary}`, this.cwd);
 		this.state.commitCount = getBranchCommitCount(this.runInfo.baseCommit, this.cwd);
 		this.state.successCount++;
@@ -2893,13 +2998,13 @@ var Orchestrator = class extends EventEmitter {
 			number: this.state.currentIteration,
 			success: true,
 			summary: output.summary,
-			keyChanges: output.key_changes_made,
-			keyLearnings: output.key_learnings,
+			keyChanges: toStringArray(output.key_changes_made),
+			keyLearnings: toStringArray(output.key_learnings),
 			timestamp: /* @__PURE__ */ new Date()
 		};
 	}
 	recordFailure(notesSummary, recordSummary, learnings) {
-		appendNotes(this.runInfo.notesPath, this.state.currentIteration, notesSummary, [], learnings);
+		appendNotes(this.runInfo.notesPath, this.state.currentIteration, notesSummary, [], toStringArray(learnings));
 		resetHard(this.cwd);
 		this.state.failCount++;
 		this.state.consecutiveFailures++;
@@ -2908,7 +3013,7 @@ var Orchestrator = class extends EventEmitter {
 			success: false,
 			summary: recordSummary,
 			keyChanges: [],
-			keyLearnings: learnings,
+			keyLearnings: toStringArray(learnings),
 			timestamp: /* @__PURE__ */ new Date()
 		};
 	}
@@ -3901,11 +4006,12 @@ program.name("gnhf").description("Before I go to bed, I tell my agents: good nig
 		maxIterations: options.maxIterations,
 		maxTokens: options.maxTokens,
 		preventSleep: config.preventSleep,
+		agentArgsOverride: config.agentArgsOverride?.[config.agent],
 		platform: process$1.platform,
 		nodeVersion: process$1.version,
 		gnhfVersion: packageVersion
 	});
-	const orchestrator = new Orchestrator(config, createAgent(config.agent, runInfo, config.agentPathOverride[config.agent]), runInfo, prompt, cwd, startIteration, {
+	const orchestrator = new Orchestrator(config, createAgent(config.agent, runInfo, config.agentPathOverride[config.agent], config.agentArgsOverride?.[config.agent]), runInfo, prompt, cwd, startIteration, {
 		maxIterations: options.maxIterations,
 		maxTokens: options.maxTokens
 	});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gnhf",
-  "version": "0.1.14",
+  "version": "0.1.16",
   "description": "Before I go to bed, I tell my agents: good night, have fun",
   "type": "module",
   "bin": {
@@ -13,6 +13,7 @@
     "lint": "eslint src",
     "format": "prettier --write src",
     "format:check": "prettier --check src",
+    "typecheck": "tsc -p tsconfig.typecheck.json --noEmit",
     "test": "npm run build && vitest run",
     "test:e2e": "npm run build && vitest run test/e2e.test.ts",
     "test:coverage": "vitest run --coverage --exclude test/e2e.test.ts"