glossarist 0.4.44 → 0.4.45

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "glossarist",
-  "version": "0.4.44",
+  "version": "0.4.45",
   "description": "JavaScript SDK for Glossarist GCR packages — read, write, validate, and manage terminology concepts",
   "type": "module",
   "main": "src/index.js",

package/src/validators/validation-error.ts

@@ -1,16 +1,19 @@
-// @ts-nocheck — TEMPORARY during TS migration. TODO(Phase 2e): remove and type fully.
 export class ValidationError {
-  constructor(path, message, severity = 'error') {
+  readonly path: string;
+  readonly message: string;
+  readonly severity: 'error' | 'warning';
+
+  constructor(path: string, message: string, severity: 'error' | 'warning' = 'error') {
     this.path = path;
     this.message = message;
     this.severity = severity;
   }
 
-  toString() {
+  toString(): string {
     return `[${this.severity.toUpperCase()}] ${this.path}: ${this.message}`;
   }
 
-  toJSON() {
+  toJSON(): { path: string; message: string; severity: string } {
     return { path: this.path, message: this.message, severity: this.severity };
   }
 }

package/src/validators/validation-result.ts

@@ -1,53 +1,52 @@
-// @ts-nocheck — TEMPORARY during TS migration. TODO(Phase 2e): remove and type fully.
 import { ValidationError } from './validation-error.js';
 
 export class ValidationResult {
-  constructor() {
-    this._issues = [];
-  }
+  private readonly _issues: ValidationError[] = [];
+
+  constructor() {}
 
-  get valid() {
+  get valid(): boolean {
     return this._issues.filter(e => e.severity === 'error').length === 0;
   }
 
-  get errors() {
+  get errors(): ReadonlyArray<ValidationError> {
     return this._issues.filter(e => e.severity === 'error');
   }
 
-  get warnings() {
+  get warnings(): ReadonlyArray<ValidationError> {
     return this._issues.filter(e => e.severity === 'warning');
   }
 
-  addError(pathOrMessage, message) {
+  addError(path: string, message?: string): this {
     if (message === undefined) {
-      this._issues.push(new ValidationError('', pathOrMessage, 'error'));
+      this._issues.push(new ValidationError('', path, 'error'));
     } else {
-      this._issues.push(new ValidationError(pathOrMessage, message, 'error'));
+      this._issues.push(new ValidationError(path, message, 'error'));
     }
     return this;
   }
 
-  addWarning(pathOrMessage, message) {
+  addWarning(path: string, message?: string): this {
     if (message === undefined) {
-      this._issues.push(new ValidationError('', pathOrMessage, 'warning'));
+      this._issues.push(new ValidationError('', path, 'warning'));
     } else {
-      this._issues.push(new ValidationError(pathOrMessage, message, 'warning'));
+      this._issues.push(new ValidationError(path, message, 'warning'));
     }
     return this;
   }
 
-  merge(other) {
+  merge(other: ValidationResult): this {
     if (other instanceof ValidationResult) {
       for (const issue of other._issues) this._issues.push(issue);
     }
     return this;
   }
 
-  toJSON() {
+  toJSON(): { valid: boolean; errors: unknown[]; warnings: unknown[] } {
     return {
       valid: this.valid,
-      errors: this.errors.map(e => e.toJSON ? e.toJSON() : e),
-      warnings: this.warnings.map(e => e.toJSON ? e.toJSON() : e),
+      errors: this.errors.map(e => typeof e.toJSON === 'function' ? e.toJSON() : e),
+      warnings: this.warnings.map(e => typeof e.toJSON === 'function' ? e.toJSON() : e),
     };
   }
 }

package/src/validators/validation-rule.ts

@@ -1,15 +1,17 @@
-// @ts-nocheck — TEMPORARY during TS migration. TODO(Phase 2e): remove and type fully.
-export class ValidationRule {
-  constructor(name, severity = 'error') {
+import type { ValidationResult } from './validation-result.js';
+
+export abstract class ValidationRule {
+  readonly name: string;
+  readonly severity: 'error' | 'warning';
+
+  constructor(name: string, severity: 'error' | 'warning' = 'error') {
     this.name = name;
     this.severity = severity;
   }
 
-  validate(_value, _path, _result) {
-    throw new Error(`${this.constructor.name} must implement validate()`);
-  }
+  abstract validate(concept: unknown, path: string, result: ValidationResult): void;
 
-  addIssue(result, path, message) {
+  addIssue(result: ValidationResult, path: string, message: string): void {
     if (this.severity === 'warning') {
       result.addWarning(path, message);
     } else {