glossarist 0.4.31 → 0.4.33

package/src/validators/partitive-drift-rule.js

@@ -1,51 +0,0 @@
-// Warns when a concept expresses the same partitive relationship via
-// BOTH a binary edge (broader_partitive / narrower_partitive /
-// has_part / is_part_of) AND a PartitiveHyperedge part targeting the
-// same concept. Round 1's decision (TODO.hyperedges/24) was "binary
-// and hyperedge coexist, no automatic reconciliation." This rule is
-// the detector for the resulting drift: pure warning, doesn't block
-// save, just surfaces the duplication so the author can pick one
-// encoding.
-//
-// See TODO.hyperedges-v2/21 for the design rationale.
-
-import { ValidationRule } from './validation-rule.js';
-
-const BINARY_PARTITIVE_TYPES = new Set([
-  'broader_partitive', 'narrower_partitive',
-  'has_part', 'is_part_of',
-]);
-
-export class PartitiveDriftRule extends ValidationRule {
-  constructor() { super('partitive-drift', 'warning'); }
-
-  validate(concept, path, result) {
-    const hyperedgeTargets = new Set();
-    for (const he of concept.partitiveHyperedges ?? []) {
-      const comp = he.comprehensive;
-      const compKey = `${comp?.source ?? ''}|${comp?.id ?? ''}`;
-      for (const part of he.parts ?? []) {
-        const key = `${part.source ?? ''}|${part.id ?? ''}`;
-        if (key === '|' || key === compKey) continue;
-        hyperedgeTargets.add(key);
-      }
-    }
-
-    if (hyperedgeTargets.size === 0) return;
-
-    const related = concept.relatedConcepts ?? [];
-    for (let i = 0; i < related.length; i++) {
-      const rc = related[i];
-      if (!BINARY_PARTITIVE_TYPES.has(rc.type)) continue;
-      const ref = rc.ref;
-      const key = `${ref?.source ?? ''}|${ref?.id ?? ''}`;
-      if (hyperedgeTargets.has(key)) {
-        this.addIssue(result,
-          `${path}relatedConcepts[${i}]`,
-          `concept has both a binary '${rc.type}' edge and a ` +
-          `PartitiveHyperedge part targeting (${ref?.source ?? '?'}, ` +
-          `${ref?.id ?? '?'}); pick one encoding to avoid divergence`);
-      }
-    }
-  }
-}

package/src/validators/partitive-hyperedge-rule.js

@@ -1,75 +0,0 @@
-import { ValidationRule } from './validation-rule.js';
-
-// Validates semantic invariants of PartitiveHyperedge entries that
-// the model constructor does NOT enforce. The constructor already
-// rejects empty comprehensive, empty parts, self-loops, invalid
-// marker values, and duplicate markers. This rule provides a
-// defensive walk at validation time plus a warning for the
-// implicit-enumeration case (absent in the source YAML, filled by
-// the model's DEFAULT_ENUMERATION constant).
-export class PartitiveHyperedgeShapeRule extends ValidationRule {
-  constructor() { super('partitive-hyperedge-shape'); }
-
-  validate(concept, path, result) {
-    const edges = concept.partitiveHyperedges ?? [];
-    for (let i = 0; i < edges.length; i++) {
-      const he = edges[i];
-      const base = `${path}partitiveHyperedges[${i}]`;
-
-      this._checkComprehensive(he, i, base, result);
-      this._checkParts(he, i, base, result);
-      this._checkMarkers(he, i, base, result);
-      this._checkSelfLoop(he, i, base, result);
-    }
-  }
-
-  _checkComprehensive(he, idx, base, result) {
-    const ref = he.comprehensive;
-    if (!ref || (!ref.source && !ref.id)) {
-      this.addIssue(result, `${base}.comprehensive`,
-        `partitive_hyperedge ${idx + 1} has empty comprehensive`);
-    }
-  }
-
-  _checkParts(he, idx, base, result) {
-    const parts = he.parts ?? [];
-    if (parts.length === 0) {
-      this.addIssue(result, `${base}.parts`,
-        `partitive_hyperedge ${idx + 1} has no parts`);
-      return;
-    }
-    for (let j = 0; j < parts.length; j++) {
-      const p = parts[j];
-      if (!p || (!p.source && !p.id)) {
-        this.addIssue(result, `${base}.parts[${j}]`,
-          `partitive_hyperedge ${idx + 1} part ${j + 1} has empty ref`);
-      }
-    }
-  }
-
-  _checkMarkers(he, idx, base, result) {
-    const markers = he.markers ?? [];
-    const seen = new Set();
-    for (const m of markers) {
-      if (seen.has(m)) {
-        this.addIssue(result, `${base}.markers`,
-          `partitive_hyperedge ${idx + 1} has duplicate marker '${m}'`);
-      }
-      seen.add(m);
-    }
-  }
-
-  _checkSelfLoop(he, idx, base, result) {
-    const c = he.comprehensive;
-    if (!c) return;
-    const cKey = `${c.source ?? ''}:${c.id ?? ''}`;
-    for (let j = 0; j < (he.parts ?? []).length; j++) {
-      const p = he.parts[j];
-      const pKey = `${p?.source ?? ''}:${p?.id ?? ''}`;
-      if (pKey === cKey) {
-        this.addIssue(result, `${base}.parts[${j}]`,
-          `partitive_hyperedge ${idx + 1} part ${j + 1} cannot be the comprehensive`);
-      }
-    }
-  }
-}