glossarist 0.2.0 → 0.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "glossarist",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "JavaScript SDK for Glossarist GCR packages — read, write, validate, and manage terminology concepts",
   "type": "module",
   "main": "src/index.js",

package/src/concept-collection.js

@@ -37,8 +37,7 @@ export class ConceptCollection {
 
   byStatus(status) {
     return new ConceptCollection(this[_items].filter(c => {
-      const langs = c.languages;
-      return langs.length > 0 && c.localization(langs[0])?.entryStatus === status;
+      return c.languages.some(lang => c.localization(lang)?.entryStatus === status);
     }));
   }
 

package/src/index.d.ts

@@ -26,7 +26,7 @@ export { ConceptCollection } from './concept-collection';
 export { ManagedConceptCollection } from './managed-concept-collection';
 
 // Validators
-export { validateConcept, validateRegister, createConceptValidator, ValidationError, ValidationRule, RegisterValidator } from './validators/index';
+export { validateConcept, validateRegister, validateGcrPackage, createConceptValidator, ValidationError, ValidationRule, ValidationResult, RegisterValidator, GcrValidator } from './validators/index';
 
 // UUID
 export { conceptUuid, localizedConceptUuid, uuidV5 } from './uuid';

package/src/index.js

@@ -5,7 +5,7 @@ export { writeConcept, writeConcepts } from './concept-writer.js';
 export { createGcr, GcrWriter } from './gcr-writer.js';
 export { ConceptCollection } from './concept-collection.js';
 export { ManagedConceptCollection } from './managed-concept-collection.js';
-export { validateConcept, validateRegister, createConceptValidator, ValidationError, ValidationRule, RegisterValidator } from './validators/index.js';
+export { validateConcept, validateRegister, validateGcrPackage, createConceptValidator, ValidationError, ValidationRule, ValidationResult, RegisterValidator, GcrValidator } from './validators/index.js';
 export { conceptUuid, localizedConceptUuid, uuidV5 } from './uuid.js';
 export { ReferenceResolver, Reference, referenceResolver } from './reference-resolver.js';
 export { V1Reader, migrateV1ToV2 } from './v1-reader.js';

package/src/validators/gcr-validator.js

@@ -0,0 +1,74 @@
+import yaml from 'js-yaml';
+import { DATASET_ASSETS } from '../dataset-asset.js';
+import { ValidationResult } from './validation-result.js';
+
+export class GcrValidator {
+  async validate(pkg) {
+    const result = new ValidationResult();
+    await this._validateMetadata(pkg, result);
+    await this._validateConcepts(pkg, result);
+    await this._validateAssets(pkg, result);
+    return result;
+  }
+
+  async _validateMetadata(pkg, result) {
+    const raw = await pkg._readText('metadata.yaml');
+    if (!raw) {
+      result.addError('metadata.yaml is missing');
+      return;
+    }
+
+    let meta;
+    try {
+      meta = yaml.load(raw);
+    } catch (e) {
+      result.addError(`metadata.yaml: invalid YAML: ${e.message}`);
+      return;
+    }
+
+    if (!meta.shortname) result.addError('metadata.yaml missing shortname');
+    if (!meta.version) result.addError('metadata.yaml missing version');
+    if (meta.concept_count == null) result.addError('metadata.yaml missing concept_count');
+  }
+
+  async _validateConcepts(pkg, result) {
+    const ids = await pkg.conceptIds();
+    if (ids.length === 0) {
+      result.addError('No concept files found in concepts/');
+    }
+  }
+
+  async _validateAssets(pkg, result) {
+    for (const asset of DATASET_ASSETS) {
+      if (asset.type === 'file') {
+        await this._validateFileAsset(pkg, asset.path, result);
+      } else if (asset.type === 'directory') {
+        await this._validateDirectoryAsset(pkg, asset.path, result);
+      }
+    }
+  }
+
+  async _validateFileAsset(pkg, path, result) {
+    const raw = await pkg._readText(path);
+    if (!raw) return;
+    try {
+      yaml.load(raw);
+    } catch (e) {
+      result.addError(`${path}: invalid YAML at line ${e.mark?.line ?? '?'}: ${e.message}`);
+    }
+  }
+
+  async _validateDirectoryAsset(pkg, dirPath, result) {
+    let hasFiles = false;
+    let hasEntries = false;
+    pkg._zip.forEach((relativePath, entry) => {
+      if (relativePath.startsWith(`${dirPath}/`)) {
+        hasEntries = true;
+        if (!entry.dir) hasFiles = true;
+      }
+    });
+    if (hasEntries && !hasFiles) {
+      result.addWarning(`${dirPath}/ directory exists but is empty`);
+    }
+  }
+}

package/src/validators/index.js

@@ -1,10 +1,13 @@
 export { ValidationError } from './validation-error.js';
 export { ValidationRule } from './validation-rule.js';
+export { ValidationResult } from './validation-result.js';
 export { ConceptValidator, LanguageCodeRule, DesignationTypeRule, EntryStatusRule } from './concept-validator.js';
 export { RegisterValidator } from './register-validator.js';
+export { GcrValidator } from './gcr-validator.js';
 
 import { ConceptValidator, LanguageCodeRule, DesignationTypeRule, EntryStatusRule } from './concept-validator.js';
 import { RegisterValidator } from './register-validator.js';
+import { GcrValidator } from './gcr-validator.js';
 
 const _default = new ConceptValidator()
   .addRule(new LanguageCodeRule())
@@ -22,3 +25,7 @@ export function createConceptValidator() {
 export function validateRegister(register) {
   return new RegisterValidator().validate(register);
 }
+
+export async function validateGcrPackage(pkg) {
+  return new GcrValidator().validate(pkg);
+}

package/src/validators/validation-result.js

@@ -0,0 +1,34 @@
+export class ValidationResult {
+  constructor() {
+    this.errors = [];
+    this.warnings = [];
+  }
+
+  get valid() {
+    return this.errors.length === 0;
+  }
+
+  addError(message) {
+    this.errors.push(message);
+    return this;
+  }
+
+  addWarning(message) {
+    this.warnings.push(message);
+    return this;
+  }
+
+  merge(other) {
+    for (const e of other.errors) this.errors.push(e);
+    for (const w of other.warnings) this.warnings.push(w);
+    return this;
+  }
+
+  toJSON() {
+    return {
+      valid: this.valid,
+      errors: [...this.errors],
+      warnings: [...this.warnings],
+    };
+  }
+}