gloomberb 0.9.8 → 0.9.10

package/src/components/command-bar/helpers.test.ts

@@ -1,20 +1,14 @@
 import { describe, expect, test } from "bun:test";
 import type { PaneTemplateDef, WizardStep } from "../../types/plugin";
-import type {
-  CommandBarRoute,
-  CommandBarWorkflowField,
-} from "./workflow/types";
+import type { CommandBarWorkflowField } from "./workflow/types";
 import {
   buildGeneratedTemplateField,
   getCollectionCommandAction,
   getCollectionCommandKind,
   getCollectionCommandVerb,
   getFirstVisibleFieldId,
-  getScreenFooterLeft,
-  getScreenFooterRight,
   getVisibleWorkflowFields,
   isCollectionCommand,
-  isRootParsedCommand,
   isRouteCommandId,
   isWorkflowTextField,
   looksDestructiveCommand,
@@ -22,7 +16,6 @@ import {
   routeCommandIdToScreen,
   slugifyName,
   summarizeError,
-  summarizePaneSettingValue,
   summarizeWorkflowFieldValue,
 } from "./helpers";
 
@@ -79,26 +72,6 @@ describe("command-bar helpers", () => {
     }, ["symbol", "price", "pnl", "volume"])).toBe("Symbol, Price, P&L +1");
   });
 
-  test("summarizes pane setting values consistently", () => {
-    expect(summarizePaneSettingValue({
-      key: "theme",
-      label: "Theme",
-      type: "select",
-      options: [{ label: "Nord", value: "nord" }],
-    }, "nord")).toBe("Nord");
-    expect(summarizePaneSettingValue({
-      key: "columns",
-      label: "Columns",
-      type: "ordered-multi-select",
-      options: [
-        { label: "Symbol", value: "symbol" },
-        { label: "Price", value: "price" },
-        { label: "P&L", value: "pnl" },
-        { label: "Volume", value: "volume" },
-      ],
-    }, ["symbol", "price", "pnl", "volume"])).toBe("Symbol, Price, P&L +1");
-  });
-
   test("normalizes wizard fields and derives defaults from steps", () => {
     const steps: WizardStep[] = [
       { key: "intro", label: "Intro", type: "info", body: ["Line one", "Line two"] },
@@ -157,61 +130,9 @@ describe("command-bar helpers", () => {
     });
   });
 
-  test("formats screen footers based on route context", () => {
-    const orderedPickerRoute: CommandBarRoute = {
-      kind: "picker",
-      pickerId: "field-multi-select",
-      title: "Columns",
-      query: "",
-      selectedIdx: 0,
-      hoveredIdx: null,
-      options: [],
-      payload: { fieldType: "ordered-multi-select" },
-    };
-    const filteredPickerRoute: CommandBarRoute = {
-      ...orderedPickerRoute,
-      query: "vol",
-    };
-    const workflowRoute: CommandBarRoute = {
-      kind: "workflow",
-      workflowId: "create-pane",
-      title: "Create Pane",
-      fields: [],
-      values: {},
-      activeFieldId: null,
-      submitLabel: "Create",
-      pending: false,
-      error: null,
-      payload: {
-        kind: "builtin",
-        actionId: "create-pane",
-      },
-    };
-    const confirmRoute: CommandBarRoute = {
-      kind: "confirm",
-      confirmId: "delete",
-      title: "Delete",
-      body: ["Delete item?"],
-      confirmLabel: "Delete",
-      cancelLabel: "Back",
-      tone: "danger",
-      onConfirm: () => {},
-      pending: false,
-      error: null,
-    };
-
-    expect(getScreenFooterLeft(null)).toBe("up/down move  enter select");
-    expect(getScreenFooterLeft(orderedPickerRoute)).toBe("up/down move  space toggle  [ ] reorder  enter done");
-    expect(getScreenFooterRight(orderedPickerRoute)).toBe("backspace/esc back");
-    expect(getScreenFooterRight(filteredPickerRoute)).toBe("backspace delete  esc back");
-    expect(getScreenFooterRight(workflowRoute)).toBe("backspace/esc back");
-    expect(getScreenFooterRight(confirmRoute)).toBe("backspace/esc back");
-  });
-
   test("maps route and collection command ids", () => {
     expect(isRouteCommandId("plugins")).toBe(true);
     expect(routeCommandIdToScreen("plugins")).toBe("plugins");
-    expect(isRootParsedCommand("remove-portfolio")).toBe(true);
     expect(isCollectionCommand("remove-portfolio")).toBe(true);
     expect(getCollectionCommandKind("remove-portfolio")).toBe("portfolio");
     expect(getCollectionCommandAction("remove-portfolio")).toBe("remove");

package/src/components/command-bar/helpers.ts

@@ -1,4 +1,4 @@
-import type { CommandDef, PaneSettingField } from "../../types/plugin";
+import type { CommandDef } from "../../types/plugin";
 import type { CommandBarRoute } from "./workflow/types";
 import type { CollectionKind, CollectionMembershipAction } from "./workflow/ops";
 
@@ -37,14 +37,6 @@ export function routeCommandIdToScreen(commandId: RouteCommandId): "ticker-searc
   }
 }
 
-export function isRootParsedCommand(commandId: string): boolean {
-  return commandId === "security-description"
-    || commandId === "add-watchlist"
-    || commandId === "add-portfolio"
-    || commandId === "remove-watchlist"
-    || commandId === "remove-portfolio";
-}
-
 export function isCollectionCommand(commandId: string): commandId is CollectionCommandId {
   return commandId === "add-watchlist"
     || commandId === "add-portfolio"
@@ -64,33 +56,6 @@ export function getCollectionCommandVerb(action: CollectionMembershipAction): st
   return action === "add" ? "Add" : "Remove";
 }
 
-export function summarizePaneSettingValue(field: PaneSettingField, value: unknown): string {
-  switch (field.type) {
-    case "toggle":
-      return value === true ? "On" : "Off";
-    case "text":
-      return typeof value === "string" && value.trim().length > 0 ? value : "Unset";
-    case "select": {
-      const option = field.options.find((entry) => entry.value === value);
-      return option?.label ?? "Unset";
-    }
-    case "multi-select":
-    case "ordered-multi-select": {
-      const selected = Array.isArray(value)
-        ? value.filter((entry): entry is string => typeof entry === "string")
-        : [];
-      if (selected.length === 0) return "None";
-      const labels = selected
-        .map((entry) => field.options.find((option) => option.value === entry)?.label ?? entry)
-        .slice(0, 3);
-      const suffix = selected.length > 3 ? ` +${selected.length - 3}` : "";
-      return `${labels.join(", ")}${suffix}`;
-    }
-    default:
-      return "";
-  }
-}
-
 export function getScreenFooterLeft(route: CommandBarRoute | null): string {
   if (!route) return "up/down move  enter select";
   switch (route.kind) {

package/src/components/command-bar/pane-settings.ts

@@ -3,7 +3,7 @@ import type { PluginRegistry } from "../../plugins/registry";
 import { fuzzyFilter } from "../../utils/fuzzy-search";
 import type { ResultItem } from "./list/model";
 import type { CommandBarRoute, CommandBarWorkflowRoute } from "./workflow/types";
-import { summarizePaneSettingValue } from "./helpers";
+import { summarizePaneSettingValue } from "../pane-settings-dialog/value";
 
 type NotifyFn = (body: string, options?: { type?: "info" | "success" | "error" }) => void;
 

package/src/components/command-bar/panel/runtime.ts

@@ -37,7 +37,6 @@ interface CommandBarPanelRuntimeOptions {
   applyThemePreview: (themeId: string | null) => void;
   cellHeightPx: number;
   cellWidthPx: number;
-  clearThemePreview: (themeId: string | null | undefined) => void;
   closeAll: (options?: { revertThemePreview?: boolean }) => void;
   commitTheme: (themeId: string) => void;
   committedThemeId: string;
@@ -92,7 +91,6 @@ export function useCommandBarPanelRuntime({
   applyThemePreview,
   cellHeightPx,
   cellWidthPx,
-  clearThemePreview,
   closeAll,
   commitTheme,
   committedThemeId,

package/src/components/command-bar/routes/ticker-search/results.ts

@@ -24,17 +24,6 @@ export function normalizeCommandTickerSearchText(value: string): string {
   return value.trim().toUpperCase().replace(/[^A-Z0-9]+/g, "");
 }
 
-export function isLikelyPlainTickerSearch(query: string): boolean {
-  const trimmed = query.trim();
-  if (!trimmed || /\s/.test(trimmed)) return false;
-  if (!/^[A-Za-z0-9.^=\-/]+$/.test(trimmed)) return false;
-
-  const compact = normalizeCommandTickerSearchText(trimmed);
-  if (compact.length < 2) return false;
-  if (compact.length <= 6) return true;
-  return /[.^=\-/]/.test(trimmed) && compact.length <= 10;
-}
-
 function isExactTickerResultMatch(item: ResultItem, query: string): boolean {
   if (item.kind !== "ticker" && item.kind !== "search") return false;
   const normalizedQuery = normalizeCommandTickerSearchText(query);

package/src/components/command-bar/surface/index.test.tsx

@@ -81,22 +81,6 @@ function mutablePaneRegistryMap(map: ReadonlyMap<string, unknown>): Map<string,
 }
 
 describe("CommandBar", () => {
-  test("renders the default layout with opencode-style chrome", async () => {
-    testSetup = await testRender(<CommandBarHarness query="" selectedTicker="AAPL" />, {
-      width: 80,
-      height: 24,
-    });
-
-    await testSetup.renderOnce();
-
-    const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("Commands");
-    expect(frame).not.toContain("Tickers");
-    expect(frame).toContain("Panes");
-    expect(frame).toContain("Portfolio");
-    expect(frame).toContain("Help");
-  });
-
   test("keeps generic command filtering separate from ticker search", async () => {
     const searchQueries: string[] = [];
     testSetup = await testRender(<CommandBarHarness

package/src/components/command-bar/surface/index.tsx

@@ -291,7 +291,6 @@ export function CommandBar({
     applyThemePreview,
     cellHeightPx,
     cellWidthPx,
-    clearThemePreview,
     closeAll,
     commitTheme,
     committedThemeId: state.config.theme,

package/src/components/feed-data-table/stack-view.test.tsx

@@ -1,148 +1,54 @@
-import { afterEach, describe, expect, test } from "bun:test";
-import { act, useState } from "react";
+import { afterEach, expect, test } from "bun:test";
+import { act } from "react";
 import { testRender } from "../../renderers/opentui/test-utils";
 import { AppContext, PaneInstanceProvider, createInitialState } from "../../state/app/context";
 import { createDefaultConfig } from "../../types/config";
-import {
-  FeedDataTableStackView,
-  type FeedDataTableItem,
-} from "./stack-view";
 import { Box, Text } from "../../ui";
+import { FeedDataTableStackView } from "./stack-view";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
-let rootKeyHits = 0;
-
-const items: FeedDataTableItem[] = [
-  {
-    id: "1",
-    eyebrow: "Reuters",
-    title:
-      "Long headline with enough words to prove the table truncates cleanly",
-    timestamp: new Date("2024-08-01T12:00:00Z"),
-    preview: "Preview text with a little more color.",
-    detailTitle: "Long headline with enough words",
-    detailMeta: ["Reuters", "Published Aug 1, 2024"],
-    detailBody:
-      "This body should stay readable when the pane opens the detail page.",
-    detailNote: "https://example.com/story",
-  },
-  {
-    id: "2",
-    eyebrow: "10-Q",
-    title: "10-Q filing",
-    timestamp: new Date("2024-08-02T12:00:00Z"),
-    preview: "Quarterly report",
-    detailTitle: "10-Q filing",
-    detailMeta: ["Filed Aug 2, 2024"],
-    detailBody: "Quarterly report details.",
-  },
-];
 
 afterEach(async () => {
-  if (testSetup) {
-    await act(async () => {
-      testSetup!.renderer.destroy();
-    });
-    testSetup = undefined;
-  }
-  rootKeyHits = 0;
+  await act(async () => testSetup?.renderer.destroy());
+  testSetup = undefined;
 });
 
-function Harness({
-  width,
-  height,
-  withRootControls = false,
-}: {
-  width: number;
-  height: number;
-  withRootControls?: boolean;
-}) {
-  const [selectedIdx, setSelectedIdx] = useState(0);
-
-  const state = createInitialState(
-    createDefaultConfig("/tmp/gloomberb-detail-data-table-test"),
-  );
-
-  return (
-    <AppContext value={{ state, dispatch: () => {} }}>
-      <PaneInstanceProvider paneId="portfolio-list:main">
-        <FeedDataTableStackView
-          width={width}
-          height={height}
-          focused
-          items={items}
-          selectedIdx={selectedIdx}
-          onSelect={setSelectedIdx}
-          rootBefore={withRootControls ? (
-            <Box height={1}>
-              <Text>Feed controls</Text>
-            </Box>
-          ) : undefined}
-          onRootKeyDown={withRootControls ? (event) => {
-            if (event.name !== "f") return false;
-            rootKeyHits += 1;
-            return true;
-          } : undefined}
-          sourceLabel="Source"
-          titleLabel="Headline"
-        />
-      </PaneInstanceProvider>
-    </AppContext>
-  );
-}
-
-async function renderSettled() {
+test("delegates root key handling", async () => {
+  let keyHits = 0;
+  const state = createInitialState(createDefaultConfig("/tmp/gloomberb-feed-table-test"));
   await act(async () => {
-    await testSetup!.renderOnce();
-    await testSetup!.renderOnce();
+    testSetup = await testRender(
+      <AppContext value={{ state, dispatch: () => {} }}>
+        <PaneInstanceProvider paneId="portfolio-list:main">
+          <FeedDataTableStackView
+            width={80}
+            height={12}
+            focused
+            items={[]}
+            selectedIdx={0}
+            onSelect={() => {}}
+            rootBefore={<Box height={1}><Text>Feed controls</Text></Box>}
+            onRootKeyDown={(event) => {
+              if (event.name !== "f") return false;
+              keyHits += 1;
+              return true;
+            }}
+          />
+        </PaneInstanceProvider>
+      </AppContext>,
+      { width: 80, height: 12 },
+    );
+    await testSetup.renderOnce();
   });
-}
 
-async function emitKeypress(event: { name?: string; sequence?: string }) {
   await act(async () => {
-    testSetup!.renderer.keyInput.emit("keypress", {
-      ctrl: false,
-      meta: false,
-      option: false,
-      shift: false,
-      eventType: "press",
-      repeated: false,
-      preventDefault: () => {},
-      stopPropagation: () => {},
-      ...event,
-    } as any);
-    await testSetup!.renderOnce();
-  });
-}
-
-describe("FeedDataTableStackView", () => {
-  test("renders a DataTable list by default", async () => {
-    testSetup = await testRender(<Harness width={90} height={16} />, {
-      width: 90,
-      height: 16,
+    (testSetup!.renderer.keyInput as any).emit("keypress", {
+      name: "f", sequence: "f", eventType: "press",
+      ctrl: false, meta: false, option: false, shift: false, repeated: false,
+      preventDefault() {}, stopPropagation() {},
     });
-
-    await renderSettled();
-    const frame = testSetup.captureCharFrame();
-
-    expect(frame).toContain("Time");
-    expect(frame).toContain("Source");
-    expect(frame).toContain("Headline");
-    expect(frame).toContain("10-Q filing");
-    expect(frame).not.toContain("j/k move");
-    expect(frame).not.toContain("Quarterly report details.");
+    await testSetup!.renderOnce();
   });
 
-  test("renders root controls and delegates root key handling", async () => {
-    testSetup = await testRender(<Harness width={90} height={16} withRootControls />, {
-      width: 90,
-      height: 16,
-    });
-
-    await renderSettled();
-    expect(testSetup.captureCharFrame()).toContain("Feed controls");
-
-    await emitKeypress({ name: "f", sequence: "f" });
-    expect(rootKeyHits).toBe(1);
-  });
+  expect(keyHits).toBe(1);
 });

package/src/components/feed-data-table/stack-view.tsx

@@ -21,7 +21,6 @@ export interface FeedDataTableItem {
   eyebrow?: string;
   title: string;
   timestamp?: Date | string | null;
-  preview?: string | null;
   detailTitle?: string;
   detailMeta?: string[];
   detailBody?: string | null;

package/src/components/layout/shell/index.test.tsx

@@ -14,7 +14,6 @@ import { cloneLayout, createDefaultConfig, TICKER_RESEARCH_PANE_ID, type LayoutC
 import type { PluginRegistry } from "../../../plugins/registry";
 import type { PaneProps } from "../../../types/plugin";
 import { Textarea } from "../../../ui";
-import { Header } from "../header";
 import {
   buildNativeWindowState,
   resolvePaneManagementShortcut,
@@ -70,7 +69,7 @@ function createShellPluginRegistry(options?: {
   } as unknown as PluginRegistry;
 }
 
-async function emitKeypress(event: { name?: string; sequence?: string; ctrl?: boolean; meta?: boolean; shift?: boolean; alt?: boolean }) {
+async function emitKeypress(event: { name?: string; sequence?: string; ctrl?: boolean; meta?: boolean; super?: boolean; shift?: boolean; alt?: boolean }) {
   await act(async () => {
     const keyEvent = {
       ctrl: false,
@@ -184,112 +183,6 @@ function findUpdateLayout(actions: ShellTestAction[]) {
   return actions.find((action) => action.type === "UPDATE_LAYOUT");
 }
 
-function HeaderHarness({
-  updateAvailable = null,
-  updateProgress = null,
-  updateCheckInProgress = false,
-  updateNotice = null,
-}: {
-  updateAvailable?: ReturnType<typeof createInitialState>["updateAvailable"];
-  updateProgress?: ReturnType<typeof createInitialState>["updateProgress"];
-  updateCheckInProgress?: boolean;
-  updateNotice?: string | null;
-}) {
-  const initialState = createInitialState(createDefaultConfig("/tmp/gloomberb-header-test"));
-  initialState.updateAvailable = updateAvailable;
-  initialState.updateProgress = updateProgress;
-  initialState.updateCheckInProgress = updateCheckInProgress;
-  initialState.updateNotice = updateNotice;
-  const [state, dispatch] = useReducer(appReducer, initialState);
-
-  return (
-    <AppContext value={{ state, dispatch }}>
-      <Header />
-    </AppContext>
-  );
-}
-
-describe("Header", () => {
-  test("shows automatic self-update status for standalone binaries", async () => {
-    testSetup = await testRender(
-      <HeaderHarness updateAvailable={{
-        version: "0.3.0",
-        tagName: "v0.3.0",
-        downloadUrl: "https://example.com/gloomberb",
-        publishedAt: "2026-04-01T00:00:00.000Z",
-        updateAction: { kind: "self" },
-      }} />,
-      { width: 120, height: 2 },
-    );
-
-    await testSetup.renderOnce();
-    const frame = testSetup!.captureCharFrame();
-
-    expect(frame).toContain("v0.3.0 available");
-    expect(frame).toContain("starting download");
-    expect(frame).not.toContain("press u to update");
-  });
-
-  test("shows the manual npm command when self-update is disabled", async () => {
-    testSetup = await testRender(
-      <HeaderHarness updateAvailable={{
-        version: "0.3.0",
-        tagName: "v0.3.0",
-        downloadUrl: "https://example.com/gloomberb",
-        publishedAt: "2026-04-01T00:00:00.000Z",
-        updateAction: { kind: "manual", command: "npm install -g gloomberb@latest" },
-      }} />,
-      { width: 120, height: 2 },
-    );
-
-    await testSetup.renderOnce();
-    const frame = testSetup!.captureCharFrame();
-
-    expect(frame).toContain("v0.3.0 available");
-    expect(frame).toContain("run npm install -g gloomberb@latest");
-    expect(frame).not.toContain("press u to update");
-  });
-
-  test("shows update download progress and notices", async () => {
-    testSetup = await testRender(
-      <HeaderHarness
-        updateAvailable={{
-          version: "0.3.0",
-          tagName: "v0.3.0",
-          downloadUrl: "https://example.com/gloomberb",
-          publishedAt: "2026-04-01T00:00:00.000Z",
-          updateAction: { kind: "self" },
-        }}
-        updateProgress={{ phase: "downloading", percent: 42 }}
-      />,
-      { width: 120, height: 2 },
-    );
-
-    await testSetup.renderOnce();
-    expect(testSetup.captureCharFrame()).toContain("Downloading v0.3.0: 42%");
-
-    testSetup.renderer.destroy();
-
-    testSetup = await testRender(
-      <HeaderHarness updateCheckInProgress />,
-      { width: 120, height: 2 },
-    );
-
-    await testSetup.renderOnce();
-    expect(testSetup.captureCharFrame()).toContain("Checking for updates...");
-
-    testSetup.renderer.destroy();
-
-    testSetup = await testRender(
-      <HeaderHarness updateNotice="Already on v0.3.1" />,
-      { width: 120, height: 2 },
-    );
-
-    await testSetup.renderOnce();
-    expect(testSetup.captureCharFrame()).toContain("Already on v0.3.1");
-  });
-});
-
 describe("Shell", () => {
   test("uses the desktop titlebar overlay height for shell chrome math", () => {
     expect(resolveAppHeaderHeightCells({ titleBarOverlay: true, cellHeightPx: 18 })).toBe(28 / 18);
@@ -716,7 +609,6 @@ describe("Shell", () => {
     await emitKeypress({
       name: "f",
       key: "f",
-      meta: true,
       super: true,
       shift: true,
       targetEditable: true,
@@ -1330,10 +1222,7 @@ describe("Shell", () => {
     );
 
     await testSetup.renderOnce();
-    await act(async () => {
-      testSetup!.mockInput.pressKey("w", { meta: true });
-      await testSetup!.renderOnce();
-    });
+    await emitKeypress({ name: "w", super: true });
 
     const updateLayout = actions.find((action) => action.type === "UPDATE_LAYOUT");
     expect(updateLayout?.layout.instances.map((instance: { instanceId: string }) => instance.instanceId)).toEqual(["portfolio-list:main"]);

package/src/components/layout/shell/index.tsx

@@ -212,7 +212,6 @@ export function Shell({
 
   const {
     dockedPanes,
-    floatingPanes,
     paneMap,
     visibleFloatingPanes,
   } = useShellResolvedPanes({

package/src/components/layout/shell/menu.ts

@@ -3,7 +3,6 @@ import {
   applyDrop,
   floatPane,
   removePane,
-  type LayoutBounds,
   type ResolvedPane,
 } from "../../../plugins/pane-manager";
 import type { PluginRegistry } from "../../../plugins/registry";

package/src/components/layout/shell/terminal-pointer-runtime.ts

@@ -6,7 +6,6 @@ import type {
   LayoutBounds,
   ResolvedPane,
 } from "../../../plugins/pane-manager";
-import type { LayoutConfig } from "../../../types/config";
 import {
   constrainFloatingRectToBounds,
   pointInRect,

package/src/components/onboarding/onboarding-wizard.tsx

@@ -81,9 +81,9 @@ export function OnboardingWizard({ config, pluginRegistry, onComplete }: Onboard
   }
 
   useEffect(() => {
-    if (editingField) {
-      setTimeout(() => inputRef.current?.focus(), 10);
-    }
+    if (!editingField) return;
+    const focusTimer = setTimeout(() => inputRef.current?.focus?.(), 10);
+    return () => clearTimeout(focusTimer);
   }, [editingField, portfolioSub, brokerFieldIdx]);
 
   useEffect(() => {

package/src/components/onboarding/wizard-keyboard.ts

@@ -72,7 +72,7 @@ export function useOnboardingKeyboard({
     }
 
     if (editingField) {
-      if (event.name === "return") {
+      if (event.name === "enter" || event.name === "return") {
         setEditingField(false);
         if (portfolioSub === "broker-fields" && selectedBrokerId) {
           const currentField = activeBrokerFields[brokerFieldIdx];
@@ -188,28 +188,7 @@ export function useOnboardingKeyboard({
         }
       }
       nextStep();
-    } else if (isBackNavigationKey(event)) {
-      if (step === "portfolio" && portfolioSub === "broker-sync") {
-        resetBrokerSync();
-        setPortfolioSub("broker-fields");
-        return;
-      }
-      if (step === "portfolio" && portfolioSub === "broker-fields") {
-        setPortfolioSub("broker-setup");
-        return;
-      }
-      if (step === "portfolio" && portfolioSub === "broker-setup") {
-        setPortfolioSub("broker-fields");
-        setBrokerFieldIdx(0);
-        return;
-      }
-      if (step === "portfolio" && portfolioSub !== "choose") {
-        setPortfolioSub("choose");
-        setBrokerFieldIdx(0);
-        return;
-      }
-      prevStep();
-    } else if (event.name === "left") {
+    } else if (isBackNavigationKey(event) || event.name === "left") {
       if (step === "portfolio" && portfolioSub === "broker-sync") {
         resetBrokerSync();
         setPortfolioSub("broker-fields");